This revision was automatically updated to reflect the committed changes.
Closed by commit rL271077: Clean up: remove trailing spaces in x86 intrinsic
headers. (authored by kromanova).
Changed prior to commit:
http://reviews.llvm.org/D20614?vs=58472&id=58869#toc
Repository:
rL LLVM
http://r
kromanova updated this revision to Diff 58472.
kromanova added a comment.
I attached full svn diff. Thank you Michael!
I had to clean up the trailing spaces from doxygen comments (because it mess up
our post-processing scripts), but since I was doing it, I decided to clean up
the rest of the he
kromanova created this revision.
kromanova added a reviewer: m_zuckerman.
kromanova added a subscriber: cfe-commits.
kromanova set the repository for this revision to rL LLVM.
Clean up: remove trailing spaces in x86 intrinsic headers.
Repository:
rL LLVM
http://reviews.llvm.org/D20614
Files:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL262385: This patch adds doxygen comments for the intrinsincs
in the header file… (authored by kromanova).
Changed prior to commit:
http://reviews.llvm.org/D17550?vs=48844&id=49534#toc
Repository:
rL
kromanova created this revision.
kromanova added a subscriber: cfe-commits.
kromanova set the repository for this revision to rL LLVM.
Here is the patch with the doxygen comments for the intrinsincs in the header
file popcntintrin.h.
The doxygen comments are automatically generated based on SCE i
This revision was automatically updated to reflect the committed changes.
Closed by commit rL260333: This patch adds doxygen comments for all the
intrinsincs in the header file… (authored by kromanova).
Changed prior to commit:
http://reviews.llvm.org/D17021?vs=47299&id=47394#toc
Repository:
kromanova created this revision.
kromanova added reviewers: ygao, probinson, echristo, gribozavr, craig.topper,
jroelofs.
kromanova added a subscriber: cfe-commits.
kromanova set the repository for this revision to rL LLVM.
Eric Christopher told me that from now on it's OK to commit doxygen comme
This revision was automatically updated to reflect the committed changes.
Closed by commit rL260160: This patch adds doxygen comments for all the
intrinsincs in the header file… (authored by kromanova).
Changed prior to commit:
http://reviews.llvm.org/D16913?vs=46988&id=47250#toc
Repository:
kromanova created this revision.
kromanova added reviewers: ygao, echristo, jroelofs, gribozavr, craig.topper,
probinson.
kromanova added a subscriber: cfe-commits.
kromanova set the repository for this revision to rL LLVM.
Hello,
Here is the patch with the doxygen comments for the intrinsincs i
This revision was automatically updated to reflect the committed changes.
Closed by commit rL259275: This patch adds doxygen comments for the intrinsincs
in the header file… (authored by kromanova).
Changed prior to commit:
http://reviews.llvm.org/D16562?vs=45924&id=46447#toc
Repository:
rL
kromanova added a comment.
Hi Eric,
Could you please accept this revision also?
I have already added missing article "the" in "This intrinsic corresponds to
instruction" (as you requested in the other doxygen comments
review).
Thank you!
Katya.
Repository:
rL LLVM
http://reviews.llvm.org/
This revision was automatically updated to reflect the committed changes.
Closed by commit rL259239: This patch adds doxygen comments for the intrinsincs
in the header file… (authored by kromanova).
Changed prior to commit:
http://reviews.llvm.org/D15999?vs=45902&id=46411#toc
Repository:
rL
kromanova created this revision.
kromanova added reviewers: dblaikie, echristo, probinson.
kromanova added a subscriber: cfe-commits.
kromanova set the repository for this revision to rL LLVM.
Hello,
The compiler always emits .debug_line version 2, though some opcodes from DWARF
3 (e.g. DW_LNS_se
kromanova added a comment.
In http://reviews.llvm.org/D15999#335653, @echristo wrote:
> Honestly if they've been reviewed like that internally I'm ok with you just
> committing them - especially if they look like this.
>
> The only concerns I'd have are in the case of "This intrinsic corresponds
kromanova added a comment.
In http://reviews.llvm.org/D15999#335653, @echristo wrote:
> Honestly if they've been reviewed like that internally I'm ok with you just
> committing them - especially if they look like this.
>
> The only concerns I'd have are in the case of "This intrinsic corresponds
kromanova added a reviewer: craig.topper.
kromanova added a comment.
Hello,
I have a lot of intrinsic header files with doxygen documentation that I will
be submitting in the near future.
We have been reviewing this internally at SCE to make sure the patch it in the
best shape before submitting
kromanova created this revision.
kromanova added reviewers: gribozavr, jroelofs, gaoyunzhong, craig.topper.
kromanova added subscribers: silvas, echristo, cfe-commits.
kromanova set the repository for this revision to rL LLVM.
Hello,
Here is the patch with the doxygen comments for the intrinsincs
kromanova removed rL LLVM as the repository for this revision.
kromanova updated this revision to Diff 45902.
kromanova added a comment.
SCE's techinical writer, Craig Flores, did the code review and suggested a few
changes to the documentation.
http://reviews.llvm.org/D15999
Files:
lib/Head
kromanova added a comment.
I did some build time measurement on a big game code where the the intrisics
are heavily used (PHC was enabled). The presence of comments didn't make any
noticeable difference.
Sean did similar measurements without PCH and didn't see any difference in
performance neit
This revision was automatically updated to reflect the committed changes.
Closed by commit rL258492: 2 missing intrinsics _cvtss_sh and _mm_cvtps_ph were
added to the intrinsics… (authored by kromanova).
Changed prior to commit:
http://reviews.llvm.org/D16177?vs=45635&id=45650#toc
Repository:
kromanova added a comment.
In http://reviews.llvm.org/D15999#333173, @silvas wrote:
> For the preview of all the changes, can you please put that in a separate
> patch from this one?
Done.
See http://reviews.llvm.org/D16442
Repository:
rL LLVM
http://reviews.llvm.org/D15999
_
kromanova added a comment.
Craig, do you think it's necessary to make the tests more fancy by checking how
the vector is initialized before the builtin invocation and/or that one element
is extracted from the vector after the builtin returned a value? It will add
additional 10-15 check lines to
kromanova updated this revision to Diff 45635.
kromanova marked an inline comment as done.
kromanova added a comment.
I further simplified the macros by removing the statement for the define that I
added (_cvtss_sh) and for the one that was there before (_mm_cvtps_ph).
I also formatted __DEFAULT
kromanova marked an inline comment as done.
Comment at: lib/Headers/f16cintrin.h:47
@@ -34,1 +46,3 @@
+
+
#define _mm_cvtps_ph(a, imm) __extension__ ({ \
craig.topper wrote:
> Can we do something like this to remove the last temporary?
>
> #define _cvtss_sh(a, i
kromanova updated this revision to Diff 45632.
kromanova marked an inline comment as done.
kromanova added a comment.
Updated patch to address Craig's comments.
Repository:
rL LLVM
http://reviews.llvm.org/D16177
Files:
lib/Headers/f16cintrin.h
test/CodeGen/f16c-builtins.c
Index: test/Co
kromanova updated this revision to Diff 45458.
kromanova added a comment.
Craig, thank you for the review. Here are the changes that you requested.
Katya.
Repository:
rL LLVM
http://reviews.llvm.org/D16177
Files:
lib/Headers/f16cintrin.h
test/CodeGen/f16c-builtins.c
Index: test/CodeGen/
kromanova added a comment.
In http://reviews.llvm.org/D15999#331649, @silvas wrote:
> In http://reviews.llvm.org/D15999#331512, @kromanova wrote:
>
> > In http://reviews.llvm.org/D15999#330794, @silvas wrote:
> >
> > > Also, can you post a patch that changes "all" the headers to have doxygen
> >
kromanova added a comment.
In http://reviews.llvm.org/D15999#331639, @silvas wrote:
> In http://reviews.llvm.org/D15999#331601, @kromanova wrote:
>
> >
>
>
> I don't think we did any testing at SCE, but we probably should have. I don't
> think Google's primary codebases (nor Apple's, or anybody
kromanova added a comment.
In http://reviews.llvm.org/D15999#330794, @silvas wrote:
> This may sound stupid, but: can you benchmark the time it takes to build some
> project (that actually uses intrinsics in most translation units, e.g. a
> game) with the headers w/ and w/o the doxygen comments
kromanova added a comment.
In http://reviews.llvm.org/D15999#330794, @silvas wrote:
> This may sound stupid, but: can you benchmark the time it takes to build some
> project (that actually uses intrinsics in most translation units, e.g. a
> game) with the headers w/ and w/o the doxygen comments
kromanova added a subscriber: cfe-commits.
kromanova added a comment.
Adding cfe-commits as a subscriber.
Repository:
rL LLVM
http://reviews.llvm.org/D16177
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mai
kromanova created this revision.
kromanova added reviewers: gribozavr, jroelofs, ygao.
kromanova added a subscriber: cfe-commits.
kromanova set the repository for this revision to rL LLVM.
Hello,
Here is the patch with the doxygen comments for the intrinsincs in the header
file __wmmintrin_pclmu
This revision was automatically updated to reflect the committed changes.
Closed by commit rL255281: Do not generate DW_TAG_imported_module for anonymous
namespaces (even nested)… (authored by kromanova).
Changed prior to commit:
http://reviews.llvm.org/D12624?vs=42364&id=42449#toc
Repository:
kromanova accepted this revision.
kromanova added a reviewer: kromanova.
kromanova added a comment.
This revision is now accepted and ready to land.
This was committed in r238386 but I forgot to close the review.
http://reviews.llvm.org/D8762
___
cf
kromanova added a comment.
> > Once we have this in place we can think about factoring the debug-specific
> > flags out of CodeGenOpts into some kind of DebugInfoOpts, to be configured
> > by whatever debugger tuning mechanism we end up with.
>
Good idea!
Thank you for such prompt review.
Ka
kromanova updated the summary for this revision.
kromanova set the repository for this revision to rL LLVM.
kromanova updated this revision to Diff 42364.
kromanova added a comment.
I have made all the changes that Richard suggested. Sorry for the delay, got
distracted by other tasks.
Anything el
kromanova added a comment.
Hi,
The initial PS4 patch caused a test failure (debug-options.c) on the PS4 bot. I
suspect that I know why the problem happens, but I'm not sure what will be the
best way to handle it. If someone knows how to fix this test more "elegantly",
I would appreciate their
This revision was automatically updated to reflect the committed changes.
Closed by commit rL250252: This patch adds missing pieces to clang, including
the PS4 toolchain (authored by kromanova).
Changed prior to commit:
http://reviews.llvm.org/D13482?vs=37292&id=37301#toc
Repository:
rL LLVM
kromanova updated this revision to Diff 37292.
kromanova added a comment.
Updated the patch based on Jonathan's comments.
Jonathan, if you have a minute, please review.
Repository:
rL LLVM
http://reviews.llvm.org/D13482
Files:
include/clang/Basic/DiagnosticDriverKinds.td
include/clang/B
kromanova added a comment.
Thank you! I will rebase and commit shortly
Katya.
Repository:
rL LLVM
http://reviews.llvm.org/D13482
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
kromanova updated this revision to Diff 36829.
kromanova added a comment.
Few more changes:
(1) There was a bug, where the PS4 driver didn't add input filename in the call
to external assembler.
Filipe fixed this problem in Tools.cpp
(2) A new testcase no-integrated-as.s was added for testing
kromanova added a comment.
Hi Pierre,
I noticed the same issue. When I downloaded a patch from
http://reviews.llvm.org/D11279, I had to manually add .keep files to make tests
to pass.
It's a Phabricator problem. The diff file that I uploaded to Phabricator
contains .keep files, however the di
kromanova created this revision.
kromanova added reviewers: filcab, echristo, alexr, probinson.
kromanova added subscribers: silvas, cfe-commits, chapuni, jroelofs, asl,
pgousseau, gbedwell.
kromanova set the repository for this revision to rL LLVM.
Initial patch for PS4 toolchain was created her
This revision was automatically updated to reflect the committed changes.
Closed by commit rL248546: This patch adds missing pieces to clang, including
the PS4 toolchain (authored by kromanova).
Changed prior to commit:
http://reviews.llvm.org/D11279?vs=34522&id=35681#toc
Repository:
rL LLVM
kromanova added a comment.
Hi Eric,
I don't mind changing .keep into README. However, originally we did it for
consistency purpose. If you grep for .keep in
/llvm/tools/clang/test/Driver/Inputs directory, you will find hundreds of
instances of these files that were created for similar reasons (
kromanova added a comment.
test/Driver/Inputs/scei-ps4_tree/target/include_common/ and
test/Driver/Inputs/scei-ps4_tree/target/include/ are expected to be present by
a test ps4-header-search.c. This test checks that these directories are found
in the header search path. If these directories ar
kromanova created this revision.
kromanova added reviewers: rsmith, dblaikie, echristo, probinson, aprantl.
kromanova added a subscriber: cfe-commits.
I had a review opened for anonymous namespaces bug in llvm-commits (see
http://reviews.llvm.org/D7895). It was opened in llvm-commits is because
kromanova added inline comments.
Comment at: lib/Driver/Tools.cpp:3590-3591
@@ -3580,4 +3589,4 @@
Args.ClaimAllArgs(options::OPT_g_flags_Group);
if (Args.hasFlag(options::OPT_gcolumn_info, options::OPT_gno_column_info,
- /*Default*/ true))
+
kromanova added inline comments.
Comment at: lib/Frontend/InitHeaderSearch.cpp:340
@@ +339,3 @@
+BaseSDKPath = P.str();
+ }
+}
jroelofs wrote:
> The lifetime of `P` ends here, yet a reference to it lives on because of the
> `= P.str()`. Using it
kromanova added inline comments.
Comment at: lib/Frontend/InitHeaderSearch.cpp:325-344
@@ +324,22 @@
+ case llvm::Triple::PS4: {
+// gets prepended later in AddPath().
+std::string BaseSDKPath = "";
+if (!HasSysroot) {
+ const char *envValue = getenv("SCE_PS4_SD
kromanova added inline comments.
Comment at: include/clang/Driver/Options.td:1853-1854
@@ -1853,2 +1852,4 @@
+def fuse_ld_EQ : Joined<["-"], "fuse-ld=">, HelpText<"Use linker ">,
Group;
+def linker_EQ : Joined<["-"], "linker=">, Alias,
MetaVarName<"">;
defm align_functions :
kromanova added inline comments.
Comment at: lib/Frontend/InitHeaderSearch.cpp:325-344
@@ +324,22 @@
+ case llvm::Triple::PS4: {
+// gets prepended later in AddPath().
+std::string BaseSDKPath = "";
+if (!HasSysroot) {
+ const char *envValue = getenv("SCE_PS4_SD
52 matches
Mail list logo
