kromanova added inline comments. ================ Comment at: lib/Driver/Tools.cpp:3590-3591 @@ -3580,4 +3589,4 @@ Args.ClaimAllArgs(options::OPT_g_flags_Group); if (Args.hasFlag(options::OPT_gcolumn_info, options::OPT_gno_column_info, - /*Default*/ true)) + /*Default*/ !Triple.isPS4CPU())) CmdArgs.push_back("-dwarf-column-info"); ---------------- echristo wrote: > filcab wrote: > > echristo wrote: > > > Hmm? > > We have different defaults from other platforms. > *nod* disabling column info yes? I have "opinions" on this, but it's not my > platform. Needs a comment. Our debugger doesn't use column information. Though it's not too much, unused column information adds to the total size of DI. We will add a comment.
================ Comment at: lib/Driver/Tools.cpp:3613 @@ -3603,3 +3612,3 @@ // backend. - if (Args.hasArg(options::OPT_gdwarf_aranges)) { + if (Args.hasArg(options::OPT_gdwarf_aranges) || Triple.isPS4CPU()) { CmdArgs.push_back("-backend-option"); ---------------- echristo wrote: > filcab wrote: > > echristo wrote: > > > Ditto. > > Ditto, different defaults. > > But I guess I can hoist out the Triple.isPS4CPU() on both cases, if you > > prefer, like it's done for other toolchains like: > > bool IsWindowsMSVC = > > getToolChain().getTriple().isWindowsMSVCEnvironment(); > Probably better to just handle it the same way as the column info I'd think. > Also, this is all terrible and needs to change, that said, not your problem. > :) We could do exactly the same for aranges as it we did for the column info. Though it seems that we will have to add 'gno_dwarf_aranges' if we want to use hasFlag function here too. Is it worth doing it? http://reviews.llvm.org/D11279 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits