https://github.com/DeinAlptraum approved this pull request.
Re Python: LGTM!
On a sidenote just fyi, there's no need to amend & forcepush when you adress
review comments. I know the contributor guide says something about how you
should have only a single commit when submitting a patch, but tha
https://github.com/DeinAlptraum approved this pull request.
Thanks for the PR! Please also add a corresponding release note for
`Type.pretty_printed` in the Python bindings section. Otherwise, LGTM!
https://github.com/llvm/llvm-project/pull/122386
___
DeinAlptraum wrote:
@efriedma-quic no idea, I would just rebase and hope that's it
https://github.com/llvm/llvm-project/pull/120494
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/DeinAlptraum approved this pull request.
LGTM! @Endilll did you want to take a look at this as well?
https://github.com/llvm/llvm-project/pull/120494
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi
@@ -2663,6 +2671,21 @@ def visitor(field, children):
conf.lib.clang_Type_visitFields(self, fields_visit_callback(visitor),
fields)
return iter(fields)
+def get_bases(self):
+"""Return an iterator for accessing the base classes of this type."""
+
+
https://github.com/DeinAlptraum edited
https://github.com/llvm/llvm-project/pull/120590
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/DeinAlptraum commented:
Hi and thanks for the PR!
To keep our history readable, please this up into smaller more focused PRs with
an appropriate title ("Add a few things" won't be accepted ;)). This could be
split into e.g. additions to the `File` interface, additions to the
@@ -2663,6 +2671,21 @@ def visitor(field, children):
conf.lib.clang_Type_visitFields(self, fields_visit_callback(visitor),
fields)
return iter(fields)
+def get_bases(self):
+"""Return an iterator for accessing the base classes of this type."""
+
+
@@ -2663,6 +2671,21 @@ def visitor(field, children):
conf.lib.clang_Type_visitFields(self, fields_visit_callback(visitor),
fields)
return iter(fields)
+def get_bases(self):
+"""Return an iterator for accessing the base classes of this type."""
+
+
@@ -1,4 +1,5 @@
import os
+import clang.cindex
DeinAlptraum wrote:
This import seems to be unused
https://github.com/llvm/llvm-project/pull/120300
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.
@@ -437,6 +437,8 @@ LLVM_19 {
LLVM_20 {
global:
clang_isBeforeInTranslationUnit;
+clang_getOffsetOfBase;
+clang_visitCXXBaseClasses;
DeinAlptraum wrote:
Not sure if this actually matters, but since all the other entries follow an
alphabetic orde
https://github.com/DeinAlptraum commented:
I'm only familiar with the Python-side of the bindings, so only reviewed those.
Minor comments, otherwise LGTM!
https://github.com/llvm/llvm-project/pull/120300
___
cfe-commits mailing list
cfe-commits@lists.
https://github.com/DeinAlptraum edited
https://github.com/llvm/llvm-project/pull/120300
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -981,3 +983,13 @@ def test_from_result_null(self):
def test_from_cursor_result_null(self):
tu = get_tu("")
self.assertEqual(tu.cursor.semantic_parent, None)
+
+def test_pretty_print(self):
+tu = get_tu("struct X { int x; }; void f(bool x) { }"
@@ -3685,6 +3695,71 @@ def write_main_file_to_stdout(self):
conf.lib.clang_CXRewriter_writeMainFileToStdOut(self)
+class PrintingPolicyProperty(BaseEnumeration):
+
+"""
+A PrintingPolicyProperty identifies a property of a PrintingPolicy.
+"""
+Indentat
https://github.com/DeinAlptraum edited
https://github.com/llvm/llvm-project/pull/120494
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/DeinAlptraum commented:
Thanks for the PR! Two minor comments and formatting, otherwise LGTM!
https://github.com/llvm/llvm-project/pull/120494
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mai
https://github.com/DeinAlptraum approved this pull request.
https://github.com/llvm/llvm-project/pull/120483
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -3109,6 +3109,29 @@ CINDEX_LINKAGE int clang_getFieldDeclBitWidth(CXCursor
C);
*/
CINDEX_LINKAGE int clang_Cursor_getNumArguments(CXCursor C);
+/**
+ * Retrieve FormatAttr on function declaration
+ */
+CINDEX_LINKAGE CXCursor clang_Cursor_getFormatAttr (CXCursor cur);
-
@@ -59,6 +59,10 @@ LLVM_13 {
clang_Cursor_getMangling;
clang_Cursor_getModule;
clang_Cursor_getNumArguments;
+clang_Cursor_getFormatAttr;
+clang_FormatAttr_getType;
+clang_FormatAttr_getFormatIdx;
+clang_FormatAttr_getFirstArg;
DeinA
https://github.com/DeinAlptraum commented:
I'm not that familiar with the C++ side of the bindings, so I would wait for
approval from others.
https://github.com/llvm/llvm-project/pull/113754
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http
https://github.com/DeinAlptraum edited
https://github.com/llvm/llvm-project/pull/113754
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/DeinAlptraum closed
https://github.com/llvm/llvm-project/pull/114383
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/DeinAlptraum closed
https://github.com/llvm/llvm-project/pull/114409
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
DeinAlptraum wrote:
Closing since this has been split into #114395, #114397, #114399, #114409
https://github.com/llvm/llvm-project/pull/114383
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
https://github.com/DeinAlptraum created
https://github.com/llvm/llvm-project/pull/114409
Sort imports using `isort`.
Remove unused imports
Collect multiple imports from the same module into a single import statement
Unify import style
>From a83338b9f4b306a81b55937e109e3065049fcfb7 Mon Sep 17 00
https://github.com/DeinAlptraum edited
https://github.com/llvm/llvm-project/pull/114409
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/DeinAlptraum closed
https://github.com/llvm/llvm-project/pull/114399
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/DeinAlptraum closed
https://github.com/llvm/llvm-project/pull/114397
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/DeinAlptraum closed
https://github.com/llvm/llvm-project/pull/114395
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/DeinAlptraum created
https://github.com/llvm/llvm-project/pull/114399
This removes workarounds for Python versions before 3.6, since our minimum
Python version has been bumped to 3.8
>From b3079f7a44d65c8d62fe201b7c5766b852a1 Mon Sep 17 00:00:00 2001
From: Jannick Kremer
https://github.com/DeinAlptraum created
https://github.com/llvm/llvm-project/pull/114397
Remove all occurrences of unused varialbes in the python bindings tests.
Use `_` to ignore unused values in tuple unpacking expressions.
>From 48e8bc646a7f73c1c0a762e8c1da7186f0ff2a5a Mon Sep 17 00:00:00 20
https://github.com/DeinAlptraum created
https://github.com/llvm/llvm-project/pull/114395
This mistake was introduced in #109846
>From 5de030fa89f4dbda6d21224a3097d83b467d1575 Mon Sep 17 00:00:00 2001
From: Jannick Kremer
Date: Thu, 31 Oct 2024 13:07:06 +0100
Subject: [PATCH] [libclang/python]
@@ -344,7 +343,7 @@ class Bar {
)
self.assertEqual(len(copy_assignment_operators_cursors), 10)
-self.assertTrue(len(non_copy_assignment_operators_cursors), 9)
+self.assertEqual(len(non_copy_assignment_operators_cursors), 7)
Dein
https://github.com/DeinAlptraum created
https://github.com/llvm/llvm-project/pull/114383
Clean up imports via isort
Remove unused imports
Remove unused variables
Remove Python <3.6 compatibility measures
>From 25e10c362338265e07ec045b2b8bbe692ae18092 Mon Sep 17 00:00:00 2001
From: Jannick Kreme
https://github.com/DeinAlptraum approved this pull request.
LGTM, but I'd like @Endilll to take a look as well, since I'm not that familiar
with our build infrastructure & cmake
https://github.com/llvm/llvm-project/pull/111367
___
cfe-commits mailing
https://github.com/DeinAlptraum closed
https://github.com/llvm/llvm-project/pull/105490
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
DeinAlptraum wrote:
@Endilll I rebased with the added tests from #109846 and checked with
[diff-cover](https://pypi.org/project/diff-cover/) that all changed lines are
covered by tests
https://github.com/llvm/llvm-project/pull/105490
___
cfe-commits
https://github.com/DeinAlptraum updated
https://github.com/llvm/llvm-project/pull/105490
>From 2e4651345d1bde971be3a2c40602acf68f2c9519 Mon Sep 17 00:00:00 2001
From: Jannick Kremer
Date: Wed, 21 Aug 2024 11:50:05 +0200
Subject: [PATCH] [libclang/python] Do not rely on ctypes' errcheck
Call co
https://github.com/DeinAlptraum closed
https://github.com/llvm/llvm-project/pull/109846
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/DeinAlptraum edited
https://github.com/llvm/llvm-project/pull/109846
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/DeinAlptraum edited
https://github.com/llvm/llvm-project/pull/109846
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/DeinAlptraum edited
https://github.com/llvm/llvm-project/pull/109846
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -279,6 +280,90 @@ def test_is_default_method(self):
self.assertTrue(xc.is_default_method())
self.assertFalse(yc.is_default_method())
+def test_is_deleted_method(self):
+source = "class X { X() = delete; }; class Y { Y(); };"
+tu = get_tu(
https://github.com/DeinAlptraum edited
https://github.com/llvm/llvm-project/pull/109846
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -46,6 +46,8 @@ def test_diagnostic_fixit(self):
self.assertEqual(tu.diagnostics[0].location.column, 26)
self.assertRegex(tu.diagnostics[0].spelling, "use of GNU old-style.*")
self.assertEqual(len(tu.diagnostics[0].fixits), 1)
+with self.assert
@@ -279,6 +280,90 @@ def test_is_default_method(self):
self.assertTrue(xc.is_default_method())
self.assertFalse(yc.is_default_method())
+def test_is_deleted_method(self):
+source = "class X { X() = delete; }; class Y { Y(); };"
+tu = get_tu(
https://github.com/DeinAlptraum updated
https://github.com/llvm/llvm-project/pull/109846
>From 68ca7ee24712a48c1b6df6aff480fb4ff3054c57 Mon Sep 17 00:00:00 2001
From: Jannick Kremer
Date: Tue, 24 Sep 2024 20:44:23 +0200
Subject: [PATCH 1/2] [libclang/python] Improve test coverage
Achieve 100%
@@ -357,6 +359,50 @@ def test_is_restrict_qualified(self):
self.assertTrue(i.type.is_restrict_qualified())
self.assertFalse(j.type.is_restrict_qualified())
+def test_get_result(self):
+tu = get_tu("void foo(); int bar(char, short);")
+foo =
@@ -357,6 +359,50 @@ def test_is_restrict_qualified(self):
self.assertTrue(i.type.is_restrict_qualified())
self.assertFalse(j.type.is_restrict_qualified())
+def test_get_result(self):
+tu = get_tu("void foo(); int bar(char, short);")
+foo =
@@ -625,6 +762,25 @@ def test_result_type_objc_method_decl(self):
self.assertEqual(cursor.kind, CursorKind.OBJC_INSTANCE_METHOD_DECL)
self.assertEqual(result_type.kind, TypeKind.VOID)
+def test_storage_class(self):
+tu = get_tu(
+"""
+ex
@@ -357,6 +359,50 @@ def test_is_restrict_qualified(self):
self.assertTrue(i.type.is_restrict_qualified())
self.assertFalse(j.type.is_restrict_qualified())
+def test_get_result(self):
+tu = get_tu("void foo(); int bar(char, short);")
+foo =
@@ -308,10 +310,10 @@ def test_element_type(self):
def test_invalid_element_type(self):
"""Ensure Type.element_type raises if type doesn't have elements."""
tu = get_tu("int i;")
-i = get_cursor(tu, "i")
-self.assertIsNotNone(i)
-with
https://github.com/DeinAlptraum commented:
@Endilll this adds the tests in preparation as discussed for #105490. While I
was at it, I also added full test coverage for all the affected classes.
https://github.com/llvm/llvm-project/pull/109846
___
cfe-
https://github.com/DeinAlptraum edited
https://github.com/llvm/llvm-project/pull/109846
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/DeinAlptraum created
https://github.com/llvm/llvm-project/pull/109846
Achieve 100% test coverage on classes Cursor, Diagnostic, Type.
>From 68ca7ee24712a48c1b6df6aff480fb4ff3054c57 Mon Sep 17 00:00:00 2001
From: Jannick Kremer
Date: Tue, 24 Sep 2024 20:44:23 +0200
Subject: [
DeinAlptraum wrote:
@fursov yes, since you are a new contributor, you cannot merge this yourself. I
can, but I am also still relatively new so I would like someone else to confirm
that this change is good to go - so we're just waiting for him to take a look
as well :)
https://github.com/llvm/
https://github.com/DeinAlptraum edited
https://github.com/llvm/llvm-project/pull/108769
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -570,6 +570,26 @@ def test_enum_values_cpp(self):
self.assertEqual(ham.kind, CursorKind.ENUM_CONSTANT_DECL)
self.assertEqual(ham.enum_value, 0x100)
+def test_enum_values_on_elaborated_type(self):
+tu = get_tu(
+"using myUType
https://github.com/DeinAlptraum approved this pull request.
Rest looks good to me.
Regarding releases, I'm not too familiar with the process here, but I believe
backports aren't done unless it's a critical security bug or similar. @Endilll
can you confirm, and do you also want to sign off on t
https://github.com/DeinAlptraum edited
https://github.com/llvm/llvm-project/pull/108769
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -570,6 +570,25 @@ def test_enum_values_cpp(self):
self.assertEqual(ham.kind, CursorKind.ENUM_CONSTANT_DECL)
self.assertEqual(ham.enum_value, 0x100)
+def test_enum_values_on_elaborated_type(self):
+tu = get_tu(
+"using myUType
https://github.com/DeinAlptraum commented:
Thanks a lot for the fix!
Except for the syntax error noted by the CI and my other comment, this looks
good to me.
https://github.com/llvm/llvm-project/pull/108769
___
cfe-commits mailing list
cfe-commits@li
https://github.com/DeinAlptraum edited
https://github.com/llvm/llvm-project/pull/108769
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/DeinAlptraum edited
https://github.com/llvm/llvm-project/pull/108769
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -3524,16 +3564,20 @@ def getCompileCommands(self, filename):
Get an iterable object providing all the CompileCommands available to
build filename. Returns None if filename is not found in the database.
"""
-return conf.lib.clang_CompilationDat
https://github.com/DeinAlptraum commented:
@Endilll tested how exactly?
All tests still pass, obviously, but I just checked and there are six lines
changed here, that are not currently covered by tests:
`Diagnostic.format()`, `Cursor.get_definition()`, `Cursor.get_usr()`,
`Type.get_result()`, `
https://github.com/DeinAlptraum edited
https://github.com/llvm/llvm-project/pull/105490
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -2454,7 +2480,7 @@ def element_type(self):
If accessed on a type that is not an array, complex, or vector type, an
exception will be raised.
"""
-result = conf.lib.clang_getElementType(self)
+result = Type.from_result(conf.lib.clang_ge
@@ -3743,82 +3765,62 @@ def write_main_file_to_stdout(self):
("clang_equalLocations", [SourceLocation, SourceLocation], bool),
("clang_equalRanges", [SourceRange, SourceRange], bool),
("clang_equalTypes", [Type, Type], bool),
-("clang_formatDiagnostic", [Diagnos
@@ -424,7 +424,7 @@ def location(self):
@property
def spelling(self):
-return conf.lib.clang_getDiagnosticSpelling(self) # type: ignore
[no-any-return]
+return
_CXString.from_result(conf.lib.clang_getDiagnosticSpelling(self))
DeinAlp
https://github.com/DeinAlptraum commented:
@Endilll this removes the `errcheck` magic conversion stuff that we discussed
the other day
https://github.com/llvm/llvm-project/pull/105490
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lis
https://github.com/DeinAlptraum edited
https://github.com/llvm/llvm-project/pull/105490
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/DeinAlptraum created
https://github.com/llvm/llvm-project/pull/105490
Call conversion functions directly instead of using them for type conversion on
library function calls via `ctypes`' `errcheck` functionality.
>From 8cf94c6486b47cbe4f9ec82cc7c8a9c4948ed012 Mon Sep 17 00:0
https://github.com/DeinAlptraum closed
https://github.com/llvm/llvm-project/pull/101802
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -65,6 +65,9 @@ Clang Python Bindings Potentially Breaking Changes
- Calling a property on the ``CompletionChunk`` or ``CompletionString`` class
statically now leads to an error, instead of returning a ``CachedProperty``
object
that is used internally. Properties are onl
https://github.com/DeinAlptraum updated
https://github.com/llvm/llvm-project/pull/101802
>From 572b1be0b204561fdbb049f0c17f065d17198ac0 Mon Sep 17 00:00:00 2001
From: Jannick Kremer
Date: Sat, 3 Aug 2024 09:28:02 +0100
Subject: [PATCH 1/7] [libclang/python] Fix bug in SourceRange.__contains__,
https://github.com/DeinAlptraum updated
https://github.com/llvm/llvm-project/pull/101802
>From 572b1be0b204561fdbb049f0c17f065d17198ac0 Mon Sep 17 00:00:00 2001
From: Jannick Kremer
Date: Sat, 3 Aug 2024 09:28:02 +0100
Subject: [PATCH 1/6] [libclang/python] Fix bug in SourceRange.__contains__,
@@ -74,6 +74,16 @@ CINDEX_LINKAGE CXSourceLocation clang_getNullLocation(void);
CINDEX_LINKAGE unsigned clang_equalLocations(CXSourceLocation loc1,
CXSourceLocation loc2);
+/**
+ * Determine for two source locations if they refer to
https://github.com/DeinAlptraum updated
https://github.com/llvm/llvm-project/pull/101802
>From 572b1be0b204561fdbb049f0c17f065d17198ac0 Mon Sep 17 00:00:00 2001
From: Jannick Kremer
Date: Sat, 3 Aug 2024 09:28:02 +0100
Subject: [PATCH 1/6] [libclang/python] Fix bug in SourceRange.__contains__,
https://github.com/DeinAlptraum updated
https://github.com/llvm/llvm-project/pull/101802
>From 572b1be0b204561fdbb049f0c17f065d17198ac0 Mon Sep 17 00:00:00 2001
From: Jannick Kremer
Date: Sat, 3 Aug 2024 09:28:02 +0100
Subject: [PATCH 1/6] [libclang/python] Fix bug in SourceRange.__contains__,
DeinAlptraum wrote:
Implemented all your suggestions
https://github.com/llvm/llvm-project/pull/101802
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/DeinAlptraum updated
https://github.com/llvm/llvm-project/pull/101802
>From 572b1be0b204561fdbb049f0c17f065d17198ac0 Mon Sep 17 00:00:00 2001
From: Jannick Kremer
Date: Sat, 3 Aug 2024 09:28:02 +0100
Subject: [PATCH 1/5] [libclang/python] Fix bug in SourceRange.__contains__,
https://github.com/DeinAlptraum updated
https://github.com/llvm/llvm-project/pull/101802
>From 572b1be0b204561fdbb049f0c17f065d17198ac0 Mon Sep 17 00:00:00 2001
From: Jannick Kremer
Date: Sat, 3 Aug 2024 09:28:02 +0100
Subject: [PATCH 1/4] [libclang/python] Fix bug in SourceRange.__contains__,
@@ -50,6 +50,18 @@ unsigned clang_equalLocations(CXSourceLocation loc1,
CXSourceLocation loc2) {
loc1.int_data == loc2.int_data);
}
+unsigned clang_lessThanLocations(CXSourceLocation loc1, CXSourceLocation loc2)
{
+ const SourceLocation Loc1 =
SourceLocation::get
https://github.com/DeinAlptraum updated
https://github.com/llvm/llvm-project/pull/101802
>From 572b1be0b204561fdbb049f0c17f065d17198ac0 Mon Sep 17 00:00:00 2001
From: Jannick Kremer
Date: Sat, 3 Aug 2024 09:28:02 +0100
Subject: [PATCH 1/4] [libclang/python] Fix bug in SourceRange.__contains__,
https://github.com/DeinAlptraum updated
https://github.com/llvm/llvm-project/pull/101802
>From 572b1be0b204561fdbb049f0c17f065d17198ac0 Mon Sep 17 00:00:00 2001
From: Jannick Kremer
Date: Sat, 3 Aug 2024 09:28:02 +0100
Subject: [PATCH 1/3] [libclang/python] Fix bug in SourceRange.__contains__,
@@ -386,6 +386,10 @@ def __contains__(self, other):
# same file, in between lines
if self.start.line < other.line < self.end.line:
return True
+# between columns in one-liner range
+elif self.start.line == other.line == self.end.line:
https://github.com/DeinAlptraum updated
https://github.com/llvm/llvm-project/pull/101802
>From 572b1be0b204561fdbb049f0c17f065d17198ac0 Mon Sep 17 00:00:00 2001
From: Jannick Kremer
Date: Sat, 3 Aug 2024 09:28:02 +0100
Subject: [PATCH 1/3] [libclang/python] Fix bug in SourceRange.__contains__,
https://github.com/DeinAlptraum edited
https://github.com/llvm/llvm-project/pull/102410
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/DeinAlptraum approved this pull request.
LGTM. Thanks for adding better error handling!
@Endilll do you also want to take a look at this before it is merged?
Otherwise, this is good to go imo.
https://github.com/llvm/llvm-project/pull/102410
__
https://github.com/DeinAlptraum edited
https://github.com/llvm/llvm-project/pull/102410
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/DeinAlptraum edited
https://github.com/llvm/llvm-project/pull/102410
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
DeinAlptraum wrote:
Unrelated, this change only touched release notes
https://github.com/llvm/llvm-project/pull/102807
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/DeinAlptraum closed
https://github.com/llvm/llvm-project/pull/102807
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/DeinAlptraum created
https://github.com/llvm/llvm-project/pull/102807
This corrects a release note introduced in #98745
>From 64212e4c8afe2ad75144bf36a1212c4e417dd8c9 Mon Sep 17 00:00:00 2001
From: Jannick Kremer
Date: Sun, 11 Aug 2024 11:00:52 +0200
Subject: [PATCH] [NFC][l
@@ -149,8 +149,8 @@ def b(x: str | bytes) -> bytes:
# this by marshalling object arguments as void**.
c_object_p: TType[_Pointer[Any]] = POINTER(c_void_p)
-### Exception Classes ###
+### Exception Classes ###
DeinAlptraum wrote:
Unnecessary whitespace chang
@@ -161,7 +161,34 @@ class TranslationUnitLoadError(Exception):
FIXME: Make libclang expose additional error information in this scenario.
"""
-pass
+# A generic error code, no further details are available.
+#
+# Errors of this kind can get their own s
@@ -59,6 +59,9 @@ Clang Python Bindings Potentially Breaking Changes
- Calling a property on the `CompletionChunk` or `CompletionString` class
statically now leads to an error, instead of returning a `CachedProperty`
object
that is used internally. Properties are only avai
@@ -161,7 +161,34 @@ class TranslationUnitLoadError(Exception):
FIXME: Make libclang expose additional error information in this scenario.
DeinAlptraum wrote:
I would say your change resolves the `FIXME` here. Thanks for expanding this to
the `create`/`pars
1 - 100 of 273 matches
Mail list logo
