https://github.com/DeinAlptraum commented:

Thank you for the PR, imo this is a much better approach than the previous one.

As I mentioned before, I'm not familiar with the testing infrastructure, but 
insofar as it works, this looks good to me.

Do note that the libclang CI should also be adapted: 
`.github/workflows/libclang-python-tests.yml`
The target it uses doesn't exist anymore, and the paths that trigger the 
workflow should also be changed to remove the old path and include 
`clang/tests/bindings/python`. You can now also remove the trigger on 
`clang/CMakeLists.txt`, which should make this run far less often on unrelated 
PRs.

https://github.com/llvm/llvm-project/pull/142948
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to