DeinAlptraum wrote:

@Endilll I added the tests as discussed on #138074 . I'm just not sure how/if 
we can reasonably test the `else` path for `briefComment`: this requires a 
libclang.so built before LLVM 3.2. In fact, I'm not entirely sure what the 
point here is: being able to use the same `libclang.so` with a newer 
`cindex.py` and then returning nonsense instead of erroring out surely can't be 
the goal, right? Perhaps we're better off removing the if/else part entirely?

https://github.com/llvm/llvm-project/pull/138132
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to