DeinAlptraum wrote: > Besides, one could just change the wording of the warning message: trying to > load a 32-bit libclang.so into a 64-bit python is always an error, testsuite > or no.
That's why you shouldn't return an exit code of 0 when this error occurs. Moreover, this seems like a workaround for that one specific issue you encountered. > Even if the error message were emitted, this doesn't help because ninja > check-all is still broken, there being no way to disable check-clang-python > even manually. It looks to me like the proper solution would be to wrap the `check-clang-python` target somehow as to change the exit code to 0. E.g. just pipe to `true` or something like that. (is there an issue with that approach? I'm not that familiar with cmake) Probably not relevant then, but is there a reason you called `os._exit` instead of `sys.exit`? `os._exit` skips exit handlers etc. so `sys.exit` is usually preferred (though I doubt it makes a difference here) https://github.com/llvm/llvm-project/pull/142353 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
