[clang] [clang] fix uefi target for aarch64 & x86_64 (PR #120632)

@@ -790,7 +790,9 @@ template class LLVM_LIBRARY_VISIBILITY UEFITargetInfo : public OSTargetInfo { protected: void getOSDefines(const LangOptions &Opts, const llvm::Triple &Triple, -MacroBuilder &Builder) const override {} +MacroBuilder

[PATCH] D86310: [X86] Align i128 to 16 bytes in x86 datalayouts

echristo accepted this revision. echristo added a comment. Explicitly still ok with this as well. Thanks for continuing here. :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86310/new/ https://reviews.llvm.org/D86310 _

[clang] [clang] Predefined macros for float128 support (PR #67196)

https://github.com/echristo commented: In general this looks good. Since we don't have full compiler-rt support for this yet we may want to wait until that to merge. Alex is already looking at this and coordinating with his needs is probably the best solution. https://github.com/llvm/llvm-proj

[PATCH] D141547: Fix format for `case` in .proto files

echristo accepted this revision. echristo added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141547/new/ https://reviews.llvm.org/D141547 __

[PATCH] D127812: [AArch64] Function multiversioning support added.

echristo added a comment. In D127812#3616603 , @danielkiss wrote: > In D127812#3602688 , @aaron.ballman > wrote: > >> In D127812#3602645 , @erichkeane >> wrote: >> >>>

[PATCH] D110549: [HIPSPV][1/4] Refactor HIP tool chain

echristo added inline comments. Comment at: clang/lib/Driver/ToolChains/HIPUtility.cpp:119-133 + // Add MC directives to embed target binaries. We ensure that each + // section and image is 16-byte aligned. This is not mandatory, but + // increases the likelihood of data to be

Re: [PATCH] D51650: Implement target_clones multiversioning

I think you are these days too :) My offer was "past-past-me". I think you're probably ok here, I did a rough scan, but getting someone like Aaron for the attribute support would be good. On Fri, Nov 5, 2021 at 12:00 PM Erich Keane via Phabricator < revi...@reviews.llvm.org> wrote: > erichkeane a

[PATCH] D51650: Implement target_clones multiversioning

echristo added a comment. FWIW I'm a bit rusty in this area myself, but thanks for doing this. Let's see if we can't get Aaron to continue reviewing :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D51650/new/ https://reviews.llvm.org/D51650

[PATCH] D103125: [Clang][WIP] Allow renaming of "clang"

echristo added a comment. I'm also not a fan of this change. From a project perspective the binary is clang and while people may wish to change the name for their own product teams it seems like that onus should be on them. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D101867: [clang][test] Update -fc++-abi tests

echristo added a comment. Couple cleanups, but should be better now. Thanks! -eric Comment at: clang/test/Driver/cxx-abi-flag.cpp:3 +// RUN: %clang -### -fc++-abi=itanium -target x86_64-unknown-linux-gnu %s \ +// RUN: |& FileCheck %s -check-prefix=ITANIUM +// RUN: %clang -##

[PATCH] D85802: [clang] Add -fc++-abi= flag for specifying which C++ ABI to use

echristo added inline comments. Comment at: clang/test/Frontend/invalid-cxx-abi.cpp:1 +// These should succeed. +// RUN: %clang -c -fc++-abi=itanium %s Following up on an offline conversation :) This should be a driver test rather than (what it ended up being) a

Re: [PATCH] D100776: [clang/Basic] Make TargetInfo.h not use DataLayout again

Sounds good. It's a soft objection, mostly because if nothing else it puts us back where we were subject to some latent bugs, but perhaps not as bad as before (though I don't find having to use an assert build reassuring ;) Anyhow, go ahead and we'll figure out something else. On Tue, Apr 27, 202

Re: [PATCH] D96203: [clang][patch] Modify sanitizer options names: renaming blacklist to blocklist

On Tue, Apr 27, 2021 at 8:01 AM Melanie Blower via Phabricator < revi...@reviews.llvm.org> wrote: > mibintc abandoned this revision. > mibintc added a comment. > > There was no resolution about what option name would be acceptable > Oh no, I'm sorry that you felt that way. I saw Vitaly's comment

[PATCH] D100776: [clang/Basic] Make TargetInfo.h not use DataLayout again

echristo added a comment. In D100776#2699603 , @thakis wrote: > In D100776#2699565 , @rnk wrote: > >> Of the three people who commented on D17183 >> , you and I are on the only on

[PATCH] D17183: Make TargetInfo store an actual DataLayout instead of a string.

echristo added a comment. In D17183#2656771 , @jyknight wrote: > In general, I think it's extremely unfortunate that Clang and LLVM have > different copies of the same information. It's a problem for way more than > just this one situation. So, I really

Re: [PATCH] D97736: [Driver] Add a experimental option to link to LLVM libc.

On Fri, Mar 5, 2021 at 1:15 AM Siva Chandra via Phabricator < revi...@reviews.llvm.org> wrote: > sivachandra added a comment. > > In D97736#2605535 , @phosek > wrote: > > > Have you considered using an input linker script? We could generate > `libc.so` that

[PATCH] D97736: [Driver] Add a experimental option to link to LLVM libc.

echristo added a comment. In addition to the bikeshed below, I'm not a huge fan of this in general. I think we should assume that the libc we link is complete and thus it would just be named "libc." and in a sysroot somewhere. Another option is perhaps looking at the rtlib option, but I'd want

[PATCH] D96203: [clang][patch] Modify sanitizer options names: renaming blacklist to blocklist

echristo added a comment. Exclusion list? or exclude? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96203/new/ https://reviews.llvm.org/D96203 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

[PATCH] D96906: [AMDGPU] gfx90a support

echristo added a comment. In D96906#2572842 , @msearles wrote: > In D96906#2572749 , @kzhuravl wrote: > >>> The point is that nobody upstream even got a chance to chime in. >> >> We are and will be taking care of an

[PATCH] D96203: [clang][patch] Modify sanitizer options names: renaming blacklist to blocklist

echristo added a reviewer: vitalybuka. echristo added a comment. In D96203#2548495 , @aaron.ballman wrote: > In D96203#2548471 , @mibintc wrote: > >> In D96203#2546856 , @aa

[PATCH] D63852: [Clang] Move assembler into a separate file

echristo accepted this revision. echristo added a comment. This revision is now accepted and ready to land. Thanks for the explanation, lgtm. -eric Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63852/new/ https://reviews.llvm.org/D63852 _

[PATCH] D89158: [NewPM] Run callbacks added via registerPipelineStartEPCallback under -O0

echristo added a comment. In D89158#2363220 , @aeubanks wrote: > Looking at BackendUtil.cpp in Clang as well as the Rust code, I'm back to > thinking that we should provide a way to to all callbacks. Then in the case > of passes added via TargetMachine,

[PATCH] D89184: Support complex target features combinations

echristo accepted this revision. echristo added a comment. This revision is now accepted and ready to land. Let's go ahead and unblock you, but getting a lot of this refactored would be great if you can. I think it's hitting the limits of the original design. :) CHANGES SINCE LAST ACTION http

[PATCH] D89184: Support complex target features combinations

echristo added a comment. I'll take a look tomorrow, sorry for the delay. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89184/new/ https://reviews.llvm.org/D89184 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D89184: Support complex target features combinations

echristo requested changes to this revision. echristo added a comment. This revision now requires changes to proceed. Mark as requesting changes :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89184/new/ https://reviews.llvm.org/D89184 ___ c

[PATCH] D89184: Support complex target features combinations

echristo added a comment. Hi Peng, Looks interesting, but I think the language support needs some more comments about what's expected and in addition through everything else please? I've added some inline comments with places I think could use it for sure. -eric Comment at:

[clang-tools-extra] 549e55b - Temporarily Revert "[clangd] Add Random Forest runtime for code completion."

Author: Eric Christopher Date: 2020-09-18T14:47:43-07:00 New Revision: 549e55b3d5634870aa9d42135f51ad46a6a0e347 URL: https://github.com/llvm/llvm-project/commit/549e55b3d5634870aa9d42135f51ad46a6a0e347 DIFF: https://github.com/llvm/llvm-project/commit/549e55b3d5634870aa9d42135f51ad46a6a0e347

[clang] 05777ab - Temporarily Revert "[DebugInfo] Move constructor homing case in shouldOmitDefinition."

Author: Eric Christopher Date: 2020-08-24T21:51:31-07:00 New Revision: 05777ab941063192b9ccb1775358a83a2700ccc1 URL: https://github.com/llvm/llvm-project/commit/05777ab941063192b9ccb1775358a83a2700ccc1 DIFF: https://github.com/llvm/llvm-project/commit/05777ab941063192b9ccb1775358a83a2700ccc1

Re: [PATCH] D85384: [X86] Add basic support for -mtune command line option in clang

This would be because at that point the default cpu was that and it probably had something to do with fallbacks. At this point it can be changed I imagine to whatever makes sense. On Wed, Aug 19, 2020, 1:12 AM Craig Topper via Phabricator < revi...@reviews.llvm.org> wrote: > craig.topper added a

[PATCH] D84068: AMDGPU/clang: Search resource directory for device libraries

echristo added a comment. Hi All, I'd really like to avoid depending on any program other than clang installing something into clang's working directory. I think this needs to be written from the perspective of specifying another directory to look for things. -eric CHANGES SINCE LAST ACTION

[PATCH] D83273: [X86] Remove the feature dependency handling in X86TargetInfo::setFeatureEnabledImpl to a table based lookup in X86TargetParser.cpp

echristo added a comment. In D83273#2194842 , @nickdesaulniers wrote: > In D83273#2194832 , @craig.topper > wrote: > >> It's a pretty nasty revert in our downstream tree where we have prototyped >> future ISAs. S

Re: [PATCH] D83273: [X86] Remove the feature dependency handling in X86TargetInfo::setFeatureEnabledImpl to a table based lookup in X86TargetParser.cpp

Ow. Can revert and reapply after we fix the caching problem perhaps? -eric On Tue, Aug 4, 2020 at 3:48 PM Nick Desaulniers via Phabricator < revi...@reviews.llvm.org> wrote: > nickdesaulniers added a comment. > > I just collected a perf profile for an entire build. > `getImpliedDisabledFeatures`

Re: [PATCH] D85231: Protect against filenames with no extension at all.

Could maybe add an assert along with the patch as well as an assert only test? On Tue, Aug 4, 2020, 1:42 PM Sterling Augustine via Phabricator < revi...@reviews.llvm.org> wrote: > saugustine added a comment. > > The darwin-dsymutil.c tests this code path right now on line 33. I found > this error

[PATCH] D84058: Pass -rtlib=libgcc in tests conditioned on the default.

echristo added a reviewer: saugustine. echristo added a comment. (Adding Sterling as well) I think this will be an OK workaround for now, go ahead and reply on the main thread as I think they'll want to set the default runtime library as part of the toolchain. I'm surprised at this behavior as w

[PATCH] D83360: [InstSimplify] Remove select ?, undef, X -> X and select ?, X, undef -> X

echristo added a comment. In D83360#2154637 , @aqjune wrote: > In D83360#2154584 , @echristo wrote: > > > It's that even before the msan instrumentation the IR doesn't look correct > > - thus a miscompile. > > > I'

[PATCH] D83360: [InstSimplify] Remove select ?, undef, X -> X and select ?, X, undef -> X

echristo added a comment. It's that even before the msan instrumentation the IR doesn't look correct - thus a miscompile. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83360/new/ https://reviews.llvm.org/D83360 _

[PATCH] D83360: [InstSimplify] Remove select ?, undef, X -> X and select ?, X, undef -> X

echristo added a comment. We're starting to see miscompiles as we do more testing as well, just nothing smaller at the moment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83360/new/ https://reviews.llvm.org/D83360

[PATCH] D83360: [InstSimplify] Remove select ?, undef, X -> X and select ?, X, undef -> X

echristo added a comment. This seems like something that we should then revert until we know that instsimplify can be updated with a fix? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83360/new/ https://reviews.llvm.org/D83360 _

[PATCH] D83897: [X86] Add a generic 32-bit CPU with sse2 with modern tuning flags to be used as the default for the 32-bit targets instead of pentium4

echristo added a comment. Did you want to just change the pentium4 tuning? Otherwise naming things is hard and this feels awkward, but I don't have any better ideas :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83897/new/ https://reviews.llvm.org/D83897 __

Re: [PATCH] D80833: [CodeView] Add full repro to LF_BUILDINFO record

Release+Asserts on x86_64-linux and the debug-info-codeview-buildinfo.c test. Sorry if the latter wasn't clear :) -eric On Fri, Jul 10, 2020 at 4:12 PM Alexandre Ganea wrote: > Thanks for letting me know Eric. What test fails exactly? What config? > > > > *De :* Eric Ch

Re: [PATCH] D80833: [CodeView] Add full repro to LF_BUILDINFO record

You'll probably want the assert as well: assert.h assertion failed at llvm-project/llvm/lib/MC/MCStreamer.cpp:134 in virtual void llvm::MCStreamer::emitIntValue(uint64_t, unsigned int): (isUIntN(8 * Size, Value) || isIntN(8 * Size, Value)) && "Invalid size" On Fri, Jul 1

Re: [PATCH] D80833: [CodeView] Add full repro to LF_BUILDINFO record

I'm seeing tests fail with a crash. Can we revert the patch and attempted fixes and start working from there? Stacktrace for the curious :) @ 0x56420187cbbe llvm::MCStreamer::emitIntValue() @ 0x5641fec38899 llvm::MCStreamer::emitInt16() @ 0x5641ff73b337 llvm::CodeViewDe

[PATCH] D83013: [LPM] Port CGProfilePass from NPM to LPM

echristo added a comment. Some inline nits. I see you've already committed and that's fine - I still don't think we should do it, but we can delete it again soon :) Comment at: clang/lib/CodeGen/BackendUtil.cpp:623 PMBuilder.LoopVectorize = CodeGenOpts.VectorizeLoop; + PMB

[PATCH] D83273: [X86] Remove the feature dependency handling in X86TargetInfo::setFeatureEnabledImpl to a table based lookup in X86TargetParser.cpp

echristo accepted this revision. echristo added a comment. This revision is now accepted and ready to land. Works for me :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83273/new/ https://reviews.llvm.org/D83273 ___ cfe-commits mailing lis

Re: [PATCH] D83013: [LPM] Port CGProfilePass from NPM to LPM

On Sun, Jul 5, 2020 at 8:47 PM Arthur Eubanks via Phabricator < revi...@reviews.llvm.org> wrote: > aeubanks added a comment. > > In D83013#2132070 , @echristo > wrote: > > > Adding Chandler and Alina here as well. > > > > In general, I don't think that this

[PATCH] D83013: [LPM] Port CGProfilePass from NPM to LPM

echristo added reviewers: chandlerc, asbirlea. echristo added a comment. Adding Chandler and Alina here as well. In general, I don't think that this is such a great idea. Being able to have this sort of thing work more reliably is one of the reasons for the new pass manager. I think I'd like to

[PATCH] D71687: Fix full loop unrolling initialization in new pass manager

echristo closed this revision. echristo added a comment. Committed a while back. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71687/new/ https://reviews.llvm.org/D71687 ___ cfe-commits mailing list cf

[clang] 0861889 - [clang/llvm] As part of using inclusive language within

Author: Eric Christopher Date: 2020-06-20T16:03:58-07:00 New Revision: 0861889be103bf7bcf013768e913695ed94b50bf URL: https://github.com/llvm/llvm-project/commit/0861889be103bf7bcf013768e913695ed94b50bf DIFF: https://github.com/llvm/llvm-project/commit

[clang-tools-extra] da6332f - [clang-tidy] As part of using inclusive language within

Author: Eric Christopher Date: 2020-06-20T15:20:11-07:00 New Revision: da6332f5f9f15f7b182f27bc9b8edbf709b48093 URL: https://github.com/llvm/llvm-project/commit/da6332f5f9f15f7b182f27bc9b8edbf709b48093 DIFF: https://github.com/llvm/llvm-project/commit/da6332f5f9f15f7b182f27bc9b8edbf709b48093

[clang-tools-extra] ef455a5 - Update comment to be more clear.

Author: Eric Christopher Date: 2020-06-20T14:44:41-07:00 New Revision: ef455a55bcf2cfea04a99c361b182ad18b7f03f1 URL: https://github.com/llvm/llvm-project/commit/ef455a55bcf2cfea04a99c361b182ad18b7f03f1 DIFF: https://github.com/llvm/llvm-project/commit/ef455a55bcf2cfea04a99c361b182ad18b7f03f1

[clang] 10563e1 - [Analysis/Transforms/Sanitizers] As part of using inclusive language

Author: Eric Christopher Date: 2020-06-20T00:42:26-07:00 New Revision: 10563e16aa2c432a883695ddd714da68751bbd77 URL: https://github.com/llvm/llvm-project/commit/10563e16aa2c432a883695ddd714da68751bbd77 DIFF: https://github.com/llvm/llvm-project/commit/10563e16aa2c432a883695ddd714da68751bbd77

[clang-tools-extra] 16897e4 - Update test file.

Author: Eric Christopher Date: 2020-06-19T23:13:28-07:00 New Revision: 16897e47baa2b7cd1f63f40f8355c372b841f83d URL: https://github.com/llvm/llvm-project/commit/16897e47baa2b7cd1f63f40f8355c372b841f83d DIFF: https://github.com/llvm/llvm-project/commit

[clang-tools-extra] 25ed42f - [clang-change-namespace] As part of using inclusive language

Author: Eric Christopher Date: 2020-06-19T23:01:42-07:00 New Revision: 25ed42f05d07d3ad85c58ee001752338211c911c URL: https://github.com/llvm/llvm-project/commit/25ed42f05d07d3ad85c58ee001752338211c911c DIFF: https://github.com/llvm/llvm-project/commit

Re: [PATCH] D82244: [SanitizeCoverage] Rename -fsanitize-coverage-{white, black}list to -fsanitize-coverage-{allow,block}list

On Fri, Jun 19, 2020 at 10:43 PM Fangrui Song via Phabricator < revi...@reviews.llvm.org> wrote: > MaskRay added inline comments. > > > > Comment at: clang/docs/ClangCommandLineReference.rst:891 > > Restrict sanitizer coverage instrumentation exclusively to modules and > function

[clang-tools-extra] d313cb6 - Update redirected output file.

Author: Eric Christopher Date: 2020-06-19T23:30:16-07:00 New Revision: d313cb6e956de9448e4b979763ee8d12ce4103cb URL: https://github.com/llvm/llvm-project/commit/d313cb6e956de9448e4b979763ee8d12ce4103cb DIFF: https://github.com/llvm/llvm-project/commit

[clang] 1f593f4 - [AST/Lex/Parse/Sema] As part of using inclusive language within

Author: Eric Christopher Date: 2020-06-20T01:15:32-07:00 New Revision: 1f593f46f35b3afb1ba6e4700285cf8fd1b81bc7 URL: https://github.com/llvm/llvm-project/commit/1f593f46f35b3afb1ba6e4700285cf8fd1b81bc7 DIFF: https://github.com/llvm/llvm-project/commit/1f593f46f35b3afb1ba6e4700285cf8fd1b81bc7

[clang-tools-extra] a146991 - Update error to read a little better when an error occurs.

Author: Eric Christopher Date: 2020-06-19T23:34:30-07:00 New Revision: a1469914fd7542526693b07a26a0bdcaa27591a3 URL: https://github.com/llvm/llvm-project/commit/a1469914fd7542526693b07a26a0bdcaa27591a3 DIFF: https://github.com/llvm/llvm-project/commit/a1469914fd7542526693b07a26a0bdcaa27591a3

[PATCH] D82244: [SanitizeCoverage] Rename -fsanitize-coverage-{white,black}list to -fsanitize-coverage-{allow,block}list

echristo added inline comments. Comment at: clang/docs/ClangCommandLineReference.rst:891 Restrict sanitizer coverage instrumentation exclusively to modules and functions that match the provided special case list, except the blacklisted ones MaskRay wrote: >

[PATCH] D82244: [SanitizeCoverage] Rename -fsanitize-coverage-{white,black}list to -fsanitize-coverage-{allow,block}list

echristo accepted this revision. echristo added a comment. This revision is now accepted and ready to land. Couple of inline comments then looks good to go. Thank you so much for your effort here. -eric Comment at: clang/docs/ClangCommandLineReference.rst:891 Restrict sani

[PATCH] D82244: [SanitizeCoverage] Rename -fsanitize-coverage-{white,black}list to -fsanitize-coverage-{allow,block}list

echristo added inline comments. Comment at: clang/docs/ClangCommandLineReference.rst:313-316 +.. option:: -mharden-sls= + +Select straight-line speculation hardening scope + Miss merge? Comment at: clang/docs/ClangCommandLineReference.rst:891

[PATCH] D82244: [SanitizeCoverage] Rename -fsanitize-coverage-{white,black}list to -fsanitize-coverage-{allow,block}list

echristo added a reviewer: HAPPY. echristo added a comment. You'll want to grab blacklist/whitelist in the comments around as well. We've been talking about having a need for deprecated aliases file for these options - it's probably worth bringing this patch up on cfe-dev and cc'ing richardsmit

[clang-tools-extra] f8a463c - As part of using inclusive language within the llvm project,

Author: Eric Christopher Date: 2020-06-19T15:43:51-07:00 New Revision: f8a463c170964bff7e239bb8268a4927a4547d3c URL: https://github.com/llvm/llvm-project/commit/f8a463c170964bff7e239bb8268a4927a4547d3c DIFF: https://github.com/llvm/llvm-project/commit

[clang-tools-extra] 937c135 - As part of using inclusive language within the llvm project,

Author: Eric Christopher Date: 2020-06-19T15:41:06-07:00 New Revision: 937c135dd57e86ccd3fd64ca7b07915a75157986 URL: https://github.com/llvm/llvm-project/commit/937c135dd57e86ccd3fd64ca7b07915a75157986 DIFF: https://github.com/llvm/llvm-project/commit/937c135dd57e86ccd3fd64ca7b07915a75157986

[clang-tools-extra] f92011d - As part of using inclusive language within the llvm project,

Author: Eric Christopher Date: 2020-06-19T15:12:18-07:00 New Revision: f92011d875cfdca1ed97bf0ab6956364c604b578 URL: https://github.com/llvm/llvm-project/commit/f92011d875cfdca1ed97bf0ab6956364c604b578 DIFF: https://github.com/llvm/llvm-project/commit/f92011d875cfdca1ed97bf0ab6956364c604b578

[PATCH] D63852: [Clang] Move assembler into a separate file

echristo added a comment. Hmm. In general I'd like to hear more about what you're trying. Can you give an idea of how you'd like to invoke the library to assemble something via clang? Why not just call into llvm directly? I'm not necessarily against changing the layering here fwiw, just wanted

Re: [clang] 059ba74 - Revert "[codeview] Put !heapallocsite on calls to operator new"

FWIW before you reapply this let me know. I've seen some other failures associated and would like to give it a run through. -eric On Sat, Jun 6, 2020 at 4:38 PM Douglas Yung via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > Author: Douglas Yung > Date: 2020-06-06T23:30:46Z > New Revision:

[PATCH] D80883: [Driver] Add multiclass OptInFlag and OptOutFlag to simplify boolean option definition

echristo accepted this revision. echristo added a comment. This looks good to me. Might want to open a project around migrating everything. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80883/new/ https://reviews.llvm.org/D80883

[clang] c554c5e - Fix full unrolling with new pass manager.

Author: Eric Christopher Date: 2020-05-29T20:08:21-07:00 New Revision: c554c5e159aee43c5cd8236e077817e9f29dea78 URL: https://github.com/llvm/llvm-project/commit/c554c5e159aee43c5cd8236e077817e9f29dea78 DIFF: https://github.com/llvm/llvm-project/commit/c554c5e159aee43c5cd8236e077817e9f29dea78

[PATCH] D71687: Fix full loop unrolling initialization in new pass manager

echristo updated this revision to Diff 267424. echristo marked an inline comment as done. echristo added a comment. Update and restructure some test cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71687/new/ https://reviews.llvm.org/D71687 Fi

[PATCH] D71687: Fix full loop unrolling initialization in new pass manager

echristo marked 7 inline comments as done. echristo added a comment. Done. New diff incoming. Comment at: clang/test/Misc/loop-opt-setup.c:12 +// Check br i1 to make sure that the loop is fully unrolled // CHECK-NOT: br i1 chandlerc wrote: > This is dead now

[PATCH] D79117: [clang] [Darwin] Add reverse mappings for aarch64/aarch64_32 to darwin arch names

echristo accepted this revision. echristo added a comment. This revision is now accepted and ready to land. This seems ok to me. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79117/new/ https://reviews.llvm.org/D79117 ___

[PATCH] D43002: Emit S_OBJNAME symbol in CodeView

echristo added a comment. First question: Since split dwarf has to do some similar things can we not use the same support? This seems to be a lot of changes for this. Second question: and if we can't use the same support can we make split dwarf use this? Having two separate methods for passin

[clang] 97a133f - Temporarily Revert "[Clang][AArch64] Capturing proper pointer alignment for Neon vld1 intrinsicts"

Author: Eric Christopher Date: 2020-05-26T18:51:00-07:00 New Revision: 97a133f15724aa7ddf5d9b62dc9c0657a4efd115 URL: https://github.com/llvm/llvm-project/commit/97a133f15724aa7ddf5d9b62dc9c0657a4efd115 DIFF: https://github.com/llvm/llvm-project/commit/97a133f15724aa7ddf5d9b62dc9c0657a4efd115

[PATCH] D79916: Map -O to -O1 instead of -O2

echristo accepted this revision. echristo added a reviewer: dexonsmith. echristo added a comment. This revision is now accepted and ready to land. I'm totally down, but you knew that already :) Duncan: Do you have any concerns? I doubt it, but just checking. Repository: rG LLVM Github Monorep

Re: [clang] d82538b - Fix -Wunused compiler warning.

Very much so. Also nice all_of use! I'd have never thought about that :) -eric On Mon, May 11, 2020 at 7:03 PM David Blaikie via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > > On Mon, May 11, 2020 at 12:21 AM Haojian Wu via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> >> Autho

Re: [PATCH] D72281: [Matrix] Add matrix type to Clang.

FWIW this broke lldb builds due to an unhandled enumeration. I've fixed them in: commit cd7cb1f4ce3ffc8be1146eeba28ae7dc50089459 (origin/master, origin/HEAD) Author: Eric Christopher Date: Mon May 11 13:44:12 2020 -0700 Update lldb for rG10658691951f to avoid Werror messages a

[PATCH] D71687: Fix full loop unrolling initialization in new pass manager

echristo marked 6 inline comments as done. echristo added a comment. OK, ready again :) Comment at: llvm/test/Transforms/LoopUnroll/FullUnroll.ll:4-6 +; We don't end up deleting the loop, but we remove everything inside of it so checking for any +; reasonable instruction from

[PATCH] D71687: Fix full loop unrolling initialization in new pass manager

echristo updated this revision to Diff 262458. echristo added a comment. Update and reduce testcase a bit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71687/new/ https://reviews.llvm.org/D71687 Files: clang/test/Misc/loop-opt-setup.c llvm/li

[PATCH] D71687: Fix full loop unrolling initialization in new pass manager

echristo updated this revision to Diff 261928. echristo edited the summary of this revision. echristo added a comment. Herald added a subscriber: zzheng. Add a testcase with opt and command line option so we can enable it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[PATCH] D79210: Let clang print registered targets for --version

echristo accepted this revision. echristo added a comment. This revision is now accepted and ready to land. Yeah, it's fine. We might want to put it behind a "long information" option, but for now it's ok. Keep an eye open if someone complains please. CHANGES SINCE LAST ACTION https://reviews

[PATCH] D79210: Let clang print registered targets for --version

echristo added a comment. LGTM if it works? Can you post the output into the commit message so we can review that here? I guess clang -v or something? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79210/new/ https://reviews.llvm.org/D79210 ___

[clang-tools-extra] 35edd70 - Temporarily revert "build: use `find_package(Python3)` if available"

Author: Eric Christopher Date: 2020-04-28T16:41:22-07:00 New Revision: 35edd704e0fda09e8e634515c0b451d4a8b6b914 URL: https://github.com/llvm/llvm-project/commit/35edd704e0fda09e8e634515c0b451d4a8b6b914 DIFF: https://github.com/llvm/llvm-project/commit/35edd704e0fda09e8e634515c0b451d4a8b6b914

[clang] 35edd70 - Temporarily revert "build: use `find_package(Python3)` if available"

Author: Eric Christopher Date: 2020-04-28T16:41:22-07:00 New Revision: 35edd704e0fda09e8e634515c0b451d4a8b6b914 URL: https://github.com/llvm/llvm-project/commit/35edd704e0fda09e8e634515c0b451d4a8b6b914 DIFF: https://github.com/llvm/llvm-project/commit/35edd704e0fda09e8e634515c0b451d4a8b6b914

Re: [PATCH] D78501: Add a facility to get system cache directory and use it in clangd

I've had to temporarily revert this as it was breaking some tests: .../sources/llvm-project/llvm/unittests/Support/Path.cpp:334:5: error: use of undeclared identifier 'set' set(Value); ^ 1 error generated. Happy to help diagnose this with you if you need some assistance.

[clang-tools-extra] faf2dce - Temporarily revert "Add a facility to get system cache directory and use it in clangd"

Author: Eric Christopher Date: 2020-04-28T15:49:46-07:00 New Revision: faf2dce1dd6ae25aa75d2685ac7bb27ec31e2ced URL: https://github.com/llvm/llvm-project/commit/faf2dce1dd6ae25aa75d2685ac7bb27ec31e2ced DIFF: https://github.com/llvm/llvm-project/commit

[PATCH] D77954: [CUDA][HIP] Fix host/device based overload resolution

echristo added a subscriber: erichkeane. echristo added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:9749 + if (isBetterMultiversionCandidate(Cand1, Cand2)) +return true; + rjmccall wrote: > yaxunl wrote: > > rjmccall wrote: > > > If we move

[PATCH] D76297: [clang][AArch64] readd support for 'p' inline asm constraint

echristo added inline comments. Comment at: clang/test/CodeGen/inline-asm-p-constraint.c:1 +// RUN: %clang_cc1 -emit-llvm %s -o - -triple aarch64-linux-gnu | FileCheck %s +void foo(void* ptr) { nickdesaulniers wrote: > Does this need `REQUIRES: aarch64-registered

[PATCH] D71687: Fix full loop unrolling initialization in new pass manager

echristo updated this revision to Diff 250232. echristo added a comment. Fix comments around full unroller. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71687/new/ https://reviews.llvm.org/D71687 Files: clang/test/Misc/loop-opt-setup.c llvm/l

[PATCH] D71687: Fix full loop unrolling initialization in new pass manager

echristo updated this revision to Diff 250229. echristo added a comment. Fixed the clang test. Tried to get something that I could reduce down and duplicate with just opt but it's been... difficult. Even the small clang testcase in isolation won't duplicate via something like: clang -O0 -fexpe

Re: [clang] 83f4372 - [CodeGen] fix clang test that runs the optimizer pipeline; NFC

urning everything down to -O0, and it all > passed except for the "fast-math" run for AArch64. > I can tweak that to not be so specific if that sounds like a reasonable > solution. > > On Wed, Feb 26, 2020 at 1:05 PM Eric Christopher > wrote: > >> I mean anything th

Re: [PATCH] D74918: Add method to TargetInfo to get CPU cache line size

I'm agreed with James on all points fwiw. On Thu, Feb 27, 2020, 2:00 PM James Y Knight via Phabricator < revi...@reviews.llvm.org> wrote: > jyknight requested changes to this revision. > jyknight added a comment. > This revision now requires changes to proceed. > > In D74918#1885869

Re: [clang] 83f4372 - [CodeGen] fix clang test that runs the optimizer pipeline; NFC

#x27;m not familiar with _Complex enough to say how to fix this > properly (seems like the check lines are already limited such that -O0 > rather than -O1 would work?). > > But this file keeps wiggling unexpectedly, it's going to move again with > https://reviews.llvm.org/D75

[PATCH] D75152: Fix typo

echristo accepted this revision. echristo added a comment. This revision is now accepted and ready to land. This probably qualifies as "obvious" :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75152/new/ https://reviews.llvm.org/D75152

Re: [clang] 83f4372 - [CodeGen] fix clang test that runs the optimizer pipeline; NFC

Is there any way to pull this test out of clang and as an opt test? What's it trying to test? -eric On Tue, Feb 25, 2020 at 6:15 AM Sanjay Patel via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > Author: Sanjay Patel > Date: 2020-02-25T09:13:49-05:00 > New Revision: 83f4372f3a708ceaa800fef

[clang-tools-extra] 28728bf - Fix a signed/unsigned warning promoted to error.

Author: Eric Christopher Date: 2020-02-18T17:49:22-08:00 New Revision: 28728bf06f556dc8be5bc1fa77129906ba68 URL: https://github.com/llvm/llvm-project/commit/28728bf06f556dc8be5bc1fa77129906ba68 DIFF: https://github.com/llvm/llvm-project/commit/28728bf06f556dc8be5bc1fa77129906ba68

[PATCH] D70172: [CUDA][HIP][OpenMP] Emit deferred diagnostics by a post-parsing AST travese

echristo added a comment. In D70172#1879481 , @jpienaar wrote: > This seems to result in triggering clang/lib/CodeGen/CGExpr.cpp:2626 when > compiling mlir/lib/Transforms/AffineDataCopyGeneration.cpp with clang build > with assertions on (clean build at

[PATCH] D63607: [clang][driver] Add basic --driver-mode=flang support for fortran

echristo added a comment. Sadly I'm just noticing this: I don't really agree with the rationale for adding fortran support to the clang driver. My proposed design here would be to move the aspects you need out of clang and into a separate library in llvm that you can use instead. I don't neces

Re: [clang] 24ab9b5 - Generalize the pass registration mechanism used by Polly to any third-party tool

On Wed, Jan 8, 2020 at 1:40 AM Serge Guelton wrote: > On Tue, Jan 07, 2020 at 04:57:29PM -0800, Eric Christopher wrote: > > > ; CHECK-EP-VECTORIZER-START-NEXT: Running pass: NoOpFunctionPass > > > +; CHECK-EXT: Running pass: {{.*}}::Bye on foo > > > &g

Re: [clang] 24ab9b5 - Generalize the pass registration mechanism used by Polly to any third-party tool

On Wed, Jan 8, 2020 at 3:07 PM Michael Kruse wrote: > Am Di., 7. Jan. 2020 um 18:57 Uhr schrieb Eric Christopher via > cfe-commits : > >> Is there anything I should have done? Probably reaching llvm-dev before > >> commiting. Reaching the right reviewers has always bee

Re: [clang] 24ab9b5 - Generalize the pass registration mechanism used by Polly to any third-party tool

Hi Serge! Thanks for a lot of the answers here :) > > The proposed infrastructure makes this process smoother and non intrusive > to the > llvm-project codebase: all development can be done in a separate git repo, > integration is controlled through cmake flags, and integration to > clang/opt/bug

  1   2   3   4   5   6   7   8   9   >