echristo added a comment. Couple cleanups, but should be better now. Thanks!
-eric ================ Comment at: clang/test/Driver/cxx-abi-flag.cpp:3 +// RUN: %clang -### -fc++-abi=itanium -target x86_64-unknown-linux-gnu %s \ +// RUN: |& FileCheck %s -check-prefix=ITANIUM +// RUN: %clang -### -fc++-abi=fuchsia -target x86_64-unknown-fuchsia %s \ ---------------- This is typically done via 2>&1 rather than |&. ================ Comment at: clang/test/Frontend/valid-cxx-abi.cpp:2 +// These should be valid cxx abi flags for these targets. +// RUN: %clang_cc1 -fc++-abi=itanium -triple x86_64-unknown-linux-gnu %s -fsyntax-only +// RUN: %clang_cc1 -fc++-abi=fuchsia -triple x86_64-unknown-fuchsia %s -fsyntax-only ---------------- I'd add a -S -o - to each of these command lines. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101867/new/ https://reviews.llvm.org/D101867 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits