echristo added inline comments.
================ Comment at: clang/docs/ClangCommandLineReference.rst:313-316 +.. option:: -mharden-sls=<arg> + +Select straight-line speculation hardening scope + ---------------- Miss merge? ================ Comment at: clang/docs/ClangCommandLineReference.rst:891 Restrict sanitizer coverage instrumentation exclusively to modules and functions that match the provided special case list, except the blacklisted ones ---------------- I'd remove the uses of blacklist and whitelist here and below. Just have the language and the documentation be for the new option. ================ Comment at: clang/docs/SanitizerCoverage.rst:435 Options - -blacklist=<string> - Blacklist file (sanitizer blacklist format). + -blacklist=<string> - Blocklist file (sanitizer blocklist format). -demangle - Print demangled function name. ---------------- blacklist here. ================ Comment at: clang/include/clang/Driver/Options.td:1002 HelpText<"Restrict sanitizer coverage instrumentation exclusively to modules and functions that match the provided special case list, except the blacklisted ones">; -def fsanitize_coverage_blacklist : Joined<["-"], "fsanitize-coverage-blacklist=">, +def : Joined<["-"], "fsanitize-coverage-whitelist=">, + Group<f_clang_Group>, Flags<[CoreOption, HelpHidden]>, Alias<fsanitize_coverage_allowlist>; ---------------- Deprecate the option and comment it as such. ================ Comment at: compiler-rt/test/sanitizer_common/TestCases/sanitizer_coverage_allowlist_blocklist.cpp:2 +// Tests -fsanitize-coverage-allowlist=whitelist.txt and +// -fsanitize-coverage-blocklist=blacklist.txt with libFuzzer-like coverage // options ---------------- blacklist filename. probably want to change wl_* and bl_* below as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82244/new/ https://reviews.llvm.org/D82244 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits