https://github.com/inbelic approved this pull request.
https://github.com/llvm/llvm-project/pull/138993
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/alexey-bataev approved this pull request.
https://github.com/llvm/llvm-project/pull/139118
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/wlei-llvm closed
https://github.com/llvm/llvm-project/pull/136333
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/erichkeane approved this pull request.
On its face, and thinking about it for ~10 minutes, this seems completely
reasonable. I think @zyn0217 has some reasonable comments, so make him happy,
and I am.
https://github.com/llvm/llvm-project/pull/139057
https://github.com/ellishg approved this pull request.
https://github.com/llvm/llvm-project/pull/136333
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang-driver
Author: Yaxun (Sam) Liu (yxsamliu)
Changes
Currently ROCm 6.4.0 only recognize spirv64-amd-amdhsa- in bundle ID.
spirv64-amd-amdhsa-unknown causes all HIP apps compiled for amdgcnspirv to fail.
Previously we fixed a similar issue for
amdgc
https://github.com/cyndyishida edited
https://github.com/llvm/llvm-project/pull/138610
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,20 @@
+// This verifies that hotpatch function attributes are correctly propagated
when compiling directly to OBJ.
+//
+// RUN: %clang_cl -c --target=x86_64-windows-msvc -O2 /Z7
-fms-hotpatch-functions-file=%S/ms-hotpatch-functions.txt /Fo%t.obj %s
si
https://github.com/lamb-j approved this pull request.
Good catch, lgtm
https://github.com/llvm/llvm-project/pull/139112
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Yaxun (Sam) Liu (yxsamliu)
Changes
Currently ROCm 6.4.0 only recognize spirv64-amd-amdhsa- in bundle ID.
spirv64-amd-amdhsa-unknown causes all HIP apps compiled for amdgcnspirv to fail.
Previously we fixed a similar issue for
amdgcn-amd-a
https://github.com/yxsamliu created
https://github.com/llvm/llvm-project/pull/139112
Currently ROCm 6.4.0 only recognize spirv64-amd-amdhsa- in bundle ID.
spirv64-amd-amdhsa-unknown causes all HIP apps compiled for amdgcnspirv to fail.
Previously we fixed a similar issue for
amdgcn-amd-amdhsa-
Author: cor3ntin
Date: 2025-05-08T19:25:50+02:00
New Revision: 09c80e2944967332c4d889ef19a001ebb4521782
URL:
https://github.com/llvm/llvm-project/commit/09c80e2944967332c4d889ef19a001ebb4521782
DIFF:
https://github.com/llvm/llvm-project/commit/09c80e2944967332c4d889ef19a001ebb4521782.diff
LOG:
https://github.com/V-FEXrt closed
https://github.com/llvm/llvm-project/pull/138993
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Ashley Coleman
Date: 2025-05-08T11:20:17-06:00
New Revision: 0beb2f56f6f6eb5aab142334a47228cbbc86c22f
URL:
https://github.com/llvm/llvm-project/commit/0beb2f56f6f6eb5aab142334a47228cbbc86c22f
DIFF:
https://github.com/llvm/llvm-project/commit/0beb2f56f6f6eb5aab142334a47228cbbc86c22f.diff
https://github.com/inbelic edited
https://github.com/llvm/llvm-project/pull/138993
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/hekota closed
https://github.com/llvm/llvm-project/pull/138964
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/dpaoliello updated
https://github.com/llvm/llvm-project/pull/125320
>From 0fc8343ec561c5b64957008c40800e8335451b9d Mon Sep 17 00:00:00 2001
From: "Daniel Paoliello (HE/HIM)"
Date: Fri, 31 Jan 2025 16:47:23 -0800
Subject: [PATCH] [aarch64][x86][win] Add support for MSVC's /fun
https://github.com/cor3ntin updated
https://github.com/llvm/llvm-project/pull/138708
Rate limit · GitHub
body {
background-color: #f6f8fa;
color: #24292e;
font-family: -apple-system,BlinkMacSystemFont,Segoe
UI,Helvetica,Arial,sans-
Author: Helena Kotas
Date: 2025-05-08T10:03:21-07:00
New Revision: 3bc3b1c6c0f35bf223c595f8426f6726d64553e7
URL:
https://github.com/llvm/llvm-project/commit/3bc3b1c6c0f35bf223c595f8426f6726d64553e7
DIFF:
https://github.com/llvm/llvm-project/commit/3bc3b1c6c0f35bf223c595f8426f6726d64553e7.diff
https://github.com/robincaloudis created
https://github.com/llvm/llvm-project/pull/139107
None
Rate limit · GitHub
body {
background-color: #f6f8fa;
color: #24292e;
font-family: -apple-system,BlinkMacSystemFont,Segoe
UI,Helvetica,
@@ -0,0 +1,251 @@
+//===-- WindowsHotPatch.cpp - Support for Windows hotpatching
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
ahatanak wrote:
> Given that the mangleCXXRecordDecl function is used outside of the
> `MangleVTable` , I think the ABI compatibility logic should be moved to
> mangleCXXCtorVTable
Could you elaborate on how to separate just the ABI compatibility logic from
`mangleCXXRecordDecl`?
Wouldn't yo
@@ -176,6 +176,21 @@ class CallerSym : public SymbolRecord {
uint32_t RecordOffset = 0;
};
+class HotPatchFuncSym : public SymbolRecord {
sivadeilra wrote:
Our hot-patch tools read PDBs and then generate metadata that is placed into
the final DLL/SYS/EXE,
@@ -105,9 +105,6 @@ void errno_getcwd(char *Buf, size_t Sz) {
clang_analyzer_eval(errno != 0); // expected-warning{{TRUE}}
clang_analyzer_eval(Path == NULL); // expected-warning{{TRUE}}
if (errno) {} // no warning
- } else if (Path == NULL) {
https://github.com/cor3ntin created
https://github.com/llvm/llvm-project/pull/139104
We already warn when memcpy/memmove involves a non-trivially-copyable type.
Although we only warn when the target (not the source) is not trivially
copyable.
As we moved to deprecate the old is __is_trivially
dschuff wrote:
This looks good to me, @sbc100 and @sunfishcode might also be interested
(presumably the sanitizer runtime will end up alongside wasi-libc in the wasi
SDK?)
https://github.com/llvm/llvm-project/pull/139014
___
cfe-commits mailing list
Author: Qiongsi Wu
Date: 2025-05-08T08:49:11-07:00
New Revision: 2017831d449774e792692aac88721e409ba475e4
URL:
https://github.com/llvm/llvm-project/commit/2017831d449774e792692aac88721e409ba475e4
DIFF:
https://github.com/llvm/llvm-project/commit/2017831d449774e792692aac88721e409ba475e4.diff
LO
https://github.com/jofrn edited https://github.com/llvm/llvm-project/pull/123609
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
cyndyishida wrote:
> The change looks reasonable but can you add a test? thanks!
Open to other suggestions @cor3ntin, but I didn't figure out a way to ensure
part of a diagnostic was omitted with cc1's `-verify` so its a driver test that
uses `FIleCheck`
https://github.com/llvm/llvm-project/p
https://github.com/sivadeilra edited
https://github.com/llvm/llvm-project/pull/138972
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
AmrDeveloper wrote:
> In addition to the collapse clause, the ordered clause also seems to have the
> same problem. For example, does your patch also fix the following crash? If
> so, you also need tests regarding the ordered clause.
> https://godbolt.org/z/96sa5jxff
>
> ```c++
> void f(void)
https://github.com/AmrDeveloper updated
https://github.com/llvm/llvm-project/pull/138592
>From af3e49f1290c61d5856a5ddf600cfd19ef485e25 Mon Sep 17 00:00:00 2001
From: AmrDeveloper
Date: Mon, 5 May 2025 23:01:02 +0200
Subject: [PATCH 1/3] [clang][OpenMP] Add error for large expr in collapse
---
https://github.com/cachemeifyoucan approved this pull request.
Thanks. LGTM.
https://github.com/llvm/llvm-project/pull/138610
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/sivadeilra updated
https://github.com/llvm/llvm-project/pull/138972
Rate limit · GitHub
body {
background-color: #f6f8fa;
color: #24292e;
font-family: -apple-system,BlinkMacSystemFont,Segoe
UI,Helvetica,Arial,san
@@ -4899,6 +4899,237 @@ void
CGOpenMPRuntime::emitSingleReductionCombiner(CodeGenFunction &CGF,
}
}
+void CGOpenMPRuntime::emitPrivateReduction(
+CodeGenFunction &CGF, SourceLocation Loc, const Expr *Privates,
+const Expr *LHSExprs, const Expr *RHSExprs, const Expr
https://github.com/mizvekov edited
https://github.com/llvm/llvm-project/pull/139057
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Marina Taylor
Date: 2025-05-08T16:48:18+01:00
New Revision: 850d96e63a611c46313a5448cd49197d9295ce5f
URL:
https://github.com/llvm/llvm-project/commit/850d96e63a611c46313a5448cd49197d9295ce5f
DIFF:
https://github.com/llvm/llvm-project/commit/850d96e63a611c46313a5448cd49197d9295ce5f.diff
https://github.com/vsapsai closed
https://github.com/llvm/llvm-project/pull/138227
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sivadeilra wrote:
> Can you provide a more technical insight about how is this gonna be used?
> What are the equivalent MSVC flags? Why is it that users (programmers) need
> to select specific functions to hotpatch?
This PR is intended to allow LLVM-generated code to work with Windows
hot-pat
https://github.com/mizvekov edited
https://github.com/llvm/llvm-project/pull/139057
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cyndyishida updated
https://github.com/llvm/llvm-project/pull/138610
>From d642c83835743409395a2b7a091eac8bf5c948c4 Mon Sep 17 00:00:00 2001
From: Cyndy Ishida
Date: Mon, 5 May 2025 16:09:00 -0700
Subject: [PATCH 1/2] [clang] Remove "unknown" from availability diags
Previous
@@ -4174,6 +4174,14 @@ PackIndexingType::computeDependence(QualType Pattern,
Expr *IndexExpr,
return TD;
}
+void PackIndexingType::Profile(llvm::FoldingSetNodeID &ID,
+ const ASTContext &Context) {
+ if (hasSelectedType() && isFullySubstituted
@@ -709,7 +711,7 @@ static AvailabilityResult CheckAvailability(ASTContext
&Context,
<< EnvName << HintMessage;
cyndyishida wrote:
no 😅
https://github.com/llvm/llvm-project/pull/138610
___
cfe-commits ma
https://github.com/cyndyishida updated
https://github.com/llvm/llvm-project/pull/138610
Rate limit · GitHub
body {
background-color: #f6f8fa;
color: #24292e;
font-family: -apple-system,BlinkMacSystemFont,Segoe
UI,Helvetica,Arial,sa
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: cor3ntin (cor3ntin)
Changes
We already warn when memcpy/memmove involves a non-trivially-copyable type.
Although we only warn when the target (not the source) is not trivially
copyable.
As we moved to deprecate the old is __is_trivially_
https://github.com/Prabhuk closed
https://github.com/llvm/llvm-project/pull/138364
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
vsapsai wrote:
Thanks for the review!
https://github.com/llvm/llvm-project/pull/138227
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Volodymyr Sapsai
Date: 2025-05-08T09:07:33-07:00
New Revision: 64bb60a471a5ddc9c9bec413c65fdab730a1e4b0
URL:
https://github.com/llvm/llvm-project/commit/64bb60a471a5ddc9c9bec413c65fdab730a1e4b0
DIFF:
https://github.com/llvm/llvm-project/commit/64bb60a471a5ddc9c9bec413c65fdab730a1e4b0.di
https://github.com/illusory0x0 updated
https://github.com/llvm/llvm-project/pull/139093
Rate limit · GitHub
body {
background-color: #f6f8fa;
color: #24292e;
font-family: -apple-system,BlinkMacSystemFont,Segoe
UI,Helvetica,Arial,sa
@@ -12166,6 +12174,15 @@ static void DiagnoseBadDeduction(Sema &S, NamedDecl
*Found, Decl *Templated,
diag::note_ovl_candidate_explicit_arg_mismatch_unnamed)
<< (index + 1);
}
+
+if (PartialDiagnosticAt *PDiag = DeductionFailure.getSFINAEDiagnost
@@ -0,0 +1,84 @@
+//===-- llvm/Target/TargetVerifier.h - LLVM IR Target Verifier --*- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
https://github.com/qiongsiwu closed
https://github.com/llvm/llvm-project/pull/138955
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/qiongsiwu edited
https://github.com/llvm/llvm-project/pull/138955
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/el-ev updated
https://github.com/llvm/llvm-project/pull/136854
>From dbe66e5e48f769589592e22bcfb8c122910d91d1 Mon Sep 17 00:00:00 2001
From: Iris Shi <0...@owo.li>
Date: Thu, 8 May 2025 23:40:15 +0800
Subject: [PATCH] [CIR] Cleanup support for C functions
---
clang/lib/CIR/C
@@ -0,0 +1,84 @@
+//===-- llvm/Target/TargetVerifier.h - LLVM IR Target Verifier --*- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
llvmbot wrote:
@llvm/pr-subscribers-clang-static-analyzer-1
Author: None (flovent)
Changes
This PR aims to fix crash caused by `std::bit_cast`(#137417) and
`__builtin_bit_cast`(#71174).
The crash caused by `std::bit_cast` is actually due to the `__builtin_bit_cast`
used in its implement
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: None (flovent)
Changes
This PR aims to fix crash caused by `std::bit_cast`(#137417) and
`__builtin_bit_cast`(#71174).
The crash caused by `std::bit_cast` is actually due to the `__builtin_bit_cast`
used in its implementation (see the cod
https://github.com/flovent created
https://github.com/llvm/llvm-project/pull/139095
This PR aims to fix crash caused by `std::bit_cast`(#137417) and
`__builtin_bit_cast`(#71174).
The crash caused by `std::bit_cast` is actually due to the `__builtin_bit_cast`
used in its implementation (see th
macurtis-amd wrote:
@nikic ping ping ping
https://github.com/llvm/llvm-project/pull/133301
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Kirill Stoimenov
Date: 2025-05-08T15:39:10Z
New Revision: 2ec08836d1fd78e9efcdfd6f1307f35c8ec633e7
URL:
https://github.com/llvm/llvm-project/commit/2ec08836d1fd78e9efcdfd6f1307f35c8ec633e7
DIFF:
https://github.com/llvm/llvm-project/commit/2ec08836d1fd78e9efcdfd6f1307f35c8ec633e7.diff
L
https://github.com/el-ev updated
https://github.com/llvm/llvm-project/pull/136854
Rate limit · GitHub
body {
background-color: #f6f8fa;
color: #24292e;
font-family: -apple-system,BlinkMacSystemFont,Segoe
UI,Helvetica,Arial,sans-ser
https://github.com/DimitrijeDobrota edited
https://github.com/llvm/llvm-project/pull/138755
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/illusory0x0 edited
https://github.com/llvm/llvm-project/pull/139093
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/inbelic closed
https://github.com/llvm/llvm-project/pull/137999
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/illusory0x0 created
https://github.com/llvm/llvm-project/pull/139093
None
From f3a692b7b0e4800277bf7df10e800ccacce98b37 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=E7=8C=97=E9=9C=B2?=
<69190413+illusory...@users.noreply.github.com>
Date: Thu, 8 May 2025 23:00:54 +0800
Subject:
github-actions[bot] wrote:
Thank you for submitting a Pull Request (PR) to the LLVM Project!
This PR will be automatically labeled and the relevant teams will be notified.
If you wish to, you can add reviewers by using the "Reviewers" section on this
page.
If this is not working for you, it
https://github.com/saksham-joshi closed
https://github.com/llvm/llvm-project/pull/138713
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
saksham-joshi wrote:
> > Yeah! you are right that the size depends on the variable, but I never said
> > to create a variable.
> > Suppose I have two functions performing same process but one is returning
> > bool and other one is returning int.
> >
> > 1. bool fnc1() { return (_Bool)true; }
>
DimitrijeDobrota wrote:
> LGTM. It looks similar as #138757. could you add a test for both PR.
I have the issue where I want to test the `custom_move` and I need check to
pass only for `-check-suffix=,MOVEFUNCTION` and fail for everything else, since
it still expects `::std::move`. I am not su
https://github.com/apdofficial updated
https://github.com/llvm/llvm-project/pull/137609
From 2e82063e9e2c159a7a713ecedbcc0bfbdbf66143 Mon Sep 17 00:00:00 2001
From: Andrej Pistek
Date: Mon, 7 Apr 2025 13:37:47 +0200
Subject: [PATCH] [git-clang-format] add fallback style arg
---
clang/tools/cl
@@ -0,0 +1,84 @@
+//===-- llvm/Target/TargetVerifier.h - LLVM IR Target Verifier --*- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
Author: Finn Plummer
Date: 2025-05-08T08:24:47-07:00
New Revision: 55517f5f4495968d01100aa00d63db7842842270
URL:
https://github.com/llvm/llvm-project/commit/55517f5f4495968d01100aa00d63db7842842270
DIFF:
https://github.com/llvm/llvm-project/commit/55517f5f4495968d01100aa00d63db7842842270.diff
https://github.com/cyndyishida edited
https://github.com/llvm/llvm-project/pull/139087
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,84 @@
+//===-- llvm/Target/TargetVerifier.h - LLVM IR Target Verifier --*- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -0,0 +1,84 @@
+//===-- llvm/Target/TargetVerifier.h - LLVM IR Target Verifier --*- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -481,6 +481,9 @@ static cl::opt HasClosedWorldAssumption(
cl::desc("Whether has closed-world assumption at link time"),
cl::init(false), cl::Hidden);
+static cl::opt VerifyTarget("verify-tgt",
shiltian wrote:
`verify-tgt` is too broad. I'd add an `
apazos wrote:
This matter was addressed at the RVI Toolchain SIG meeting on 05/08/25.
It was concluded that the duplication of implied extensions, such as in the
cases of G and Zifencei, and F and Zicsr, can be silently disregarded. Both GCC
and LLVM toolchains are consistent with this approac
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Jan Svoboda (jansvoboda11)
Changes
Force-validation of user headers was implemented in acb803e8 to deal with files
changing during build. The dependency scanner guarantees an immutable file
system during single build session, so the valid
llvmbot wrote:
@llvm/pr-subscribers-clang-modules
Author: Jan Svoboda (jansvoboda11)
Changes
Force-validation of user headers was implemented in acb803e8 to deal with files
changing during build. The dependency scanner guarantees an immutable file
system during single build session, so t
https://github.com/jansvoboda11 created
https://github.com/llvm/llvm-project/pull/139091
Force-validation of user headers was implemented in acb803e8 to deal with files
changing during build. The dependency scanner guarantees an immutable file
system during single build session, so the validat
https://github.com/cyndyishida edited
https://github.com/llvm/llvm-project/pull/139087
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Cyndy Ishida (cyndyishida)
Changes
With the introduction of tbd-v5 holding rpaths, the order in which attributes
are passed to `clang-installapi` must be represented in tbd files. Previously,
all of these attributes were stored in a non-d
@@ -1181,7 +1228,9 @@ DEFINE_LIBUNWIND_FUNCTION(__unw_getcontext)
#endif
+#ifndef __arm64ec__
mstorsjo wrote:
Thanks, that's indeed cleaner when one clearly see which bits are the arm64ec
version of that line.
https://github.com/llvm/llvm-project/pull/1385
https://github.com/Stylie777 approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/139055
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jthackray approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/139055
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -12166,6 +12174,15 @@ static void DiagnoseBadDeduction(Sema &S, NamedDecl
*Found, Decl *Templated,
diag::note_ovl_candidate_explicit_arg_mismatch_unnamed)
<< (index + 1);
}
+
+if (PartialDiagnosticAt *PDiag = DeductionFailure.getSFINAEDiagnost
Author: cor3ntin
Date: 2025-05-08T12:15:05+02:00
New Revision: ce7c1963b914931817dd983f488cc0b810187b3a
URL:
https://github.com/llvm/llvm-project/commit/ce7c1963b914931817dd983f488cc0b810187b3a
DIFF:
https://github.com/llvm/llvm-project/commit/ce7c1963b914931817dd983f488cc0b810187b3a.diff
LOG:
@@ -12166,6 +12174,15 @@ static void DiagnoseBadDeduction(Sema &S, NamedDecl
*Found, Decl *Templated,
diag::note_ovl_candidate_explicit_arg_mismatch_unnamed)
<< (index + 1);
}
+
+if (PartialDiagnosticAt *PDiag = DeductionFailure.getSFINAEDiagnost
https://github.com/cor3ntin updated
https://github.com/llvm/llvm-project/pull/139057
Rate limit · GitHub
body {
background-color: #f6f8fa;
color: #24292e;
font-family: -apple-system,BlinkMacSystemFont,Segoe
UI,Helvetica,Arial,sans-
llvmbot wrote:
@llvm/pr-subscribers-libcxx
@llvm/pr-subscribers-clang
Author: Aaron Ballman (AaronBallman)
Changes
It's the end of an era. The IRC channel was previously where the community
gathered to discuss technical topics but is now a ghost town where the primary
activity is moderat
AaronBallman wrote:
> @AaronBallman oh thanks for the review! one problem at the moment is that the
> tests cover features that are dependent on the ptrauth options parsing PR, as
> well as the null value authentication work, etc
>
> I'm not sure the best path forward for dealing with all the
@@ -4899,6 +4899,234 @@ void
CGOpenMPRuntime::emitSingleReductionCombiner(CodeGenFunction &CGF,
}
}
+void CGOpenMPRuntime::emitPrivateReduction(
+CodeGenFunction &CGF, SourceLocation Loc, ArrayRef Privates,
+ArrayRef LHSExprs, ArrayRef RHSExprs,
+ArrayRef Reduct
https://github.com/erichkeane commented:
I like the change, it is a very positive difference. I'm not quite sure I get
the partial-diagnostic/generating the string, and
https://github.com/llvm/llvm-project/pull/139066
___
cfe-commits mailing list
cf
@@ -12166,6 +12174,15 @@ static void DiagnoseBadDeduction(Sema &S, NamedDecl
*Found, Decl *Templated,
diag::note_ovl_candidate_explicit_arg_mismatch_unnamed)
<< (index + 1);
}
+
+if (PartialDiagnosticAt *PDiag = DeductionFailure.getSFINAEDiagnost
https://github.com/erichkeane edited
https://github.com/llvm/llvm-project/pull/139066
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/erichkeane approved this pull request.
https://github.com/llvm/llvm-project/pull/139076
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/AaronBallman created
https://github.com/llvm/llvm-project/pull/139076
It's the end of an era. The IRC channel was previously where the community
gathered to discuss technical topics but is now a ghost town where the primary
activity is moderators (me) kickbanning the same in
https://github.com/erichkeane commented:
I honestly really like the approach. Those attributes really only differ by
spelling and are almost semantically identical, so it makes a lot of sense to
do it this way. So I'm happy.
The accessors could be cleaned up, otherwise this is a LGTM.
https
https://github.com/erichkeane edited
https://github.com/llvm/llvm-project/pull/137882
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1538,11 +1533,44 @@ def CUDAShared : InheritableAttr {
}
def : MutualExclusions<[CUDAConstant, CUDAShared, HIPManaged]>;
-def SYCLKernel : InheritableAttr {
- let Spellings = [Clang<"sycl_kernel">];
- let Subjects = SubjectList<[FunctionTmpl]>;
- let LangOpts = [SYCLDev
1 - 100 of 187 matches
Mail list logo
