================
@@ -12166,6 +12174,15 @@ static void DiagnoseBadDeduction(Sema &S, NamedDecl 
*Found, Decl *Templated,
              diag::note_ovl_candidate_explicit_arg_mismatch_unnamed)
           << (index + 1);
     }
+
+    if (PartialDiagnosticAt *PDiag = DeductionFailure.getSFINAEDiagnostic()) {
+      unsigned DiagID =
----------------
erichkeane wrote:

#2 makes sense to me.

For #1: It seems to me that a way to 'downgrade' a diagnostic to a note is a 
better solution here.  I dont' really know what that looks like and might 
require a bit of a trip through the DiagnosticsEngine (@aaronballman for 
visibility), but I would vastly prefer that.

https://github.com/llvm/llvm-project/pull/139066
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to