ahatanak wrote:

> Given that the mangleCXXRecordDecl function is used outside of the 
> `MangleVTable` , I think the ABI compatibility logic should be moved to 
> mangleCXXCtorVTable

Could you elaborate on how to separate just the ABI compatibility logic from 
`mangleCXXRecordDecl`?

Wouldn't you have to move the code to `mangleCXXVTable` and `mangleCXXVTT` too? 
I'm not sure we want to duplicate code in multiple functions.

https://github.com/llvm/llvm-project/pull/138947
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to