https://github.com/erichkeane commented:

I honestly really like the approach.  Those attributes really only differ by 
spelling and are almost semantically identical, so it makes a lot of sense to 
do it this way.  So I'm happy.

The accessors could be cleaned up, otherwise this is a LGTM.

https://github.com/llvm/llvm-project/pull/137882
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to