[clang] d257cd8 - [CodeGen][asan] Use `%t` instead of `cd` in test

2024-08-16 Thread Vitaly Buka via cfe-commits
Author: Vitaly Buka Date: 2024-08-16T23:02:12-07:00 New Revision: d257cd875873666d250e3fa7e95aafcd099f4e2f URL: https://github.com/llvm/llvm-project/commit/d257cd875873666d250e3fa7e95aafcd099f4e2f DIFF: https://github.com/llvm/llvm-project/commit/d257cd875873666d250e3fa7e95aafcd099f4e2f.diff L

[clang] [Clang] Remove 3-element vector load and store special handling (PR #104661)

2024-08-16 Thread Matt Arsenault via cfe-commits
@@ -45,7 +45,7 @@ void test3(packedfloat3 *p) { *p = (packedfloat3) { 3.2f, 2.3f, 0.1f }; } // CHECK: @test3( -// CHECK: store <4 x float> {{.*}}, align 4 +// CHECK: store <3 x float> {{.*}}, align 4 arsenm wrote: According to the langref the backend can wid

[clang] [llvm] [PowerPC] Fix codegen for transparent_union function params (PR #101738)

2024-08-16 Thread Eli Friedman via cfe-commits
https://github.com/efriedma-quic approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/101738 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] fix divide by zero in ComplexExprEvaluator (PR #104666)

2024-08-16 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: None (c8ef) Changes fix: #55390. --- Full diff: https://github.com/llvm/llvm-project/pull/104666.diff 2 Files Affected: - (modified) clang/lib/AST/ExprConstant.cpp (+4-3) - (added) clang/test/SemaCXX/complex-div.cpp (+3) ``d

[clang] [clang] fix divide by zero in ComplexExprEvaluator (PR #104666)

2024-08-16 Thread via cfe-commits
https://github.com/c8ef created https://github.com/llvm/llvm-project/pull/104666 fix: #55390. >From b58b9c3ad5fb2b37715ba9f52c905b6961159f0c Mon Sep 17 00:00:00 2001 From: c8ef Date: Sat, 17 Aug 2024 05:42:39 + Subject: [PATCH] [clang] fix divide by zero in ComplexExprEvaluator --- clang/

[clang] [flang] [flang][driver] Add pre-processing type to `.i` files (PR #104664)

2024-08-16 Thread Andrzej Warzyński via cfe-commits
banach-space wrote: Hi Kareem, thanks for the fix! Is there any reference that would document .i files? Perhaps GFortran docs? This might be sth standard, but we should capture that in our docs nonetheless (eg in a commit summary). Btw, I will be OOO for a while, so apologies in advance if th

[clang] [flang] [flang][driver] Add pre-processing type to `.i` files (PR #104664)

2024-08-16 Thread Kareem Ergawy via cfe-commits
https://github.com/ergawy updated https://github.com/llvm/llvm-project/pull/104664 >From 1f504bf784ee3b19ed29d2db1ba4ba26ac7d7d66 Mon Sep 17 00:00:00 2001 From: ergawy Date: Sat, 17 Aug 2024 00:20:11 -0500 Subject: [PATCH] [flang][driver] Add pre-processing type to `.i` files This diff allows

[clang] [flang] [flang][driver] Add pre-processing type to `.i` files (PR #104664)

2024-08-16 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-flang-driver Author: Kareem Ergawy (ergawy) Changes This diff allows `.i` files emitted by flang-new to be treated as valid files in the pre-processing phase. This, in turn, allows flang-new to add pre-processing options (e.g. `-I`) when launching comp

[clang] [flang] [flang][driver] Add pre-processing type to `.i` files (PR #104664)

2024-08-16 Thread Kareem Ergawy via cfe-commits
https://github.com/ergawy created https://github.com/llvm/llvm-project/pull/104664 This diff allows `.i` files emitted by flang-new to be treated as valid files in the pre-processing phase. This, in turn, allows flang-new to add pre-processing options (e.g. `-I`) when launching compilation job

[clang] [Clang] Remove 3-element vector load and store special handling (PR #104661)

2024-08-16 Thread Craig Topper via cfe-commits
@@ -45,7 +45,7 @@ void test3(packedfloat3 *p) { *p = (packedfloat3) { 3.2f, 2.3f, 0.1f }; } // CHECK: @test3( -// CHECK: store <4 x float> {{.*}}, align 4 +// CHECK: store <3 x float> {{.*}}, align 4 topperc wrote: Is the backend able to lower this a a singl

[clang] [llvm] [RISCV] Implement Clang Builtins for XCValu Extension in CV32E40P (PR #100684)

2024-08-16 Thread Craig Topper via cfe-commits
@@ -152,12 +152,22 @@ namespace clang { }; } + namespace RISCVXCV { + enum { +LastRVVBuiltin = RISCVVector::FirstTSBuiltin - 1, +#define BUILTIN(ID, TYPE, ATTRS) BI__builtin_riscv_cv_##ID, +#include "clang/Basic/BuiltinsRISCVXCV.def" topperc wrote:

[clang] [clang-format] Change BinPackParameters to an enum to add a BreakAlways (PR #101882)

2024-08-16 Thread Owen Pan via cfe-commits
owenca wrote: There's a compiler warning: ``` In file included from /Users/Owen/llvm-project/clang/lib/Format/AffectedRangeManager.cpp:16: /Users/Owen/llvm-project/clang/lib/Format/FormatToken.h:1982:13: warning: unused function 'startsNextParameter' [-Wunused-function] 1982 | static bool star

[clang] [clang][bytecode] Fix shifting negative values (PR #104663)

2024-08-16 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Timm Baeder (tbaederr) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/104663.diff 2 Files Affected: - (modified) clang/lib/AST/ByteCode/Interp.h (+11) - (modified) clang/test/AST/ByteCode/cxx23.cpp (+14) `

[clang] [clang][bytecode] Fix shifting negative values (PR #104663)

2024-08-16 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr created https://github.com/llvm/llvm-project/pull/104663 None >From 3faff3df9ebadbc12e34d15c96742856020bf7f1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Sat, 17 Aug 2024 06:15:45 +0200 Subject: [PATCH] [clang][bytecode] Fix shifting negative v

[clang] [clang][bytecode] Classify 1-bit unsigned integers as bool (PR #104662)

2024-08-16 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Timm Baeder (tbaederr) Changes This happens for enum types with bool parent types. isBooleanType() returns false for them however. The previous version did the same thing by re-classifying the enum integer type, but that breaks with forw

[clang] [clang][bytecode] Classify 1-bit unsigned integers as bool (PR #104662)

2024-08-16 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr created https://github.com/llvm/llvm-project/pull/104662 This happens for enum types with bool parent types. isBooleanType() returns false for them however. The previous version did the same thing by re-classifying the enum integer type, but that breaks with forwar

[clang] [Clang] Remove 3-element vector load and store special handling (PR #104661)

2024-08-16 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-codegen @llvm/pr-subscribers-backend-amdgpu Author: Shilei Tian (shiltian) Changes Clang uses a long-time special handling of the case where 3 element vector loads and stores are performed as 4 element, and then a shufflevector is used to extrac

[clang] [Clang] Remove 3-element vector load and store special handling (PR #104661)

2024-08-16 Thread Shilei Tian via cfe-commits
shiltian wrote: * **#104661** https://app.graphite.dev/github/pr/llvm/llvm-project/104661?utm_source=stack-comment-icon"; target="_blank">https://static.graphite.dev/graphite-32x32-black.png"; alt="Graphite" width="10px" height="10px"/> 👈 * `main` This stack of pull requests is managed by Grap

[clang] [Clang] Remove 3-element vector load and store special handling (PR #104661)

2024-08-16 Thread Shilei Tian via cfe-commits
https://github.com/shiltian ready_for_review https://github.com/llvm/llvm-project/pull/104661 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Remove 3-element vector load and store special handling (PR #104661)

2024-08-16 Thread Shilei Tian via cfe-commits
https://github.com/shiltian created https://github.com/llvm/llvm-project/pull/104661 Clang uses a long-time special handling of the case where 3 element vector loads and stores are performed as 4 element, and then a shufflevector is used to extract the used elements. Odd sized vector codegen

[clang] [clang-format] Adjust requires clause wrapping (#101550) (PR #102078)

2024-08-16 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `sanitizer-x86_64-linux-fast` running on `sanitizer-buildbot3` while building `clang` at step 2 "annotate". Full details are available at: https://lab.llvm.org/buildbot/#/builders/169/builds/2242 Here is the relevant piece of

[clang] [llvm] [HLSL][SPIRV]Add SPIRV generation for HLSL dot (PR #104656)

2024-08-16 Thread Greg Roth via cfe-commits
https://github.com/pow2clk updated https://github.com/llvm/llvm-project/pull/104656 >From 9aff63478b76f042c05b7ae3dd1a2c099dc615de Mon Sep 17 00:00:00 2001 From: Greg Roth Date: Fri, 2 Aug 2024 20:10:04 -0600 Subject: [PATCH 1/2] Add SPIRV generation for HLSL dot This adds the SPIRV fdot, sdot

[clang] [llvm] [HLSL][DXIL][SPIRV] Create llvm dot intrinsic and use for HLSL (PR #102872)

2024-08-16 Thread Greg Roth via cfe-commits
pow2clk wrote: Here's the new PR for anyone who wants to keep following along in its altered state: #104656 https://github.com/llvm/llvm-project/pull/102872 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman

[clang] [clang-format] Adjust requires clause wrapping (#101550) (PR #102078)

2024-08-16 Thread Nathan Sidwell via cfe-commits
https://github.com/urnathan closed https://github.com/llvm/llvm-project/pull/102078 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 4cf9a42 - [clang-format] Adjust requires clause wrapping (#101550) (#102078)

2024-08-16 Thread via cfe-commits
Author: Nathan Sidwell Date: 2024-08-16T21:05:08-04:00 New Revision: 4cf9a4266167c686e7e405ead5d6c1cd389eeca5 URL: https://github.com/llvm/llvm-project/commit/4cf9a4266167c686e7e405ead5d6c1cd389eeca5 DIFF: https://github.com/llvm/llvm-project/commit/4cf9a4266167c686e7e405ead5d6c1cd389eeca5.diff

[clang] [llvm] [HLSL][SPIRV]Add SPIRV generation for HLSL dot (PR #104656)

2024-08-16 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-llvm-ir Author: Greg Roth (pow2clk) Changes This adds the SPIRV fdot, sdot, and udot intrinsics and allows them to be created at codegen depending on the target architecture. This required moving some of the DXIL-specific choices to DXIL instruction ex

[clang] [llvm] [HLSL][SPIRV]Add SPIRV generation for HLSL dot (PR #104656)

2024-08-16 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-codegen @llvm/pr-subscribers-backend-spir-v @llvm/pr-subscribers-backend-directx Author: Greg Roth (pow2clk) Changes This adds the SPIRV fdot, sdot, and udot intrinsics and allows them to be created at codegen depending on the target architecture.

[clang] [llvm] [HLSL][SPIRV]Add SPIRV generation for HLSL dot (PR #104656)

2024-08-16 Thread Greg Roth via cfe-commits
https://github.com/pow2clk edited https://github.com/llvm/llvm-project/pull/104656 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Add SPIRV generation for HLSL dot (PR #104656)

2024-08-16 Thread Greg Roth via cfe-commits
https://github.com/pow2clk created https://github.com/llvm/llvm-project/pull/104656 This adds the SPIRV fdot, sdot, and udot intrinsics and allows them to be created at codegen depending on the target architecture. This required moving some of the DXIL-specific choices to DXIL instruction expa

[clang] [docs] Document the missing Apple availability platforms (PR #104653)

2024-08-16 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Ian Anderson (ian-twilightcoder) Changes Add the supported application extension and Mac Catalyst platforms to the availability attribute documentation. --- Full diff: https://github.com/llvm/llvm-project/pull/104653.diff 1 Files Affect

[clang] [docs] Document the missing Apple availability platforms (PR #104653)

2024-08-16 Thread Ian Anderson via cfe-commits
https://github.com/ian-twilightcoder created https://github.com/llvm/llvm-project/pull/104653 Add the supported application extension and Mac Catalyst platforms to the availability attribute documentation. >From f833ec7e5e1dd8d8076df157ab0766b87ea0734b Mon Sep 17 00:00:00 2001 From: Ian Anders

[clang] [llvm] [HLSL][DXIL][SPIRV] Create llvm dot intrinsic and use for HLSL (PR #102872)

2024-08-16 Thread Greg Roth via cfe-commits
pow2clk wrote: Closing in light of the above. A new PR will capture the DXIL and SPIRV-specific work https://github.com/llvm/llvm-project/pull/102872 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listin

[clang] [llvm] [HLSL][DXIL][SPIRV] Create llvm dot intrinsic and use for HLSL (PR #102872)

2024-08-16 Thread Greg Roth via cfe-commits
https://github.com/pow2clk closed https://github.com/llvm/llvm-project/pull/102872 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [AArch64] Add a check for invalid default features (PR #104435)

2024-08-16 Thread Ahmed Bougacha via cfe-commits
https://github.com/ahmedbougacha edited https://github.com/llvm/llvm-project/pull/104435 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Fix sema checks thinking kernels aren't kernels (PR #104460)

2024-08-16 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 closed https://github.com/llvm/llvm-project/pull/104460 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] e169cc1 - [Clang] Fix sema checks thinking kernels aren't kernels (#104460)

2024-08-16 Thread via cfe-commits
Author: Joseph Huber Date: 2024-08-16T18:36:27-05:00 New Revision: e169cc162adbe89d498e774bccf4e228af989849 URL: https://github.com/llvm/llvm-project/commit/e169cc162adbe89d498e774bccf4e228af989849 DIFF: https://github.com/llvm/llvm-project/commit/e169cc162adbe89d498e774bccf4e228af989849.diff

[clang] [HLSL][Doc] Document multi-argument resolution (PR #104474)

2024-08-16 Thread Justin Bogner via cfe-commits
https://github.com/bogner commented: If I understand correctly from reading this, there should never be a case where both dxc and clang both choose an overload but those differ. Ie, any case where the behaviour disagrees will result in clang failing to resolve the overload because it's ambiguo

[clang] nonblocking/nonallocating attributes: 2nd pass caller/callee analysis (PR #99656)

2024-08-16 Thread Doug Wyatt via cfe-commits
https://github.com/dougsonos edited https://github.com/llvm/llvm-project/pull/99656 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] nonblocking/nonallocating attributes: 2nd pass caller/callee analysis (PR #99656)

2024-08-16 Thread Doug Wyatt via cfe-commits
@@ -0,0 +1,256 @@ +// RUN: %clang_cc1 -fsyntax-only -fblocks -fcxx-exceptions -std=c++20 -verify %s +// These are in a separate file because errors (e.g. incompatible attributes) currently prevent +// the FXAnalysis pass from running at all. + +// This diagnostic is re-enabled a

[clang] [clang][NFC] Split invalid-cpu-note tests (PR #104601)

2024-08-16 Thread Fangrui Song via cfe-commits
@@ -0,0 +1,90 @@ +// Use --implicit-check-not to ensure no additional CPUs are in this list + +// RUN: not %clang_cc1 -triple arm64--- -target-cpu not-a-cpu -fsyntax-only %s 2>&1 | FileCheck %s --implicit-check-not={{[a-zA-Z0-9]}} +// RUN: not %clang_cc1 -triple arm64--- -tune-cp

[clang] [Clang] Fix sema checks thinking kernels aren't kernels (PR #104460)

2024-08-16 Thread Artem Belevich via cfe-commits
https://github.com/Artem-B approved this pull request. https://github.com/llvm/llvm-project/pull/104460 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][ExtractAPI] Stop dropping fields of nested anonymous record types when they aren't attached to variable declaration (PR #104600)

2024-08-16 Thread via cfe-commits
https://github.com/QuietMisdreavus approved this pull request. https://github.com/llvm/llvm-project/pull/104600 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [AArch64] Add a check for invalid default features (PR #104435)

2024-08-16 Thread Ahmed Bougacha via cfe-commits
@@ -892,7 +905,7 @@ def ProcessorFeatures { FeatureComplxNum, FeatureCRC, FeatureJS, FeatureLSE, FeaturePAuth, FeatureFPAC, FeatureRAS, FeatureRCPC, FeatureRDM, -

[clang] [llvm] [AArch64] Add a check for invalid default features (PR #104435)

2024-08-16 Thread Ahmed Bougacha via cfe-commits
@@ -845,7 +857,8 @@ def ProcessorFeatures { list AppleA12 = [HasV8_3aOps, FeatureSHA2, FeatureAES, FeatureFPARMv8, FeatureNEON, FeaturePerfMon, FeatureFullFP16, FeatureComplxNum, FeatureCRC, FeatureJS

[clang] [llvm] [AArch64] Add a check for invalid default features (PR #104435)

2024-08-16 Thread Ahmed Bougacha via cfe-commits
https://github.com/ahmedbougacha commented: A couple small issues inline, LGTM otherwise, thanks! >> FEAT_SSBS is not mandatory for any architecture. > > https://reviews.llvm.org/D54629 says it is mandatory for 8.5-a but I can't > see that in the Arm ARM. It was indeed originally mandatory (se

[clang] [llvm] [AArch64] Add a check for invalid default features (PR #104435)

2024-08-16 Thread Ahmed Bougacha via cfe-commits
https://github.com/ahmedbougacha edited https://github.com/llvm/llvm-project/pull/104435 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] 5ef2456 - [clang-doc] add support for enums comments in html generation (#101282)

2024-08-16 Thread via cfe-commits
Author: PeterChou1 Date: 2024-08-16T18:37:17-04:00 New Revision: 5ef2456a438578b0783241a2744efc62d47e5ab6 URL: https://github.com/llvm/llvm-project/commit/5ef2456a438578b0783241a2744efc62d47e5ab6 DIFF: https://github.com/llvm/llvm-project/commit/5ef2456a438578b0783241a2744efc62d47e5ab6.diff LO

[clang-tools-extra] [clang-doc] add support for enums comments in html generation (PR #101282)

2024-08-16 Thread via cfe-commits
https://github.com/PeterChou1 closed https://github.com/llvm/llvm-project/pull/101282 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] fix crash by avoiding invalidation of extern main declaration during strictness checks (PR #104594)

2024-08-16 Thread via cfe-commits
https://github.com/cor3ntin closed https://github.com/llvm/llvm-project/pull/104594 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] e4f3735 - [Clang] fix crash by avoiding invalidation of extern main declaration during strictness checks (#104594)

2024-08-16 Thread via cfe-commits
Author: Oleksandr T. Date: 2024-08-17T00:01:33+02:00 New Revision: e4f3735d5f600b17b8f86956162d41ce82096685 URL: https://github.com/llvm/llvm-project/commit/e4f3735d5f600b17b8f86956162d41ce82096685 DIFF: https://github.com/llvm/llvm-project/commit/e4f3735d5f600b17b8f86956162d41ce82096685.diff

[clang] [llvm] [HLSL][DXIL][SPIRV] Create llvm dot intrinsic and use for HLSL (PR #102872)

2024-08-16 Thread Justin Bogner via cfe-commits
bogner wrote: > There is some discussion in the RFC, but I don't see a consensus on the "dot" > intrinsic in particular. I personally haven't found the arguments in favor of > it particularly compelling. > > This really needs an RFC specific to that intrinsic (class), which includes a > clear

[clang] [HIP] search fatbin symbols for libs passed by -l (PR #104638)

2024-08-16 Thread Artem Belevich via cfe-commits
@@ -76,8 +79,75 @@ class HIPUndefinedFatBinSymbols { return GPUBinHandleSymbols; } + // Collect symbols from static libraries specified by -l options. + void processStaticLibraries() { +llvm::SmallVector LibNames; +llvm::SmallVector LibPaths; +llvm::SmallVe

[clang] [HIP] search fatbin symbols for libs passed by -l (PR #104638)

2024-08-16 Thread Artem Belevich via cfe-commits
@@ -76,8 +79,75 @@ class HIPUndefinedFatBinSymbols { return GPUBinHandleSymbols; } + // Collect symbols from static libraries specified by -l options. + void processStaticLibraries() { +llvm::SmallVector LibNames; +llvm::SmallVector LibPaths; +llvm::SmallVe

[clang] [HIP] search fatbin symbols for libs passed by -l (PR #104638)

2024-08-16 Thread Artem Belevich via cfe-commits
https://github.com/Artem-B approved this pull request. LGTM in general with a couple of nits. https://github.com/llvm/llvm-project/pull/104638 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[clang] [HIP] search fatbin symbols for libs passed by -l (PR #104638)

2024-08-16 Thread Artem Belevich via cfe-commits
https://github.com/Artem-B edited https://github.com/llvm/llvm-project/pull/104638 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [RISCV] Add Hazard3 Core as taped out for RP2350 (PR #102452)

2024-08-16 Thread Craig Topper via cfe-commits
@@ -402,6 +402,21 @@ // MCPU-SIFIVE-P670-SAME: "-target-feature" "+zvkt" // MCPU-SIFIVE-P670-SAME: "-target-abi" "lp64d" +// RUN: %clang -target riscv32 -### -c %s 2>&1 -mcpu=rp2350-hazard3 | FileCheck -check-prefix=MCPU-HAZARD3 %s +// MCPU-HAZARD3: "-target-cpu" "rp2350-haza

[clang] [clang][driver] Fix -print-target-triple OS version for apple targets (PR #104037)

2024-08-16 Thread Martin Storsjö via cfe-commits
mstorsjo wrote: > @mstorsjo I think you put the finger on something I don't really understand > at the moment. What is the relationship between `armv7` and `thumbv7` as a > target triple? Is there any documentation on what an "effective triple" is in > comparison to a "non-effective triple"?

[clang] [clang] Rename all AST/Interp stuff to AST/ByteCode (PR #104552)

2024-08-16 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `clang-hip-vega20` running on `hip-vega20-0` while building `clang` at step 3 "annotate". Full details are available at: https://lab.llvm.org/buildbot/#/builders/123/builds/3819 Here is the relevant piece of the build log for

[clang] 1a8817a - Reland "[flang][cuda][driver] Make sure flang does not switch to cc1 (#104613)"

2024-08-16 Thread Valentin Clement via cfe-commits
Author: Valentin Clement (バレンタイン クレメン) Date: 2024-08-16T13:41:24-07:00 New Revision: 1a8817aebe12b8d4708ee849fb8f792cffb7ae85 URL: https://github.com/llvm/llvm-project/commit/1a8817aebe12b8d4708ee849fb8f792cffb7ae85 DIFF: https://github.com/llvm/llvm-project/commit/1a8817aebe12b8d4708ee849fb8f7

[clang-tools-extra] [clang-tidy] use upper case letters for bool conversion suffix (PR #102831)

2024-08-16 Thread Carlos Galvez via cfe-commits
carlosgalvezp wrote: > An inconsistency is that readability-uppercase-literal-suffix only handles l > and u by default whereas the check here also handles f Then that check should be updated to handle the F suffix as well. It doesn't make sense to have different style for different suffixes:

[clang] de9338f - Revert "Reland "[flang][cuda][driver] Make sure flang does not switch to cc1 (#104613)""

2024-08-16 Thread Valentin Clement via cfe-commits
Author: Valentin Clement Date: 2024-08-16T13:19:26-07:00 New Revision: de9338fc625d8d67c18032492b2e743cd53f4b37 URL: https://github.com/llvm/llvm-project/commit/de9338fc625d8d67c18032492b2e743cd53f4b37 DIFF: https://github.com/llvm/llvm-project/commit/de9338fc625d8d67c18032492b2e743cd53f4b37.di

[clang] nonblocking/nonallocating attributes: 2nd pass caller/callee analysis (PR #99656)

2024-08-16 Thread Doug Wyatt via cfe-commits
https://github.com/dougsonos edited https://github.com/llvm/llvm-project/pull/99656 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] nonblocking/nonallocating attributes: 2nd pass caller/callee analysis (PR #99656)

2024-08-16 Thread Doug Wyatt via cfe-commits
@@ -0,0 +1,256 @@ +// RUN: %clang_cc1 -fsyntax-only -fblocks -fcxx-exceptions -std=c++20 -verify %s +// These are in a separate file because errors (e.g. incompatible attributes) currently prevent +// the FXAnalysis pass from running at all. + +// This diagnostic is re-enabled a

[clang] [Clang] Overflow Pattern Exclusions (PR #100272)

2024-08-16 Thread Vitaly Buka via cfe-commits
vitalybuka wrote: > > Can we split `-fsanitize=unsigned-integer-overflow` into > > `-fsanitize=unsigned-integer-overflow-patternA,unsigned-integer-overflow-patternB,unsigned-integer-overflow-patternC...` > > ? > > Then it's quite intuitive to disable them with `no-sanitize`. > > Yikes, no way.

[clang] [Matrix] Preserve signedness when extending matrix index expression. (PR #103044)

2024-08-16 Thread John McCall via cfe-commits
https://github.com/rjmccall approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/103044 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] af81b4f - Reland "[flang][cuda][driver] Make sure flang does not switch to cc1 (#104613)"

2024-08-16 Thread Valentin Clement via cfe-commits
Author: Valentin Clement (バレンタイン クレメン) Date: 2024-08-16T13:10:36-07:00 New Revision: af81b4f9f98f6ac89f876637f065d6525e374468 URL: https://github.com/llvm/llvm-project/commit/af81b4f9f98f6ac89f876637f065d6525e374468 DIFF: https://github.com/llvm/llvm-project/commit/af81b4f9f98f6ac89f876637f065d

[clang] [HIP] search fatbin symbols for libs passed by -l (PR #104638)

2024-08-16 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang @llvm/pr-subscribers-clang-driver Author: Yaxun (Sam) Liu (yxsamliu) Changes For -fgpu-rdc linking, clang needs to collect undefined fatbin symbols and resolve them to the embedded fatbin. This has been done for object files and archive files pas

[clang] [HIP] search fatbin symbols for libs passed by -l (PR #104638)

2024-08-16 Thread Yaxun Liu via cfe-commits
https://github.com/yxsamliu created https://github.com/llvm/llvm-project/pull/104638 For -fgpu-rdc linking, clang needs to collect undefined fatbin symbols and resolve them to the embedded fatbin. This has been done for object files and archive files passed as input files to clang. However,

[clang] [llvm] [AMDGPU] Convert AMDGPUResourceUsageAnalysis pass from Module to MF pass (PR #102913)

2024-08-16 Thread Scott Linder via cfe-commits
@@ -0,0 +1,220 @@ +//===- AMDGPUMCResourceInfo.cpp --- MC Resource Info --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [llvm] [AMDGPU] Convert AMDGPUResourceUsageAnalysis pass from Module to MF pass (PR #102913)

2024-08-16 Thread Scott Linder via cfe-commits
@@ -0,0 +1,220 @@ +//===- AMDGPUMCResourceInfo.cpp --- MC Resource Info --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [llvm] [AMDGPU] Convert AMDGPUResourceUsageAnalysis pass from Module to MF pass (PR #102913)

2024-08-16 Thread Scott Linder via cfe-commits
@@ -0,0 +1,220 @@ +//===- AMDGPUMCResourceInfo.cpp --- MC Resource Info --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [llvm] [AMDGPU] Convert AMDGPUResourceUsageAnalysis pass from Module to MF pass (PR #102913)

2024-08-16 Thread Scott Linder via cfe-commits
@@ -0,0 +1,220 @@ +//===- AMDGPUMCResourceInfo.cpp --- MC Resource Info --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [llvm] [AMDGPU] Convert AMDGPUResourceUsageAnalysis pass from Module to MF pass (PR #102913)

2024-08-16 Thread Scott Linder via cfe-commits
https://github.com/slinder1 commented: LGTM, with some nits The expressions look pretty reasonable to me, although I didn't really go through validating that they are correct https://github.com/llvm/llvm-project/pull/102913 ___ cfe-commits mailing li

[clang] [llvm] [AMDGPU] Convert AMDGPUResourceUsageAnalysis pass from Module to MF pass (PR #102913)

2024-08-16 Thread Scott Linder via cfe-commits
https://github.com/slinder1 edited https://github.com/llvm/llvm-project/pull/102913 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] use upper case letters for bool conversion suffix (PR #102831)

2024-08-16 Thread via cfe-commits
https://github.com/Da-Viper updated https://github.com/llvm/llvm-project/pull/102831 >From 8a4f6af9fc1f44c2f8b5fd3693ca14eaf776fd02 Mon Sep 17 00:00:00 2001 From: Ebuka Ezike Date: Sun, 11 Aug 2024 21:39:35 +0100 Subject: [PATCH 01/11] [clang-tidy] use upper cace letters for bool conversion su

[clang] [llvm] [llvm][clang] Move RewriterBuffer to ADT. (PR #99770)

2024-08-16 Thread Artem Dergachev via cfe-commits
https://github.com/haoNoQ approved this pull request. Works for me! IIUC nobody touched this code in a while, and that's probably because it's basically perfect for everyone's existing purposes. So I think moving it to ADT is appropriate. https://github.com/llvm/llvm-project/pull/99770 ___

[clang] [llvm] [PowerPC] Fix codegen for transparent_union function params (PR #101738)

2024-08-16 Thread Lei Huang via cfe-commits
lei137 wrote: > I'm not an expert here, but I think the change you made makes sense since the > `Ty` is supposed to be the first field. > > Also, might be a dumb question, I saw we have 32-bit Linux run lines, but is > that still worth testing? Thanks for taking a look @amy-kwan. The 32bit l

[clang] nonblocking/nonallocating attributes: 2nd pass caller/callee analysis (PR #99656)

2024-08-16 Thread via cfe-commits
@@ -0,0 +1,256 @@ +// RUN: %clang_cc1 -fsyntax-only -fblocks -fcxx-exceptions -std=c++20 -verify %s +// These are in a separate file because errors (e.g. incompatible attributes) currently prevent +// the FXAnalysis pass from running at all. + +// This diagnostic is re-enabled a

[clang] [compiler-rt] [ubsan] Display correct runtime messages for negative _BitInt (PR #96240)

2024-08-16 Thread Vitaly Buka via cfe-commits
vitalybuka wrote: > > How i can see the full amount of breakage on different platforms > > proactively? I have created a PR: #104607 to address the big endian issue > > with the test as my // REQUIRES: x86-registered-target turned out not to be > > enough to exclude running test in the big end

[clang] nonblocking/nonallocating attributes: 2nd pass caller/callee analysis (PR #99656)

2024-08-16 Thread Doug Wyatt via cfe-commits
@@ -0,0 +1,256 @@ +// RUN: %clang_cc1 -fsyntax-only -fblocks -fcxx-exceptions -std=c++20 -verify %s +// These are in a separate file because errors (e.g. incompatible attributes) currently prevent +// the FXAnalysis pass from running at all. + +// This diagnostic is re-enabled a

[clang] [Clang] [Sema] Error on reference types inside a union with msvc 1900+ (PR #102851)

2024-08-16 Thread via cfe-commits
zeroomega wrote: > I think those are failing because of unexpected passes in libc++ tests: > > ``` > TEST 'llvm-libc++-static-clangcl.cfg.in :: > libcxx/utilities/expected/expected.void/transform_error.mandates.verify.cpp' > FAILED > Exit Code: 0 > >

[clang] [llvm] [PowerPC] Fix codegen for transparent_union function params (PR #101738)

2024-08-16 Thread Amy Kwan via cfe-commits
https://github.com/amy-kwan commented: I'm not an expert here, but I think the change you made makes sense since the `Ty` is supposed to be the first field. Also, might be a dumb question, I saw we have 32-bit Linux run lines, but is that still worth testing? https://github.com/llvm/llvm-proj

[clang] [flang] [flang][cuda][driver] Make sure flang does not switch to cc1 (PR #104613)

2024-08-16 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `ppc64le-flang-rhel-clang` running on `ppc64le-flang-rhel-test` while building `clang,flang` at step 6 "test-build-unified-tree-check-flang". Full details are available at: https://lab.llvm.org/buildbot/#/builders/157/builds/5

[clang] [Matrix] Preserve signedness when extending matrix index expression. (PR #103044)

2024-08-16 Thread John McCall via cfe-commits
@@ -4348,8 +4348,18 @@ LValue CodeGenFunction::EmitMatrixSubscriptExpr(const MatrixSubscriptExpr *E) { !E->isIncomplete() && "incomplete matrix subscript expressions should be rejected during Sema"); LValue Base = EmitLValue(E->getBase()); - llvm::Value *RowIdx

[clang] [HLSL] Implement output parameter (PR #101083)

2024-08-16 Thread John McCall via cfe-commits
@@ -1121,3 +1121,99 @@ bool SemaHLSL::CheckBuiltinFunctionCall(unsigned BuiltinID, CallExpr *TheCall) { } return false; } + +bool SemaHLSL::CheckCompatibleParameterABI(FunctionDecl *New, + FunctionDecl *Old) { + if (New->getNumPar

[clang] [flang] Revert "[flang][cuda][driver] Make sure flang does not switch to cc1" (PR #104632)

2024-08-16 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-driver Author: Valentin Clement (バレンタイン クレメン) (clementval) Changes Reverts llvm/llvm-project#104613 --- Full diff: https://github.com/llvm/llvm-project/pull/104632.diff 2 Files Affected: - (modified) clang/lib/Driver/Types.cpp (-3) - (modified

[clang] [flang] Revert "[flang][cuda][driver] Make sure flang does not switch to cc1" (PR #104632)

2024-08-16 Thread Valentin Clement バレンタイン クレメン via cfe-commits
https://github.com/clementval closed https://github.com/llvm/llvm-project/pull/104632 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] e315ba1 - Revert "[flang][cuda][driver] Make sure flang does not switch to cc1" (#104632)

2024-08-16 Thread via cfe-commits
Author: Valentin Clement (バレンタイン クレメン) Date: 2024-08-16T12:02:37-07:00 New Revision: e315ba185b835c8ee520076b434377cfb7350067 URL: https://github.com/llvm/llvm-project/commit/e315ba185b835c8ee520076b434377cfb7350067 DIFF: https://github.com/llvm/llvm-project/commit/e315ba185b835c8ee520076b43437

[clang] [flang] Revert "[flang][cuda][driver] Make sure flang does not switch to cc1" (PR #104632)

2024-08-16 Thread Valentin Clement バレンタイン クレメン via cfe-commits
https://github.com/clementval created https://github.com/llvm/llvm-project/pull/104632 Reverts llvm/llvm-project#104613 >From cf8d13e27b647afaca66457d93b45a7da0e9cdfb Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Valentin=20Clement=20=28=E3=83=90=E3=83=AC=E3=83=B3?= =?UTF-8?q?=E3=82=BF=E3=82=A4=E3=

[clang] [llvm] [RISCV] Add Hazard3 Core as taped out for RP2350 (PR #102452)

2024-08-16 Thread Sam Elliott via cfe-commits
@@ -108,6 +108,7 @@ Changes to the RISC-V Backend fill value) rather than NOPs. * Added Syntacore SCR4 and SCR5 CPUs: ``-mcpu=syntacore-scr4/5-rv32/64`` * ``-mcpu=sifive-p470`` was added. +* Added Hazard3 CPU: ``-mcpu=hazard3`` (32-bit only). lenary wrote: D

[clang] [llvm] [RISCV] Add Hazard3 Core as taped out for RP2350 (PR #102452)

2024-08-16 Thread Luke Wren via cfe-commits
@@ -402,6 +402,21 @@ // MCPU-SIFIVE-P670-SAME: "-target-feature" "+zvkt" // MCPU-SIFIVE-P670-SAME: "-target-abi" "lp64d" +// RUN: %clang -target riscv32 -### -c %s 2>&1 -mcpu=rp2350-hazard3 | FileCheck -check-prefix=MCPU-HAZARD3 %s +// MCPU-HAZARD3: "-target-cpu" "rp2350-haza

[clang] [llvm] [RISCV] Add Hazard3 Core as taped out for RP2350 (PR #102452)

2024-08-16 Thread Luke Wren via cfe-commits
@@ -108,6 +108,7 @@ Changes to the RISC-V Backend fill value) rather than NOPs. * Added Syntacore SCR4 and SCR5 CPUs: ``-mcpu=syntacore-scr4/5-rv32/64`` * ``-mcpu=sifive-p470`` was added. +* Added Hazard3 CPU: ``-mcpu=hazard3`` (32-bit only). Wren6991 wrote:

[clang] [llvm] [HLSL][DXIL][SPIRV] Create llvm dot intrinsic and use for HLSL (PR #102872)

2024-08-16 Thread Nikita Popov via cfe-commits
nikic wrote: > > Please create a separate RFC for these intrinsics. I don't think there is a > > consensus on these intrinsics, and > > https://discourse.llvm.org/t/rfc-all-the-math-intrinsics/78294 covers way > > too much disparate ground (something like "tan" and something like "dot" > > ar

[clang] [Clang] Check constraints for an explicit instantiation of a member function (PR #104438)

2024-08-16 Thread via cfe-commits
@@ -5663,6 +5663,8 @@ def err_explicit_instantiation_internal_linkage : Error< def err_explicit_instantiation_not_known : Error< "explicit instantiation of %0 does not refer to a function template, " "variable template, member function, member class, or static data member">

[clang] [flang] [flang][cuda][driver] Make sure flang does not switch to cc1 (PR #104613)

2024-08-16 Thread Valentin Clement バレンタイン クレメン via cfe-commits
https://github.com/clementval closed https://github.com/llvm/llvm-project/pull/104613 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] e6b9f12 - [flang][cuda][driver] Make sure flang does not switch to cc1 (#104613)

2024-08-16 Thread via cfe-commits
Author: Valentin Clement (バレンタイン クレメン) Date: 2024-08-16T11:56:22-07:00 New Revision: e6b9f12b0ac0f1e6f7f7145719092c10731e4fe4 URL: https://github.com/llvm/llvm-project/commit/e6b9f12b0ac0f1e6f7f7145719092c10731e4fe4 DIFF: https://github.com/llvm/llvm-project/commit/e6b9f12b0ac0f1e6f7f7145719092

[clang] [clang-format] Introduce "ReflowComments: IndentOnly" to re-indent comments without breaking internal structure (think Doxygen). (PR #96804)

2024-08-16 Thread Iuri Chaer via cfe-commits
ichaer wrote: @mydeveloperday, what do you think, is this good to merge? https://github.com/llvm/llvm-project/pull/96804 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [HLSL] Implement support for HLSL intrinsic - saturate (PR #104619)

2024-08-16 Thread Farzon Lotfi via cfe-commits
@@ -1285,6 +1289,34 @@ static unsigned getBoolCmpOpcode(unsigned PredNum) { } } +static APFloat getZeroFP(const Type *LLVMFloatTy) { farzonl wrote: I'm a little suprised this didn't already exist. https://github.com/llvm/llvm-project/pull/104619 __

[clang] [llvm] [HLSL] Implement support for HLSL intrinsic - saturate (PR #104619)

2024-08-16 Thread Farzon Lotfi via cfe-commits
@@ -362,6 +364,34 @@ static bool expandClampIntrinsic(CallInst *Orig, Intrinsic::ID ClampIntrinsic) { return true; } +static bool expandSaturateIntrinsic(CallInst *SaturateCall) { farzonl wrote: wait for @pow2clk change merges then change this to return `

[clang] Implement resource binding type prefix mismatch diagnostic infrastructure (PR #97103)

2024-08-16 Thread Joshua Batista via cfe-commits
@@ -551,24 +541,21 @@ getHLSLResourceAttrFromEitherDecl(VarDecl *VD, // the resource attr could be on the record decl itself or on one of // its fields (the resource handle, most commonly) bob80905 wrote: Yes, I think I may have left support for that

  1   2   3   4   >