[PATCH] D136436: [Clang][LoongArch] Add register alias handling without `$` prefix

tangyouling added a comment. In D136436#3890737 , @SixWeining wrote: > In D136436#3881382 , @MaskRay wrote: > >> In D136436#3876684 , @SixWeining >> wrote: >> >>> In D13

[PATCH] D135858: [clang][Interp] Support pointer arithmetic in binary operators

tbaeder marked an inline comment as done. tbaeder added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:241 + // Pointer arithmethic special case. This is supported for one of + // LHS and RHS being a pointer type and the other being an integer type. + if

[PATCH] D136572: Harmonize cmake_policy() across standalone builds of all projects

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9dd01a5241dc: Harmonize cmake_policy() across standalone builds of all projects (authored by mgorny). Repository: rG LLVM Github Monorepo CHANGES

[clang] 9dd01a5 - Harmonize cmake_policy() across standalone builds of all projects

Author: Michał Górny Date: 2022-10-28T08:46:48+02:00 New Revision: 9dd01a5241dc5b46e92485e05bc345221df8938c URL: https://github.com/llvm/llvm-project/commit/9dd01a5241dc5b46e92485e05bc345221df8938c DIFF: https://github.com/llvm/llvm-project/commit/9dd01a5241dc5b46e92485e05bc345221df8938c.diff

[PATCH] D136572: Harmonize cmake_policy() across standalone builds of all projects

mgorny added a comment. In D136572#3889317 , @mstorsjo wrote: > Also for the record, I'd love to get rid of this symlink based setup, if I > could make cmake produce project files where caching works in the same way. > The main requirement for that woul

[PATCH] D136436: [Clang][LoongArch] Add register alias handling without `$` prefix

xen0n added a comment. In D136436#3890737 , @SixWeining wrote: > In D136436#3881382 , @MaskRay wrote: > >> In D136436#3876684 , @SixWeining >> wrote: >> >>> In D136436#3

[PATCH] D136828: [clang][Interp] Diagnose uninitialized array record fields

tbaeder updated this revision to Diff 471404. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136828/new/ https://reviews.llvm.org/D136828 Files: clang/lib/AST/Interp/Interp.cpp clang/lib/AST/Interp/Pointer.h clang/test/AST/Interp/cxx20.cpp Index: clang/test/AST/Interp/cxx20.cpp ===

[PATCH] D134859: [clang][Interp] Implement basic support for floating point values

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/PrimType.h:39 PT_Bool, + PT_Float, PT_Ptr, sepavloff wrote: > tbaeder wrote: > > sepavloff wrote: > > > In contrast to other members of this enumeration, `PT_Float` does not > > > designate a

[PATCH] D136154: [clang-format] Fix the continuation indenter

owenpan added a comment. In D136154#3882163 , @hel-ableton wrote: > I hope we can somewhat start from square 1 again with this. See https://reviews.llvm.org/D136154#3890747. It doesn't "fix" the last example in https://github.com/llvm/llvm-project/issu

[PATCH] D136154: [clang-format] Fix the continuation indenter

owenpan added inline comments. Comment at: clang/lib/Format/ContinuationIndenter.cpp:803-804 CurrentState.LastSpace = State.Column; - } else if ((Previous.isOneOf(TT_BinaryOperator, TT_ConditionalExpr, - TT_CtorInitializerColon)) &&

[PATCH] D136846: [Driver] Add -fsample-profile-use-profi

HaoyuZhang added a comment. Sorry for not providing the enough information about our investigation. We have opened an issue to show that there are some perf boost with profi on autofdo base on Intel Alder Lake platform by experimen

[PATCH] D136797: [clang-tidy] Skip template ctors in modernize-use-equals-default

This revision was automatically updated to reflect the committed changes. Closed by commit rG29e4606ced72: [clang-tidy] Skip template ctors in modernize-use-equals-default (authored by alexander-shaposhnikov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[clang-tools-extra] 29e4606 - [clang-tidy] Skip template ctors in modernize-use-equals-default

Author: Alexander Shaposhnikov Date: 2022-10-28T05:30:19Z New Revision: 29e4606ced7284c87a88fdcd34a6d179a1350fe9 URL: https://github.com/llvm/llvm-project/commit/29e4606ced7284c87a88fdcd34a6d179a1350fe9 DIFF: https://github.com/llvm/llvm-project/commit/29e4606ced7284c87a88fdcd34a6d179a1350fe9.d

[PATCH] D136436: [Clang][LoongArch] Add register alias handling without `$` prefix

SixWeining added a comment. In D136436#3881382 , @MaskRay wrote: > In D136436#3876684 , @SixWeining > wrote: > >> In D136436#3873987 , @xen0n wrote: >> >>> In D136436#387

[PATCH] D136846: [Driver] Add -fsample-profile-use-profi

wenlei added a comment. Did you see measurable perf boost with profi on autofdo? Or what motivated you to turn on profi? In most cases, profi helps when csspgo is used (instead of traditional autofdo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D136846: [Driver] Add -fsample-profile-use-profi

HaoyuZhang added a comment. Thank you for the comments. The subject has been modified. For wenlei's comment, I am working on a Chromium patch for enabling profi algorithm in Chrome OS. The reviewer Hans hope an user-facing fl

[PATCH] D136831: [clang][Interp] Protect Record creation against infinite recusion

shafik accepted this revision. shafik added a comment. LGTM Comment at: clang/test/AST/Interp/records.cpp:144 + // ref-error {{has incomplete type 'const Bar'}} +}; +constexpr Bar B; // expected-error {{must be initialized by a constant expression}} \ ---

[PATCH] D136564: [clang] Instantiate NTTPs and template default arguments with sugar

rtrieu added a comment. I noticed some build failures after your commit. I'm trying to get a standalone reproducer. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136564/new/ https://reviews.llvm.org/D136564 __

[PATCH] D136913: [HLSL] support RWByteAddressBuffer.

python3kgae created this revision. python3kgae added reviewers: pow2clk, beanz, bogner. Herald added a subscriber: Anastasia. Herald added a project: All. python3kgae requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Only RWByteAddressBuffer:

[PATCH] D136817: [RISCV] Add H extension

kito-cheng added inline comments. Comment at: llvm/test/MC/RISCV/rvi-aliases-valid.s:270 -# CHECK-S-OBJ: hfence.vvma a0 -hfence.vvma a0 Note: Those testcase are moved to `rv32ih-aliases-valid.s`, not just removed. Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D136817: [RISCV] Add H extension

kito-cheng updated this revision to Diff 471386. kito-cheng added a comment. Update instructions which are belong H extension now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136817/new/ https://reviews.llvm.org/D136817 Files: clang/test/Prepr

[PATCH] D116735: [RISCV] Adjust RV64I data layout by using n32:64 in layout string

craig.topper updated this revision to Diff 471385. craig.topper added a comment. Refine ReleaseNotes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116735/new/ https://reviews.llvm.org/D116735 Files: clang/lib/Basic/Targets/RISCV.h llvm/docs/Re

[PATCH] D136532: [clang][Interp] Implement left and right shifts

shafik accepted this revision. shafik added a comment. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136532/new/ https://reviews.llvm.org/D136532 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mail

[PATCH] D136839: [clang][Interp] Handle non-primitive locals without initializer

shafik accepted this revision. shafik added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136839/new/ https://reviews.llvm.org/D136839 ___

[PATCH] D136888: Move getenv for AS_SECURE_LOG_FILE to clang

MaskRay added inline comments. Comment at: clang/test/Driver/AS_SECURE_LOG_FILE.s:1 +// RUN: env AS_SECURE_LOG_FILE=%t %clang -target x86_64-apple-darwin -c %s -o %t.o -### 2>&1 | FileCheck %s -DLOG_FILE=%t +// CHECK: "-cc1as" `--target=` for new tests remove u

[PATCH] D135932: [X86] Add AVX-IFMA instructions.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0e720e6adad1: [X86] Add AVX-IFMA instructions. (authored by FreddyYe). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[clang] 0e720e6 - [X86] Add AVX-IFMA instructions.

Author: Freddy Ye Date: 2022-10-28T09:42:30+08:00 New Revision: 0e720e6adad13d9a3d29dc41e5c62240047acf55 URL: https://github.com/llvm/llvm-project/commit/0e720e6adad13d9a3d29dc41e5c62240047acf55 DIFF: https://github.com/llvm/llvm-project/commit/0e720e6adad13d9a3d29dc41e5c62240047acf55.diff LOG

[PATCH] D134128: [P0857R0 Part B] Resubmit an implemention for constrained template template parameters

h-vetinari added a comment. Congratulations for landing this! How far do you (both) think we're away from completing concepts? Are the issues (aside from CWG1496 & CWG1734) mentioned on https://clang.llvm.org/cxx_status.html tracked anywhere else? I see that https://github.com/orgs/llvm/projec

[PATCH] D136888: Move getenv for AS_SECURE_LOG_FILE to clang

benlangmuir updated this revision to Diff 471351. benlangmuir added a comment. Herald added a subscriber: ormris. - Updated to use cc1 option in clang - Moved the llvm-mc option to a central location so it can be used when initialized MCTargetOptions - Added tests to cover cc1 and cc1as since eac

[PATCH] D136601: [OpenMP] [OMPIRBuilder] Create a new datatype to hold the unique target region info

jsjodin added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:3031 +OrderedEntries[E.getOrder()] = +std::make_tuple(&E, Loc, EntryInfo.ParentName); +ParentFunctions[E.getOrder()] = EntryInfo.ParentName; mikerice wrot

[PATCH] D135932: [X86] Add AVX-IFMA instructions.

FreddyYe updated this revision to Diff 471350. FreddyYe added a comment. Rebase. THX for all of the review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135932/new/ https://reviews.llvm.org/D135932 Files: clang/docs/ReleaseNotes.rst clang/inc

[PATCH] D136784: [Clang] Improve diagnostic message for loop hint pragma

eopXD updated this revision to Diff 471344. eopXD added a comment. Update code to handle when IdentifierInfo is null. The .Case syntax seems to evaulate expression in other non-trigger cases. The "loop" case was triggered for test case in loop unroll and jam, resulting in segmentation fault. Anywa

[PATCH] D136906: [Clang][LoongArch] Implement __builtin_loongarch_dbar builtin

gonglingqin created this revision. gonglingqin added reviewers: xen0n, xry111, SixWeining, wangleiat, MaskRay. Herald added subscribers: StephenFan, hiraditya. Herald added a project: All. gonglingqin requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: l

[PATCH] D129531: [clang][C++20] P0960R3: Allow initializing aggregates from a parenthesized list of values

ayzhao updated this revision to Diff 471338. ayzhao added a comment. we don't need CHECK-DAG here Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129531/new/ https://reviews.llvm.org/D129531 Files: clang/docs/ReleaseNotes.rst clang/include/clang

[Diffusion] rGe4ec6ce8a75c: Clang: Add release note for defaulted-special-members-POD GCC ABI fix

hubert.reinterpretcast added inline comments. BRANCHES main /clang/docs/ReleaseNotes.rst:612-613 Shouldn't the usage of POD here be clarified to say that we mean "POD for the purposes of Itanium ABI layout"? Users: dblaikie (Author) https://reviews.llvm.org/rGe4ec6ce8a75c

[Diffusion] rGe4ec6ce8a75c: Clang: Add release note for defaulted-special-members-POD GCC ABI fix

hubert.reinterpretcast added a subscriber: cfe-commits. BRANCHES main Users: dblaikie (Author) https://reviews.llvm.org/rGe4ec6ce8a75c ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm

[PATCH] D116735: [RISCV] Adjust RV64I data layout by using n32:64 in layout string

jrtc27 added inline comments. Comment at: llvm/docs/ReleaseNotes.rst:122 been removed. +* n32 was added to the RV64I datalayout string. arichardson wrote: > Without additional context I don't think this makes much sense to most > readers. Before looking at

[PATCH] D116735: [RISCV] Adjust RV64I data layout by using n32:64 in layout string

arichardson added inline comments. Comment at: llvm/docs/ReleaseNotes.rst:122 been removed. +* n32 was added to the RV64I datalayout string. Without additional context I don't think this makes much sense to most readers. Before looking at this patch descrip

[PATCH] D129531: [clang][C++20] P0960R3: Allow initializing aggregates from a parenthesized list of values

ayzhao added a comment. In D129531#3880875 , @ayzhao wrote: > In D129531#3873872 , @royjacobson > wrote: > >> Thanks for working on it! It looks really good. Please remember to update >> the feature test macro (

[PATCH] D129531: [clang][C++20] P0960R3: Allow initializing aggregates from a parenthesized list of values

ayzhao updated this revision to Diff 471329. ayzhao marked 11 inline comments as done. ayzhao added a comment. Fix PCH test and address some code review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129531/new/ https://reviews.llvm.org/D12

[PATCH] D136886: [clang] [ASTImporter] RFC: Correct importer to not duplicate sugared types

vabridgers updated this revision to Diff 471328. vabridgers added a comment. remove commented code from test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136886/new/ https://reviews.llvm.org/D136886 Files: clang/lib/AST/ASTImporter.cpp c

[PATCH] D136601: [OpenMP] [OMPIRBuilder] Create a new datatype to hold the unique target region info

mikerice added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:3031 +OrderedEntries[E.getOrder()] = +std::make_tuple(&E, Loc, EntryInfo.ParentName); +ParentFunctions[E.getOrder()] = EntryInfo.ParentName; vitalybuka w

[clang] 01636fb - Fix documentation error in e8433a2b06d5

Author: Amy Huang Date: 2022-10-27T22:41:49Z New Revision: 01636fb0aef0ef06f1fa13292ce7682348b41d27 URL: https://github.com/llvm/llvm-project/commit/01636fb0aef0ef06f1fa13292ce7682348b41d27 DIFF: https://github.com/llvm/llvm-project/commit/01636fb0aef0ef06f1fa13292ce7682348b41d27.diff LOG: Fix

[PATCH] D136797: [clang-tidy] Skip template ctors in modernize-use-equals-default

alexander-shaposhnikov updated this revision to Diff 471309. alexander-shaposhnikov marked an inline comment as done. alexander-shaposhnikov added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136797/new/ https://reviews

[PATCH] D136888: Move getenv for AS_SECURE_LOG_FILE to clang

benlangmuir added inline comments. Comment at: llvm/lib/MC/MCContext.cpp:62 -static cl::opt +static cl::opt AsSecureLogFileName("as-secure-log-file-name", steven_wu wrote: > benlangmuir wrote: > > Interestingly, `opt` doesn't have a parser; this code only work

[PATCH] D136888: Move getenv for AS_SECURE_LOG_FILE to clang

steven_wu added a comment. If we have to fix it, I slightly prefer just give it a proper option in CodeGenOption and a `cc1` and `cc1as` flag. Comment at: llvm/lib/MC/MCContext.cpp:62 -static cl::opt +static cl::opt AsSecureLogFileName("as-secure-log-file-name", ---

[PATCH] D136601: [OpenMP] [OMPIRBuilder] Create a new datatype to hold the unique target region info

vitalybuka added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:3031 +OrderedEntries[E.getOrder()] = +std::make_tuple(&E, Loc, EntryInfo.ParentName); +ParentFunctions[E.getOrder()] = EntryInfo.ParentName; mikerice w

[PATCH] D136894: Add clang-doc readme

brettw created this revision. brettw added a reviewer: paulkirth. brettw added a project: clang-tools-extra. Herald added a project: All. brettw requested review of this revision. Herald added a subscriber: cfe-commits. Adds a readme to clang-doc with an overview of the structure of the code. Re

[PATCH] D136188: Update docs for -fuse-ctor-homing

This revision was automatically updated to reflect the committed changes. Closed by commit rGe8433a2b06d5: Update docs for -fuse-ctor-homing (authored by akhuang). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136188/new/ https://reviews.llvm.org/D1

[clang] e8433a2 - Update docs for -fuse-ctor-homing

Author: Amy Huang Date: 2022-10-27T22:24:34Z New Revision: e8433a2b06d554df922d67f953a06701402536a1 URL: https://github.com/llvm/llvm-project/commit/e8433a2b06d554df922d67f953a06701402536a1 DIFF: https://github.com/llvm/llvm-project/commit/e8433a2b06d554df922d67f953a06701402536a1.diff LOG: Upd

[PATCH] D136797: [clang-tidy] Skip template ctors in modernize-use-equals-default

ymandel added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/UseEqualsDefaultCheck.cpp:249 unless(isVariadic()), parameterCountIs(0), +unless(hasParent(functionTemplateDecl())), IsPublicOrOutOfLine

[PATCH] D136797: [clang-tidy] Skip template ctors in modernize-use-equals-default

alexander-shaposhnikov marked 3 inline comments as done. alexander-shaposhnikov added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/UseEqualsDefaultCheck.cpp:249 unless(isVariadic()), parameterCountIs(0), +unless(hasP

[PATCH] D136797: [clang-tidy] Skip template ctors in modernize-use-equals-default

alexander-shaposhnikov updated this revision to Diff 471304. alexander-shaposhnikov added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136797/new/ https://reviews.llvm.org/D136797 Files: clang-tools-extra/clang-tidy/

[PATCH] D136886: [ASTImporter] RFC: Correct importer to not duplicate sugared types

vabridgers updated this revision to Diff 471303. vabridgers added a comment. remove commented line Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136886/new/ https://reviews.llvm.org/D136886 Files: clang/lib/AST/ASTImporter.cpp clang/unittests/

[PATCH] D136786: Fix `unsafe-fp-math` attribute emission.

michele.scandale added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:1865 FuncAttrs.addAttribute("approx-func-fp-math", "true"); -if ((LangOpts.FastMath || - (!LangOpts.FastMath && LangOpts.AllowFPReassoc && - LangOpts.AllowRecip && !LangOp

[PATCH] D136497: [Clang] support for outputs along indirect edges of asm goto

void added a comment. It might be easier to see the main changes here if you submit the (very nice) refactoring of `EmitAsmStores` first. Comment at: clang/lib/CodeGen/CGStmt.cpp:2358 +// the expression, do the conversion. +if (ResultRegTypes[i] != ResultTruncRegTypes[

[PATCH] D136888: Move getenv for AS_SECURE_LOG_FILE to clang

benlangmuir added inline comments. Comment at: llvm/lib/MC/MCContext.cpp:62 -static cl::opt +static cl::opt AsSecureLogFileName("as-secure-log-file-name", Interestingly, `opt` doesn't have a parser; this code only worked with the default value before. Repos

[PATCH] D136888: Move getenv for AS_SECURE_LOG_FILE to clang

benlangmuir created this revision. benlangmuir added a reviewer: steven_wu. Herald added a subscriber: hiraditya. Herald added a project: All. benlangmuir requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, MaskRay. Herald added projects: clang, LLVM. Avoid call

[PATCH] D136886: [ASTImporter] RFC: Correct importer to not duplicate sugared types

vabridgers created this revision. vabridgers added a reviewer: mizvekov. Herald added a reviewer: a.sidorin. Herald added a reviewer: shafik. Herald added a project: All. vabridgers requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. I'm not su

[PATCH] D119051: Extend the C++03 definition of POD to include defaulted functions

dblaikie added a comment. In D119051#3888667 , @rnk wrote: > I realized I forgot some things I should've mentioned: > > - This probably deserves a release note, if it doesn't have one already that > I missed or forgot about e4ec6ce8a75c208b49b163c81cda9

[clang] 0cb65b0 - Revert "[OpenMP] [OMPIRBuilder] Create a new datatype to hold the unique target region info"

Author: Kevin Athey Date: 2022-10-27T13:57:25-07:00 New Revision: 0cb65b0a585c8b3d4a8a2aefe994a8fc907934f8 URL: https://github.com/llvm/llvm-project/commit/0cb65b0a585c8b3d4a8a2aefe994a8fc907934f8 DIFF: https://github.com/llvm/llvm-project/commit/0cb65b0a585c8b3d4a8a2aefe994a8fc907934f8.diff L

[PATCH] D136854: [HIP] add -fhiplib-add-rpath

yaxunl updated this revision to Diff 471289. yaxunl added a comment. rename to --offload-add-rpath CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136854/new/ https://reviews.llvm.org/D136854 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/ToolChains/Linux.cpp clang/t

[PATCH] D136601: [OpenMP] [OMPIRBuilder] Create a new datatype to hold the unique target region info

kda added a comment. The bracket builds have finished and they seem to have a conclusive result. The test starts failing with this patch. Built at this patch: https://lab.llvm.org/buildbot/#/builders/236/builds/803 Built at prior patch: https://lab.llvm.org/buildbot/#/builders/236/builds/804

[PATCH] D136694: [clang][Interp] Check that constructor calls initialize all record fields

shafik added inline comments. Comment at: clang/lib/AST/Interp/Interp.cpp:1 //===--- InterpState.cpp - Interpreter for the constexpr VM -*- C++ -*-===// // Probably a separate NFC commit Comment at: clang/lib/AST/Interp/Interp.cpp:465 +b

[clang] e4ec6ce - Clang: Add release note for defaulted-special-members-POD GCC ABI fix

Author: David Blaikie Date: 2022-10-27T20:41:22Z New Revision: e4ec6ce8a75c208b49b163c81cda90dc7373c791 URL: https://github.com/llvm/llvm-project/commit/e4ec6ce8a75c208b49b163c81cda90dc7373c791 DIFF: https://github.com/llvm/llvm-project/commit/e4ec6ce8a75c208b49b163c81cda90dc7373c791.diff LOG:

[PATCH] D136784: [Clang] Improve diagnostic message for loop hint pragma

Meinersbur accepted this revision. Meinersbur added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/lib/Parse/ParsePragma.cpp:1306 StringRef Str = PragmaName.getIdentifierInfo()->getName(); std::string ClangLoopStr = (llvm::Twine("clang

[clang] 439209d - [docs] Fix old path for clang-format

Author: Ji, Jinsong Date: 2022-10-27T13:14:05-07:00 New Revision: 439209dbcbf2ceb09cd445f8f59b26e8b98d4f8e URL: https://github.com/llvm/llvm-project/commit/439209dbcbf2ceb09cd445f8f59b26e8b98d4f8e DIFF: https://github.com/llvm/llvm-project/commit/439209dbcbf2ceb09cd445f8f59b26e8b98d4f8e.diff L

[PATCH] D136568: [Clang] Support constexpr builtin ilogb

jcranmer-intel added inline comments. Comment at: clang/test/Sema/constant-builtins-ilogb.cpp:53-63 +// assert smallest subnormal and largest finite numbers +static_assert(__builtin_ilogbf(1.40129846E-45f) == -149); +static_assert(__builtin_ilogbf(3.40282347E+38f) == 127); + +sta

[PATCH] D133052: [clang] Avoid crash when expanding conversion templates in concepts.

usaxena95 added a comment. Not sure if this has come up already but this would still crash on template concept C = requires(T a) { foo(a); }; struct D1 { template D1(TO); }; struct D2 { friend void foo(D1); }; static_assert(C); as we only consider conversion to its

[PATCH] D136568: [Clang] Support constexpr builtin ilogb

Izaron added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:12452 +int Ilogb; +if (APFloat::opStatus St = ilogb(F, Ilogb); !isConstantOpStatus(St)) + return false; hubert.reinterpretcast wrote: > hubert.reinterpretcast wrote: > > hubert.

[PATCH] D136190: [clang][Sema][NFC] Remove redundant isTypeValid

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG488cf1038c88: [clang][Sema][NFC] Remove redundant isTypeValid (authored by troyj). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 488cf10 - [clang][Sema][NFC] Remove redundant isTypeValid

Author: Troy Johnson Date: 2022-10-27T12:48:11-07:00 New Revision: 488cf1038c88a6d7e5378d493a253e1dc6a97cd9 URL: https://github.com/llvm/llvm-project/commit/488cf1038c88a6d7e5378d493a253e1dc6a97cd9 DIFF: https://github.com/llvm/llvm-project/commit/488cf1038c88a6d7e5378d493a253e1dc6a97cd9.diff

[PATCH] D136080: [flang] Add -ffp-contract option processing

awarzynski accepted this revision. awarzynski added a comment. LGTM, thanks for implementing this! Comment at: clang/lib/Driver/ToolChains/Flang.cpp:98-99 +} else + // Clang's "fast-honor-pragmas" option is not supported because it is + // non-standard and pragmas

[PATCH] D136786: Fix `unsafe-fp-math` attribute emission.

zahiraam added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:1865 FuncAttrs.addAttribute("approx-func-fp-math", "true"); -if ((LangOpts.FastMath || - (!LangOpts.FastMath && LangOpts.AllowFPReassoc && - LangOpts.AllowRecip && !LangOpts.Finit

[PATCH] D136776: [clang codegen] Fix __try/__finally blocks in C++ constructors.

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. From what I know, we could always build the GlobalDecl with the base ctor/dtor variant. The complete and deleting variants always delegate to the base variants, and we will only ever emit the SEH fu

[PATCH] D136872: [OpenMP][OpenMPIRBuilder] Migrate loadOffloadInfoMetadata from clang to OMPIRbuilder

jdoerfert added inline comments. Comment at: llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h:2167 +Module &M, llvm::OffloadEntriesInfoManager &OffloadEntriesInfoManager, +bool isDevice); + Why is this in llvm namespace? This should be qualified further,

[PATCH] D136874: [clang][LTO] Passing vec-extabi to the Backend on AIX

qiongsiwu1 created this revision. qiongsiwu1 added reviewers: w2yehia, MaskRay. qiongsiwu1 added a project: clang. Herald added subscribers: ormris, StephenFan, steven_wu, hiraditya, inglorion. Herald added a project: All. qiongsiwu1 requested review of this revision. Herald added a subscriber: cfe

[PATCH] D119051: Extend the C++03 definition of POD to include defaulted functions

rnk added a comment. In D119051#3888906 , @erichkeane wrote: > I noticed in a downstream that this changes how we emit structs to IR > sometimes (see https://godbolt.org/z/74xeq9rTj for an example, but the > 'no-opaque-pointers' isn't necessary to caus

[PATCH] D136872: [OpenMP][OpenMPIRBuilder] Migrate loadOffloadInfoMetadata from clang to OMPIRbuilder

TIFitis created this revision. TIFitis added a reviewer: jdoerfert. Herald added subscribers: guansong, hiraditya, yaxunl. Herald added a project: All. TIFitis published this revision for review. TIFitis added reviewers: ABataev, jhuber6. Herald added subscribers: llvm-commits, cfe-commits, sstefan

[PATCH] D136474: [CodeView][clang] Disable emitting command line into CodeView by default and add flag to enable

thieta added a comment. I am fine with this plan as well. And I am willing to chip in and try to fix the issues with the current implementation since we actually use the feature. @thakis do you mind explaining the issues you see and how to replicate them and I can have a look. Repository: r

[PATCH] D136474: [CodeView][clang] Disable emitting command line into CodeView by default and add flag to enable

thakis added a comment. > That works for me, I just want to make it clear that the long term goal for > the project is that we emit the command line in LF_BUILDINFO by default, > rather than disabling it once and for all. If it's not ready yet, great, > let's disable it and continue. Fully on

[PATCH] D136572: Harmonize cmake_policy() across standalone builds of all projects

mstorsjo added a comment. Also for the record, I'd love to get rid of this symlink based setup, if I could make cmake produce project files where caching works in the same way. The main requirement for that would be to have the whole cmake build started from the toplevel llvm-project directory

[PATCH] D136188: Update docs for -fuse-ctor-homing

akhuang updated this revision to Diff 471240. akhuang added a comment. Add another debug info strategy to the description Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136188/new/ https://reviews.llvm.org/D136188 Files: clang/docs/UsersManual.rs

[PATCH] D136572: Harmonize cmake_policy() across standalone builds of all projects

mstorsjo accepted this revision. mstorsjo added a comment. In D136572#3888630 , @mgorny wrote: > @mstorsjo, could you check this version? LGTM, this seems to work for my usecase (with lld,lldb,clang enabled this way). Thanks for the quick revert and fix

[PATCH] D136572: Harmonize cmake_policy() across standalone builds of all projects

MaskRay added a comment. It'll be good if we have a wiki describing how downstream users invoke cmake, so that large cmake refactoring can be verified beforehand. (like usage verification https://github.com/opencollab/llvm-toolchain-integration-test-suite, but for cmake invocations) CHANGES S

[PATCH] D136568: [Clang] Support constexpr builtin ilogb

hubert.reinterpretcast added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:12452 +int Ilogb; +if (APFloat::opStatus St = ilogb(F, Ilogb); !isConstantOpStatus(St)) + return false; hubert.reinterpretcast wrote: > hubert.reinterpretcast wr

[PATCH] D135488: [codegen] Display stack layouts in console

paulkirth updated this revision to Diff 471235. paulkirth added a comment. Address comments - fix brancing style - update parameters to use const - use llvm::sort in place of std::sort - remove path strings from debug info in test files Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D136568: [Clang] Support constexpr builtin ilogb

hubert.reinterpretcast added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:12452 +int Ilogb; +if (APFloat::opStatus St = ilogb(F, Ilogb); !isConstantOpStatus(St)) + return false; hubert.reinterpretcast wrote: > Izaron wrote: > > majneme

[PATCH] D136854: [HIP] add -fhiplib-add-rpath

yaxunl added a comment. In D136854#3889141 , @MaskRay wrote: > If an option does not affect compilation, I prefer `--` to `-f` I will rename it as --offload-add-rpath Comment at: clang/include/clang/Driver/Options.td:4158 + HelpText<

[PATCH] D136568: [Clang] Support constexpr builtin ilogb

hubert.reinterpretcast added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:12452 +int Ilogb; +if (APFloat::opStatus St = ilogb(F, Ilogb); !isConstantOpStatus(St)) + return false; Izaron wrote: > majnemer wrote: > > Izaron wrote: > > > j

[PATCH] D134902: [clang] Implement -fstrict-flex-arrays=3

This revision was automatically updated to reflect the committed changes. Closed by commit rG7f93ae808634: [clang] Implement -fstrict-flex-arrays=3 (authored by void). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134902/new/ https://reviews.llvm.or

[clang] 7f93ae8 - [clang] Implement -fstrict-flex-arrays=3

Author: Bill Wendling Date: 2022-10-27T10:50:04-07:00 New Revision: 7f93ae808634e33e4dc9bce753c909aa5f9a6eb4 URL: https://github.com/llvm/llvm-project/commit/7f93ae808634e33e4dc9bce753c909aa5f9a6eb4 DIFF: https://github.com/llvm/llvm-project/commit/7f93ae808634e33e4dc9bce753c909aa5f9a6eb4.diff

[PATCH] D136854: [HIP] add -fhiplib-add-rpath

MaskRay added a comment. If an option does not affect compilation, I prefer `--` to `-f` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136854/new/ https://reviews.llvm.org/D136854 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:

[PATCH] D136807: [clang][Sema] Fix a clang crash with btf_type_tag

yonghong-song updated this revision to Diff 471216. yonghong-song added a comment. - Add the bug fix description in Release Note - Actually compare debuginfo btf_type_tag output instead of marking 'expected-no-diagnostics'. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D136807: [clang][Sema] Fix a clang crash with btf_type_tag

yonghong-song added a comment. In D136807#3888317 , @aaron.ballman wrote: > The changes generally look good to me, but can you add a release note for the > fix as well? Yes, will add the bug fix brief description to clang/docs/ReleaseNotes.rst =

[PATCH] D136854: [HIP] add -fhiplib-add-rpath

tra added inline comments. Comment at: clang/include/clang/Driver/Options.td:4156 HelpText<"Do not add -rpath with architecture-specific resource directory to the linker flags">; +def fhiplib_add_rpath: Flag<["-"], "fhiplib-add-rpath">, Flags<[NoArgumentUnused]>, + HelpText

[PATCH] D116735: [RISCV] Adjust RISCV data layout by using n32:64 in layout string

craig.topper updated this revision to Diff 471209. craig.topper added a comment. Add to release notes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116735/new/ https://reviews.llvm.org/D116735 Files: clang/lib/Basic/Targets/RISCV.h llvm/docs/R

[PATCH] D136864: [Clang] Create opaque type for AArch64 SVE2p1/SME2 svcount_t.

sdesmalen created this revision. Herald added subscribers: kristof.beyls, tschuett. Herald added a project: All. sdesmalen requested review of this revision. Herald added subscribers: cfe-commits, alextsao1999. Herald added a project: clang. This patch adds the builtin type __SVCount_t to Clang, w

[PATCH] D136190: [clang][Sema] remove redundant isTypeValid

bruno accepted this revision. bruno added a comment. This revision is now accepted and ready to land. Nice cleanup, before landing please capitalize `remove` in the title and also add `[NFC]` to it! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136

[PATCH] D134453: Disambiguate type names when printing NTTP types

DoDoENT updated this revision to Diff 471204. DoDoENT added a comment. apply git-clang-format to changed files Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134453/new/ https://reviews.llvm.org/D134453 Files: clang/docs/ReleaseNotes.rst clang/

  1   2   3   >