thakis added a comment.

> That works for me, I just want to make it clear that the long term goal for 
> the project is that we emit the command line in LF_BUILDINFO by default, 
> rather than disabling it once and for all. If it's not ready yet, great, 
> let's disable it and continue.

Fully on board with this :)

> FWIW, we could probably move the terminal detection to the cc1 job. It 
> inherits the TTY, right, so it can do the detection? I would look at how we 
> handle fcolor-diagnostics here as reference, is that in the cc1 line or not?




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136474/new/

https://reviews.llvm.org/D136474

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to