HaoyuZhang added a comment. Thank you for the comments. The subject has been modified.
For wenlei's comment, I am working on a Chromium patch <https://chromium-review.googlesource.com/c/chromium/src/+/3919316> for enabling profi algorithm in Chrome OS. The reviewer Hans hope an user-facing flag can be used in Chromium BUILD.gn instead of "-mllvm" shape. With investigating that profi is not a user-facing feature yet, we choose to make it to be a driver flag. :) ================ Comment at: clang/test/CodeGen/pgo-sample-use-profi.cpp:1 +//Test if profi flat is enabled in frontend as user-facing feature. +// ---------------- MaskRay wrote: > Remove the test. > > This change only needs a clang/test/Driver test showing that the option > passes `-sample-profile-use-profi` to -cc1. Thank you for the comments. So we only need to RUN the command for example: `//RUN: %clang_cc1 %s -fsample-profile-use-profi -fdebug-pass-manager -emit-llvm -o - 2>&1 | FileCheck %s` `//CHECK: Running pass: VerifierPass` and without any test code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136846/new/ https://reviews.llvm.org/D136846 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
