alexander-shaposhnikov marked 3 inline comments as done.
alexander-shaposhnikov added inline comments.
================
Comment at: clang-tools-extra/clang-tidy/modernize/UseEqualsDefaultCheck.cpp:249
unless(isVariadic()), parameterCountIs(0),
+ unless(hasParent(functionTemplateDecl())),
IsPublicOrOutOfLineUntilCPP20),
----------------
ymandel wrote:
> since this appears in both branches, can you place it above on line 244? that
> will also save a `hasParent` call (fwiw).
> ```
> unless(hasParent(anyOf(IsUnionLikeClass, functionTemplateDecl())))
> ```
(changed to anyOf(hasParent(...)) (hasParent(anyOf(...)) doesn't compile))
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D136797/new/
https://reviews.llvm.org/D136797
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
