[PATCH] D125291: Introduce @llvm.threadlocal.address intrinsic to access TLS variable (1/3)

ChuanqiXu added a comment. @rjmccall @eli.friedman @jyknight gentle ping~ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125291/new/ https://reviews.llvm.org/D125291 ___ cfe-commits mailing list cfe-commi

[PATCH] D123319: Change how we handle auto return types for lambda operator() to be consistent with gcc

dblaikie added a comment. In D123319#3506745 , @shafik wrote: >> Any update/further details here? > > David, apologies for not getting back to you sooner. The context is D105564 > which I started working on again recent

[PATCH] D125622: [clang-tidy] Reject invalid enum initializers in C files

LegalizeAdulthood marked 2 inline comments as done. LegalizeAdulthood added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/modernize-macro-to-enum.c:9 + +// C forbids comma operator in initializing expressions. +#define BAD_OP 1, 2 aaron

[PATCH] D125742: Minor refactor of CanonicalIncludes::addSystemHeadersMapping.

ppluzhnikov created this revision. ppluzhnikov added a reviewer: ilya-biryukov. Herald added subscribers: usaxena95, kadircet, arphaman. Herald added a project: All. ppluzhnikov requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Be

[PATCH] D125402: [clang][diag] warn if function returns class type by-const-value

nlee added a comment. In D125402#3508845 , @aaron.ballman wrote: > Thank you for working on this new diagnostic! We don't typically add new > diagnostics that are off by default unless they're for pedantic diagnostics > or are reasonably expected to be

[PATCH] D125517: [Frontend] [Coroutines] Emit error when we found incompatible allocation function in promise_type

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG452fac9534c0: [Frontend] [Coroutines] Emit error when we found incompatible allocation (authored by ChuanqiXu). Repository: rG LLVM Github Monorep

[clang] 452fac9 - [Frontend] [Coroutines] Emit error when we found incompatible allocation

Author: Chuanqi Xu Date: 2022-05-17T10:36:21+08:00 New Revision: 452fac9534c00290e92819202d445810e33d0444 URL: https://github.com/llvm/llvm-project/commit/452fac9534c00290e92819202d445810e33d0444 DIFF: https://github.com/llvm/llvm-project/commit/452fac9534c00290e92819202d445810e33d0444.diff LO

[PATCH] D124977: [NFC][Clang] Modify expect of fail test or XFAIL because CSKY align is different

zixuan-wu added a comment. Gentle pin.. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124977/new/ https://reviews.llvm.org/D124977 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com

[PATCH] D123534: [dwarf] Emit a DIGlobalVariable for constant strings.

paulkirth added a comment. Thanks for the quick response. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123534/new/ https://reviews.llvm.org/D123534 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D123534: [dwarf] Emit a DIGlobalVariable for constant strings.

hctim added a comment. Done, I'll take a look and resubmit later. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123534/new/ https://reviews.llvm.org/D123534 ___ cfe-commits mailing list cfe-commits@lists

[clang] ed2c321 - Revert "[dwarf] Emit a DIGlobalVariable for constant strings."

Author: Mitch Phillips Date: 2022-05-16T19:07:38-07:00 New Revision: ed2c3218f5badf88cb7897fabf8faa01e8aa2044 URL: https://github.com/llvm/llvm-project/commit/ed2c3218f5badf88cb7897fabf8faa01e8aa2044 DIFF: https://github.com/llvm/llvm-project/commit/ed2c3218f5badf88cb7897fabf8faa01e8aa2044.diff

[PATCH] D123534: [dwarf] Emit a DIGlobalVariable for constant strings.

paulkirth added a comment. Hi, we're seeing a breakage in Fuchsia's clang CI for x64 windows that I think is related to this patch. https://luci-milo.appspot.com/ui/p/fuchsia/builders/toolchain.ci/clang-windows-x64/b8813962058917346337/overview We see a test failure in Clang :: CodeGen/debug-in

[PATCH] D124435: [X86] Always extend the integer parameters in callee

rjmccall added a comment. I'm fine with alternatives on the names. I just don't think we want names that imply that the caller and callee are parallel here, as if there were some sort of requirement that the callee always extends. In those conventions, the callee gets passed 8 or 16 meaningfu

[PATCH] D124806: [clang-tidy] add support for Demorgan conversions to readability-simplify-bool-expr

njames93 updated this revision to Diff 429907. njames93 added a comment. Extend fix-its to also support removing parens where possible. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124806/new/ https://reviews.llvm.org/D124806 Files: clang-tools

[PATCH] D123534: [dwarf] Emit a DIGlobalVariable for constant strings.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4680982b36a8: [dwarf] Emit a DIGlobalVariable for constant strings. (authored by hctim). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[clang] 4680982 - [dwarf] Emit a DIGlobalVariable for constant strings.

Author: Mitch Phillips Date: 2022-05-16T16:52:16-07:00 New Revision: 4680982b36a84770a1600fc438be8ec090671724 URL: https://github.com/llvm/llvm-project/commit/4680982b36a84770a1600fc438be8ec090671724 DIFF: https://github.com/llvm/llvm-project/commit/4680982b36a84770a1600fc438be8ec090671724.diff

[PATCH] D125679: [Clang] Added options for integrated backend only used for SPIR-V for now

iliya-diyachkov added a comment. I'm not an expert in clang, but overall the patch looks good to me. Comment at: clang/docs/UsersManual.rst:3640 +Clang also supports integrated generation of SPIR-V without use of ``llvm-spirv`` +tool as an exerimental feature when ``-fintegrat

[PATCH] D123538: [symbolizer] Parse DW_TAG_variable DIs to show line info for globals

dblaikie added inline comments. Comment at: llvm/lib/DebugInfo/DWARF/DWARFUnit.cpp:769-783 +DataExtractor Data(Location.Expr, /*IsLittleEndian=*/true, 8); +uint64_t DataOffset = 0; +uint8_t Operation = Data.getU8(&DataOffset); +if (Operation == dwarf::DW_OP_addr)

[PATCH] D123534: [dwarf] Emit a DIGlobalVariable for constant strings.

dblaikie accepted this revision. dblaikie added a comment. Seems good - if folks find the growth too much, or it creates weird perf issues otherwise, we can discuss that if/when it comes up. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123534/new/

[PATCH] D125727: [clang] Avoid suggesting typoed directives in `.S` files

ken-matsui added a comment. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125727/new/ https://reviews.llvm.org/D125727 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

[PATCH] D125727: [clang] Avoid suggesting typoed directives in `.S` files

nickdesaulniers added a comment. pushed 45e01ce5fe6a5e4dc25ffdf626caa344fbcb93dd Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125727/new/ https://reviews.llvm.org/D125727

[PATCH] D125727: [clang] Avoid suggesting typoed directives in `.S` files

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG45e01ce5fe6a: [clang] Avoid suggesting typoed directives in `.S` files (authored by ken-matsui, committed by nickdesaulniers). Repository: rG LLVM

[clang] 45e01ce - [clang] Avoid suggesting typoed directives in `.S` files

Author: Ken Matsui Date: 2022-05-16T15:46:59-07:00 New Revision: 45e01ce5fe6a5e4dc25ffdf626caa344fbcb93dd URL: https://github.com/llvm/llvm-project/commit/45e01ce5fe6a5e4dc25ffdf626caa344fbcb93dd DIFF: https://github.com/llvm/llvm-project/commit/45e01ce5fe6a5e4dc25ffdf626caa344fbcb93dd.diff LO

[PATCH] D125727: [clang] Avoid suggesting typoed directives in `.S` files

nickdesaulniers added a comment. sorted, will commit soon Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125727/new/ https://reviews.llvm.org/D125727 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D125727: [clang] Avoid suggesting typoed directives in `.S` files

nickdesaulniers added a comment. Sorry, it looks like `arcanist` or my PHP runtime was auto updated on my host and has regressed. I need to sort that out first. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125727/new/ https://reviews.llvm.org/D12

[PATCH] D125727: [clang] Avoid suggesting typoed directives in `.S` files

nickdesaulniers added a comment. > I do not have permission to land this patch, so could you please do it on my > behalf? Will do. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125727/new/ https://reviews.llvm.org/D125727 ___

[PATCH] D125727: [clang] Avoid suggesting typoed directives in `.S` files

ken-matsui added a comment. @nickdesaulniers Thank you for your review! I do not have permission to land this patch, so could you please do it on my behalf? Here is my information: Name: `Ken Matsui` Email: `v...@kmatsui.me` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D125727: [clang] Avoid suggesting typoed directives in `.S` files

nickdesaulniers accepted this revision. nickdesaulniers added a comment. This revision is now accepted and ready to land. thanks for the patch! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125727/new/ https://reviews.llvm.org/D125727

[PATCH] D125727: [clang] Avoid suggesting typoed directives in `.S` files

ken-matsui added a comment. Sorry for having missed it. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125727/new/ https://reviews.llvm.org/D125727 ___ cfe-commits mailing list cfe-commits@list

[PATCH] D125727: [clang] Avoid suggesting typoed directives in `.S` files

ken-matsui updated this revision to Diff 429877. ken-matsui added a comment. Remove `- < %s` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125727/new/ https://reviews.llvm.org/D125727 Files: clang/lib/Lex/PPDirectives.cpp clang/test/Preprocess

[PATCH] D125727: [clang] Avoid suggesting typoed directives in `.S` files

nickdesaulniers added inline comments. Comment at: clang/test/Preprocessor/suggest-typoed-directive.S:1 +// RUN: %clang_cc1 -fsyntax-only -verify %s - < %s + These three can be removed now as well. Clang will read `%s` as input without the need to read from std

[PATCH] D125705: [OpenMP] Don't build the offloading driver without a source input

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb653b409ff44: [OpenMP] Don't build the offloading driver without a source input (authored by jhuber6). Changed prior to commit: https://reviews.ll

[clang] b653b40 - [OpenMP] Don't build the offloading driver without a source input

Author: Joseph Huber Date: 2022-05-16T18:19:02-04:00 New Revision: b653b409ff44b09ade04bb6e579f5f9790424611 URL: https://github.com/llvm/llvm-project/commit/b653b409ff44b09ade04bb6e579f5f9790424611 DIFF: https://github.com/llvm/llvm-project/commit/b653b409ff44b09ade04bb6e579f5f9790424611.diff

[PATCH] D125719: [Attribute] Add attribute NeverOptimizeNone

arsenm added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:1934 !F->hasFnAttribute(llvm::Attribute::AlwaysInline)) { B.addAttribute(llvm::Attribute::OptimizeNone); I still think adding optnone to everything at -O0 is a bad idea in

[PATCH] D125727: [clang] Avoid suggesting typoed directives in `.S` files

ken-matsui added a comment. Removed it 👍 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125727/new/ https://reviews.llvm.org/D125727 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.l

[PATCH] D125727: [clang] Avoid suggesting typoed directives in `.S` files

ken-matsui updated this revision to Diff 429872. ken-matsui added a comment. Remove `-x assembler-with-cpp` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125727/new/ https://reviews.llvm.org/D125727 Files: clang/lib/Lex/PPDirectives.cpp clang/

[PATCH] D125727: [clang] Avoid suggesting typoed directives in `.S` files

nickdesaulniers added inline comments. Comment at: clang/test/Preprocessor/suggest-typoed-directive.S:1 +// RUN: %clang_cc1 -fsyntax-only -verify -S %s -o %t + nickdesaulniers wrote: > nickdesaulniers wrote: > > Consider adding a test: > > > > ``` > > // RUN: %c

[PATCH] D125727: [clang] Avoid suggesting typoed directives in `.S` files

ken-matsui added inline comments. Comment at: clang/lib/Lex/PPDirectives.cpp:484 const SourceLocation &EndLoc) const { + // If this is a `.S` file, treat unknown # directives as non-preprocessor + // directives. nickde

[PATCH] D125727: [clang] Avoid suggesting typoed directives in `.S` files

ken-matsui added a comment. Thank you for your review! I've fixed it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125727/new/ https://reviews.llvm.org/D125727 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D125727: [clang] Avoid suggesting typoed directives in `.S` files

ken-matsui updated this revision to Diff 429869. ken-matsui added a comment. Update the code as reviewed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125727/new/ https://reviews.llvm.org/D125727 Files: clang/lib/Lex/PPDirectives.cpp clang/tes

[PATCH] D125728: [WebAssembly] Update supported features in -mcpu=generic

sunfish created this revision. Herald added subscribers: pmatos, asb, ecnelises, jgravelle-google, sbc100, dschuff. Herald added a project: All. sunfish requested review of this revision. Herald added a subscriber: aheejin. Herald added a project: clang. Enable nontrapping-fptoint, sign-ext, bulk

[PATCH] D125727: Avoid suggesting typoed directives in `.S` files

nickdesaulniers added inline comments. Comment at: clang/test/Preprocessor/suggest-typoed-directive.S:1 +// RUN: %clang_cc1 -fsyntax-only -verify -S %s -o %t + nickdesaulniers wrote: > Consider adding a test: > > ``` > // RUN: %clang_cc1 -fsyntax-only -verify %s

[PATCH] D125727: Avoid suggesting typoed directives in `.S` files

nickdesaulniers added inline comments. Comment at: clang/lib/Lex/PPDirectives.cpp:484 const SourceLocation &EndLoc) const { + // If this is a `.S` file, treat unknown # directives as non-preprocessor + // directives. A

[PATCH] D125727: Avoid suggesting typoed directives in `.S` files

nickdesaulniers added inline comments. Comment at: clang/test/Preprocessor/suggest-typoed-directive.S:1 +// RUN: %clang_cc1 -fsyntax-only -verify -S %s -o %t + Consider adding a test: ``` // RUN: %clang_cc1 -fsyntax-only -verify %s -x assembler-with-cpp < %s ```

[PATCH] D124726: Suggest typoed directives in preprocessor conditionals

ken-matsui added a comment. I see. Thank you. I fixed the issue using its workaround. https://reviews.llvm.org/D125727 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124726/new/ https://reviews.llvm.org/D124726

[PATCH] D125727: Avoid suggesting typoed directives in `.S` files

ken-matsui created this revision. ken-matsui added a reviewer: aaron.ballman. Herald added a project: All. ken-matsui requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch is itended to avoid suggesting typoed directives in `.S` files

[PATCH] D125678: [clang][extract-api] Don't emit symbols prefixed with an underscore

zixuw accepted this revision. zixuw added a comment. In D125678#3517168 , @QuietMisdreavus wrote: > clang-format failed: > > --- clang-format > > changed files: > > clang/test/ExtractAPI/underscored.c I think it's fine. clang-format alw

[PATCH] D125678: [clang][extract-api] Don't emit symbols prefixed with an underscore

QuietMisdreavus added a comment. clang-format failed: --- clang-format changed files: clang/test/ExtractAPI/underscored.c Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125678/new/ https://reviews.llvm.org/D125678

[PATCH] D125678: [clang][extract-api] Don't emit symbols prefixed with an underscore

QuietMisdreavus accepted this revision. QuietMisdreavus added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125678/new/ https://reviews.llvm.org/D125678 _

[PATCH] D125711: [concepts] Implement dcl.decl.general p4: No constraints on non-template funcs

royjacobson accepted this revision. royjacobson added a comment. This revision is now accepted and ready to land. Code and added/modified tests LGTM! Do you think we should add a release note, given that it could break existing code? Its seems a bit unlikely, but the amount of broken tests have

[PATCH] D125723: [MSVC] Add support for MSVC pragma optimize

steplong created this revision. Herald added a project: All. steplong requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. MSVC's pragma optimize turns optimizations on or off based on the list passed. Depends on D125722

[PATCH] D125722: [Attribute] Add clang optsize attribute

steplong created this revision. Herald added a reviewer: aaron.ballman. Herald added a project: All. steplong requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add the ability to put `__attribute__((optsize))` on functions. Depends on D12572

[PATCH] D125720: [Attribute] Add clang frame_pointer attribute

steplong created this revision. Herald added a reviewer: aaron.ballman. Herald added a project: All. steplong requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add the ability to put __attribute__((frame_pointer(arg))) on functions. arg is on

[PATCH] D123676: [clang-format] Fix WhitespaceSensitiveMacros not being honoured when macro closing parenthesis is followed by a newline.

curdeius added a comment. In D123676#3515949 , @krasimir wrote: > It looks like this regressed the following example by adding an unwanted > level of indentation to the `#elif B` branch: Sure, I'll have a look. It seems that even this: MACRO_BEGIN

[PATCH] D125719: [Attribute] Add attribute NeverOptimizeNone

steplong created this revision. Herald added a reviewer: aaron.ballman. Herald added a project: All. steplong requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add NeverOptimizeNone to facilitate removing OptimizeNone. This allows us to remov

[PATCH] D124726: Suggest typoed directives in preprocessor conditionals

erichkeane added a comment. In D124726#3516896 , @ken-matsui wrote: > @nathanchance > > Oops, thank you for your comment! > I would like to work on a hotfix patch for this issue. > > @aaron.ballman > > Should we entirely opt-out of this suggestion on `.S

[PATCH] D125624: [gold] Remove an external dependency to GNU binutils' header file

pcc added inline comments. Comment at: llvm/tools/gold/gold-plugin.cpp:44-52 // FIXME: remove this declaration when we stop maintaining Ubuntu Quantal and // Precise and Debian Wheezy (binutils 2.23 is required) #define LDPO_PIE 3 #define LDPT_GET_SYMBOLS_V3 28 // FIXME:

[PATCH] D125683: [runtimes] Replace LIBCXX_ENABLE_STATIC_ABI_LIBRARY & friends by a new LIBCXX_CXX_ABI choice

mstorsjo added a comment. In D125683#3516883 , @ldionne wrote: > In D125683#3515675 , @mstorsjo > wrote: > >> It looks like this patch still lacks compatibility handling for all external >> users that are settin

[PATCH] D125624: [gold] Remove an external dependency to GNU binutils' header file

MaskRay added a comment. I haven't checked but for `ninja check-llvm-tools-gold`, we still hope that the tests are disabled if the system does not provide gold. There may need a toggle for the tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[PATCH] D124726: Suggest typoed directives in preprocessor conditionals

ken-matsui added a comment. @nathanchance Oops, thank you for your comment! I would like to work on a hotfix patch for this issue. @aaron.ballman Should we entirely opt-out of this suggestion on `.S` files? I think there are other approaches here, such as decreasing the max edit distance to av

[PATCH] D125683: [runtimes] Replace LIBCXX_ENABLE_STATIC_ABI_LIBRARY & friends by a new LIBCXX_CXX_ABI choice

ldionne added a comment. In D125683#3515675 , @mstorsjo wrote: > It looks like this patch still lacks compatibility handling for all external > users that are setting this option, which need to be able to set the option > in this way at least until afte

[PATCH] D125675: Optimise findRefs for XRefs and docHighlights

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2fb6ece2ca83: Optimise findRefs for XRefs and docHighlights (authored by usaxena95). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[clang-tools-extra] 2fb6ece - Optimise findRefs for XRefs and docHighlights

Author: Utkarsh Saxena Date: 2022-05-16T21:07:14+02:00 New Revision: 2fb6ece2ca83d33909c628d682f821d05aa67a97 URL: https://github.com/llvm/llvm-project/commit/2fb6ece2ca83d33909c628d682f821d05aa67a97 DIFF: https://github.com/llvm/llvm-project/commit/2fb6ece2ca83d33909c628d682f821d05aa67a97.diff

[PATCH] D125675: Optimise findRefs for XRefs and docHighlights

usaxena95 updated this revision to Diff 429807. usaxena95 marked 4 inline comments as done. usaxena95 added a comment. Addressed comments and added performance measurements. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125675/new/ https://reviews.

[PATCH] D123534: [dwarf] Emit a DIGlobalVariable for constant strings.

hctim updated this revision to Diff 429799. hctim added a comment. Touch ups from comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123534/new/ https://reviews.llvm.org/D123534 Files: clang/lib/CodeGen/CGDebugInfo.cpp clang/lib/CodeGen/C

[PATCH] D125682: Add documentHighlight in clangd check for performance measurements.

This revision was automatically updated to reflect the committed changes. Closed by commit rG5edd7665fd16: Add documentHighlight in clangd check for performance measurements. (authored by usaxena95). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1256

[clang-tools-extra] 5edd766 - Add documentHighlight in clangd check for performance measurements.

Author: Utkarsh Saxena Date: 2022-05-16T20:22:36+02:00 New Revision: 5edd7665fd163555f1afe2187907eba95d24c11b URL: https://github.com/llvm/llvm-project/commit/5edd7665fd163555f1afe2187907eba95d24c11b DIFF: https://github.com/llvm/llvm-project/commit/5edd7665fd163555f1afe2187907eba95d24c11b.diff

[PATCH] D101471: [clang-tidy] Add proper emplace checks to modernize-use-emplace

kuhar resigned from this revision. kuhar added inline comments. Herald added a subscriber: carlosgalvezp. Herald added a project: All. Comment at: clang-tools-extra/clang-tidy/modernize/UseEmplaceCheck.cpp:44 + // FullNameTrimmed matches any of the given Names. + const StringRe

[PATCH] D123538: [symbolizer] Parse DW_TAG_variable DIs to show line info for globals

hctim added inline comments. Comment at: llvm/lib/DebugInfo/DWARF/DWARFUnit.cpp:769-783 +DataExtractor Data(Location.Expr, /*IsLittleEndian=*/true, 8); +uint64_t DataOffset = 0; +uint8_t Operation = Data.getU8(&DataOffset); +if (Operation == dwarf::DW_OP_addr) { +

[PATCH] D123538: [symbolizer] Parse DW_TAG_variable DIs to show line info for globals

hctim updated this revision to Diff 429783. hctim marked 2 inline comments as done. hctim added a comment. Patch update. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123538/new/ https://reviews.llvm.org/D123538 Files: llvm/include/llvm/DebugInf

[PATCH] D125711: [concepts] Implement dcl.decl.general p4: No constraints on non-template funcs

erichkeane created this revision. erichkeane added a reviewer: clang-language-wg. Herald added a project: All. erichkeane requested review of this revision. The standard says: The optional requires-clause ([temp.pre]) in an init-declarator or member-declarator shall be present only if the dec

[clang] 0b69b83 - [Driver] Change "zlib not installed" diagnostic to "zlib not enabled"

Author: Fangrui Song Date: 2022-05-16T10:42:44-07:00 New Revision: 0b69b8384d9b92898ec29f78a2364bec2277e516 URL: https://github.com/llvm/llvm-project/commit/0b69b8384d9b92898ec29f78a2364bec2277e516 DIFF: https://github.com/llvm/llvm-project/commit/0b69b8384d9b92898ec29f78a2364bec2277e516.diff

[PATCH] D125709: [analyzer][Casting] Support isa, cast, dyn_cast of SVals

bzcheeseman added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/SVals.h:102 template T castAs() const { assert(T::classof(*this)); Is it worth refactoring this and getAs to use `cast` and `dyn_cast` as appropriate

[PATCH] D125709: [analyzer][Casting] Support isa, cast, dyn_cast of SVals

steakhal created this revision. steakhal added reviewers: NoQ, martong, Szelethus, balazske, ASDenysPetrov, bzcheeseman. Herald added subscribers: manas, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun. Herald added a project: All. steakhal requeste

[PATCH] D125708: [analyzer][NFC] Remove unused default SVal constructors

steakhal created this revision. steakhal added reviewers: NoQ, martong, Szelethus, balazske, ASDenysPetrov, bzcheeseman. Herald added subscribers: manas, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun. Herald added a project: All. steakhal requeste

[PATCH] D125707: [analyzer][NFC] Remove unused friend SVal declarations

steakhal created this revision. steakhal added reviewers: NoQ, martong, Szelethus, balazske, ASDenysPetrov, bzcheeseman. Herald added subscribers: manas, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun. Herald added a project: All. steakhal requeste

[PATCH] D125706: [analyzer][NFC] Use idiomatic classof instead of isKind

steakhal created this revision. steakhal added reviewers: NoQ, martong, Szelethus, balazske, ASDenysPetrov, bzcheeseman. Herald added subscribers: manas, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun. Herald added a project: All. steakhal requeste

[clang] babbd96 - [docs] Re-generate ClangCommandLineReference.rst

Author: Fangrui Song Date: 2022-05-16T10:34:01-07:00 New Revision: babbd96f23d5e21712223ece8f6318e6bc93269b URL: https://github.com/llvm/llvm-project/commit/babbd96f23d5e21712223ece8f6318e6bc93269b DIFF: https://github.com/llvm/llvm-project/commit/babbd96f23d5e21712223ece8f6318e6bc93269b.diff

[PATCH] D125487: [Tooling/DependencyScanning] Refactor dependency scanning to produce pre-lexed preprocessor directive tokens, instead of minimized sources

akyrtzi updated this revision to Diff 429766. akyrtzi added a comment. Make sure to enable line comments for dependency directive lexing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125487/new/ https://reviews.llvm.org/D125487 Files: clang/inc

[PATCH] D125622: [clang-tidy] Reject invalid enum initializers in C files

aaron.ballman added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/modernize-macro-to-enum.c:9 + +// C forbids comma operator in initializing expressions. +#define BAD_OP 1, 2 LegalizeAdulthood wrote: > aaron.ballman wrote: > > It's also

[PATCH] D125705: [OpenMP] Don't build the offloading driver without a source input

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125705/new/ https://reviews.llvm.org/D125705 ___

[PATCH] D125705: [OpenMP] Don't build the offloading driver without a source input

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, tianshilei1992, wsmoses. Herald added subscribers: guansong, yaxunl. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1, MaskRay. Herald added a project: clang. T

[PATCH] D124726: Suggest typoed directives in preprocessor conditionals

aaron.ballman added a comment. In D124726#3516346 , @nathanchance wrote: > I see an instance of this warning in the Linux kernel due to the "Now, for > unknown directives inside a skipped conditional block, we diagnose the > unknown directive as a warn

[PATCH] D125555: [clang] Add __has_target_feature

tra added a comment. Oops. forgot to hit 'submit' last week, so there's some overlap with Aaron's question. Comment at: clang/docs/LanguageExtensions.rst:275 + // On amdgcn target + #if __has_target_feature("s-memtime-inst") +x = __builtin_amdgcn_s_memtime(); ---

[PATCH] D125622: [clang-tidy] Reject invalid enum initializers in C files

LegalizeAdulthood added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/modernize-macro-to-enum.c:9 + +// C forbids comma operator in initializing expressions. +#define BAD_OP 1, 2 aaron.ballman wrote: > It's also forbidden in C++. C++ ju

[PATCH] D124726: Suggest typoed directives in preprocessor conditionals

nathanchance added subscribers: nickdesaulniers, nathanchance. nathanchance added a comment. I see an instance of this warning in the Linux kernel due to the "Now, for unknown directives inside a skipped conditional block, we diagnose the unknown directive as a warning if it is sufficiently simi

[PATCH] D124613: In MSVC compatibility mode, friend function declarations behave as function declarations

rnk added a comment. I haven't given any input yet because I haven't yet seen a reduced example of the conforming code that is broken by this change. If someone can put together a small godbolt example that shows the issue affecting ADL, I'd appreciate it. I don't fully understand the code patt

[PATCH] D124918: [clang-tidy] Add a new check for non-trivial unused variables.

veluca93 added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/performance-unused-no-side-effect.rst:93 + { + "std::string": ["swap"], + "absl::int128": [], LegalizeAdulthood wrote: > Since `std::string` is just a type alias, sh

[PATCH] D124918: [clang-tidy] Add a new check for non-trivial unused variables.

veluca93 updated this revision to Diff 429745. veluca93 marked 6 inline comments as done. veluca93 added a comment. Switch from bitmasks to arrays. Add more tests & update doc. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124918/new/ https://revie

[PATCH] D123534: [dwarf] Emit a DIGlobalVariable for constant strings.

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. Looks good to me. I generally agree with Adrian's suggestions. Comment at: llvm/test/DebugInfo/COFF/global-no-strings.ll:1 +; RUN: llc < %s | FileCheck %s +; RUN: llc < %s -filetyp

[PATCH] D125400: [clang][Analyzer] Add errno state to standard functions modeling.

balazske added a comment. @martong Do you mean that a "describe" function is needed for the return value constraint of the function and for the errno constraint type? Then a note tag can contain what the function is assumed to return on success and what is allowed (or not) to do with `errno`. F

[PATCH] D113743: [RFC][clang][DebugInfo] Allow function-local statics and types to be scoped within a lexical block

krisb abandoned this revision. krisb added a comment. Herald added a project: All. Split on two: D125694 and D125695 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113743/new/ h

[PATCH] D125695: [clang][DebugInfo] Allow function-local type-like entities to be scoped within a lexical block (5/5)

krisb created this revision. krisb added reviewers: dblaikie, aprantl, probinson. Herald added a project: All. krisb requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is a part from D113743 split to mak

[PATCH] D91157: [AArch64] Out-of-line atomics (-moutline-atomics) implementation.

efriedma added a comment. https://github.com/llvm/llvm-project/issues/29472 was never fixed; whatever issues exist with -moutline-atomics also exist with -mno-outline-atomics. (I don't think anyone has run into any practical issues with this, so it hasn't been a priority for anyone.) Reposit

[PATCH] D115232: [clangd] Indexing of standard library

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. sorry for the long turn around here, LGTM. let's ship it! Comment at: clang-tools-extra/clangd/index/StdLib.cpp:233 + // Sadly we can't use IndexOpts.FileFilter to restr

[PATCH] D125694: [clang][DebugInfo] Allow function-local statics to be scoped within a lexical block (4/5)

krisb created this revision. krisb added reviewers: dblaikie, aprantl, probinson. Herald added a project: All. krisb requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is a part from D113743 split to mak

[PATCH] D125693: [DebugInfo][WIP] Support types, imports and static locals declared in a lexical block (3/5)

krisb added a comment. Mark this and D125691 as WIP since I'm still testing the approach on various combinations of debug info and optimization options (O0, O3 , thinlto, split-dwarf, split-dwarf-inlining, gline-tabl

[PATCH] D91157: [AArch64] Out-of-line atomics (-moutline-atomics) implementation.

sebpop added a comment. Herald added a subscriber: MaskRay. Herald added a project: All. Hi Pavel, We need to handle one more case for __sync_* builtins, please see testcase and patches applied to GCC: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105162 Repository: rG LLVM Github Monorepo C

[PATCH] D123676: [clang-format] Fix WhitespaceSensitiveMacros not being honoured when macro closing parenthesis is followed by a newline.

krasimir added a comment. It looks like this regressed the following example by adding an unwanted level of indentation to the `#elif B` branch: % ./clang-format --version clang-format version 15.0.0 (https://github.com/llvm/llvm-project.git 50cd52d9357224cce66a9e00c9a0417c658a5655) % cat

[PATCH] D125555: [clang] Add __has_target_feature

yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: clang/docs/LanguageExtensions.rst:275 + // On amdgcn target + #if __has_target_feature("s-memtime-inst") +x = __builtin_amdgcn_s_memtime(); yaxunl wrote: > aaron.ballman wrot

  1   2   >