iliya-diyachkov added a comment. I'm not an expert in clang, but overall the patch looks good to me.
================ Comment at: clang/docs/UsersManual.rst:3640 +Clang also supports integrated generation of SPIR-V without use of ``llvm-spirv`` +tool as an exerimental feature when ``-fintegrated-objemitter`` flag is passed in +the command line. ---------------- Please fix typo in "exerimental". ================ Comment at: clang/include/clang/Driver/ToolChain.h:392 + + /// IsIntegratedBackendSupported - Does this tool chain supports + /// -fintegrated-objemitter. ---------------- Probably change "supports" to "support". ================ Comment at: clang/include/clang/Driver/ToolChain.h:396 + + /// IsNonIntegratedBackendSupported - Does this tool chain supports + /// -fno-integrated-objemitter. ---------------- The same issue. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125679/new/ https://reviews.llvm.org/D125679 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
