[PATCH] D98254: Fix typo in two files in Clang

2021-08-30 Thread Shivam Gupta via Phabricator via cfe-commits
xgupta accepted this revision. xgupta added a comment. This revision is now accepted and ready to land. Thanks, LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98254/new/ https://reviews.llvm.org/D98254

[PATCH] D102836: [clang] Fix Typo in AST Matcher Reference

2021-08-30 Thread Shivam Gupta via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG4a6d8a11f89b: [clang] Fix Typo in AST Matcher Reference (authored by xgupta). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102836/new/ https://reviews.llvm

[clang] 4a6d8a1 - [clang] Fix Typo in AST Matcher Reference

2021-08-30 Thread Shivam Gupta via cfe-commits
Author: Shivam Gupta Date: 2021-08-31T12:21:47+05:30 New Revision: 4a6d8a11f89b9eae984e1b9608c1c010dc6a037b URL: https://github.com/llvm/llvm-project/commit/4a6d8a11f89b9eae984e1b9608c1c010dc6a037b DIFF: https://github.com/llvm/llvm-project/commit/4a6d8a11f89b9eae984e1b9608c1c010dc6a037b.diff

[PATCH] D102836: [clang] Fix Typo in AST Matcher Reference

2021-08-30 Thread Shivam Gupta via Phabricator via cfe-commits
xgupta accepted this revision. xgupta added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102836/new/ https://reviews.llvm.org/D102836 ___

[PATCH] D91311: Add new 'preferred_name' attribute.

2021-08-30 Thread David Blaikie via Phabricator via cfe-commits
dblaikie added a comment. @rsmith - would it make sense to disable preferred names use when `PrintingPolicy::PrintCanonicalTypes` is used? It's used in `CGDebugInfo`, but also in `Sema::findFailedBooleanCondition` - so maybe we need another `PrintingPolicy` flag for this so `CGDebugInfo` can us

[PATCH] D108886: Add RISC-V sifive-s51 cpu

2021-08-30 Thread Alexander Pivovarov via Phabricator via cfe-commits
apivovarov updated this revision to Diff 369635. apivovarov added a comment. update the patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108886/new/ https://reviews.llvm.org/D108886 Files: clang/test/Driver/riscv-cpus.c llvm/include/llvm/Su

[PATCH] D101935: [clang] Search runtimes build tree for openmp runtime

2021-08-30 Thread Jon Chesterfield via Phabricator via cfe-commits
JonChesterfield planned changes to this revision. JonChesterfield added a comment. Yeah, we probably can't leave the installed program with a search path only used for testing. I'm planning to revisit this to use libomptarget_amdgcn_bc_path instead of LIBRARY_PATH for testing, then drop the LIB

[clang] 4f3a92c - DebugInfo: Refactor/deduplicate various template argument list emission

2021-08-30 Thread David Blaikie via cfe-commits
Author: David Blaikie Date: 2021-08-30T22:39:46-07:00 New Revision: 4f3a92ca0aff115ee17649610c46d8705e550a03 URL: https://github.com/llvm/llvm-project/commit/4f3a92ca0aff115ee17649610c46d8705e550a03 DIFF: https://github.com/llvm/llvm-project/commit/4f3a92ca0aff115ee17649610c46d8705e550a03.diff

[PATCH] D108085: Use installed llvm-lit.py instead of lit.py PR-51072

2021-08-30 Thread Tom Stellard via Phabricator via cfe-commits
tstellar added inline comments. Comment at: clang/test/utils/update_cc_test_checks/lit.local.cfg:24 +# Windows: llvm-lit.py, Linux: llvm-lit +llvm_lit = glob.glob(os.path.join(config.llvm_tools_dir, 'llvm-lit*'))[0] +lit = config.llvm_external_lit if config.llvm_external_lit else

[PATCH] D108818: [clang] Add a -canonical-prefixes option

2021-08-30 Thread Reid Kleckner via Phabricator via cfe-commits
rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm +@jansvoboda11 for lack of a better alternative owner for Driver patches. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108818/new/ https://reviews.llvm.org/D108818 _

[PATCH] D105168: [RISCV] Unify the arch string parsing logic to RISCVISAInfo.

2021-08-30 Thread Jim Lin via Phabricator via cfe-commits
Jim added inline comments. Comment at: llvm/lib/Support/RISCVISAInfo.cpp:387 +ExtensionInfoIterator->Version.Minor); + if (ExtName == "e") +HasE = true; Does this need to check it is invalid if XLen is 64? ==

[PATCH] D101960: [openmp] Drop requirement on library path environment variables

2021-08-30 Thread Ye Luo via Phabricator via cfe-commits
ye-luo added a comment. In D101960#2961133 , @jdoerfert wrote: > There are 3 problems here (ignoring our test setup which should be discussed > separately): > > 1. make sure clang finds libomp.so > 2. make sure libomp.so (or clang?) finds libomptarget.so

[PATCH] D101935: [clang] Search runtimes build tree for openmp runtime

2021-08-30 Thread Ye Luo via Phabricator via cfe-commits
ye-luo added a comment. It seems that this path is baked in to clang executable even after make install. I'm not convinced this is the right direction. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101935/new/ https://reviews.llvm.org/D101935 ___

[PATCH] D108958: [OpenMP] Make CUDA math library functions SPMD amenable

2021-08-30 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108958/new/ https://reviews.llvm.org/D108958 ___

[PATCH] D108905: [ItaniumCXXABI] Make __cxa_end_catch calls unconditionally nounwind

2021-08-30 Thread John McCall via Phabricator via cfe-commits
rjmccall added a comment. Thanks, Richard. Fangrui, I think we can't do anything on this patch without a CWG decision about the right semantics, so this will have to sit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108905/new/ https://reviews.l

[PATCH] D108881: [clang][driver] Honor the last -flto(=.*)? argument

2021-08-30 Thread Steven Wu via Phabricator via cfe-commits
steven_wu added a comment. In D108881#2973719 , @mnadeem wrote: > In D108881#2973516 , @steven_wu > wrote: > >> I will do a cleanup of `parseLTOMode` function since we don't need a >> `OptPos` parameter anymore.

[PATCH] D107290: [PoC][RISCV] Add support for the vscale_range attribute

2021-08-30 Thread Craig Topper via Phabricator via cfe-commits
craig.topper added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVTargetMachine.cpp:101 + } else { +RVVBitsMin = RVVVectorBitsMinOpt; +RVVBitsMax = RVVVectorBitsMaxOpt; If clang always emits the attribute, are these options effectively dead for

[PATCH] D108881: [clang][driver] Honor the last -flto(=.*)? argument

2021-08-30 Thread Usman Nadeem via Phabricator via cfe-commits
mnadeem added a comment. In D108881#2973516 , @steven_wu wrote: > I will do a cleanup of `parseLTOMode` function since we don't need a `OptPos` > parameter anymore. There are few minor places references `OPT_flto` or > `OPT_foffload_lto` can be cleaned

[PATCH] D106994: [modules] Fix miscompilation when using two RecordDecl definitions with the same name.

2021-08-30 Thread Volodymyr Sapsai via Phabricator via cfe-commits
vsapsai added a comment. Thanks for the review! Comment at: clang/lib/Serialization/ASTReaderDecl.cpp:3328-3331 // If there's no definition yet, then DC's definition is added by an update // record, but we've not yet loaded that update record. In this case, we //

[PATCH] D106994: [modules] Fix miscompilation when using two RecordDecl definitions with the same name.

2021-08-30 Thread Volodymyr Sapsai via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG93764ff6e200: [modules] Fix miscompilation when using two RecordDecl definitions with the… (authored by vsapsai). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[clang] 93764ff - [modules] Fix miscompilation when using two RecordDecl definitions with the same name.

2021-08-30 Thread Volodymyr Sapsai via cfe-commits
Author: Volodymyr Sapsai Date: 2021-08-30T17:51:38-07:00 New Revision: 93764ff6e2005b92057cffa9b3866307e2de260f URL: https://github.com/llvm/llvm-project/commit/93764ff6e2005b92057cffa9b3866307e2de260f DIFF: https://github.com/llvm/llvm-project/commit/93764ff6e2005b92057cffa9b3866307e2de260f.di

[PATCH] D107764: [OpenMP][OpenMPIRBuilder] Implement loop unrolling.

2021-08-30 Thread Michael Kruse via Phabricator via cfe-commits
Meinersbur added inline comments. Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:2055 +/// Attach loop metadata \p Properties to the loop described by \p Loop. If the +/// loop already has metadata, the loop properties are appended. +static void addLoopMetadata(CanonicalLo

[PATCH] D108045: [clangd] Fix clangd crash when including a header

2021-08-30 Thread Queen Dela Cruz via Phabricator via cfe-commits
qdelacru updated this revision to Diff 369581. qdelacru added a comment. Create macro directive only preamble patch for code completion CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108045/new/ https://reviews.llvm.org/D108045 Files: clang-tools-extra/clangd/CodeComplete.cpp clang-

[PATCH] D105671: [Intrinsics][ObjC] Mark objc_retain and friends as thisreturn.

2021-08-30 Thread Jon Roelofs via Phabricator via cfe-commits
jroelofs updated this revision to Diff 369584. jroelofs added a comment. Herald added a subscriber: dexonsmith. Rebased. Also, turns out that `stripPointerCasts()` can see through the `thisreturn` attribute, which defeats a self retain optimization, breaking one of the clang tests. I tweaked a

[PATCH] D108881: [clang][driver] Honor the last -flto(=.*)? argument

2021-08-30 Thread Teresa Johnson via Phabricator via cfe-commits
tejohnson added a comment. In D108881#2973516 , @steven_wu wrote: > I will do a cleanup of `parseLTOMode` function since we don't need a `OptPos` > parameter anymore. There are few minor places references `OPT_flto` or > `OPT_foffload_lto` can be cleane

[PATCH] D105937: [OpenMP] Encode `omp [...] assume[...]` assumptions with `omp[x]` prefix

2021-08-30 Thread Joseph Huber via Phabricator via cfe-commits
jhuber6 accepted this revision. jhuber6 added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105937/new/ https://reviews.llvm.org/D105937 _

[PATCH] D108958: [OpenMP] Make CUDA math library functions SPMD amenable

2021-08-30 Thread Joseph Huber via Phabricator via cfe-commits
jhuber6 created this revision. jhuber6 added a reviewer: jdoerfert. Herald added subscribers: guansong, yaxunl. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. This patch adds the SPMD amenable assumption to the CUDA math l

[PATCH] D107049: [clang-repl] Re-implement clang-interpreter as a test case.

2021-08-30 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith added inline comments. Comment at: clang/unittests/Interpreter/ExceptionTests/InterpreterExceptionTest.cpp:73-76 +#ifdef _MSC_VER +// Tell the windows linker to export the type_info symbol required by exceptions +#pragma comment(linker, "/export:??_7type_info@@6B@") +#en

[PATCH] D108881: [clang][driver] Honor the last -flto(=.*)? argument

2021-08-30 Thread Steven Wu via Phabricator via cfe-commits
steven_wu added a comment. I will do a cleanup of `parseLTOMode` function since we don't need a `OptPos` parameter anymore. There are few minor places references `OPT_flto` or `OPT_foffload_lto` can be cleaned up too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[PATCH] D108905: [ItaniumCXXABI] Make __cxa_end_catch calls unconditionally nounwind

2021-08-30 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith added a comment. I've forwarded the question here onto CWG, with Arthur's example and the suggestion that maybe we shouldn't allow throwing an exception with a non-noexcept destructor. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108905/ne

[PATCH] D105759: [WIP] Implement P2361 Unevaluated string literals

2021-08-30 Thread Corentin Jabot via Phabricator via cfe-commits
cor3ntin added a comment. At @aaron.ballman request, here are some data collection trying to assert the amount of breakage On a corpus of 78M lines of C++ code corresponding to all the packages in vcpkg - Number of strings with encoding prefix in `_Pragma`: 3/3383 (all in test suits) - Number

[PATCH] D108881: [clang][driver] Honor the last -flto(=.*)? argument

2021-08-30 Thread Usman Nadeem via Phabricator via cfe-commits
mnadeem updated this revision to Diff 369558. mnadeem retitled this revision from "[clang][driver] Honor the last -flto= flag even if an earlier -flto is present" to "[clang][driver] Honor the last -flto(=.*)? argument". mnadeem edited the summary of this revision. mnadeem added a comment. Herald

[PATCH] D104386: [PowerPC][Builtins] Added a number of builtins for compatibility with XL.

2021-08-30 Thread Nemanja Ivanovic via Phabricator via cfe-commits
nemanjai added a comment. In D104386#2973245 , @dim wrote: > Note that this unexpectedly broke FreeBSD's powerpc64 builds, as we've long > used the following in our `lib/libc/powerpc64/string/bcopy.S`: > > #ifndef FN_NAME > #ifdef MEMMOVE > #define

[PATCH] D101759: [PowerPC] Scalar IBM MASS library conversion pass

2021-08-30 Thread Eli Friedman via Phabricator via cfe-commits
efriedma added a comment. > I agree. I think the problem is that this patch is trying to decide on a > global lowering strategy for llvm.* math intrinsics in > llvm/lib/Target/PowerPC/PPCISelLowering.cpp but such global decision making > does not go well with finer granularity of fast-math flag

[PATCH] D106191: [clang] Option control afn flag

2021-08-30 Thread Bardia Mahjour via Phabricator via cfe-commits
bmahjour added inline comments. Comment at: clang/include/clang/Driver/Options.td:1732-1733 NegFlag>; -def fapprox_func : Flag<["-"], "fapprox-func">, Group, Flags<[CC1Option, NoDriverOption]>, - MarshallingInfoFlag>, ImpliedByAnyOf<[menable_unsafe_fp_math.KeyPath]>; defm

[PATCH] D101759: [PowerPC] Scalar IBM MASS library conversion pass

2021-08-30 Thread Bardia Mahjour via Phabricator via cfe-commits
bmahjour added a comment. In D101759#2971567 , @efriedma wrote: > errno handling for math library functions is a mess. Currently, we don't > model it properly; we just mark the calls "readnone" and hope for the best. > If you don't want to fix that, j

[PATCH] D104386: [PowerPC][Builtins] Added a number of builtins for compatibility with XL.

2021-08-30 Thread Dimitry Andric via Phabricator via cfe-commits
dim added subscribers: emaste, dim. dim added a comment. Note that this unexpectedly broke FreeBSD's powerpc64 builds, as we've long used the following in our `lib/libc/powerpc64/string/bcopy.S`: #ifndef FN_NAME #ifdef MEMMOVE #define FN_NAME __memmove WEAK_REFERE

[PATCH] D108881: [clang][driver] Honor the last -flto= flag even if an earlier -flto is present

2021-08-30 Thread Steven Wu via Phabricator via cfe-commits
steven_wu added a comment. I agree that it might be good to change to the behavior that last arg wins but it might be simpler to set `-flto` to be an alias of `-flto=full`: diff --git a/clang/include/clang/Driver/Options.td b/clang/include/clang/Driver/Options.td index 1a3d1dcceec7..a796fb7

[PATCH] D108905: [ItaniumCXXABI] Make __cxa_end_catch calls unconditionally nounwind

2021-08-30 Thread John McCall via Phabricator via cfe-commits
rjmccall added a comment. In D108905#2973172 , @modimo wrote: > In D108905#2973099 , @rjmccall > wrote: > >> Yeah, I think this is the most natural interpretation of the current >> standard. But that would be a

[PATCH] D108302: [PowerPC] Fixed the crash due to early if conversion with fixed CR fields.

2021-08-30 Thread Victor Huang via Phabricator via cfe-commits
NeHuang updated this revision to Diff 369531. NeHuang added a comment. Address review comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108302/new/ https://reviews.llvm.org/D108302 Files: llvm/lib/Target/PowerPC/PPCInstrInfo.cpp llvm/test

[PATCH] D108905: [ItaniumCXXABI] Make __cxa_end_catch calls unconditionally nounwind

2021-08-30 Thread Di Mo via Phabricator via cfe-commits
modimo added a comment. In D108905#2973099 , @rjmccall wrote: > Yeah, I think this is the most natural interpretation of the current > standard. But that would be a very unfortunate rule, because people who > write `catch (...) {}` do reasonably expect

[PATCH] D108905: [ItaniumCXXABI] Make __cxa_end_catch calls unconditionally nounwind

2021-08-30 Thread John McCall via Phabricator via cfe-commits
rjmccall added a comment. In D108905#2973066 , @modimo wrote: > In D108905#2971861 , @rjmccall > wrote: > >> I'm not really sure what the standard expects to happen if an exception >> destructor throws. The sta

[PATCH] D108905: [ItaniumCXXABI] Make __cxa_end_catch calls unconditionally nounwind

2021-08-30 Thread Di Mo via Phabricator via cfe-commits
modimo added a comment. In D108905#2971861 , @rjmccall wrote: > I'm not really sure what the standard expects to happen if an exception > destructor throws. The standard tells us when the destruction happens — the > latest point it can — but that claus

[PATCH] D106994: [modules] Fix miscompilation when using two RecordDecl definitions with the same name.

2021-08-30 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/lib/Serialization/ASTReaderDecl.cpp:3328-3331 // If there's no definition yet, then DC's definition is added by an update // record, but we'v

[PATCH] D107024: [DIBuilder] Do not replace empty enum types

2021-08-30 Thread Kyungwoo Lee via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG47b239eb5a17: [DIBuilder] Do not replace empty enum types (authored by ellis, committed by kyulee). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107024/new/

[clang] 47b239e - [DIBuilder] Do not replace empty enum types

2021-08-30 Thread Kyungwoo Lee via cfe-commits
Author: Ellis Hoag Date: 2021-08-30T12:33:03-07:00 New Revision: 47b239eb5a17065d13c317600c46e56ffe2d6c75 URL: https://github.com/llvm/llvm-project/commit/47b239eb5a17065d13c317600c46e56ffe2d6c75 DIFF: https://github.com/llvm/llvm-project/commit/47b239eb5a17065d13c317600c46e56ffe2d6c75.diff LO

[PATCH] D106876: Remove non-affecting module maps from PCM files.

2021-08-30 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith added a comment. This should have a testcase. I would imagine you can test this by constructing a situation where you build a module twice with different sets of module map files being considered and checking that you get bit-for-bit identical outputs. (For example: set up a temporary ar

[PATCH] D108765: [docs] Fix documentation of clang-format BasedOnStyle type

2021-08-30 Thread Ludovic Jozeau via Phabricator via cfe-commits
FederAndInk updated this revision to Diff 369519. FederAndInk marked an inline comment as done. FederAndInk added a comment. add common plural rules, use python3 explicitly, reorder imports Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108765/new/

[PATCH] D108765: [docs] Fix documentation of clang-format BasedOnStyle type

2021-08-30 Thread Ludovic Jozeau via Phabricator via cfe-commits
FederAndInk marked 2 inline comments as done. FederAndInk added inline comments. Comment at: clang/docs/tools/dump_format_style.py:9 import re +import inspect +import subprocess HazardyKnusperkeks wrote: > I think these should be sorted. ok, it will be done ==

[PATCH] D106994: [modules] Fix miscompilation when using two RecordDecl definitions with the same name.

2021-08-30 Thread Volodymyr Sapsai via Phabricator via cfe-commits
vsapsai added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106994/new/ https://reviews.llvm.org/D106994 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D108765: [docs] Fix documentation of clang-format BasedOnStyle type

2021-08-30 Thread Ludovic Jozeau via Phabricator via cfe-commits
FederAndInk marked an inline comment as done. FederAndInk added inline comments. Comment at: clang/docs/tools/dump_format_style.py:26 +def register_plural(singular: str, plural: str): + if plural not in plurals: HazardyKnusperkeks wrote: > FederAndInk wrote: >

[PATCH] D108765: [docs] Fix documentation of clang-format BasedOnStyle type

2021-08-30 Thread Björn Schäpers via Phabricator via cfe-commits
HazardyKnusperkeks added a comment. In D108765#2972159 , @FederAndInk wrote: > And again, I don't really understand if we are allowed or not to pull in a > dependency such as pluralizer or inflect, this would be another idea My Python knowledge is very

[PATCH] D106876: Remove non-affecting module maps from PCM files.

2021-08-30 Thread Ilya Kuteev via Phabricator via cfe-commits
ilyakuteev added a comment. Hello everyone! We have very slow remote compilations without this patch. :(. I'll be very grateful for your review. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106876/new/ https://reviews.llvm.org/D106876 ___

[PATCH] D108881: [clang][driver] Honor the last -flto= flag even if an earlier -flto is present

2021-08-30 Thread Usman Nadeem via Phabricator via cfe-commits
mnadeem added a comment. Combined with the code in `else if (Triple.isAMDGPU())` since the code is identical. Removed the code to add `-flto` in favour of `-flto=full` since both are equivalent: https://clang.llvm.org/docs/CommandGuide/clang.html#cmdoption-flto CHANGES SINCE LAST ACTION http

[PATCH] D108881: [clang][driver] Honor the last -flto= flag even if an earlier -flto is present

2021-08-30 Thread Usman Nadeem via Phabricator via cfe-commits
mnadeem updated this revision to Diff 369498. mnadeem marked 3 inline comments as done. mnadeem edited the summary of this revision. mnadeem added a subscriber: apazos. mnadeem added a comment. Herald added subscribers: kerbowa, nhaehnle, jvesely. Address comments. CHANGES SINCE LAST ACTION ht

[PATCH] D108482: [Clang] Fix instantiation of OpaqueValueExprs (Bug #45964)

2021-08-30 Thread John McCall via Phabricator via cfe-commits
rjmccall added inline comments. Comment at: clang/lib/Sema/TreeTransform.h:10515-10525 + // Note that SourceExpr can be nullptr. + ExprResult SourceExpr = TransformExpr(E->getSourceExpr()); + if (SourceExpr.isInvalid()) +return ExprError(); + if (SourceExpr.get() == E->ge

[PATCH] D108905: [ItaniumCXXABI] Make __cxa_end_catch calls unconditionally nounwind

2021-08-30 Thread Arthur O'Dwyer via Phabricator via cfe-commits
Quuxplusone added a comment. > Well, I'm saying two things. First, it is not clear to me what the expected > behavior of that code is under the standard. The fact that it appears to work > in one particular implementation is not in any way conclusive; we have to > look at the specification. Ah

[PATCH] D108893: clang-tidy: introduce readability-containter-data-pointer check

2021-08-30 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. In D108893#2972651 , @Eugene.Zelenko wrote: > In D108893#2972634 , @compnerd > wrote: > >> @Eugene.Zelenko I'd like to have @aaron.ballman weigh in on the naming, and >> assuming

[PATCH] D108905: [ItaniumCXXABI] Make __cxa_end_catch calls unconditionally nounwind

2021-08-30 Thread John McCall via Phabricator via cfe-commits
rjmccall added a comment. Well, I'm saying two things. First, it is not clear to me what the expected behavior of that code is under the standard. The fact that it appears to work in one particular implementation is not in any way conclusive; we have to look at the specification. Second, I t

[PATCH] D107024: [DIBuilder] Do not replace empty enum types

2021-08-30 Thread Ellis Hoag via Phabricator via cfe-commits
ellis updated this revision to Diff 369496. ellis added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107024/new/ https://reviews.llvm.org/D107024 Files: clang/test/CodeGen/debug-info-codeview-heapallocsite.c clang/test/CodeG

[PATCH] D43002: [CodeView] Emit S_OBJNAME record

2021-08-30 Thread Daniel Paoliello via Phabricator via cfe-commits
dpaoliello added a comment. Herald added a subscriber: ormris. @rnk @aganea Ping... Just wanted to see what was happening with this change, and if there is anything I can do to help get it merged in. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D43

[PATCH] D102943: [modules] Use `HashBuilder` and `MD5` for the module hash.

2021-08-30 Thread Alexandre Rames via Phabricator via cfe-commits
arames added inline comments. Comment at: clang/include/clang/Basic/ObjCRuntime.h:486 + template + friend void addHash(llvm::HashBuilderImpl &HBuilder, + const ObjCRuntime &OCR) { I have added these in the same line as existing `hash_value

[PATCH] D102943: [modules] Use `HashBuilder` and `MD5` for the module hash.

2021-08-30 Thread Alexandre Rames via Phabricator via cfe-commits
arames updated this revision to Diff 369489. arames added a comment. Fix to native endianness. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102943/new/ https://reviews.llvm.org/D102943 Files: clang/include/clang/Basic/ObjCRuntime.h clang/incl

[PATCH] D108893: clang-tidy: introduce readability-containter-data-pointer check

2021-08-30 Thread Eugene Zelenko via Phabricator via cfe-commits
Eugene.Zelenko added a comment. In D108893#2972634 , @compnerd wrote: > @Eugene.Zelenko I'd like to have @aaron.ballman weigh in on the naming, and > assuming that he's okay with `modernize.container-data-pointer`, I'll change > it to that. Sure, Aaron

[PATCH] D108893: clang-tidy: introduce readability-containter-data-pointer check

2021-08-30 Thread Saleem Abdulrasool via Phabricator via cfe-commits
compnerd added a comment. @Eugene.Zelenko I'd like to have @aaron.ballman weigh in on the naming, and assuming that he's okay with `modernize.container-data-pointer`, I'll change it to that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108893/new

[PATCH] D108424: [NFC][clang] Move multiversion resolver code generation to llvm/ subdirectory

2021-08-30 Thread Andrei Elovikov via Phabricator via cfe-commits
a.elovikov updated this revision to Diff 369485. a.elovikov added a comment. Rebase + ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108424/new/ https://reviews.llvm.org/D108424 Files: clang/lib/CodeGen/CGBuiltin.cpp clang/lib/CodeGen/Code

[clang] 0e42ec1 - DebugInfo: Correct printing empty template parameter packs

2021-08-30 Thread David Blaikie via cfe-commits
Author: David Blaikie Date: 2021-08-30T10:20:12-07:00 New Revision: 0e42ec1add336e7fbf6cc1f82f663cabe48bf55e URL: https://github.com/llvm/llvm-project/commit/0e42ec1add336e7fbf6cc1f82f663cabe48bf55e DIFF: https://github.com/llvm/llvm-project/commit/0e42ec1add336e7fbf6cc1f82f663cabe48bf55e.diff

[PATCH] D108905: [ItaniumCXXABI] Make __cxa_end_catch calls unconditionally nounwind

2021-08-30 Thread Arthur O'Dwyer via Phabricator via cfe-commits
Quuxplusone added a comment. Peanut gallery says: Does this godbolt demonstrate the situation where "destroying an exception can throw an exception"? https://godbolt.org/z/Ghjz53rrj You're not proposing to change the behavior of this program, are you? (If you're proposing to change it: I don't th

[PATCH] D108423: [NFC][clang] Move IR-independent parts of target MV support to X86TargetParser.cpp

2021-08-30 Thread Andrei Elovikov via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1724a164378f: [NFC][clang] Move IR-independent parts of target MV support to X86TargetParser. (authored by a.elovikov). Changed prior to commit: h

[clang] 1724a16 - [NFC][clang] Move IR-independent parts of target MV support to X86TargetParser.cpp

2021-08-30 Thread Andrei Elovikov via cfe-commits
Author: Andrei Elovikov Date: 2021-08-30T09:48:48-07:00 New Revision: 1724a164378f1fb5210771680eb577ddf13c5a47 URL: https://github.com/llvm/llvm-project/commit/1724a164378f1fb5210771680eb577ddf13c5a47 DIFF: https://github.com/llvm/llvm-project/commit/1724a164378f1fb5210771680eb577ddf13c5a47.dif

[PATCH] D108905: [ItaniumCXXABI] Make __cxa_end_catch calls unconditionally nounwind

2021-08-30 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay updated this revision to Diff 369467. MaskRay retitled this revision from "[ItaniumCXXABI] Set nounwind on __cxa_begin_catch/__cxa_end_catch" to "[ItaniumCXXABI] Make __cxa_end_catch calls unconditionally nounwind". MaskRay edited the summary of this revision. MaskRay added a comment. Her

[PATCH] D108765: [docs] Fix documentation of clang-format BasedOnStyle type

2021-08-30 Thread Ludovic Jozeau via Phabricator via cfe-commits
FederAndInk added inline comments. Comment at: clang/docs/tools/dump_format_style.py:26 +def register_plural(singular: str, plural: str): + if plural not in plurals: MyDeveloperDay wrote: > This failed for me with invalid syntax Oh, ok, sorry, I might be using

[PATCH] D108765: [docs] Fix documentation of clang-format BasedOnStyle type

2021-08-30 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay added inline comments. Comment at: clang/docs/tools/dump_format_style.py:26 +def register_plural(singular: str, plural: str): + if plural not in plurals: This failed for me with invalid syntax Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D108886: Add RISC-V sifive-s51 cpu

2021-08-30 Thread Craig Topper via Phabricator via cfe-commits
craig.topper added a comment. Please upload patches with full context. Using -U99 as documented here https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108886/new/ htt

[PATCH] D108893: clang-tidy: introduce readability-containter-data-pointer check

2021-08-30 Thread Saleem Abdulrasool via Phabricator via cfe-commits
compnerd updated this revision to Diff 369453. compnerd marked 2 inline comments as done. compnerd added a comment. Update release notes to incorporate feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108893/new/ https://reviews.llvm.org/D10

[PATCH] D108893: clang-tidy: introduce readability-containter-data-pointer check

2021-08-30 Thread Saleem Abdulrasool via Phabricator via cfe-commits
compnerd marked 2 inline comments as done. compnerd added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:87 + + Finds cases where code could use ``data`` rather than the address of an element. + Eugene.Zelenko wrote: > It'll be good idea t

[PATCH] D108905: [ItaniumCXXABI] Set nounwind on __cxa_begin_catch/__cxa_end_catch

2021-08-30 Thread Wenlei He via Phabricator via cfe-commits
wenlei added subscribers: modimo, wenlei. wenlei added a comment. +@modimo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108905/new/ https://reviews.llvm.org/D108905 ___ cfe-commits mailing list cfe-comm

[PATCH] D108919: [clan-repl] Install clang-repl

2021-08-30 Thread Raphael Isemann via Phabricator via cfe-commits
teemperor added a comment. This is essentially what D106813 was supposed to do, so this is also LGTM. You probably want to file a bugreport for @tstellar to cherry-pick this to the release. The biggest impact from this seems to be that it increases the release

[PATCH] D104285: [analyzer][AST] Retrieve value by direct index from list initialization of constant array declaration.

2021-08-30 Thread Denys Petrov via Phabricator via cfe-commits
ASDenysPetrov added a comment. In D104285#2972215 , @martong wrote: > @ASDenysPetrov Denis, do you think it would make sense to handle the > non-multi-dimensional cases first? I see that you have useful patches in the > stack that depends on this change

[PATCH] D108308: Cleanup identifier parsing.

2021-08-30 Thread Corentin Jabot via Phabricator via cfe-commits
cor3ntin updated this revision to Diff 369446. cor3ntin added a comment. Move a comment to the header file per Aaron request Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108308/new/ https://reviews.llvm.org/D108308 Files: clang-tools-extra/clan

[PATCH] D104647: [analyzer] Support SVal::getType for pointer-to-member values

2021-08-30 Thread Gabor Marton via Phabricator via cfe-commits
martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. This looks good to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104647/new/ https://reviews.llvm.org/D104647 ___

[PATCH] D108702: [PowerPC][NFC] Rename P10 builtins vec_clrl, vec_clrr to vec_clr_first and vec_clr_last

2021-08-30 Thread Victor Huang via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2e5c17d19e37: [PowerPC][NFC] Rename P10 builtins vec_clrl, vec_clrr to vec_clr_first and… (authored by NeHuang). Repository: rG LLVM Github Monore

[clang] 2e5c17d - [PowerPC][NFC] Rename P10 builtins vec_clrl, vec_clrr to vec_clr_first and vec_clr_last

2021-08-30 Thread Victor Huang via cfe-commits
Author: Victor Huang Date: 2021-08-30T09:52:15-05:00 New Revision: 2e5c17d19e370c4d4f17ee89ca645113692f5407 URL: https://github.com/llvm/llvm-project/commit/2e5c17d19e370c4d4f17ee89ca645113692f5407 DIFF: https://github.com/llvm/llvm-project/commit/2e5c17d19e370c4d4f17ee89ca645113692f5407.diff

[PATCH] D108919: [clan-repl] Install clang-repl

2021-08-30 Thread Vassil Vassilev via Phabricator via cfe-commits
v.g.vassilev added a comment. @tstellar, is there a hope to get that in the llvm13 branch? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108919/new/ https://reviews.llvm.org/D108919 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

[PATCH] D108919: [clan-repl] Install clang-repl

2021-08-30 Thread Vassil Vassilev via Phabricator via cfe-commits
v.g.vassilev created this revision. v.g.vassilev added reviewers: teemperor, rsmith, tstellar. Herald added a subscriber: mgorny. v.g.vassilev requested review of this revision. This patch installs clang-repl in the install directory. https://reviews.llvm.org/D108919 Files: clang/tools/clang-

[PATCH] D108441: [clang] Fix JSON AST output when a filter is used

2021-08-30 Thread William Woodruff via Phabricator via cfe-commits
woodruffw added a comment. Gentle ping for review on this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108441/new/ https://reviews.llvm.org/D108441 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[PATCH] D108918: [clang] NFC: Extract DiagnosticOptions parsing

2021-08-30 Thread Jan Svoboda via Phabricator via cfe-commits
jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith, arphaman. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The way we parse `DiagnosticOptions` is a bit involved. `DiagnosticOptions` are

[PATCH] D108917: Define __powerpc and __PPC macros

2021-08-30 Thread Jake Egan via Phabricator via cfe-commits
Jake-Egan created this revision. Herald added subscribers: shchenz, kbarton, nemanjai. Jake-Egan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D108917 Files: clang/lib/Bas

[PATCH] D106713: Thread safety analysis: Warn when demoting locks on back edges

2021-08-30 Thread Aaron Puchert via Phabricator via cfe-commits
aaronpuchert added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106713/new/ https://reviews.llvm.org/D106713 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[PATCH] D106644: [clang][analyzer] Add standard streams to alpha.unix.Stream checker.

2021-08-30 Thread Gabor Marton via Phabricator via cfe-commits
martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp:504 + + OrigStdin = findStdStream("stdin", C); + OrigStdout = findStdStream("stdout", C); steakhal wrote: > balazske wrote: > > steakhal wrote: > > > balazske wrote:

[PATCH] D93769: [clang] Add support for option -ffp-eval-method and extend #pragma float_control similarly

2021-08-30 Thread Matvey Larionov via Phabricator via cfe-commits
matthewtff added a comment. > Did someone perhaps fix this in trunk? I don't see it on godbolt: > https://godbolt.org/z/r76rx5Evd You've missed the -target argument. It still reproduces with correct arguments: https://godbolt.org/z/1ozhjYvhf Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D93769: [clang] Add support for option -ffp-eval-method and extend #pragma float_control similarly

2021-08-30 Thread Erich Keane via Phabricator via cfe-commits
erichkeane added a comment. In D93769#2972203 , @erichkeane wrote: > In D93769#2972151 , @matthewtff > wrote: > >>> It looks like Melanie asked the questions but it wasn't resolved. >> >> Can this CL be reverted an

[PATCH] D104285: [analyzer][AST] Retrieve value by direct index from list initialization of constant array declaration.

2021-08-30 Thread Gabor Marton via Phabricator via cfe-commits
martong added a comment. @ASDenysPetrov Denis, do you think it would make sense to handle the non-multi-dimensional cases first? I see that you have useful patches in the stack that depends on this change (i.e handling a StringLiteral or a CompoundLiteralExpr) but perhaps they would be meaningf

[PATCH] D107960: [clang][analyzer] Make ReturnPtrRange checker warn at negative index.

2021-08-30 Thread Gabor Marton via Phabricator via cfe-commits
martong added a comment. Would it make sense to tweak `assumeInBound` in a way to handle symbolic regions differently than concrete regions? I mean static int arr[10]; return arr - 1; // we want a warning here ... int *p = conjure(); return p - 1; // no warning here Repository:

[PATCH] D93769: [clang] Add support for option -ffp-eval-method and extend #pragma float_control similarly

2021-08-30 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. In D93769#2972151 , @matthewtff wrote: >> It looks like Melanie asked the questions but it wasn't resolved. > > Can this CL be reverted and relanded later with a fix? This breakage is > crucial for a lot of remote/distribute

[PATCH] D93769: [clang] Add support for option -ffp-eval-method and extend #pragma float_control similarly

2021-08-30 Thread Erich Keane via Phabricator via cfe-commits
erichkeane added a comment. In D93769#2972151 , @matthewtff wrote: >> It looks like Melanie asked the questions but it wasn't resolved. > > Can this CL be reverted and relanded later with a fix? This breakage is > crucial for a lot of remote/distributed c

[PATCH] D108912: [release][analyzer] Add 13.0.0 release notes

2021-08-30 Thread Balázs Benics via Phabricator via cfe-commits
steakhal added a comment. Maybe a couple other noteworthy commits: efa7df1682c2859dabe3646ee7dc01e68629417f : better R-value tracking. aa454dda2eed4e71081bc57b1f32dfce2486b177

[PATCH] D108765: [docs] Fix documentation of clang-format BasedOnStyle type

2021-08-30 Thread Ludovic Jozeau via Phabricator via cfe-commits
FederAndInk updated this revision to Diff 369431. FederAndInk added a comment. generate plurals, for now supporting -y ending (-y to -ies/-ys), track generated plurals and show new ones to be checked Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D10

[PATCH] D108765: [docs] Fix documentation of clang-format BasedOnStyle type

2021-08-30 Thread Ludovic Jozeau via Phabricator via cfe-commits
FederAndInk added a comment. Ok, here is my proposal for plurals, I have some ideas, I think the safest/most complete would be to have a file tracking generated plurals and tell the user of the script to check newly generated plurals then add them to git, this would also allow reviewers to see

[PATCH] D93769: [clang] Add support for option -ffp-eval-method and extend #pragma float_control similarly

2021-08-30 Thread Matvey Larionov via Phabricator via cfe-commits
matthewtff added a comment. > It looks like Melanie asked the questions but it wasn't resolved. Can this CL be reverted and relanded later with a fix? This breakage is crucial for a lot of remote/distributed compilation systems. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

  1   2   >