cor3ntin added a comment. At @aaron.ballman request, here are some data collection trying to assert the amount of breakage
On a corpus of 78M lines of C++ code corresponding to all the packages in vcpkg - Number of strings with encoding prefix in `_Pragma`: 3/3383 (all in test suits) - Number of strings with encoding prefix in deprecated/nodiscard attributes: 0/845 - Number of strings with encoding prefix in static_assert: 62/92800 (all in in test suits) - Number of strings with encoding prefix in `extern` : 3/39829 (all in in test suits) Note that, due to the complexity of operating these sort of queries at this scale, this was done by regex and as such is not exact, nor is the approach fully representative of all C++ code. However, I think it gives a good idea of the risk (or lack thereof) involved Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105759/new/ https://reviews.llvm.org/D105759 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
