steven_wu added a comment. In D108881#2973719 <https://reviews.llvm.org/D108881#2973719>, @mnadeem wrote:
> In D108881#2973516 <https://reviews.llvm.org/D108881#2973516>, @steven_wu > wrote: > >> I will do a cleanup of `parseLTOMode` function since we don't need a >> `OptPos` parameter anymore. There are few minor places references `OPT_flto` >> or `OPT_foffload_lto` can be cleaned up too. > > Will you incorporate the functional changes in this patch? Or is there still > a need for this change? The current change set in this review is functional change while the cleanup I want is not functional after the rewrite the old option as Alias. Once flto is the alias, there is no need to handle that in the driver and those might actually become source of bug in the future. I think it would be good to do the cleanup in the same commit unless you have compelling reason not to. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108881/new/ https://reviews.llvm.org/D108881 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
