vsapsai added a comment.
Thanks for the review!
================
Comment at: clang/lib/Serialization/ASTReaderDecl.cpp:3328-3331
// If there's no definition yet, then DC's definition is added by an update
// record, but we've not yet loaded that update record. In this case, we
// commit to DC being the canonical definition now, and will fix this when
// we load the update record.
----------------
rsmith wrote:
> I believe there's no need to have logic matching this case in C because the
> only way that a class definition can be added by an update record is due to
> template instantiation. So we can use the simpler logic below for C.
Thanks, it's good to know.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D106994/new/
https://reviews.llvm.org/D106994
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
