[PATCH] D99320: [RISCV] [1/2] Add intrinsic for Zbb extension

craig.topper added a comment. I think this looks good to me. Anyone else have any comments? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99320/new/ https://reviews.llvm.org/D99320 ___ cfe-commits mailin

[PATCH] D99009: [RISCV] [1/2] Add intrinsic for Zbr extension

craig.topper added a comment. I think this looks good to me. Anyone else have any comments? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99009/new/ https://reviews.llvm.org/D99009 ___ cfe-commits mailin

[PATCH] D99580: [CLANG] [DebugInfo] Convert File name to native format

kamleshbhalui updated this revision to Diff 334359. kamleshbhalui added a comment. updated patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99580/new/ https://reviews.llvm.org/D99580 Files: clang/lib/CodeGen/CGDebugInfo.cpp clang/test/CodeG

[PATCH] D99580: [CLANG] [DebugInfo] Convert File name to native format

kamleshbhalui updated this revision to Diff 334356. kamleshbhalui added a comment. clang formatting the patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99580/new/ https://reviews.llvm.org/D99580 Files: clang/lib/CodeGen/CGDebugInfo.cpp cl

[PATCH] D99631: [RISCV] Refine pre-define macro tests

This revision was automatically updated to reflect the committed changes. Closed by commit rG32ca5a037ab9: [RISCV] Refine pre-define macro tests (authored by Jim). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99631/new/ https://reviews.llvm.org/D99

[clang] 32ca5a0 - [RISCV] Refine pre-define macro tests

Author: Jim Lin Date: 2021-03-31T14:06:20+08:00 New Revision: 32ca5a037ab9191d570bf9b5e0f13e28c3db27d9 URL: https://github.com/llvm/llvm-project/commit/32ca5a037ab9191d570bf9b5e0f13e28c3db27d9 DIFF: https://github.com/llvm/llvm-project/commit/32ca5a037ab9191d570bf9b5e0f13e28c3db27d9.diff LOG:

LLVM buildmaster will be restarted soon

Hello everyone, LLVM buildmaster will be restarted in the nearest hour. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D99580: [CLANG] [DebugInfo] Convert File name to native format

kamleshbhalui updated this revision to Diff 334338. kamleshbhalui added a comment. Marked failed tests as unsupported on windows system Because now clang emits native path for DIFile. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99580/new/ https:/

[PATCH] D96853: [clang][AVR] Support variable decorator '__flash'

benshi001 updated this revision to Diff 334336. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96853/new/ https://reviews.llvm.org/D96853 Files: clang/include/clang/Basic/DiagnosticFrontendKinds.td clang/lib/Basic/Targets/AVR.cpp clang/lib/CodeGen/TargetInfo.cpp clang/test/CodeGen

[PATCH] D99009: [RISCV] [1/2] Add intrinsic for Zbr extension

craig.topper added inline comments. Comment at: clang/include/clang/Basic/BuiltinsRISCV.def:28 +TARGET_BUILTIN(__builtin_riscv_crc32_d, "LiLi", "nc", "experimental-zbr") +TARGET_BUILTIN(__builtin_riscv_crc32c_d, "LiLi", "nc", "experimental-zbr") + Jim wrote: > I

[PATCH] D96853: [clang][AVR] Support variable decorator '__flash'

benshi001 marked 3 inline comments as done. benshi001 added inline comments. Comment at: clang/test/CodeGen/avr-flash.c:1 +// RUN: %clang_cc1 -triple avr -emit-llvm-only -verify %s + benshi001 wrote: > Anastasia wrote: > > If you are only checking the diagnostics

[PATCH] D96853: [clang][AVR] Support variable decorator '__flash'

benshi001 added a comment. In D96853#2659266 , @Anastasia wrote: > Btw is any pointer conversion between address space 1 and the default address > space allowed? I.e. is the following code valid: > > __flash static const int var1[] = {111, 222, 333}; >

[PATCH] D99009: [RISCV] [1/2] Add intrinsic for Zbr extension

Jim added inline comments. Comment at: clang/include/clang/Basic/BuiltinsRISCV.def:28 +TARGET_BUILTIN(__builtin_riscv_crc32_d, "LiLi", "nc", "experimental-zbr") +TARGET_BUILTIN(__builtin_riscv_crc32c_d, "LiLi", "nc", "experimental-zbr") + I don't know why it does

[PATCH] D96853: [clang][AVR] Support variable decorator '__flash'

benshi001 added a comment. In D96853#2659266 , @Anastasia wrote: > Btw is any pointer conversion between address space 1 and the default address > space allowed? I.e. is the following code valid: > > __flash static const int var1[] = {111, 222, 333}; >

[PATCH] D99008: [RISCV] [2/2] Add intrinsic for Zbr extension

LevyHsu updated this revision to Diff 334332. LevyHsu added a comment. 1. clang/lib/Headers/riscv_zbr_intrin.h - Fix coding style issues - Added error messages to alert user not include this headfile directly. 2. clang/lib/Headers/rvintrin.h - Fix coding style issues. Repository: rG LLVM

[PATCH] D99009: [RISCV] [1/2] Add intrinsic for Zbr extension

LevyHsu updated this revision to Diff 334331. LevyHsu marked 9 inline comments as done. LevyHsu added a comment. 1. clang/lib/Sema/SemaChecking.cpp - Rewrite Sema::CheckRISCVBuiltinFunctionCall - Coding style fix 2. llvm/include/llvm/IR/IntrinsicsRISCV.td - BitMan_GPR_Intrinsics's op1 now ma

[PATCH] D96853: [clang][AVR] Support variable decorator '__flash'

benshi001 updated this revision to Diff 334330. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96853/new/ https://reviews.llvm.org/D96853 Files: clang/include/clang/Basic/DiagnosticFrontendKinds.td clang/lib/Basic/Targets/AVR.cpp clang/lib/CodeGen/TargetInfo.cpp clang/test/CodeGen

[PATCH] D89013: [libcxx] Support per-target __config_site in per-target runtime build

MaskRay added a comment. Regarding /usr/include/x86_64-unknown-linux-gnu/c++/v1 /usr/include/c++/v1 With GCC multiarch, some `include` search paths are preceded by machine-os-env specific suffix directories. Note: 'vendor' is not there. So you may see `.../include/x86_64-linux-gnu` but the

[PATCH] D99319: [RISCV] [2/2] Add intrinsic for Zbb extension

LevyHsu updated this revision to Diff 334328. LevyHsu added a comment. 1. clang/lib/Headers/riscv_zbb_intrin.h - Fixed llvm header and other style issues. 2. clang/lib/Headers/rvintrin.h - Fixed llvm header and other style issues. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[PATCH] D99556: Add support to -Wa,--version in clang

MaskRay accepted this revision. MaskRay added inline comments. Comment at: clang/test/Driver/as-version.s:3 + +// RUN: %clang -Wa,--version -c -fintegrated-as %s -o /dev/null \ +// RUN: | FileCheck --check-prefix=IAS %s Delete excess spaces Repository: rG

[PATCH] D99631: [RISCV] Refine pre-define macro tests

HsiangKai accepted this revision. HsiangKai added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99631/new/ https://reviews.llvm.org/D99631 __

[PATCH] D99320: [RISCV] [1/2] Add intrinsic for Zbb extension

LevyHsu updated this revision to Diff 334322. LevyHsu added a comment. 1. clang/lib/Sema/SemaChecking.cpp - Fixed var name & loop 2. clang/test/CodeGen/RISCV/rvb-intrinsics/riscv64-zbb.c - renamed function Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D89013: [libcxx] Support per-target __config_site in per-target runtime build

phosek updated this revision to Diff 334323. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89013/new/ https://reviews.llvm.org/D89013 Files: clang/lib/Driver/ToolChains/Fuchsia.cpp clang/lib/Driver/ToolChains/Gnu.cpp clang/test/Driver/fuchsia.

[PATCH] D96853: [clang][AVR] Support variable decorator '__flash'

benshi001 added inline comments. Comment at: clang/test/CodeGen/avr-flash.c:1 +// RUN: %clang_cc1 -triple avr -emit-llvm-only -verify %s + Anastasia wrote: > If you are only checking the diagnostics you should pass: > > `-emit-llvm-only` -> `-syntax-only` > > a

[PATCH] D99610: [RISCV][Clang] Add all RVV Fixed-Point Arithmetic intrinsic functions.

HsiangKai accepted this revision. HsiangKai added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99610/new/ https://reviews.llvm.org/D99610 __

[PATCH] D99528: [RISCV][Clang] Add more RVV Integer intrinsic functions.

HsiangKai accepted this revision. HsiangKai added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99528/new/ https://reviews.llvm.org/D99528 __

[PATCH] D99631: [RISCV] Refine pre-define macro tests

Jim created this revision. Jim added reviewers: craig.topper, simoncook, HsiangKai. Herald added subscribers: vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, benna, psnobl, jocewei, PkmX, jfb, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, sh

[PATCH] D99630: phase 01: add new command line flag to enable UAR in 3 modes (always, [runtime], never).

kda created this revision. Herald added subscribers: jansvoboda11, dexonsmith, dang, hiraditya. kda requested review of this revision. Herald added projects: clang, Sanitizers, LLVM. Herald added subscribers: llvm-commits, Sanitizers, cfe-commits. Repository: rG LLVM Github Monorepo https://rev

[PATCH] D99580: [CLANG] [DebugInfo] Convert File name to native format

kamleshbhalui added a comment. In D99580#2659352 , @dblaikie wrote: > @rnk @akhuang - I think we touched on this before maybe in some other > thread/patch/discussion? > > Ah, @probinson mentioned in the linked thread: > >> Is this https://bugs.llvm.org/sh

[PATCH] D98548: [clang][Sema] Don't try to initialize implicit variable of invalid anonymous union/struct

This revision was automatically updated to reflect the committed changes. Closed by commit rG99fd06622784: [clang][Sema] Don't try to initialize implicit variable of invalid anonymous… (authored by TaWeiTu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[clang] 99fd066 - [clang][Sema] Don't try to initialize implicit variable of invalid anonymous union/struct

Author: Ta-Wei Tu Date: 2021-03-31T09:05:45+08:00 New Revision: 99fd0662278470f5405b8abd79b681b96cac7856 URL: https://github.com/llvm/llvm-project/commit/99fd0662278470f5405b8abd79b681b96cac7856 DIFF: https://github.com/llvm/llvm-project/commit/99fd0662278470f5405b8abd79b681b96cac7856.diff LOG

[PATCH] D88978: [WIP] Attach debug intrinsics to allocas, and use correct address space

arsenm added a comment. Is this still needed? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88978/new/ https://reviews.llvm.org/D88978 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://list

[PATCH] D99556: Add support to -Wa,--version in clang

jcai19 added inline comments. Comment at: clang/test/Driver/as-version.s:9 +// RUN: | FileCheck --check-prefix=GAS %s +// GAS: GNU assembler nickdesaulniers wrote: > What happens if we run this on windows (where I suspect that GAS isn't > available)? Perhaps

[PATCH] D99556: Add support to -Wa,--version in clang

jcai19 updated this revision to Diff 334315. jcai19 marked an inline comment as done. jcai19 added a comment. Update tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99556/new/ https://reviews.llvm.org/D99556 Files: clang/lib/Driver/ToolChai

[clang] 9eef0fa - Fix test expectations for %diff documentation.

Author: Richard Smith Date: 2021-03-30T17:48:08-07:00 New Revision: 9eef0fae2b840cef0b44cf94517f70a41cd84d42 URL: https://github.com/llvm/llvm-project/commit/9eef0fae2b840cef0b44cf94517f70a41cd84d42 DIFF: https://github.com/llvm/llvm-project/commit/9eef0fae2b840cef0b44cf94517f70a41cd84d42.diff

[clang] c23ee77 - [www] List both the regular and expanded form of %diff in the

Author: Richard Smith Date: 2021-03-30T17:25:01-07:00 New Revision: c23ee7718ea4f9292622af3d80efe2491eb2a506 URL: https://github.com/llvm/llvm-project/commit/c23ee7718ea4f9292622af3d80efe2491eb2a506 DIFF: https://github.com/llvm/llvm-project/commit/c23ee7718ea4f9292622af3d80efe2491eb2a506.diff

[PATCH] D99611: [OPENMP]Fix PR48658: [OpenMP 5.0] Compiler crash when OpenMP atomic sync hints used.

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. Hm, OK. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99611/new/ https://reviews.llvm.org/D99611

[PATCH] D52050: WIP: [Driver] Fix architecture triplets and search paths for Linux x32

glaubitz added a comment. In D52050#2660022 , @hvdijk wrote: > I think the problem is actually the other thing covered before (don't provide > un-normalised triples as cmake arguments), though the wrong detection of > LLVM_HOST_TRIPLE will cause other is

[PATCH] D99623: [WebAssembly] Implement i64x2 comparisons

dschuff accepted this revision. dschuff added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/Basic/BuiltinsWebAssembly.def:218 -TARGET_BUILTIN(__builtin_wasm_eq_i64x2, "V2LLiV2LLiV2LLi", "nc", "simd128") - Is t

[PATCH] D93095: Introduce -Wreserved-identifier

rsmith added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:383 + "identifier %0 is reserved because %select{" + "|" // passing 0 for %1 is not valid but we need that | to make the enum order match the diagnostic + "it starts with '_' at global

[clang] d87384f - [www] Fix build of attribute documentation.

Author: Richard Smith Date: 2021-03-30T16:18:55-07:00 New Revision: d87384f7dfa1158150d9759654d5f19a929b81b7 URL: https://github.com/llvm/llvm-project/commit/d87384f7dfa1158150d9759654d5f19a929b81b7 DIFF: https://github.com/llvm/llvm-project/commit/d87384f7dfa1158150d9759654d5f19a929b81b7.diff

[clang] 1705136 - Fix pluralization error in diagnostic, and move C++ testcase to proper

Author: Richard Smith Date: 2021-03-30T16:18:55-07:00 New Revision: 1705136590cd88176729efec8d291e98249713cb URL: https://github.com/llvm/llvm-project/commit/1705136590cd88176729efec8d291e98249713cb DIFF: https://github.com/llvm/llvm-project/commit/1705136590cd88176729efec8d291e98249713cb.diff

[PATCH] D88452: [Driver] Move detectLibcxxIncludePath to ToolChain

phosek updated this revision to Diff 334297. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88452/new/ https://reviews.llvm.org/D88452 Files: clang/include/clang/Driver/ToolChain.h clang/lib/Driver/ToolChain.cpp clang/lib/Driver/ToolChains/Fuch

[PATCH] D98856: Always emit error for wrong interfaces to scalable vectors, unless cmdline flag is passed.

ctetreau accepted this revision. ctetreau added inline comments. Comment at: llvm/lib/CodeGen/ValueTypes.cpp:17 +unsigned EVT::getVectorNumElements() const { + auto Error = []() { sdesmalen wrote: > ctetreau wrote: > > Out of curiosity, what is the eventual pl

[PATCH] D99551: [clang-offload-wrapper] Add standard notes for ELF offload images

vzakhari updated this revision to Diff 334292. vzakhari added a comment. Herald added a subscriber: mgorny. Updated revision fixes //BUILD_SHARED_LIBS// build. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99551/new/ https://reviews.llvm.org/D99551 Files: clang/test/Driver/Inputs/emp

[PATCH] D99556: Add support to -Wa,--version in clang

nickdesaulniers added inline comments. Comment at: clang/test/Driver/as-version.s:9 +// RUN: | FileCheck --check-prefix=GAS %s +// GAS: GNU assembler What happens if we run this on windows (where I suspect that GAS isn't available)? Perhaps a `CHECK-NOT: clan

[PATCH] D99363: [Windows] Turn off text mode in TableGen and Rewriter to stop CRLF translation

aganea added a comment. >> In D99363#2653476 , >> @abhina.sreeskantharajan wrote: >> >>> > > This was only other file from https://reviews.llvm.org/D96363 that was using > OF_TextWithCRLF instead of OF_Text. Please let me know if this latest patch > htt

[PATCH] D89013: [libcxx] Support per-target __config_site in per-target runtime build

phosek updated this revision to Diff 334289. phosek retitled this revision from "[libcxx] Support per-target __config in per-target runtime build" to "[libcxx] Support per-target __config_site in per-target runtime build". phosek edited the summary of this revision. phosek added a comment. @ldio

[PATCH] D99580: [CLANG] [DebugInfo] Convert File name to native format

kamleshbhalui added a comment. In D99580#2659858 , @amccarth wrote: > Another possible issue is that llvm::sys::path and other functions try to map > Windows filesystem concepts to Posix ones. There are many cases where there > isn't a perfect mapping. F

[PATCH] D52050: WIP: [Driver] Fix architecture triplets and search paths for Linux x32

hvdijk added a comment. I think the problem is actually the other thing covered before (don't provide un-normalised triples as cmake arguments), though the wrong detection of LLVM_HOST_TRIPLE will cause other issues too. If we would just update config.guess, the default configuration (not speci

[PATCH] D99456: [C++2b] Support size_t literals

AntonBikineev updated this revision to Diff 334288. AntonBikineev marked 2 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99456/new/ https://reviews.llvm.org/D99456 Files: clang/include/clang/Basic/DiagnosticCommonKinds.td

[clang] ee176d2 - [www] Color Clang 11 and Clang 12 features as green and not yellow, and

Author: Richard Smith Date: 2021-03-30T15:22:16-07:00 New Revision: ee176d2e6e9d58af2dd1856f3c1f54ae85f2b89b URL: https://github.com/llvm/llvm-project/commit/ee176d2e6e9d58af2dd1856f3c1f54ae85f2b89b DIFF: https://github.com/llvm/llvm-project/commit/ee176d2e6e9d58af2dd1856f3c1f54ae85f2b89b.diff

[PATCH] D99551: [clang-offload-wrapper] Add standard notes for ELF offload images

vzakhari updated this revision to Diff 334282. vzakhari added a comment. I am not sure what is wrong with the uploaded ELF files. The test works locally. Let's try it with a thinner YAML template. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99551/new/ https://reviews.llvm.org/D9955

[PATCH] D99456: [C++2b] Support size_t literals

rsmith accepted this revision. rsmith added a comment. Thanks! Looks good to me. Please wait a day or so in case Aaron has more comments before going ahead. Comment at: clang/include/clang/Basic/DiagnosticCommonKinds.td:198-200 +def err_size_t_literal_too_large: Error< + "%se

[PATCH] D99005: [clang] Implement P2266 Simpler implicit move

mizvekov added inline comments. Comment at: clang/lib/Sema/SemaTemplateInstantiateDecl.cpp:1059 +else if (auto *F = dyn_cast(DC)) + goto unimplemented; // FIXME: get the return type here somehow... +else rjmccall wrote: > mizvekov wrote: > > rjmccall

[PATCH] D99623: [WebAssembly] Implement i64x2 comparisons

tlively created this revision. tlively added reviewers: aheejin, dschuff. Herald added subscribers: wingo, ecnelises, sunfish, hiraditya, jgravelle-google, sbc100. tlively requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. R

[PATCH] D99611: [OPENMP]Fix PR48658: [OpenMP 5.0] Compiler crash when OpenMP atomic sync hints used.

ABataev added inline comments. Comment at: clang/test/OpenMP/atomic_codegen.cpp:61 St().get() %= b; -#pragma omp atomic +#pragma omp atomic hint(6) s.field++; jdoerfert wrote: > Should this influence the IR in any way? Currently not, it is just igno

[PATCH] D99622: [OpenMP51] Accept `primary` as proc bind affinity policy in Clang

cchen created this revision. cchen added a reviewer: ABataev. Herald added subscribers: guansong, yaxunl. cchen requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: llvm-commits, cfe-commits, sstefan1. Herald added projects: clang, LLVM. Repository: rG

[PATCH] D99611: [OPENMP]Fix PR48658: [OpenMP 5.0] Compiler crash when OpenMP atomic sync hints used.

jdoerfert added inline comments. Comment at: clang/test/OpenMP/atomic_codegen.cpp:61 St().get() %= b; -#pragma omp atomic +#pragma omp atomic hint(6) s.field++; Should this influence the IR in any way? Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D99556: Add support to -Wa,--version in clang

jcai19 updated this revision to Diff 334277. jcai19 marked an inline comment as done. jcai19 added a comment. Update tests to address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99556/new/ https://reviews.llvm.org/D99556 Files: clang

[PATCH] D99580: [CLANG] [DebugInfo] Convert File name to native format

amccarth added a comment. The previous discussions (that I participated in) were centered around the redirecting virtual filesystem, which creates paths in hybrid style and there is no "correct" way to make those native without taking breaking changes and making it less useful for writing platf

[PATCH] D99554: [ThinLTO] During module importing, close one source module before open another one for distributed mode.

This revision was automatically updated to reflect the committed changes. Closed by commit rGd535a05ca1a6: [ThinLTO] During module importing, close one source module before open (authored by wmi). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99554/n

[clang] d535a05 - [ThinLTO] During module importing, close one source module before open

Author: Wei Mi Date: 2021-03-30T14:37:29-07:00 New Revision: d535a05ca1a6b959399762d5e14efde1fcfe6af8 URL: https://github.com/llvm/llvm-project/commit/d535a05ca1a6b959399762d5e14efde1fcfe6af8 DIFF: https://github.com/llvm/llvm-project/commit/d535a05ca1a6b959399762d5e14efde1fcfe6af8.diff LOG: [

[PATCH] D99537: [OPENMP51]Initial support for the dispatch directive

This revision was automatically updated to reflect the committed changes. Closed by commit rGb7899ba0e8b7: [OPENMP51]Initial support for the dispatch directive. (authored by mikerice). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CH

[clang] b7899ba - [OPENMP51]Initial support for the dispatch directive.

Author: Mike Rice Date: 2021-03-30T14:12:53-07:00 New Revision: b7899ba0e8b7a7b8fbab06a8b3f2d70f16d7a250 URL: https://github.com/llvm/llvm-project/commit/b7899ba0e8b7a7b8fbab06a8b3f2d70f16d7a250 DIFF: https://github.com/llvm/llvm-project/commit/b7899ba0e8b7a7b8fbab06a8b3f2d70f16d7a250.diff LOG

[PATCH] D46443: [libc++] Add missing cstdalign header

ldionne requested changes to this revision. ldionne added a comment. Trying to summarize the discussion here for the author: 1. Please add a `` header to libc++ that does `#include_next ` and then defines both `__alignof_is_defined` and `__alignas_is_defined`. 2. Please re-add a test checking f

[PATCH] D99292: [flang][driver] Add support for `-cpp/-nocpp`

kiranchandramohan accepted this revision. kiranchandramohan added a comment. This revision is now accepted and ready to land. LGTM. Comment at: flang/include/flang/Frontend/CompilerInvocation.h:142 + /// + /// \param [in] ppOpts The preprocessor options + void collectMacroDe

[PATCH] D52050: WIP: [Driver] Fix architecture triplets and search paths for Linux x32

hvdijk added a comment. I am building with cmake -G Ninja ../llvm -DCMAKE_BUILD_TYPE=Release -DLLVM_ENABLE_PROJECTS='clang;libcxx;libcxxabi' -DLLVM_HOST_TRIPLE=x86_64-pc-linux-gnux32 -DBUILD_SHARED_LIBS=ON -DLLVM_LIBDIR_SUFFIX=x32 -DLLVM_ENABLE_RTTI=ON -DLLVM_BUILD_TESTS=ON -DLLVM_TARGETS_T

[PATCH] D99617: [OPENMP]Fix PR48607: Crash during clang openmp codegen for firstprivate() of `float _Complex`.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe2c7bf08cc8e: [OPENMP]Fix PR48607: Crash during clang openmp codegen for firstprivate() of… (authored by ABataev). Changed prior to commit: https:

[clang] e2c7bf0 - [OPENMP]Fix PR48607: Crash during clang openmp codegen for firstprivate() of `float _Complex`.

Author: Alexey Bataev Date: 2021-03-30T13:39:45-07:00 New Revision: e2c7bf08cc8e9c2461dd18b283b76ed2b3c59630 URL: https://github.com/llvm/llvm-project/commit/e2c7bf08cc8e9c2461dd18b283b76ed2b3c59630 DIFF: https://github.com/llvm/llvm-project/commit/e2c7bf08cc8e9c2461dd18b283b76ed2b3c59630.diff

[PATCH] D99456: [C++2b] Support size_t literals

AntonBikineev updated this revision to Diff 334263. AntonBikineev added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99456/new/ https://reviews.llvm.org/D99456 Files: clang/include/clang/Basic/DiagnosticCommonKinds.t

[PATCH] D99456: [C++2b] Support size_t literals

AntonBikineev marked an inline comment as done. AntonBikineev added inline comments. Comment at: clang/include/clang/Basic/DiagnosticCommonKinds.td:198-200 +def err_size_t_literal_too_large: Error< + "%select{signed |}0'size_t' literal is out of range of possible " + "%select{s

[PATCH] D99617: [OPENMP]Fix PR48607: Crash during clang openmp codegen for firstprivate() of `float _Complex`.

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:644 + if (PI->getType()->isFirstClassType()) +; LValue LV = WrapperCGF.MakeAddrLValue( jdoerfert wrote: > leftover? yes, need to restore original code here Reposit

[PATCH] D99617: [OPENMP]Fix PR48607: Crash during clang openmp codegen for firstprivate() of `float _Complex`.

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LG, one nit. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:644 + if (PI->getType()->isFirstClassType()) +; LValue LV = WrapperCGF.MakeAddrLValue( -

[PATCH] D93095: Introduce -Wreserved-identifier

serge-sans-paille added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:13640 + warnOnReservedIdentifier(New); + aaron.ballman wrote: > rsmith wrote: > > serge-sans-paille wrote: > > > serge-sans-paille wrote: > > > > rsmith wrote: > > > > > Is there

[PATCH] D99592: [PoC][Clang] Use TypeSize instead of uint64_t for getTypeAllocSize().

sdesmalen added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:2856 Address AddrToStoreInto = Address::invalid(); -if (SrcSize <= DstSize) { +if (llvm::TypeSize::isKnownLE(SrcSize, DstSize)) { AddrToStoreInto = Builder.CreateElementB

[PATCH] D93095: Introduce -Wreserved-identifier

serge-sans-paille updated this revision to Diff 334261. serge-sans-paille marked 10 inline comments as done. serge-sans-paille added a comment. Address all the needed changes pointed out by @aaron.ballman *except* the most critical one on the call to warnOnReservedIdentifier being spread at sever

[PATCH] D52050: WIP: [Driver] Fix architecture triplets and search paths for Linux x32

glaubitz added a comment. In D52050#2659654 , @hvdijk wrote: > I am testing the below, on top of c8e56f394af0b9e32c413d62a0e7aebbba3e6b70 > , both > in a Debian chroot and in my non-Deb

[PATCH] D99517: Implemented [[clang::musttail]] attribute for guaranteed tail calls.

rsmith added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:2829-2830 +def err_musttail_needs_call : Error< + "%0 attribute requires that the return value is a function call, which must " + "not create or destroy any temporaries.">; +def err_mustt

[PATCH] D99617: [OPENMP]Fix PR48607: Crash during clang openmp codegen for firstprivate() of `float _Complex`.

ABataev created this revision. ABataev added a reviewer: jdoerfert. Herald added subscribers: guansong, yaxunl. ABataev requested review of this revision. Herald added a subscriber: sstefan1. Herald added a project: clang. Need to cast the argument for the debug wrapper function call to the corres

[PATCH] D52050: WIP: [Driver] Fix architecture triplets and search paths for Linux x32

hvdijk added a comment. I am testing the below, on top of c8e56f394af0b9e32c413d62a0e7aebbba3e6b70 , both in a Debian chroot and in my non-Debian system. Initial testing in the Debian chroot suggests that this works for simple

[PATCH] D98160: [clang] Use decltype((E)) for compound requirement type constraint

This revision was automatically updated to reflect the committed changes. Closed by commit rG3ad6dd5d8f0a: [clang] Use decltype((E)) for compound requirement type constraint (authored by mizvekov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98160/

[clang] 3ad6dd5 - [clang] Use decltype((E)) for compound requirement type constraint

Author: Matheus Izvekov Date: 2021-03-30T22:00:33+02:00 New Revision: 3ad6dd5d8f0a70756f665e8179ad7c5210022c11 URL: https://github.com/llvm/llvm-project/commit/3ad6dd5d8f0a70756f665e8179ad7c5210022c11 DIFF: https://github.com/llvm/llvm-project/commit/3ad6dd5d8f0a70756f665e8179ad7c5210022c11.dif

[PATCH] D99360: [OpenMP][WIP] Add standard notes for ELF offload images

vzakhari abandoned this revision. vzakhari added a comment. The revision was split into: D99612 , D99551 , D99552 , D99553 CHANGES SINCE LAST ACTION https://re

[PATCH] D99190: WIP: [SYCL] Add design document for SYCL mode

tschuett added a comment. The OMPIRBuilder is the modern version of late outlining: https://github.com/llvm/llvm-project/blob/main/llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h You may consider to go that way with SYCL as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D99190: WIP: [SYCL] Add design document for SYCL mode

ABataev added inline comments. Comment at: clang/docs/SYCLSupport.md:123 +traverse all symbols accessible from kernel functions and add them to the +"device part" of the code marking them with the new SYCL device attribute. + bader wrote: > Naghasan wrote: > > Op

[PATCH] D99484: Use `GNUInstallDirs` to support custom installation dirs.

Ericson2314 added inline comments. Comment at: clang/cmake/modules/AddClang.cmake:127 + LIBRARY DESTINATION ${CMAKE_INSTALL_LIBDIR}${LLVM_LIBDIR_SUFFIX} + ARCHIVE DESTINATION ${CMAKE_INSTALL_LIBDIR}${LLVM_LIBDIR_SUFFIX} + RUNTIME DESTINATION ${CMAKE_INS

[PATCH] D99456: [C++2b] Support size_t literals

rsmith added inline comments. Comment at: clang/include/clang/Basic/DiagnosticCommonKinds.td:198-200 +def err_size_t_literal_too_large: Error< + "%select{signed |}0'size_t' literal is out of range of possible " + "%select{signed |}0'size_t' values">; I wonder i

Re: [clang] 9320ac9 - [Clang] Only run test when X86 backend is built.

Is there a more reliable remark that could be tested for? (Clang shouldn't be testing all remarks - just that the remark infrastructure in general is wired up (specific remarks should be tested in llvm) - so picking some really stable remark would be great) maybe there's a remark for "this always_

[PATCH] D99568: [clang][invocation] Fix copy constructor, add copy assignment to CompilerInvocation

dexonsmith added a comment. I'm not sure a deep copy is entirely sound, due to odd ownership rules in "remapped buffers" (I forget the subclass that includes those). A few months ago I got most of the way to deleting those (lifting the logic up into the clang tooling that needed it)... maybe we

[PATCH] D99554: [ThinLTO] During module importing, close one source module before open another one for distributed mode.

wmi added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:1583 ModuleToDefinedGVSummaries[M->getModuleIdentifier()], - ModuleMap, CGOpts.CmdArgs)) { + nullptr, CGOpts.CmdArgs)) { handleAllErrors(

[PATCH] D99554: [ThinLTO] During module importing, close one source module before open another one for distributed mode.

wmi updated this revision to Diff 334240. wmi added a comment. Address Teresa's comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99554/new/ https://reviews.llvm.org/D99554 Files: clang/lib/CodeGen/BackendUtil.cpp clang/test/CodeGen/thinl

[PATCH] D99524: [RISCV][Clang] Add some RVV Integer intrinsic functions.

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99524/new/ https://reviews.llvm.org/D99524 _

[PATCH] D99037: [Matrix] Implement explicit type conversions for matrix types

SaurabhJha added a comment. Hey, I should mention that I am new to clang/llvm. My below thoughts could be wrong. > IIRC, making C-style casts work correctly in C++ will actually be easier if > you make one of the specialized casts do it; I'd say go ahead and do it in > `static_cast`. > > Casts

[PATCH] D99037: [Matrix] Implement explicit type conversions for matrix types

rjmccall added a comment. In D99037#2659290 , @SaurabhJha wrote: > Hey @fhahn @rjmccall , > > Thank you so much for your reviews. Apart from the rest of your comments, > here are the two principle things I am going to do next: > > 1. Replace the `reinterp

[PATCH] D97362: [clang][parser] Allow attributes in explicit template instantiations

aaron.ballman added a comment. Thanks for merging, I think this seems reasonable but is missing some test coverage still. Comment at: clang/lib/Parse/ParseDecl.cpp:4656-4657 !getLangOpts().ObjC) { -ProhibitAttributes(attrs); +ProhibitCXX11Attributes(attrs, diag:

[PATCH] D99551: [clang-offload-wrapper] Add standard notes for ELF offload images

vzakhari updated this revision to Diff 334233. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99551/new/ https://reviews.llvm.org/D99551 Files: clang/test/Driver/Inputs/clang-offload-wrapper/elf32be clang/test/Driver/Inputs/clang-offload-wrapper/elf32le clang/test/Driver/Inputs/clan

[PATCH] D99320: [RISCV] [1/2] Add intrinsic for Zbb extension

craig.topper added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:3418 // message. + bool Feature_Missing = false; + SmallVector ReqFeatures; LLVM coding style does not allow _ in variable names. Comment at: clang/lib/Sema/Se

[PATCH] D99190: WIP: [SYCL] Add design document for SYCL mode

bader added a subscriber: ABataev. bader added inline comments. Comment at: clang/docs/SYCLSupport.md:73 +the integration header is used (included) by the SYCL runtime implementation, so +the header must be available before the host compilation starts.* + Naghas

[PATCH] D99580: [CLANG] [DebugInfo] Convert File name to native format

dblaikie added subscribers: akhuang, probinson, rnk. dblaikie added a comment. @rnk @akhuang - I think we touched on this before maybe in some other thread/patch/discussion? Ah, @probinson mentioned in the linked thread: > Is this https://bugs.llvm.org/show_bug.cgi?id=44170 which had a tentativ

  1   2   3   >