craig.topper added inline comments.
================
Comment at: clang/lib/Sema/SemaChecking.cpp:3418
// message.
+ bool Feature_Missing = false;
+ SmallVector<StringRef> ReqFeatures;
----------------
LLVM coding style does not allow _ in variable names.
================
Comment at: clang/lib/Sema/SemaChecking.cpp:3427
+ continue;
+ else {
+ // Make message like "experimental-zbr" to "Zbr"
----------------
Drop the else. Since the if has a continue, control flow won't reach here if
the 'if' is true.
================
Comment at: clang/test/CodeGen/RISCV/rvb-intrinsics/riscv64-zbb.c:25
+//
+long orcb64_2(long a) {
+ return __builtin_riscv_orc_b_64(a);
----------------
Why _2?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D99320/new/
https://reviews.llvm.org/D99320
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
