rjmccall added a comment. In D99037#2659290 <https://reviews.llvm.org/D99037#2659290>, @SaurabhJha wrote:
> Hey @fhahn @rjmccall , > > Thank you so much for your reviews. Apart from the rest of your comments, > here are the two principle things I am going to do next: > > 1. Replace the `reinterpret_cast`with `static_cast`. Do you think I should > focus this revision to C-style casts and do `static_casts` in another patch? IIRC, making C-style casts work correctly in C++ will actually be easier if you make one of the specialized casts do it; I'd say go ahead and do it in `static_cast`. Casts in C use basically a completely different code path. > 2. Create a new `CK_MatrixCast` and implement its handling. > > Is there any existing code I can look at that can help me implement the > handler code for `CK_MatrixCast`? I could look at vectors because I was doing > `CK_Bitcast` but I don't think I can rely on that now. Right, vector casts are their own unfortunate thing which we don't want to semantically emulate. What code do you want to get out of this? Are there e.g. vectorized float->double conversions we can use, or is the operation basically doomed to break the matrix apart and put it back together again? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99037/new/ https://reviews.llvm.org/D99037 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
