[PATCH] D88220: [C++20] P1825R0: More implicit moves

nullptr.cpp updated this revision to Diff 313493. nullptr.cpp added a comment. Add more tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88220/new/ https://reviews.llvm.org/D88220 Files: clang/include/clang/Basic/DiagnosticGroups.td clang/i

[PATCH] D93656: Moving UniqueInternalLinkageNamesPass to the start of IR pipelines.

hoy added a comment. In D93656#2469504 , @dblaikie wrote: > In D93656#2469485 , @hoy wrote: > >> In D93656#2468841 , @aeubanks wrote: >> >>> In D93656#2468834

[PATCH] D93747: Rename debug linkage name with -funique-internal-linkage-names

hoy added a comment. > In D93656 , @dblaikie wrote: > Though the C case is interesting - it means you'll end up with C functions > with the same DWARF 'name' but different linkage name. I don't know what > that'll do to DWARF consumers - I guess they'll probably

[PATCH] D93683: [clangd] Do not take stale definition from the static index.

ArcsinX added a comment. In D93683#2468842 , @sammccall wrote: > I'm not 100% sure this bug would block adding the equivalent change for > `fuzzyFind` though - it'll affect documentSymbol but not code-completion IIUC > (because of the workaround I mentio

[PATCH] D84673: [clang][cli] Port DiagnosticOpts to new option parsing system

dexonsmith added inline comments. Comment at: llvm/utils/TableGen/OptParserEmitter.cpp:102-107 + std::string getMacroName() const { +if (KeyPath.startswith("DiagnosticOpts.")) + return (Twine("DIAG_") + MarshallingInfo::MacroName).str(); + +return MarshallingInfo::M

[PATCH] D93656: Moving UniqueInternalLinkageNamesPass to the start of IR pipelines.

hoy added a comment. The changes that rename debug linkage name has been separated as D93747 . I'm moving the discussion there. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93656/new/ https://reviews.llvm.org/D936

[PATCH] D93702: [clang][cli] NFC: Make marshalling macros reusable

dexonsmith added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:3040 -#define OPTION_WITH_MARSHALLING( \ -PREFIX_TYPE, NAME, ID, KIND, GROUP, ALIAS, ALIASARGS, FLAGS, PARAM, \ -HELPTEXT, META

[PATCH] D93747: Rename debug linkage name with -funique-internal-linkage-names

hoy created this revision. Herald added subscribers: dexonsmith, wenlei, hiraditya. hoy requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Funtions that are renamed under -funique-internal-linkage-names have their debug link

[PATCH] D93701: [clang][cli] NFC: Make Diags optional in normalizer

dexonsmith added a comment. > This is needed for a future patch, where we start using normalizers in > contexts where no Diags are available. Can you explain what those contexts are? I'm wondering if they can be changed to create a `DiagnosticsEngine` instead of having to account for it being m

[PATCH] D93595: [analyzer] Fix extraction of punned and known scalar SVals

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RegionStore.cpp:1648 +else + bitPos = ORegionRawOffs.getOffset().getQuantity(); +return bitPos * Ctx.getCharWidth(); NoQ wrote: > This assignment can overflow. Both because the raw

[PATCH] D93679: [clang][cli] Port getAllArgumentValues to the marshalling infrastructure

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93679/new/ https://reviews.llvm.org/D93679

[PATCH] D93595: [analyzer] Fix extraction of punned and known scalar SVals

NoQ added inline comments. Comment at: clang/test/Analysis/concrete-endian.cpp:49 +#elif defined(__BIG_ENDIAN__) + clang_analyzer_eval(pps[3] == 0x8877); // expected-warning{{TRUE}} + clang_analyzer_eval(pps[2] == 0xaa99); // expected-warning{{TRUE}}

[PATCH] D93698: [clang][cli] Port a CommaJoined option to the marshalling infrastructure

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM, with one nit. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:333-337 +for (const std::string &Value : Values) { + if (&Value != &Values.front())

[PATCH] D93595: [analyzer] Fix extraction of punned and known scalar SVals

NoQ added a comment. I think you've found a very nice and compact 50% solution to the problem. I didn't think of this while i was looking for a proper fix. Very nice. Comment at: clang/lib/StaticAnalyzer/Core/RegionStore.cpp:1629-1631 +static SVal getSValAsConcreteInt(SValBuil

[PATCH] D93656: Moving UniqueInternalLinkageNamesPass to the start of IR pipelines.

hoy updated this revision to Diff 313488. hoy added a comment. Fixing IR test failure. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93656/new/ https://reviews.llvm.org/D93656 Files: clang/lib/CodeGen/BackendUtil.cpp llvm/include/llvm/Passes/P

[PATCH] D93656: Moving UniqueInternalLinkageNamesPass to the start of IR pipelines.

dblaikie added a comment. In D93656#2469485 , @hoy wrote: > In D93656#2468841 , @aeubanks wrote: > >> In D93656#2468834 , @hoy wrote: >> >>> In D93656#2468821

[PATCH] D93656: Moving UniqueInternalLinkageNamesPass to the start of IR pipelines.

hoy updated this revision to Diff 313487. hoy added a comment. Separated PassBuilder changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93656/new/ https://reviews.llvm.org/D93656 Files: clang/lib/CodeGen/BackendUtil.cpp llvm/include/llvm/P

[PATCH] D93656: Moving UniqueInternalLinkageNamesPass to the start of IR pipelines.

hoy added a comment. In D93656#2468841 , @aeubanks wrote: > In D93656#2468834 , @hoy wrote: > >> In D93656#2468821 , @aeubanks wrote: >> >>> Also it looks like this is doing

[PATCH] D86844: [LoopDeletion] Allows deletion of possibly infinite side-effect free loops

atmnpatel added inline comments. Comment at: llvm/lib/Transforms/Utils/LoopUtils.cpp:621 } } nikic wrote: > Unrelated, but why do these updates happen before the branch from preheader > to exit is added in IR? Shouldn't it be the other way around a

[PATCH] D92039: [-Wcalled-once-parameter] Introduce 'called_once' attribute

NoQ added a comment. In D92039#2463039 , @vsavchenko wrote: > Add one gigantic comment on status kinds and the reasons behind some of the > design choices This was freakin' awesome, thanks a lot. With all the background in place, the rest of the patch w

[PATCH] D86844: [LoopDeletion] Allows deletion of possibly infinite side-effect free loops

atmnpatel updated this revision to Diff 313484. atmnpatel added a comment. Addressed comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86844/new/ https://reviews.llvm.org/D86844 Files: clang/test/Misc/loop-opt-setup.c llvm/include/llvm/Tr

[PATCH] D91927: [X86] Add x86_amx type for intel AMX.

LuoYuanke added inline comments. Comment at: llvm/lib/Target/X86/X86LowerAMXType.cpp:265 +// If the dst type is <256 x i32>*, it is valid intruction. +// %0 = bitcast x86_amx* %tile to <256 x i32>* +// %1 = load <256 x i32>, <256 x i32>* %0, align 64 -

[PATCH] D93743: [NewPM] Run ObjC ARC passes

aeubanks added a comment. I couldn't find any existing tests that these passes run under the legacy PM. Perhaps checking the output of -debug-pass-manager is enough for a test? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93743/new/ https://revie

[PATCH] D93743: [NewPM] Run ObjC ARC passes

aeubanks created this revision. aeubanks added reviewers: ahatanak, ychen. Herald added a subscriber: hiraditya. aeubanks requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Match the legacy PM in running various ObjC ARC pass

[PATCH] D91927: [X86] Add x86_amx type for intel AMX.

LuoYuanke updated this revision to Diff 313458. LuoYuanke added a comment. Address Pengfei's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91927/new/ https://reviews.llvm.org/D91927 Files: clang/test/CodeGen/X86/amx_api.c llvm/includ

[PATCH] D76572: Replace `T(x)` with `reinterpret_cast(x)` everywhere it means reinterpret_cast. No functional change

This revision was automatically updated to reflect the committed changes. Closed by commit rG22cf54a7fba6: Replace `T(x)` with `reinterpret_cast(x)` everywhere it means… (authored by arthur.j.odwyer). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[clang] 22cf54a - Replace `T(x)` with `reinterpret_cast(x)` everywhere it means reinterpret_cast. NFC.

Author: Arthur O'Dwyer Date: 2020-12-22T19:54:29-05:00 New Revision: 22cf54a7fba670642c121684ac3c7ff7e35dfa5c URL: https://github.com/llvm/llvm-project/commit/22cf54a7fba670642c121684ac3c7ff7e35dfa5c DIFF: https://github.com/llvm/llvm-project/commit/22cf54a7fba670642c121684ac3c7ff7e35dfa5c.diff

[PATCH] D86671: [clang-tidy] Add new case type to check variables with Hungarian notation

dougpuob added a comment. In D86671#2456161 , @njames93 wrote: > One last point, is there a way to validate that these options are only set > where it makes sense. If someone tries to use say > `MacroDefinitionHungarianPrefix` That could be warning worth

[PATCH] D93273: [CodeGen][ObjC] Destroy callee-destroyed arguments in the caller function when the receiver is nil

lanza added a comment. Hey @ahatanak, I've ran into this problem in my companies projects and was wondering what the status of this patch is? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93273/new/ https://reviews.llvm.org/D93273 ___

[PATCH] D90507: [Driver] Add DWARF64 flag: -gdwarf64

ayermolo added inline comments. Comment at: clang/test/Driver/debug-options.c:379 +// VALIDT: x86_64 +// RUN: %clang -### -c -gdwarf-5 -gdwarf64 -target VALIDT %s 2>&1 | FileCheck -check-prefix=GDWARF64_ON %s +// RUN: %clang -### -c -gdwarf-4 -gdwarf64 -target VALIDT %s 2>&1 | F

[PATCH] D89617: Prepend "uniq" to symbol names hash with -funique-internal-linkage-names

MaskRay added a comment. `.L` prefixed symbols will be discarded by the linker in the default mode (none of `--discard-none/--discard-locals/--discard-all` is specified). So if you use `.L` (called PrivateGlobalPrefix in MC), this will work without any linker change (if possible I would hope we

[PATCH] D90507: [Driver] Add DWARF64 flag: -gdwarf64

MaskRay added inline comments. Comment at: clang/test/Driver/debug-options.c:379 +// VALIDT: x86_64 +// RUN: %clang -### -c -gdwarf-5 -gdwarf64 -target VALIDT %s 2>&1 | FileCheck -check-prefix=GDWARF64_ON %s +// RUN: %clang -### -c -gdwarf-4 -gdwarf64 -target VALIDT %s 2>&1 | Fi

[PATCH] D86844: [LoopDeletion] Allows deletion of possibly infinite side-effect free loops

jonpa added inline comments. Comment at: llvm/lib/Transforms/Scalar/LoopDeletion.cpp:132 /// A loop is considered dead if it does not impact the observable behavior of /// the program other than finite running time. This never removes a loop that /// might be infinite (unless

[PATCH] D76572: Replace `T(x)` with `reinterpret_cast(x)` everywhere it means reinterpret_cast. No functional change

Quuxplusone updated this revision to Diff 313446. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76572/new/ https://reviews.llvm.org/D76572 Files: clang/lib/CodeGen/CGCall.h llvm/include/llvm/IR/SymbolTableListTraits.h llvm/include/llvm/Object/

[PATCH] D91927: [X86] Add x86_amx type for intel AMX.

LuoYuanke added inline comments. Comment at: llvm/lib/Target/X86/X86LowerAMXType.cpp:264 + SmallVector DeadInsts; + SmallVector DeadBitcasts; + pengfei wrote: > Maybe better to use BitCastInst? There may be dead load or store instructions. Co

[PATCH] D76572: Replace `T(x)` with `reinterpret_cast(x)` everywhere it means reinterpret_cast. No functional change

Quuxplusone updated this revision to Diff 313433. Quuxplusone edited the summary of this revision. Quuxplusone added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Rebase in preparation for finally pushing this thing if the buildbots seem happy. Repository:

[PATCH] D93600: [clangd] When querying drivers by binary, look in PATH too

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thanks, this looks good, just a couple of nits. I guess you don't have commit access, I'm happy to land this for you when you're happy with it. Just need an email address to associate th

[PATCH] D93490: [clang-format] PR48539 ReflowComments breaks Qt translation comments

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. This revision is now accepted and ready to land. This looks good to me. In D93490#2468351 , @JVApen wrote: > In D93490#2467733 , @MyDev

[PATCH] D93452: [clangd] Trim memory periodically

sammccall added a comment. In D93452#2467471 , @njames93 wrote: > I feel like we need some kind of entry for this in release notes given how > much of an issue it is. Good point. I usually procrastinate this and do a sweep of `git log` at release time,

[clang-tools-extra] f7a2612 - [clangd] Release notes for b8c37153d5393aad96

Author: Sam McCall Date: 2020-12-22T22:58:45+01:00 New Revision: f7a26127f21fb1ca8252879ca647835ea7c5903d URL: https://github.com/llvm/llvm-project/commit/f7a26127f21fb1ca8252879ca647835ea7c5903d DIFF: https://github.com/llvm/llvm-project/commit/f7a26127f21fb1ca8252879ca647835ea7c5903d.diff LO

[PATCH] D93656: Moving UniqueInternalLinkageNamesPass to the start of IR pipelines.

dblaikie added inline comments. Comment at: llvm/include/llvm/IR/DebugInfoMetadata.h:2056-2059 + void replaceRawLinkageName(MDString *LinkageName) { +replaceOperandWith(3, LinkageName); + } + hoy wrote: > tmsriram wrote: > > dblaikie wrote: > > > The need t

[PATCH] D93726: [clangd] Use atomics instead of locks to track periodic memory trimming

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3dbe471a2603: [clangd] Use atomics instead of locks to track periodic memory trimming (authored by sammccall). Changed prior to commit: https://re

[clang-tools-extra] 3dbe471 - [clangd] Use atomics instead of locks to track periodic memory trimming

Author: Sam McCall Date: 2020-12-22T22:32:22+01:00 New Revision: 3dbe471a260392ec63dda8deb2709160afc56dde URL: https://github.com/llvm/llvm-project/commit/3dbe471a260392ec63dda8deb2709160afc56dde DIFF: https://github.com/llvm/llvm-project/commit/3dbe471a260392ec63dda8deb2709160afc56dde.diff LO

[PATCH] D93726: [clangd] Use atomics instead of locks to track periodic memory trimming

sammccall added a comment. In D93726#2468855 , @qchateau wrote: > LGTM > > Small nits: > > - `operator()` is not `const` but `Next` is `mutable`, seems to me you > intended to have `operator()` as `const` Oops, I originally did plan to make `operator()`

[PATCH] D90507: [Driver] Add DWARF64 flag: -gdwarf64

ayermolo updated this revision to Diff 313421. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90507/new/ https://reviews.llvm.org/D90507 Files: clang/include/clang/Basic/CodeGenOptions.def clang/include/clang/Driver/Options.td clang/lib/CodeGen

[PATCH] D93726: [clangd] Use atomics instead of locks to track periodic memory trimming

qchateau accepted this revision. qchateau added a comment. This revision is now accepted and ready to land. LGTM Small nits: - `operator()` is not `const` but `Next` is `mutable`, seems to me you intended to have `operator()` as `const` - memory orders for the atomic operations can probably be

[PATCH] D93630: [Attr] Apply GNU-style attributes to expression statements

aaron.ballman added a comment. In D93630#2468241 , @vsavchenko wrote: > In D93630#2468197 , @aaron.ballman > wrote: > >> However, taking a step back -- what attributes would need this functionality >> (and couldn'

[PATCH] D93683: [clangd] Do not take stale definition from the static index.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. In D93683#2467631 , @ArcsinX wrote: > I also want to propose the similar patch for fuzzyFind() (as a part of this > patch or a separate one), but

[PATCH] D93656: Moving UniqueInternalLinkageNamesPass to the start of IR pipelines.

aeubanks added a comment. In D93656#2468834 , @hoy wrote: > In D93656#2468821 , @aeubanks wrote: > >> Also it looks like this is doing 2 different things, the moving of things >> from Clang to LLVM's PassBuilder, a

[PATCH] D93656: Moving UniqueInternalLinkageNamesPass to the start of IR pipelines.

hoy added a comment. In D93656#2468821 , @aeubanks wrote: > Also it looks like this is doing 2 different things, the moving of things > from Clang to LLVM's PassBuilder, and separately the change to the pass > itself. Can these be separated? I'm not sur

[PATCH] D93656: Moving UniqueInternalLinkageNamesPass to the start of IR pipelines.

aeubanks added a comment. Also it looks like this is doing 2 different things, the moving of things from Clang to LLVM's PassBuilder, and separately the change to the pass itself. Can these be separated? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D93656: Moving UniqueInternalLinkageNamesPass to the start of IR pipelines.

aeubanks added inline comments. Comment at: llvm/include/llvm/Passes/PassBuilder.h:140 bool DebugLogging; + bool UniqueLinkageNames; TargetMachine *TM; This seems better suited to be part of PipelineTuningOptions rather than directly in PassBuilder Repo

[PATCH] D93656: Moving UniqueInternalLinkageNamesPass to the start of IR pipelines.

tmsriram added inline comments. Comment at: llvm/lib/Transforms/Utils/UniqueInternalLinkageNames.cpp:26-29 +static cl::opt UniqueDebugAndProfileNames( +"unqiue-debug-profile-names", cl::init(true), cl::Hidden, +cl::desc("Uniqueify debug and profile symbol Names")); +

[PATCH] D93656: Moving UniqueInternalLinkageNamesPass to the start of IR pipelines.

hoy added inline comments. Comment at: llvm/include/llvm/IR/DebugInfoMetadata.h:2056-2059 + void replaceRawLinkageName(MDString *LinkageName) { +replaceOperandWith(3, LinkageName); + } + tmsriram wrote: > dblaikie wrote: > > The need to add this API makes m

[PATCH] D93726: [clangd] Use atomics instead of locks to track periodic memory trimming

sammccall created this revision. sammccall added a reviewer: qchateau. Herald added subscribers: usaxena95, kadircet, jfb, arphaman. sammccall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. Instead of always locking/

[PATCH] D90507: [Driver] Add DWARF64 flag: -gdwarf64

ayermolo updated this revision to Diff 313412. ayermolo marked an inline comment as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90507/new/ https://reviews.llvm.org/D90507 Files: clang/include/clang/Basic/CodeGenOptions.def clang/include/

[PATCH] D93656: Moving UniqueInternalLinkageNamesPass to the start of IR pipelines.

tmsriram added inline comments. Comment at: llvm/include/llvm/IR/DebugInfoMetadata.h:2056-2059 + void replaceRawLinkageName(MDString *LinkageName) { +replaceOperandWith(3, LinkageName); + } + dblaikie wrote: > The need to add this API makes me a bit uncerta

[PATCH] D90507: [Driver] Add DWARF64 flag: -gdwarf64

ayermolo updated this revision to Diff 313410. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90507/new/ https://reviews.llvm.org/D90507 Files: clang/include/clang/Basic/CodeGenOptions.def clang/include/clang/Driver/Options.td clang/lib/CodeGen

[clang-tools-extra] 7ec7788 - Try to fix build on Windows

Author: Stephen Kelly Date: 2020-12-22T20:25:58Z New Revision: 7ec7788ac175f3ccb7083de0e786438ad8610771 URL: https://github.com/llvm/llvm-project/commit/7ec7788ac175f3ccb7083de0e786438ad8610771 DIFF: https://github.com/llvm/llvm-project/commit/7ec7788ac175f3ccb7083de0e786438ad8610771.diff LOG:

[PATCH] D93656: Moving UniqueInternalLinkageNamesPass to the start of IR pipelines.

dblaikie added a subscriber: rnk. dblaikie added a comment. This should have a LLVM test coverage for the LLVM changes. (I realize they're also tested by the Clang test, because there's no way to test Clang's pass manager creation short of testing the effect of running the pass manager (hmm - /

[PATCH] D91302: Handle template instantiations better in clang-tidy check

steveire added a comment. In D91302#2468665 , @thakis wrote: > Looks like this breaks tests on windows: > http://45.33.8.238/win/30322/step_8.txt > > Ptal, and revert for now if it takes a while to fix. (In particular, prefer > reverting over disabling t

[PATCH] D91302: Handle template instantiations better in clang-tidy check

thakis added a comment. Looks like this breaks tests on windows: http://45.33.8.238/win/30322/step_8.txt Ptal, and revert for now if it takes a while to fix. (In particular, prefer reverting over disabling the test on win.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D93721: [NFC][AMDGPU] Do not override GetDefaultDwarfVersion

scott.linder added reviewers: t-tye, laurentm0, yaxunl. scott.linder added a comment. No other target overrides `GetDefaultDwarfVersion` with the same implementation, and in the future when we make changes we can add them at the points in the hierarchy where they make sense semantically. Repos

[PATCH] D93721: [NFC][AMDGPU] Do not override GetDefaultDwarfVersion

scott.linder created this revision. Herald added subscribers: kerbowa, t-tye, tpr, dstuttard, yaxunl, nhaehnle, jvesely, kzhuravl. scott.linder requested review of this revision. Herald added subscribers: cfe-commits, wdng. Herald added a project: clang. Use the implementation inhereted from `Too

[PATCH] D91303: [clang-tidy] readability-container-size-empty: simplify implementation

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM! Comment at: clang-tools-extra/clang-tidy/readability/ContainerSizeEmptyCheck.cpp:101 - ignoringImpCasts(stringLiteral(hasSize(0))), - ignoringImpCasts(cxxBindTemporaryExpr(has(DefaultConstruct

[PATCH] D91302: Handle template instantiations better in clang-tidy check

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa5311d731e1b: [clang-tidy] Handle template instantiations in conta

[clang-tools-extra] a5311d7 - [clang-tidy] Handle template instantiations in container size check

Author: Stephen Kelly Date: 2020-12-22T18:44:45Z New Revision: a5311d731e1b95e93b35b1e9183a4a531df386e7 URL: https://github.com/llvm/llvm-project/commit/a5311d731e1b95e93b35b1e9183a4a531df386e7 DIFF: https://github.com/llvm/llvm-project/commit/a5311d731e1b95e93b35b1e9183a4a531df386e7.diff LOG:

[PATCH] D80623: WIP: Add an API to simplify setting TraversalKind in clang-tidy matchers

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! I'm assuming that @sammccall may be busy given the holiday season, so I think it's fine to land this as-is if you don't hear from him in the next day. If he has additional

[PATCH] D91302: Handle template instantiations better in clang-tidy check

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91302/new/ https://reviews.llvm.org/D91302 ___ cfe-commits mailing list cfe-commit

[clang-tools-extra] b2e734d - Revert "[clangd] zap a few warnings"

Author: Arthur Eubanks Date: 2020-12-22T10:34:03-08:00 New Revision: b2e734d5f46d70c5a73dd16b0619c58eff6b8052 URL: https://github.com/llvm/llvm-project/commit/b2e734d5f46d70c5a73dd16b0619c58eff6b8052 DIFF: https://github.com/llvm/llvm-project/commit/b2e734d5f46d70c5a73dd16b0619c58eff6b8052.diff

[PATCH] D80623: WIP: Add an API to simplify setting TraversalKind in clang-tidy matchers

steveire added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchFinder.h:118 +/// behavior of clang-tidy. +virtual llvm::Optional +getCheckTraversalKind() const; aaron.ballman wrote: > steveire wrote: > > aaron.ballman wrote: > > >

[clang] 34e72a1 - Revert "DR2064: decltype(E) is only a dependent type if E is type-dependent, not"

Author: Arthur Eubanks Date: 2020-12-22T10:18:08-08:00 New Revision: 34e72a146111dd986889a0f0ec8767b2ca6b2913 URL: https://github.com/llvm/llvm-project/commit/34e72a146111dd986889a0f0ec8767b2ca6b2913 DIFF: https://github.com/llvm/llvm-project/commit/34e72a146111dd986889a0f0ec8767b2ca6b2913.diff

[clang] af0dbaa - Revert "Following up on PR48517, fix handling of template arguments that refer"

Author: Arthur Eubanks Date: 2020-12-22T10:18:08-08:00 New Revision: af0dbaaa38f54b0366177aae43545a8848d3fe56 URL: https://github.com/llvm/llvm-project/commit/af0dbaaa38f54b0366177aae43545a8848d3fe56 DIFF: https://github.com/llvm/llvm-project/commit/af0dbaaa38f54b0366177aae43545a8848d3fe56.diff

[clang] 2080232 - Revert "[c++20] P1907R1: Support for generalized non-type template arguments of scalar type."

Author: Arthur Eubanks Date: 2020-12-22T10:18:08-08:00 New Revision: 208023233398a677cc0aacb8153be9801db03af6 URL: https://github.com/llvm/llvm-project/commit/208023233398a677cc0aacb8153be9801db03af6 DIFF: https://github.com/llvm/llvm-project/commit/208023233398a677cc0aacb8153be9801db03af6.diff

[clang] ab7a60e - Revert "Fix MSVC "not all control paths return a value" warnings. NFCI."

Author: Arthur Eubanks Date: 2020-12-22T10:18:07-08:00 New Revision: ab7a60eb4100ab197665b86f682dad0e787a4fed URL: https://github.com/llvm/llvm-project/commit/ab7a60eb4100ab197665b86f682dad0e787a4fed DIFF: https://github.com/llvm/llvm-project/commit/ab7a60eb4100ab197665b86f682dad0e787a4fed.diff

[clang] 85d4a4b - Revert "Fix memory leak complicated non-type template arguments."

Author: Arthur Eubanks Date: 2020-12-22T10:18:07-08:00 New Revision: 85d4a4bcc717a31ff40c4bd979dd6d78beb84b43 URL: https://github.com/llvm/llvm-project/commit/85d4a4bcc717a31ff40c4bd979dd6d78beb84b43 DIFF: https://github.com/llvm/llvm-project/commit/85d4a4bcc717a31ff40c4bd979dd6d78beb84b43.diff

[PATCH] D80623: WIP: Add an API to simplify setting TraversalKind in clang-tidy matchers

steveire updated this revision to Diff 313386. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80623/new/ https://reviews.llvm.org/D80623 Files: clang/include/clang/ASTMatchers/ASTMatchFinder.h clang/lib/ASTMatch

[PATCH] D91302: Handle template instantiations better in clang-tidy check

steveire updated this revision to Diff 313385. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91302/new/ https://reviews.llvm.org/D91302 Files: clang-tools-extra/clang-tidy/readability/ContainerSizeEmptyCheck.cpp

[PATCH] D80623: WIP: Add an API to simplify setting TraversalKind in clang-tidy matchers

aaron.ballman added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchFinder.h:118 +/// behavior of clang-tidy. +virtual llvm::Optional +getCheckTraversalKind() const; steveire wrote: > aaron.ballman wrote: > > steveire wrote: > > >

[PATCH] D91303: [clang-tidy] readability-container-size-empty: simplify implementation

steveire updated this revision to Diff 313381. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91303/new/ https://reviews.llvm.org/D91303 Files: clang-tools-extra/clang-tidy/readability/ContainerSizeEmptyCheck.cpp

[PATCH] D92024: [clang] Implement P0692R1 from C++20 (access checking on specializations and instantiations)

aorlov added a comment. One more ping! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92024/new/ https://reviews.llvm.org/D92024 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[PATCH] D52050: [Driver] Fix architecture triplets and search paths for Linux x32

jrtc27 added a comment. In D52050#2466874 , @glaubitz wrote: > In D52050#2441164 , @glaubitz wrote: > >> In D52050#2441141 , @jrtc27 wrote: >> >>> What gets done currently fo

[PATCH] D91944: OpenMP 5.0 metadirective

ABataev added inline comments. Comment at: clang/lib/Sema/TreeTransform.h:8383-8388 + DeclarationNameInfo DirName; + getDerived().getSema().StartOpenMPDSABlock(OMPD_metadirective, DirName, + nullptr, D->getBeginLoc()); + StmtResult R

[PATCH] D91944: OpenMP 5.0 metadirective

jdoerfert added a comment. (Please make sure all clang and clang-tidy tests pass properly so we can merge the patch) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91944/new/ https://reviews.llvm.org/D91944

[PATCH] D91944: OpenMP 5.0 metadirective

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. As discussed in the OpenMP in LLVM call on December 9th, we should go ahead with this patch and add support for the missing features, e.g., dependent selectors, afterwards. LGTM Reposi

[PATCH] D93490: [clang-format] PR48539 ReflowComments breaks Qt translation comments

JVApen added a comment. In D93490#2467733 , @MyDeveloperDay wrote: > remove // = and // ~ cases Wouldn't it make sense to explicitly document that `//=` and `//~` are not put in here as reflowing them results in wrong results? CHANGES SINCE LAST ACTIO

[PATCH] D93586: [InstCombine] use poison as placeholder for undemanded elems

spatel added a comment. In D93586#2467248 , @aqjune wrote: >> There are 792 files in llvm/test, most of which are in test/Transform (119) >> and test/CodeGen(655). >> The transition will be swiftly done (if there's no other issue hopefully) by >> the nex

[PATCH] D91303: Simplify implementation of container-size-empty

steveire updated this revision to Diff 313370. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91303/new/ https://reviews.llvm.org/D91303 Files: clang-tools-extra/clang-tidy/readability/ContainerSizeEmptyCheck.cpp

[PATCH] D91303: Simplify implementation of container-size-empty

steveire added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/ContainerSizeEmptyCheck.cpp:56 - hasEitherOperand(ignoringImpCasts( - anyOf(integerLiteral(equals(1)), -

[PATCH] D93630: [Attr] Apply GNU-style attributes to expression statements

vsavchenko updated this revision to Diff 313362. vsavchenko added a comment. Maintain previous behavior unless preceeded by a statement attribute Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93630/new/ https://reviews.llvm.org/D93630 Files: cla

[PATCH] D91302: Handle template instantiations better in clang-tidy check

steveire updated this revision to Diff 313361. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91302/new/ https://reviews.llvm.org/D91302 Files: clang-tools-extra/clang-tidy/readability/ContainerSizeEmptyCheck.cpp

[PATCH] D52050: [Driver] Fix architecture triplets and search paths for Linux x32

hvdijk added a comment. In D52050#2466874 , @glaubitz wrote: > However, that's not the same as whether we're on an x86_64 system or on an > x32 system determines which GNU triplet to use and which include and library > search paths are our primary ones.

[PATCH] D91302: Handle template instantiations better in clang-tidy check

steveire updated this revision to Diff 313360. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91302/new/ https://reviews.llvm.org/D91302 Files: clang-tools-extra/clang-tidy/readability/ContainerSizeEmptyCheck.cpp

[PATCH] D93630: [Attr] Apply GNU-style attributes to expression statements

vsavchenko added a comment. In D93630#2468197 , @aaron.ballman wrote: > However, taking a step back -- what attributes would need this functionality > (and couldn't be written on something within the expression statement)? It is still good old `suppress

[PATCH] D87702: [Frontend] Add pragma align natural and sort out pragma pack stack effect

jasonliu added inline comments. Comment at: clang/include/clang/Sema/Sema.h:505 +// AlignPackInfo::getFromRawEncoding, it should not be inspected directly. +uint32_t getRawEncoding(const AlignPackInfo &Info) const { + std::uint32_t Encoding{}; this g

[PATCH] D80623: WIP: Add an API to simplify setting TraversalKind in clang-tidy matchers

steveire added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchFinder.h:118 +/// behavior of clang-tidy. +virtual llvm::Optional +getCheckTraversalKind() const; aaron.ballman wrote: > steveire wrote: > > sammccall wrote: > > > I d

[PATCH] D91302: Handle template instantiations better in clang-tidy check

steveire updated this revision to Diff 313354. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91302/new/ https://reviews.llvm.org/D91302 Files: clang-tools-extra/clang-tidy/readability/ContainerSizeEmptyCheck.cpp

[PATCH] D93630: [Attr] Apply GNU-style attributes to expression statements

aaron.ballman added a comment. In D93630#2468168 , @vsavchenko wrote: > @aaron.ballman I totally agree, but I also would like to understand. > `__attribute__` is a GNU extension, right? Correct. > Then why does it affect the grammar of C? I always thou

[PATCH] D90670: Simplifying memory globalization from the front end to move optimizations to the middle end.

josemonsalve2 updated this revision to Diff 313352. josemonsalve2 added a comment. Modifying 3 more tests to reflect changes in this patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90670/new/ https://reviews.llvm.org/D90670 Files: clang/lib/

[PATCH] D91302: Handle template instantiations better in clang-tidy check

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/ContainerSizeEmptyCheck.cpp:56 +AST_MATCHER(Expr, usedInBooleanContext) { + std::string exprName = "__booleanContextExpr"; + auto result = Comment at:

  1   2   >