jonpa added inline comments.
================ Comment at: llvm/lib/Transforms/Scalar/LoopDeletion.cpp:132 /// A loop is considered dead if it does not impact the observable behavior of /// the program other than finite running time. This never removes a loop that /// might be infinite (unless it is never executed), as doing so could change ---------------- Seems like it would be nice to update this comment. ================ Comment at: llvm/lib/Transforms/Scalar/LoopDeletion.cpp:211 // Don't remove loops for which we can't solve the trip count. // They could be infinite, in which case we'd be changing program behavior. const SCEV *S = SE.getConstantMaxBackedgeTakenCount(L); ---------------- and also this comment..? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86844/new/ https://reviews.llvm.org/D86844 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
