dexonsmith added inline comments.
================
Comment at: llvm/utils/TableGen/OptParserEmitter.cpp:102-107
+ std::string getMacroName() const {
+ if (KeyPath.startswith("DiagnosticOpts."))
+ return (Twine("DIAG_") + MarshallingInfo::MacroName).str();
+
+ return MarshallingInfo::MacroName;
+ }
----------------
This seems like a bit of a semantic layering violation. It'd be pretty
unexpected if someone renamed `DiagnosticOpts` in clang that they'd have to
update this code in llvm. Is there another way to solve this problem?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D84673/new/
https://reviews.llvm.org/D84673
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
