[PATCH] D82777: Clang Driver: Use Apple ld64's new @response-file support.

arphaman added a comment. got it, we'll do what we can to release it as soon as possible in Xcode Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82777/new/ https://reviews.llvm.org/D82777 ___ cfe-commits

[PATCH] D86999: getClangStripDependencyFileAdjuster(): Do not remove -M args when using MSVC cl driver

shivanshu3 created this revision. shivanshu3 added reviewers: aeubanks, kadircet. Herald added a project: clang. Herald added a subscriber: cfe-commits. shivanshu3 requested review of this revision. Herald added a subscriber: ormris. MSVC's cl.exe has a few command line arguments which start with

[PATCH] D86993: Document Clang's expectations of the C standard library.

rjmccall added a comment. Wording looks good. Should we alsso document our assumptions about what functions exist in the standard library — the functions that we'll always use even in freestanding builds? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D85778: More accurately compute the ranges of possible values for +, -, *, &, %.

zequanwu added a comment. In D85778#2251173 , @rsmith wrote: > In D85778#2251160 , @zequanwu wrote: > >> Hi, this change seems like hits a false positive case in chromium build: >> https://bugs.chromium.org/p/chrom

[PATCH] D85778: More accurately compute the ranges of possible values for +, -, *, &, %.

rsmith added a comment. In D85778#2251160 , @zequanwu wrote: > Hi, this change seems like hits a false positive case in chromium build: > https://bugs.chromium.org/p/chromium/issues/detail?id=1124085 That's not a false positive. The code is (simplified):

[PATCH] D85778: More accurately compute the ranges of possible values for +, -, *, &, %.

zequanwu added a comment. Hi, this change hits a false positive case in chromium build: https://bugs.chromium.org/p/chromium/issues/detail?id=1124085 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85778/new/ https://reviews.llvm.org/D85778 ___

[PATCH] D85778: More accurately compute the ranges of possible values for +, -, *, &, %.

rsmith added a comment. In D85778#2248714 , @nikic wrote: > Just for the record, the additional analysis has a measurable compile-time > impact (0.3% at O0): > https://llvm-compile-time-tracker.com/compare.php?from=e7f53044e7263cdbbb4fed9abf086b88ba486bb

[clang] 0ffbbce - Don't take the expression range into account when looking for widening

Author: Richard Smith Date: 2020-09-01T17:42:12-07:00 New Revision: 0ffbbce78de60f4f4d03d6ef97fe2f3bb4275e08 URL: https://github.com/llvm/llvm-project/commit/0ffbbce78de60f4f4d03d6ef97fe2f3bb4275e08 DIFF: https://github.com/llvm/llvm-project/commit/0ffbbce78de60f4f4d03d6ef97fe2f3bb4275e08.diff

[PATCH] D67935: Add `#pragma clang deprecated`, used to deprecate macros

erik.pilkington requested review of this revision. erik.pilkington added a comment. @aaron.ballman: Did you happen to get any feedback on macro attributes? There are a growing number of macros that we'd like to be able to deprecate, and having a workable solution would be useful for us. Reposi

[PATCH] D86930: [clang-format] Handle typename macros inside cast expressions

dougpuob added a comment. I am a beginner to compiler, interesting in how to write Unit Test case for change so I ran it, but found difference with my expection. You mentioned Before: x = (STACK_OF(uint64_t)) & a; After: x = (STACK_OF(uint64_t))&a; Your input test data is identical with the ex

[PATCH] D76211: OpenMP Metadirective with user defined condition

jdoerfert added a comment. reverse ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76211/new/ https://reviews.llvm.org/D76211 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

[PATCH] D86993: Document Clang's expectations of the C standard library.

rsmith updated this revision to Diff 289329. rsmith added a comment. Add missing word. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86993/new/ https://reviews.llvm.org/D86993 Files: clang/docs/Toolchain.rst Index: clang/docs/Toolchain.rst ===

[PATCH] D86993: Document Clang's expectations of the C standard library.

rsmith created this revision. rsmith added reviewers: fhahn, rjmccall. Herald added a project: clang. Herald added a subscriber: cfe-commits. rsmith requested review of this revision. As suggested in https://reviews.llvm.org/D86815 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/

[PATCH] D84455: [Concepts] Fix a deserialization crash.

aaronpuchert added a comment. > in some cases (e.g. implicit deduction guide templates synthesized from the > constructor), hasTypeConstraint returns true, and getTypeConstraint returns a > nullptr. If that's the case, can we reproduce this with a parsed AST? I've only seen this error on deser

[PATCH] D86508: [clang] implement+test remaining C90 __builtin_ functions

nickdesaulniers added inline comments. Comment at: clang/include/clang/Basic/Builtins.def:513 BUILTIN(__builtin_printf, "icC*.", "Fp:0:") +BUILTIN(__builtin_putchar, "ii", "F") +BUILTIN(__builtin_puts, "icC*", "nF") nickdesaulniers wrote: > nickdesaulniers wrote

[PATCH] D84604: Thread safety analysis: Consider global variables in scope

aaronpuchert updated this revision to Diff 289316. aaronpuchert added a comment. Rebase on top of D84603 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84604/new/ https://reviews.llvm.org/D84604 Files: clang/lib

[PATCH] D86508: [clang] implement+test remaining C90 __builtin_ functions

nickdesaulniers added inline comments. Comment at: clang/include/clang/Basic/Builtins.def:513 BUILTIN(__builtin_printf, "icC*.", "Fp:0:") +BUILTIN(__builtin_putchar, "ii", "F") +BUILTIN(__builtin_puts, "icC*", "nF") nickdesaulniers wrote: > rsmith wrote: > > aar

[PATCH] D86508: [clang] implement+test remaining C90 __builtin_ functions

nickdesaulniers updated this revision to Diff 289312. nickdesaulniers marked an inline comment as done. nickdesaulniers added a comment. - rebase on master, precommitted getLangOpts() change, dropped p7.cpp test change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[PATCH] D86508: [clang] implement+test remaining C90 __builtin_ functions

nickdesaulniers added inline comments. Comment at: clang/include/clang/Basic/Builtins.def:513 BUILTIN(__builtin_printf, "icC*.", "Fp:0:") +BUILTIN(__builtin_putchar, "ii", "F") +BUILTIN(__builtin_puts, "icC*", "nF") rsmith wrote: > aaron.ballman wrote: > > Shoul

[PATCH] D86861: [clangd] Handle templates more consistently in type hierarchy

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGca842c825a1c: [clangd] Handle templates more consistently in type hierarchy (authored by nridge). Repository: rG LLVM Github Monorepo CHANGES SIN

[clang-tools-extra] ca842c8 - [clangd] Handle templates more consistently in type hierarchy

Author: Nathan Ridge Date: 2020-09-01T19:18:37-04:00 New Revision: ca842c825a1caf10aacb1dc63664d565b1f2f4eb URL: https://github.com/llvm/llvm-project/commit/ca842c825a1caf10aacb1dc63664d565b1f2f4eb DIFF: https://github.com/llvm/llvm-project/commit/ca842c825a1caf10aacb1dc63664d565b1f2f4eb.diff

[clang] 7cd6b0c - [clang] Do not consider the template arguments of bases to be bases themselves

Author: Nathan Ridge Date: 2020-09-01T19:18:03-04:00 New Revision: 7cd6b0c3b5db61be94ed7f494d5036b2c30aaf3f URL: https://github.com/llvm/llvm-project/commit/7cd6b0c3b5db61be94ed7f494d5036b2c30aaf3f DIFF: https://github.com/llvm/llvm-project/commit/7cd6b0c3b5db61be94ed7f494d5036b2c30aaf3f.diff

[PATCH] D86424: [clang] Do not consider the template arguments of bases to be bases themselves

This revision was automatically updated to reflect the committed changes. Closed by commit rG7cd6b0c3b5db: [clang] Do not consider the template arguments of bases to be bases themselves (authored by nridge). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D86105: [darwin] Disable the -Wpsabi warning

ab added a comment. Hmm, is there a more general way to disable warnings? I'm not familiar with these parts, so I'll defer to you folks =] Comment at: clang/lib/CodeGen/TargetInfo.cpp:2515-2516 + if (!CallerHasFeat && !CalleeHasFeat) { +// Darwin doesn't enable AVX/AVX51

[clang] 663f4f7 - [clang] consistently use getLangOpts()

Author: Nick Desaulniers Date: 2020-09-01T15:56:53-07:00 New Revision: 663f4f7edc2476231fa5bfc04519d5fd51a10112 URL: https://github.com/llvm/llvm-project/commit/663f4f7edc2476231fa5bfc04519d5fd51a10112 DIFF: https://github.com/llvm/llvm-project/commit/663f4f7edc2476231fa5bfc04519d5fd51a10112.di

[PATCH] D86671: [clang-tidy] Add new case type to check variables with Hungarian notation

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.cpp:185 +getHungarianNotationTypePrefix(const std::string &TypeName, + const NamedDecl *Decl) { + if (0 == TypeName.length()) {

[PATCH] D83004: [UpdateCCTestChecks] Include generated functions if asked

jdoerfert added a comment. reverse ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83004/new/ https://reviews.llvm.org/D83004 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

[clang] 0c2d872 - [PowerPC] Implement builtins for xvcvspbf16 and xvcvbf16spn

Author: Amy Kwan Date: 2020-09-01T17:16:43-05:00 New Revision: 0c2d872d5dec3eba10a8245bbcb3eebcf405ef9f URL: https://github.com/llvm/llvm-project/commit/0c2d872d5dec3eba10a8245bbcb3eebcf405ef9f DIFF: https://github.com/llvm/llvm-project/commit/0c2d872d5dec3eba10a8245bbcb3eebcf405ef9f.diff LOG:

[PATCH] D86795: [PowerPC] Implement builtins for xvcvspbf16 and xvcvbf16spn

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0c2d872d5dec: [PowerPC] Implement builtins for xvcvspbf16 and xvcvbf16spn (authored by amyk). Changed prior to commit: https://reviews.llvm.org/D8

[PATCH] D86621: [clang][Sparc] Default to -mcpu=v9 for SparcV8 on Solaris

ro added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:350 return A->getValue(); +if (T.getArch() == llvm::Triple::sparc && T.isOSSolaris()) + return "v9"; ro wrote: > efriedma wrote: > > ro wrote: > > > brad wrote: > > >

[PATCH] D86508: [clang] implement+test remaining C90 __builtin_ functions

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/Builtins.def:488 +BUILTIN(__builtin_calloc, "v*zz", "F") +BUILTIN(__builtin_exit, "vi", "Fr") BUILTIN(__builtin_fprintf, "iP*cC*.", "Fp:1:") rsmith wrote: > aaron.ballman wrote: > > Shoul

[PATCH] D86508: [clang] implement+test remaining C90 __builtin_ functions

rsmith added inline comments. Comment at: clang/include/clang/Basic/Builtins.def:488 +BUILTIN(__builtin_calloc, "v*zz", "F") +BUILTIN(__builtin_exit, "vi", "Fr") BUILTIN(__builtin_fprintf, "iP*cC*.", "Fp:1:") aaron.ballman wrote: > Should we be adding `atexit()`

[PATCH] D86508: [clang] implement+test remaining C90 __builtin_ functions

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/Builtins.def:488 +BUILTIN(__builtin_calloc, "v*zz", "F") +BUILTIN(__builtin_exit, "vi", "Fr") BUILTIN(__builtin_fprintf, "iP*cC*.", "Fp:1:") Should we be adding `atexit()` as well?

[PATCH] D86621: [clang][Sparc] Default to -mcpu=v9 for SparcV8 on Solaris

ro added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:350 return A->getValue(); +if (T.getArch() == llvm::Triple::sparc && T.isOSSolaris()) + return "v9"; efriedma wrote: > ro wrote: > > brad wrote: > > > ro wrote: > > >

[PATCH] D60939: [Concepts] Delayed Constraint Substitution

rsmith added a comment. I wonder if there's a cleaner way to model this: Suppose we add a new `Expr` subclass for an expression with delayed template argument substitution, which would capture a list of `TemplateArgument`s and an inner `Expr*` into which those template arguments have not yet be

[clang] 478eb98 - [Docs] Remove outdated OS limitation

Author: Julian Lettner Date: 2020-09-01T14:44:17-07:00 New Revision: 478eb98cd25cb0ebc01fc2c3889ae94d3f1797d3 URL: https://github.com/llvm/llvm-project/commit/478eb98cd25cb0ebc01fc2c3889ae94d3f1797d3 DIFF: https://github.com/llvm/llvm-project/commit/478eb98cd25cb0ebc01fc2c3889ae94d3f1797d3.diff

[PATCH] D86980: [Docs] Remove outdated OS limitation

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG478eb98cd25c: [Docs] Remove outdated OS limitation (authored by yln). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[PATCH] D86980: [Docs] Remove outdated OS limitation

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86980/new/ https://reviews.llvm.org/D86980 __

[PATCH] D86980: [Docs] Remove outdated OS limitation

yln created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. yln requested review of this revision. Thread Sanitizer is supported on macOS. rdar://68159753 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D86980 Files: clang/docs/UsersManua

[PATCH] D86621: [clang][Sparc] Default to -mcpu=v9 for SparcV8 on Solaris

efriedma added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:350 return A->getValue(); +if (T.getArch() == llvm::Triple::sparc && T.isOSSolaris()) + return "v9"; ro wrote: > brad wrote: > > ro wrote: > > > efriedma wrote:

[PATCH] D84603: Thread safety analysis: More consistent warning message

This revision was automatically updated to reflect the committed changes. aaronpuchert marked an inline comment as done. Closed by commit rG8ca00c5cdc0b: Thread safety analysis: More consistent warning message (authored by aaronpuchert). Changed prior to commit: https://reviews.llvm.org/D84603?

[clang] 8ca00c5 - Thread safety analysis: More consistent warning message

Author: Aaron Puchert Date: 2020-09-01T23:16:05+02:00 New Revision: 8ca00c5cdc0b86a433b80db633f3ff46e6547895 URL: https://github.com/llvm/llvm-project/commit/8ca00c5cdc0b86a433b80db633f3ff46e6547895 DIFF: https://github.com/llvm/llvm-project/commit/8ca00c5cdc0b86a433b80db633f3ff46e6547895.diff

[PATCH] D86621: [clang][Sparc] Default to -mcpu=v9 for SparcV8 on Solaris

efriedma added inline comments. Comment at: clang/lib/Basic/Targets/Sparc.cpp:224 +Builder.defineMacro("__GCC_HAVE_SYNC_COMPARE_AND_SWAP_8"); + } } ro wrote: > efriedma wrote: > > ro wrote: > > > efriedma wrote: > > > > This probably should be refactored so

[PATCH] D86621: [clang][Sparc] Default to -mcpu=v9 for SparcV8 on Solaris

ro added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:350 return A->getValue(); +if (T.getArch() == llvm::Triple::sparc && T.isOSSolaris()) + return "v9"; brad wrote: > ro wrote: > > efriedma wrote: > > > Do we want to m

[PATCH] D85091: [Sema, CodeGen] Implement [[likely]] and [[unlikely]] in IfStmt

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaStmt.cpp:578 +static std::pair +getLikelihood(const Stmt *Stmt) { + if (const auto *AS = dyn_cast(Stmt)) rsmith wrote: > Sema doesn't care about any of this; can you move this code to CodeGen an

[PATCH] D86621: [clang][Sparc] Default to -mcpu=v9 for SparcV8 on Solaris

ro added inline comments. Comment at: clang/lib/Basic/Targets/Sparc.cpp:224 +Builder.defineMacro("__GCC_HAVE_SYNC_COMPARE_AND_SWAP_8"); + } } efriedma wrote: > ro wrote: > > efriedma wrote: > > > This probably should be refactored so the target-independent

[PATCH] D85091: [Sema, CodeGen] Implement [[likely]] and [[unlikely]] in IfStmt

rsmith added a comment. Looking specifically for attributes in the 'then' and 'else' cases of an `if` seems like a fine first pass at this, but I think this is the wrong way to lower these attributes in the longer term: we should have a uniform treatment of them that looks for the most recent p

[PATCH] D86820: [X86] Add a /tune: option for clang-cl

craig.topper updated this revision to Diff 289273. craig.topper added a comment. Use an alias. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86820/new/ https://reviews.llvm.org/D86820 Files: clang/include/clang/Driver/Options.td clang/test/Driver/cl-x86-flags.c Index: clang/test/

[PATCH] D86621: [clang][Sparc] Default to -mcpu=v9 for SparcV8 on Solaris

efriedma added inline comments. Comment at: clang/lib/Basic/Targets/Sparc.cpp:224 +Builder.defineMacro("__GCC_HAVE_SYNC_COMPARE_AND_SWAP_8"); + } } ro wrote: > efriedma wrote: > > This probably should be refactored so the target-independent code generates

[PATCH] D86802: [Modules] Don't parse/load explicit module maps if modules are disabled

andrewjcg abandoned this revision. andrewjcg added a comment. Ahh, I see, make sense. The motivating issue was due to an apparent bug where realpaths in umbrella dir support for module map files get leaked into dep files for includes starting with `..` (e.g. `#include "../foo.h"`) in non-modula

[PATCH] D86936: [clang] Limit the maximum level of fold-expr expansion.

sammccall added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:5092 "expression not permitted as operand of fold expression">; +def err_fold_expression_expansion_exceeded: Error< + "fold expression expansion level %0 exceeded maximum of %1">; --

[PATCH] D86621: [clang][Sparc] Default to -mcpu=v9 for SparcV8 on Solaris

brad added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:350 return A->getValue(); +if (T.getArch() == llvm::Triple::sparc && T.isOSSolaris()) + return "v9"; ro wrote: > efriedma wrote: > > Do we want to make sparc and sp

[PATCH] D86802: [Modules] Don't parse/load explicit module maps if modules are disabled

rsmith requested changes to this revision. rsmith added a comment. This revision now requires changes to proceed. Sorry for not noticing this review earlier. We can't make this change. Module map files are still useful and still used even when modules are disabled -- they power the undeclared in

[PATCH] D86559: [Sema, CodeGen] Allow [[likely]] and [[unlikely]] on labels

staffantj added a comment. In D86559#2250344 , @Mordante wrote: > In D86559#2250106 , @staffantj wrote: > >> In D86559#2250034 , @aaron.ballman >> wrote: >> >>> In D86559#22

[clang] b1f3948 - Do not emit "-tune-cpu generic" for PS4 platform

Author: Douglas Yung Date: 2020-09-01T12:37:47-07:00 New Revision: b1f394862053867cdc6b2300e725e053504519d5 URL: https://github.com/llvm/llvm-project/commit/b1f394862053867cdc6b2300e725e053504519d5 DIFF: https://github.com/llvm/llvm-project/commit/b1f394862053867cdc6b2300e725e053504519d5.diff

[PATCH] D86965: Do not emit "-tune-cpu generic" for PS4 platform

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb1f394862053: Do not emit "-tune-cpu generic" for PS4 platform (authored by dyung). Changed prior to commit: https://reviews.llvm.org/D86965?vs=28

[PATCH] D86965: Do not emit "-tune-cpu generic" for PS4 platform

probinson accepted this revision. probinson added a comment. This revision is now accepted and ready to land. Couple of nits and LGTM. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:2078 - // Default to "generic" unless -march is present. + // Default to "generic" unless

[PATCH] D86559: [Sema, CodeGen] Allow [[likely]] and [[unlikely]] on labels

Mordante added a comment. In D86559#2250106 , @staffantj wrote: > In D86559#2250034 , @aaron.ballman > wrote: > >> In D86559#2243575 , @staffantj >> wrote: >> >>> This is n

[PATCH] D85091: [Sema, CodeGen] Implement [[likely]] and [[unlikely]] in IfStmt

Mordante marked 8 inline comments as done. Mordante added a comment. Thanks again for your feedback. Once we agree on what to do with the Likelihood state in the output I'll finish the changes and submit a new patch. Comment at: clang/include/clang/Basic/AttrDocs.td:1697 +It i

[PATCH] D86508: [clang] implement+test remaining C90 __builtin_ functions

rsmith added a comment. LGTM I've not checked all the types are correct (someone should double-check that prior to commit), but it looks like GCC provides these `__builtin_*` functions, so we should too. The addition of the non-`__builtin_` versions should improve our diagnostics but otherwise

[PATCH] D86649: Fix for assertion failure on PR46865

wristow added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:3098 // have been value-dependent too), so diagnose that. -assert(!VD->mightBeUsableInConstantExpressions(Info.Ctx)); +assert(!VD->isUsableInConstantExpressions(Info.Ctx)); if (!Info.check

[PATCH] D85032: [builtins] Make divXf3 handle denormal results

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG93eed63d2f31: [builtins] Make __div[sdt]f3 handle denormal results (authored by atrosinenko). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D86965: Do not emit "-tune-cpu generic" for PS4 platform

dyung created this revision. dyung added a reviewer: probinson. dyung added a project: clang. dyung requested review of this revision. For the PS4, do not emit "-tune-cpu generic" since the platform only has 1 known CPU and we do not want to prevent optimizations by tuning for a generic rather t

[PATCH] D86958: [Docs] Add/update release notes for D71913 (LTO WPD changes)

tejohnson updated this revision to Diff 289238. tejohnson added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86958/new/ https://reviews.llvm.org/D86958 Files: clang/docs/ReleaseNotes.rst lld/docs/ReleaseNotes.rst

[PATCH] D86853: [modules] Fix crash in call to `FunctionDecl::setPure()`

bruno added reviewers: rsmith, v.g.vassilev. bruno added inline comments. Comment at: clang/lib/Serialization/ASTReaderDecl.cpp:870 + // definition (which is required for `setPure`). + const bool pure = Record.readInt(); FD->setHasInheritedPrototype(Record.readInt()); --

[PATCH] D84345: [AMDGPU] Set the default globals address space to 1

arichardson updated this revision to Diff 289235. arichardson added a comment. clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84345/new/ https://reviews.llvm.org/D84345 Files: clang/lib/Basic/Targets/AMDGPU.cpp clang/lib/CodeGen/CG

[PATCH] D86802: [Modules] Don't parse/load explicit module maps if modules are disabled

andrewjcg updated this revision to Diff 289236. andrewjcg added a comment. simplify test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86802/new/ https://reviews.llvm.org/D86802 Files: clang/lib/Frontend/FrontendAction.cpp clang/test/Modules/e

[PATCH] D86713: [clang-format] Parse nullability attributes as a pointer qualifier

arichardson added a comment. In D86713#2242381 , @arichardson wrote: > In D86713#2242354 , @JakeMerdichAMD > wrote: > >> In D86713#2242300 , @arichardson >> wrote: >> >>> I

[PATCH] D86964: [ASTMatchers] Avoid recursion in ancestor matching to save stack space.

sammccall created this revision. sammccall added a reviewer: hokein. Herald added a project: clang. Herald added a subscriber: cfe-commits. sammccall requested review of this revision. A recent change increased the stack size of memoizedMatchesAncestorOfRecursively leading to stack overflows on re

[PATCH] D86508: [clang] implement+test remaining C90 __builtin_ functions

nickdesaulniers added a comment. bumping for review. Are there additional reviewers we could add to share the burden? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86508/new/ https://reviews.llvm.org/D86508 ___

[PATCH] D86721: [clang-format] Parse double-square attributes as pointer qualifiers

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86721/new/ https://reviews.llvm.org/D86721 __

[PATCH] D85091: [Sema, CodeGen] Implement [[likely]] and [[unlikely]] in IfStmt

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:1693 +The attributes are used to aid the compiler to determine which branch is +likely or unlikely to be taken. This is done by marking the first statement in +the branch with one of the two at

[PATCH] D86559: [Sema, CodeGen] Allow [[likely]] and [[unlikely]] on labels

aaron.ballman added a comment. In D86559#2250106 , @staffantj wrote: > In D86559#2250034 , @aaron.ballman > wrote: > >> In D86559#2243575 , @staffantj >> wrote: >> >>> As o

[PATCH] D86802: [Modules] Don't parse/load explicit module maps if modules are disabled

bruno added inline comments. Comment at: clang/test/Modules/explicit-module-maps.cpp:4 + +// RUN: %clang_cc1 -fmodule-map-file=%S/Inputs/explicit-module-maps/invalid.modulemap -verify %s +// expected-no-diagnostics Minor suggestion here given the content of the

[PATCH] D86514: Correctly parse LateParsedTemplates in case of multiple dependent modules

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Thanks! Comment at: clang/lib/Serialization/ASTReader.cpp:8395 +for (unsigned Idx = 0, N = LateParsed.size(); Idx < N; + /* In loop */) { + FunctionDecl *FD

[PATCH] D86559: [Sema, CodeGen] Allow [[likely]] and [[unlikely]] on labels

staffantj added a comment. In D86559#2250034 , @aaron.ballman wrote: > In D86559#2243575 , @staffantj wrote: > >> As one of the SG14 industry members driving this, I'm firmly in the camp >> that this is what we're

[PATCH] D86559: [Sema, CodeGen] Allow [[likely]] and [[unlikely]] on labels

aaron.ballman added a comment. In D86559#2243575 , @staffantj wrote: > As one of the SG14 industry members driving this, I'm firmly in the camp that > this is what we're expecting. In the first case the 1/2 case are "neutral". > This is a very explicit,

[PATCH] D86960: [clang-format] Parse __underlying_type(T) as a type

arichardson created this revision. arichardson added reviewers: MyDeveloperDay, JakeMerdichAMD, sammccall, curdeius. Herald added subscribers: cfe-commits, jfb. Herald added a project: clang. arichardson requested review of this revision. Before: MACRO(__underlying_type(A) * a); After: MACRO(__u

[PATCH] D86959: [clang-format] Fix formatting of _Atomic() qualifier

arichardson created this revision. arichardson added reviewers: MyDeveloperDay, JakeMerdichAMD, sammccall, curdeius. Herald added subscribers: cfe-commits, jfb. Herald added a project: clang. arichardson requested review of this revision. Before: _Atomic(uint64_t) * a; After: _Atomic(uint64_t) *a

[PATCH] D86736: [analyzer][NFC] Don't bind values to ObjCForCollectionStmt, replace it with a GDM trait

Szelethus added a comment. In D86736#2249920 , @martong wrote: > I don't have anymore immediate concerns, but I will need more time to comb > through the rest of the patch in more details... hopefully I can do that in > the following days. Thank you so

[PATCH] D86958: [Docs] Add/update release notes for D71913 (LTO WPD changes)

MaskRay added inline comments. Comment at: lld/docs/ReleaseNotes.rst:29 (`D77231 `_) -* ``--lto-whole-program-visibility`` is added to support LTO whole-program devirtualization. +* ``--lto-whole-program-visibility`` is added to specify that c

[PATCH] D86958: [Docs] Add/update release notes for D71913 (LTO WPD changes)

tejohnson created this revision. tejohnson added a reviewer: hans. Herald added subscribers: dexonsmith, inglorion. Herald added a reviewer: MaskRay. Herald added projects: clang, LLVM. tejohnson requested review of this revision. This adds documentation for the options added / changed by D71913

[PATCH] D86736: [analyzer][NFC] Don't bind values to ObjCForCollectionStmt, replace it with a GDM trait

martong added a comment. I don't have anymore immediate concerns, but I will need more time to comb through the rest of the patch in more details... hopefully I can do that in the following days. Comment at: clang/lib/StaticAnalyzer/Core/ProgramState.cpp:327 +using ObjCForLct

[PATCH] D85676: [NewPM] collapsing nested pass mangers of the same type

ychen added a comment. In D85676#2245787 , @asbirlea wrote: > Seems like a good idea. I'm curious if you saw any impact from this change. Yeah, I'm curious too but I didn't measure it yet. What's the recommended ways to measure it? Repository: rG LLV

[PATCH] D86861: [clangd] Handle templates more consistently in type hierarchy

nridge added a comment. In D86861#2249490 , @hokein wrote: > IIUC, you're mostly fixing the issues mentioned in > https://github.com/clangd/vscode-clangd/pull/44#issuecomment-669092168. If it > just contains two fixes (this, and https://reviews.llvm.org/

[PATCH] D85031: [builtins] Unify the softfloat division implementation

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0e90d8d4fed8: [builtins] Unify the softfloat division implementation (authored by atrosinenko). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D62574: Add support for target-configurable address spaces.

ebevhan added a comment. In D62574#2242471 , @Anastasia wrote: > The only thing is that it would be good to test the new target setting logic > somehow... do you have any ideas in mind? We could think of creating a dummy > target for that or adding a dum

[PATCH] D84049: Disable use of _ExtInt with '__atomic' builtins

ldionne added inline comments. Comment at: libcxx/test/libcxx/atomics/ext-int.verify.cpp:1 +// REQUIRES: clang-11 + jtmott-intel wrote: > ldionne wrote: > > This isn't great, since it won't run on clang-12, etc. I'll change it to: > > > > ``` > > // UNSUPPORTED:

[PATCH] D85984: [analyzer] Add a new checker alpha.cplusplus.CPlusPlus11Lock

ASDenysPetrov updated this revision to Diff 289190. ASDenysPetrov added a comment. Added //timed// functions support and tests for them. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85984/new/ https://reviews.llvm.org/D85984 Files: clang/include/clang/StaticAnalyzer/Checkers/Checker

[PATCH] D86707: [SystemZ][z/OS] Adding initial toolchain for z/OS

lalovic added a comment. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86707/new/ https://reviews.llvm.org/D86707 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[PATCH] D86491: [DebugInfo] Move constructor homing case in shouldOmitDefinition.

akhuang closed this revision. akhuang added a comment. ah sorry, this was relanded in b1009ee84fc0242bcebd07889306bf39d9b7170f . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D8649

[PATCH] D84049: Disable use of _ExtInt with '__atomic' builtins

jtmott-intel added inline comments. Comment at: libcxx/test/libcxx/atomics/ext-int.verify.cpp:1 +// REQUIRES: clang-11 + ldionne wrote: > This isn't great, since it won't run on clang-12, etc. I'll change it to: > > ``` > // UNSUPPORTED: clang-4, clang-5, clang-

[PATCH] D86950: [clang-format] Check that */& after typename macros are pointers/references

arichardson created this revision. arichardson added reviewers: MyDeveloperDay, JakeMerdichAMD, sammccall, curdeius. Herald added a project: clang. Herald added a subscriber: cfe-commits. arichardson requested review of this revision. Depends on D86930 (Fix the a

[PATCH] D84988: [Coverage] Add empty line regions to SkippedRegions

vsk added inline comments. Comment at: llvm/lib/ProfileData/Coverage/CoverageMapping.cpp:483 bool GapRegion = CR.value().Kind == CounterMappingRegion::GapRegion; if (CR.index() + 1 == Regions.size() || zequanwu wrote: > vsk wrote: > > zequanwu wro

[PATCH] D86926: FormatTest: Provide real line number in failure messages

arichardson updated this revision to Diff 289181. arichardson added a comment. - fix missing argument Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86926/new/ https://reviews.llvm.org/D86926 Files: clang/unittests/Format/FormatTest.cpp Index:

[PATCH] D84049: Disable use of _ExtInt with '__atomic' builtins

ldionne added inline comments. Comment at: libcxx/test/libcxx/atomics/ext-int.verify.cpp:1 +// REQUIRES: clang-11 + This isn't great, since it won't run on clang-12, etc. I'll change it to: ``` // UNSUPPORTED: clang-4, clang-5, clang-6, clang-7, clang-8, clang-9

[PATCH] D86782: [clang-format] Allow configuring list of macros that map to attributes

arichardson updated this revision to Diff 289180. arichardson added a comment. - Add test for config parsing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86782/new/ https://reviews.llvm.org/D86782 Files: clang/docs/ClangFormatStyleOptions.rst

[PATCH] D86926: FormatTest: Provide real line number in failure messages

arichardson added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:23 using clang::tooling::toReplacements; +using testing::internal::ScopedTrace; This is an internal class in the current gtest.h, but upstream has now included it in the publ

[PATCH] D86782: [clang-format] Allow configuring list of macros that map to attributes

arichardson updated this revision to Diff 289167. arichardson added a comment. - fix name of key in config file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86782/new/ https://reviews.llvm.org/D86782 Files: clang/docs/ClangFormatStyleOptions.rs

[PATCH] D86533: (Urgent!) [release][docs][analyzer] Add 11.0.0. release notes

ASDenysPetrov added inline comments. Comment at: clang/docs/ReleaseNotes.rst:453 + equal or known to be non-equal. + +- Added :ref:`on-demand parsing ` capability to Cross Translation I've added the patch "Reasoning about comparison expressions in RangeConstra

  1   2   >