aaron.ballman added inline comments.
================
Comment at: clang/lib/Sema/SemaStmt.cpp:578
+static std::pair<Stmt::Likelihood, const Attr *>
+getLikelihood(const Stmt *Stmt) {
+ if (const auto *AS = dyn_cast<AttributedStmt>(Stmt))
----------------
rsmith wrote:
> Sema doesn't care about any of this; can you move this code to CodeGen and
> remove the code that stores likelihood data in the AST?
FWIW, I asked for it to be moved out of CodeGen and into Sema because the
original implementation in CodeGen was doing a fair amount of work trying to
interrogate the AST for this information. Now that we've switched the design to
only be on the substatement of an if/else statement (rather than an arbitrary
statement), it may be that CodeGen is a better place for this again (and if so,
I'm sorry for the churn).
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D85091/new/
https://reviews.llvm.org/D85091
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
