probinson accepted this revision. probinson added a comment. This revision is now accepted and ready to land.
Couple of nits and LGTM. ================ Comment at: clang/lib/Driver/ToolChains/Clang.cpp:2078 - // Default to "generic" unless -march is present. + // Default to "generic" unless -march is present or targetting the PS4 std::string TuneCPU; ---------------- Missing final period. ================ Comment at: clang/test/Driver/ps4-cpu-defaults.cpp:7 // CHECK-NOT: exceptions +// CHECK-NOT: "-tune-cpu" "generic" ---------------- I'd rather see just `CHECK-NOT: "-tune-cpu"` (without the "generic") . There's no reason for any special tuning. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86965/new/ https://reviews.llvm.org/D86965 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
