[PATCH] D80753: [clang-tidy] remove duplicate fixes of alias checkers

njames93 added inline comments. Comment at: clang-tools-extra/test/clang-tidy/infrastructure/duplicate-fixes-of-alias-checkers.cpp:4-8 +template +class initializer_list { +public: + initializer_list() noexcept {} +}; This isn't needed for the test case and can

[PATCH] D80753: [clang-tidy] remove duplicate fixes of alias checkers

Daniel599 added inline comments. Comment at: clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.h:250 void removeIncompatibleErrors(); + void removeDuplicatedFixesOfAliasCheckers(); maybe I need to rename this method since now it's removing the errors

[PATCH] D80753: [clang-tidy] remove duplicate fixes of alias checkers

Daniel599 marked 2 inline comments as done. Daniel599 added inline comments. Comment at: clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.h:51 bool IsWarningAsError; + std::vector EnabledDiagnosticAliases; }; njames93 wrote: > Just ignore this, but d

[PATCH] D80753: [clang-tidy] remove duplicate fixes of alias checkers

Daniel599 updated this revision to Diff 267489. Daniel599 marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80753/new/ https://reviews.llvm.org/D80753 Files: clang-tools-extra/clang-tidy/ClangTidy.cpp clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsu

[PATCH] D80668: [Clang][Sanitizers] Expect test failure on {arm,thumb}v7

MaskRay added a comment. `arc` adds many unneeded tags from Phabricator. You can drop `Reviewers:` `Subscribers:` `Tags:` and the text `Summary:` with the following script: arcfilter () { arc amend git log -1 --pretty=%B | awk '/Reviewers:|Subscribers:/{p=1} /Reviewed By:|Differential

[PATCH] D80830: [clang-format] [PR46130] When editing a file with unbalance {} the namespace comment fixer can incorrectly comment the wrong closing brace

MaskRay added a comment. `arc` adds many unneeded tags from Phabricator. You can drop `Reviewers:` `Subscribers:` `Tags:` and the text `Summary:` with the following script: arcfilter () { arc amend git log -1 --pretty=%B | awk '/Reviewers:|Subscribers:/{p=1} /Reviewed By:|Differential

[PATCH] D77658: [analyzer] StdLibraryFunctionsChecker: Add sanity checks for constraints

MaskRay added a comment. `arc` adds many unneeded tags from Phabricator. You can drop `Reviewers:` `Subscribers:` `Tags:` and the text `Summary:` with the following script: arcfilter () { arc amend git log -1 --pretty=%B | awk '/Reviewers:|Subscribers:/{p=1} /Reviewed By:|Differential

[PATCH] D80631: [clang-tidy] RenamerClangTidyChecks ignore builtin and command line macros

MaskRay added a comment. `arc` adds many unneeded tags from Phabricator. You can drop `Reviewers:` `Subscribers:` `Tags:` and the text `Summary:` with the following script: arcfilter () { arc amend git log -1 --pretty=%B | awk '/Reviewers:|Subscribers:/{p=1} /Reviewed By:|Differential

[PATCH] D80222: Replace Clang's createRuntimeFunction with the definitions in OMPKinds.def

jdoerfert added a comment. Oh, sorry. You merged all of my patch, right? It was not ready and even now it is unclear if the representation change in my patch is good or not. I was trying to suggest you only take the InternalOMPIRBuilder stuff so you can avoid the static function, not all of my

[PATCH] D80222: Replace Clang's createRuntimeFunction with the definitions in OMPKinds.def

jhuber6 added a comment. In D80222#2065141 , @jdoerfert wrote: > Initialize the internal OpenMPIRbuilder (see my patch). Isn't it initialized on line 1063 in `CGOpenMPRuntime.cpp`? There weren't any conflicts listed there when I merged your patch so it

[PATCH] D80242: [Clang] implement -fno-eliminate-unused-debug-types

MaskRay added inline comments. Comment at: clang/include/clang/Basic/CodeGenOptions.def:291 ///< including them in the name). +CODEGENOPT(DebugUnusedTypes, 1, 0) /// < Whether to emit typedefs that may be +

[PATCH] D80883: [Driver] Add multiclass OptInFlag and OptOutFlag to simplify boolean option definition

MaskRay created this revision. MaskRay added reviewers: dblaikie, echristo, efriedma, joerg, rsmith. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D80883 Files: clang/include/clang/Driver/Options.td Index

[PATCH] D80222: Replace Clang's createRuntimeFunction with the definitions in OMPKinds.def

jdoerfert added a comment. Initialize the internal OpenMPIRbuilder (see my patch). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80222/new/ https://reviews.llvm.org/D80222 ___ cfe-commits mailing list

[PATCH] D80879: clang-tidy and clang-query wont crash with invalid command line options

njames93 updated this revision to Diff 267483. njames93 added a comment. Fix compile error Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80879/new/ https://reviews.llvm.org/D80879 Files: clang-tools-extra/clang-query/tool/ClangQuery.cpp clang-

[PATCH] D80753: [clang-tidy] remove duplicate fixes of alias checkers

njames93 added a comment. In D80753#2065067 , @Daniel599 wrote: > Thank you @njames93, I already started and took a bit different approach. > In case of a conflict, leaving it to clang-tidy itself didn't help as it > added both of the fix-its together re

[clang] 1b6d29e - [Driver] Fix BooleanFFlag identifiers to use 'f' 'fno_' prefixes instead of suffixes

Author: Fangrui Song Date: 2020-05-30T15:41:38-07:00 New Revision: 1b6d29e06b07e518025b6f06445ad3275d6f5684 URL: https://github.com/llvm/llvm-project/commit/1b6d29e06b07e518025b6f06445ad3275d6f5684 DIFF: https://github.com/llvm/llvm-project/commit/1b6d29e06b07e518025b6f06445ad3275d6f5684.diff

[PATCH] D80879: clang-tidy and clang-query wont crash with invalid command line options

njames93 created this revision. njames93 added reviewers: aaron.ballman, alexfh. Herald added a project: clang. Herald added a subscriber: cfe-commits. Motivated by clang-tidy crashed for unknown command line argument. Repository: rG LLVM Github M

[PATCH] D80880: [clang] [MinGW] Link kernel32 once after the last instance of msvcrt

mstorsjo created this revision. mstorsjo added reviewers: jacek, mati865, amccarth, rnk. Herald added a project: clang. The msvcrt library isn't a pure import library; it does contain regular object files with wrappers/fallbacks, and these can require linking against kernel32. This only makes a

[PATCH] D80753: [clang-tidy] remove duplicate fixes of alias checkers

Daniel599 updated this revision to Diff 267478. Daniel599 added a comment. Thank you @njames93, I already started and took a bit different approach. In case of a conflict, leaving it to clang-tidy itself didn't help as it added both of the fix-its together resulting in `= 0{};`, so I thought it w

[PATCH] D80631: [clang-tidy] RenamerClangTidyChecks ignore builtin and command line macros

This revision was automatically updated to reflect the committed changes. Closed by commit rG44119626dedf: [clang-tidy] RenamerClangTidyChecks ignore builtin and command line macros (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D80877: [clang-tidy] Added MacroDefiniton docs for readability-identifier-naming

njames93 created this revision. njames93 added reviewers: aaron.ballman, alexfh. Herald added subscribers: cfe-commits, xazax.hun. Herald added a project: clang. Updates the docs to include `MacroDefinition` documentation. The docs are still missing `ObjCIVar` however I don't have a clue about ho

[PATCH] D80876: [clang] Default to windows response files when running on windows

sbc100 created this revision. Herald added subscribers: cfe-commits, sunfish, aheejin. Herald added a project: clang. sbc100 added a reviewer: ruiu. This matches other tools such as llvm-ar, lld, etc. This consistency is useful when authoring downstream tools as it means they can always use windo

[clang-tools-extra] 4411962 - [clang-tidy] RenamerClangTidyChecks ignore builtin and command line macros

Author: Nathan James Date: 2020-05-30T20:49:33+01:00 New Revision: 44119626dedfebe245fe6ce26487949201299d38 URL: https://github.com/llvm/llvm-project/commit/44119626dedfebe245fe6ce26487949201299d38 DIFF: https://github.com/llvm/llvm-project/commit/44119626dedfebe245fe6ce26487949201299d38.diff

[PATCH] D80242: [Clang] implement -fno-eliminate-unused-debug-types

dblaikie added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:5565 +if (CGDebugInfo *DI = getModuleDebugInfo()) + if (getCodeGenOpts().DebugUnusedTypes) { +QualType QT = getContext().getTypedefType(cast(D)); nickdesaulniers wrot

[PATCH] D80836: Support GCC [[gnu::attributes]] in C2x mode

aaron.ballman added inline comments. Comment at: clang/utils/TableGen/ClangAttrEmitter.cpp:87 Ret.emplace_back("CXX11", std::string(Name), "gnu", true); + if (Spelling->getValueAsBit("AllowInC")) +Ret.emplace_back("C2x", std::string(Name), "gnu", true); --

[PATCH] D80873: [clang][cmake] Force CMAKE_LINKER for multistage build in case of BOOTSTRAP_LLVM_ENABLE_LLD and MSVC

krisb created this revision. krisb added reviewers: phosek, thakis, russell.gallop. Herald added subscribers: llvm-commits, cfe-commits, mgorny. Herald added projects: clang, LLVM. (I'm trying to get a bootstrap self-build on Windows, where lld is used as a linker for the stage2.) I assume BOOTST

[PATCH] D80836: Support GCC [[gnu::attributes]] in C2x mode

aaron.ballman updated this revision to Diff 267466. aaron.ballman marked an inline comment as done. aaron.ballman added a comment. Updated to remove the KnownToGCC tablegen bit. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80836/new/ https://reviews.llvm.org/D80836 Files: clang/incl

[PATCH] D77572: [clang-tidy] add new check readability-use-anyofallof

njames93 accepted this revision. njames93 added a comment. LGMT, just a few minor nits though. Comment at: clang-tools-extra/clang-tidy/readability/UseAnyOfAllOfCheck.cpp:15-16 +#include "clang/Frontend/CompilerInstance.h" +#include +#include + Fairly certai

[PATCH] D80237: [hip] Ensure pointer in struct argument has proper `addrspacecast`.

rjmccall added a comment. In D80237#2062991 , @arsenm wrote: > In D80237#2058108 , @rjmccall wrote: > > > In D80237#2055902 , @arsenm wrote: > > > > > In D80237#2051933

[PATCH] D77836: [Attribute] Fix noderef attribute false-negatives

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, but please wait for a few days in case @rsmith has further concerns. Comment at: clang/lib/Sema/SemaInit.cpp:8182 !ToPtrType->getPointeeTyp

[PATCH] D80753: [clang-tidy] remove duplicate fixes of alias checkers

njames93 added a comment. In D80753#2064857 , @Daniel599 wrote: > I have made the needed changes in order to detect a conflict in duplicated > fix-it of aliased checkers and also added a test for it. > Now I`ll try to work on combining aliased errors tog

[PATCH] D79437: [clang-tidy] Add fsetpos argument checker

aaron.ballman added a comment. btw, if you're interested in exploring a static analyzer solution for this, here's a recent review of an analyzer feature that's in the same general problem space: https://reviews.llvm.org/D80018 Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION h

[PATCH] D80631: [clang-tidy] RenamerClangTidyChecks ignore builtin and command line macros

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you for this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80631/new/ https://reviews.llvm.org/D80631

[PATCH] D77572: [clang-tidy] add new check readability-use-anyofallof

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, though please wait a bit for @njames93 to speak up if they still have concerns. Comment at: clang-tools-extra/clang-tidy/readability/UseAnyOfAllOfCheck.c

[PATCH] D54408: [ASTMatchers] Add matchers available through casting to derived

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. In D54408#2056251 , @steveire wrote: > @aaron.ballman I think we agreed in Belfast in November (after the most > recent comment) to get

[PATCH] D71199: [clang-tidy] New check cppcoreguidelines-prefer-member-initializer

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/PreferMemberInitializerCheck.cpp:106-107 +void PreferMemberInitializerCheck::registerMatchers(MatchFinder *Finder) { + if (!getLangOpts().CPlusPlus) +return; + T

[PATCH] D79437: [clang-tidy] Add fsetpos argument checker

aaron.ballman added a comment. In D79437#2052704 , @DerWaschbar wrote: > In D79437#2052109 , @aaron.ballman > wrote: > > > Have you considered writing a static analyzer check so you can do data and > > control flo

[PATCH] D79118: Implement _ExtInt ABI for all ABIs in Clang, enable type for ABIs

erichkeane closed this revision. erichkeane added a comment. Herald added a subscriber: sstefan1. Yikes, I apparently misspelled "Revision" as "revisions"!. https://github.com/llvm/llvm-project/commit/8a1c999c9b0817d4de778a62965b4af86416e4b7 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D80753: [clang-tidy] remove duplicate fixes of alias checkers

Daniel599 updated this revision to Diff 267455. Daniel599 added a comment. Herald added subscribers: llvm-commits, dexonsmith. Herald added a project: LLVM. I have made the needed changes in order to detect a conflict in duplicated fix-it of aliased checkers and also added a test for it. Now I`ll

[PATCH] D60620: [HIP] Support target id by --offload-arch

yaxunl added a comment. > // ... > // RUN: -x hip --offload-arch=gfx908 \ > // RUN: --offload-arch=gfx908:sramecc+:xnack+ > Does this mean that HIP will create two compilation passes -- one for gfx908 > and one for gfx908:sramecc+:xnack+ ? > Or does it mean that the first line is ignored if y

[PATCH] D77066: [analyzer] ApiModeling: Add buffer size arg constraint

Szelethus added a comment. In D77066#2062849 , @martong wrote: > - Remove SValBuilder param I failed to emphasize that the point was to remove the new `CheckerContext` parameters :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D80830: [clang-format] [PR46130] When editing a file with unbalance {} the namespace comment fixer can incorrectly comment the wrong closing brace

This revision was automatically updated to reflect the committed changes. Closed by commit rG50bdd6073113: [clang-format] [PR46130] When editing a file with unbalance {} the namespace… (authored by MyDeveloperDay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[PATCH] D80830: [clang-format] [PR46130] When editing a file with unbalance {} the namespace comment fixer can incorrectly comment the wrong closing brace

MyDeveloperDay added a comment. We don't really have any performance tests, but the following shows some analysis, all builds are release build: - clang-format-ns is built with this change (compiled with VS2017) - clang-format is without (compiled with VS2017) - c:/Program\ Files/LLVM/bin/clang-

[PATCH] D80830: [clang-format] [PR46130] When editing a file with unbalance {} the namespace comment fixer can incorrectly comment the wrong closing brace

curdeius added a comment. OK, great. Thanks for all the information. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80830/new/ https://reviews.llvm.org/D80830 ___ cfe-commits mailing list cfe-commits@li

[clang] 50bdd60 - [clang-format] [PR46130] When editing a file with unbalance {} the namespace comment fixer can incorrectly comment the wrong closing brace

Author: mydeveloperday Date: 2020-05-30T13:15:27+01:00 New Revision: 50bdd60731130dbde81fa477ba8916c58039d73a URL: https://github.com/llvm/llvm-project/commit/50bdd60731130dbde81fa477ba8916c58039d73a DIFF: https://github.com/llvm/llvm-project/commit/50bdd60731130dbde81fa477ba8916c58039d73a.diff

[PATCH] D77491: [Sema] Introduce BuiltinAttr, per-declaration builtin-ness

tambre updated this revision to Diff 267450. tambre marked 4 inline comments as done. tambre added a comment. Fix some intrinsics not being marked as builtin due to being static in the headers. Make some code easier to read, fix test for sigsetjmp in Sema/implicit-builtin-decl.c to reflect the o

[PATCH] D77491: [Sema] Introduce BuiltinAttr, per-declaration builtin-ness

tambre marked an inline comment as done. tambre added inline comments. Comment at: clang/lib/AST/Decl.cpp:3169-3175 } else { -if (!getIdentifier()) +const auto *Attr = getAttr(); + +if (!Attr) return 0; +BuiltinID = Attr->getID(); aaro

[PATCH] D79800: [Sema] Implement DR2233

tambre abandoned this revision. tambre added a comment. In D79800#2058985 , @rsmith wrote: > Unfortunately, I think this approach basically can't work, because we need to > consider inheriting default arguments from a previous (or subsequent!) > declarat

[PATCH] D80829: [OpenMP][SYCL] Do not crash on attempt to diagnose unsupported type use

This revision was automatically updated to reflect the committed changes. Closed by commit rGbd85b7d66887: [OpenMP][SYCL] Do not crash on attempt to diagnose unsupported type use (authored by Fznamznon, committed by bader). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[clang] bd85b7d - [OpenMP][SYCL] Do not crash on attempt to diagnose unsupported type use

Author: Mariya Podchishchaeva Date: 2020-05-30T12:27:58+03:00 New Revision: bd85b7d6688725e854a694f9f3e8baa6a3077a4a URL: https://github.com/llvm/llvm-project/commit/bd85b7d6688725e854a694f9f3e8baa6a3077a4a DIFF: https://github.com/llvm/llvm-project/commit/bd85b7d6688725e854a694f9f3e8baa6a3077a

[PATCH] D80802: [RISCV] Upgrade RVV MC to v0.9.

HsiangKai updated this revision to Diff 267447. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80802/new/ https://reviews.llvm.org/D80802 Files: clang/lib/Driver/ToolChains/Arch/RISCV.cpp clang/test/Driver/riscv-arch.c llvm/lib/Target/RISCV/Asm