MaskRay added inline comments.
================ Comment at: clang/include/clang/Basic/CodeGenOptions.def:291 ///< including them in the name). +CODEGENOPT(DebugUnusedTypes, 1, 0) /// < Whether to emit typedefs that may be + /// < unused. ---------------- This flag is now more than "typedefs" ================ Comment at: clang/include/clang/Driver/Options.td:3346 defm reorder_blocks : BooleanFFlag<"reorder-blocks">, Group<clang_ignored_gcc_optimization_f_Group>; -defm eliminate_unused_debug_types : BooleanFFlag<"eliminate-unused-debug-types">, Group<clang_ignored_f_Group>; +defm eliminate_unused_debug_types : + BooleanFFlag<"eliminate-unused-debug-types">, Group<f_Group>, ---------------- This group is for ignored options. Add this near other f options. I fixed the FIXME about BooleanFFlag with TableGen special identifier `NAME`. The way we define boolean options still look verbose to me, so I just created D80883. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80242/new/ https://reviews.llvm.org/D80242 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits