tambre abandoned this revision.
tambre added a comment.

In D79800#2058985 <https://reviews.llvm.org/D79800#2058985>, @rsmith wrote:

> Unfortunately, I think this approach basically can't work, because we need to 
> consider inheriting default arguments from a previous (or subsequent!) 
> declaration before dropping default arguments preceding a pack. I think we 
> will instead need to detect this situation when issuing the diagnostic for a 
> parameter with a default argument followed by a parameter without one, and 
> will need to make sure that all the parts of Clang that look at default 
> arguments can cope with them being discontiguous.


Thanks for reviewing!
Abandoning, as I lack the motivation to implement the proper solution you laid 
out.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79800/new/

https://reviews.llvm.org/D79800



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
  • [PATCH] D79800: [... John McCall via Phabricator via cfe-commits
    • [PATCH] D798... Richard Smith - zygoloid via Phabricator via cfe-commits
    • [PATCH] D798... Raul Tambre via Phabricator via cfe-commits

Reply via email to