[PATCH] D74813: [RFC] Add hash of block contents to function block names

alexbdv marked 6 inline comments as done. alexbdv added a comment. For tests - the existing block tests should be enough, just need to update them. I updated a few - want to make sure changes are final before updating all the tests to not have to update tests again. Comment at

[PATCH] D50078: clang-format: support aligned nested conditionals formatting

Typz marked an inline comment as done. Typz added a comment. Typz added inline comments. Comment at: clang/lib/Format/WhitespaceManager.h:163 +// it does not increase the indent for "chained" conditionals. +int ConditionalsLevel; + This field is not initi

[PATCH] D62368: Add support for Hygon Dhyana processor

fanjinke added a comment. Hi Cryptoad, Thank you so much for your comment. I will divide it into two patches according to your suggestion. Best regards. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62368/new/ https://reviews.llvm.org/D62368

[PATCH] D77621: Change BitcodeWriter buffer to std::vector instead of SmallVector.

dexonsmith added a comment. In D77621#1995673 , @browneee wrote: > Thanks for the revert explanation and notes, nikic. > > @dexonsmith what is your current thinking on going back to the original > std::vector approach? SmallVector has only been limited

[PATCH] D74813: [RFC] Add hash of block contents to function block names

alexbdv updated this revision to Diff 259487. Herald added a reviewer: jhenderson. Herald added a project: libc++abi. Herald added a subscriber: libcxx-commits. Herald added a reviewer: libc++abi. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74813/ne

[PATCH] D50078: clang-format: support aligned nested conditionals formatting

Typz added a comment. In D50078#1998398 , @dyung wrote: > Hi, this change that you submitted in commit > 5daa25fd7a184524759b6ad065a8bd7e95aa149a > seems > to be causing the test "Cla

[PATCH] D75917: Expose llvm fence instruction as clang intrinsic

saiislam updated this revision to Diff 259485. saiislam added a comment. Removed documentation from clang doc. Squashed all changes into a single commit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75917/new/ https://reviews.llvm.org/D75917 File

[PATCH] D76451: [clangd] Enable textual fallback for go-to-definition on dependent names

nridge added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:569 ASTResults = locateASTReferent(NearbyIdent->location(), NearbyIdent, AST, - *MainFilePath, Index); + *MainFilePath, Inde

[PATCH] D76451: [clangd] Enable textual fallback for go-to-definition on dependent names

nridge updated this revision to Diff 259483. nridge marked 7 inline comments as done. nridge added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76451/new/ https://reviews.llvm.org/D76451 Files: clang-tools-ext

[PATCH] D77621: ADT: SmallVector size & capacity use word-size integers when elements are small.

browneee updated this revision to Diff 259480. browneee added a comment. Switch approach back to std::vector change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77621/new/ https://reviews.llvm.org/D77621 Files: clang-tools-extra/clang-doc/Seri

[PATCH] D78693: Make "#pragma clang attribute" support uninitialized attribute.

jfb added a comment. Looks pretty good to me. Not my areas of expertise so I’d like to have others look too. Thanks for doing this! Comment at: clang/test/Parser/pragma-attribute.cpp:190 +#pragma clang attribute pop +#pragma clang attribute push([[clang::uninitialized]], apply

[PATCH] D78694: [clang-format] Fix lambda with ellipsis in return type

johnchen902 created this revision. johnchen902 added a project: clang-format. Herald added a project: clang. Herald added a subscriber: cfe-commits. johnchen902 retitled this revision from "[Format] Fix lambda with ellipsis in return type" to "[clang-format] Fix lambda with ellipsis in return type

[PATCH] D78693: Make "#pragma clang attribute" support uninitialized attribute.

jcai19 created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When using -ftrivial-auto-var-init=* options to initiate automatic variables in a file, to disable initialization on some variables, currently we have to manually annotate the variables with uninit

[PATCH] D50078: clang-format: support aligned nested conditionals formatting

dyung added a comment. Hi, this change that you submitted in commit 5daa25fd7a184524759b6ad065a8bd7e95aa149a seems to be causing the test "Clang-Unit :: Format/./FormatTests.exe/FormatTest.ConfigurableUseOfTab" to randomly f

[PATCH] D77233: [NFC] Refactoring PropertyAttributeKind for ObjCPropertyDecl and ObjCDeclSpec.

This revision was automatically updated to reflect the committed changes. Closed by commit rG2aa044ed088a: [NFC] Refactoring PropertyAttributeKind for ObjCPropertyDecl and ObjCDeclSpec. (authored by plotfi). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D75917: Expose llvm fence instruction as clang intrinsic

sameerds added a comment. Can you please submit a squashed single commit for review against the master branch? All the recent commits seem to be relative to previous commits, and I am having trouble looking at the change as a whole. The commit description needs some fixes: 1. Remove use of Tit

[PATCH] D77954: [CUDA][HIP] Fix host/device based overload resolution

yaxunl updated this revision to Diff 259458. yaxunl added a comment. Revised to let host/device take precedence over multiversion, as John suggested. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77954/new/ https://reviews.llvm.org/D77954 Files: clang/lib/Sema/SemaOverload.cpp clan

[PATCH] D78655: [HIP] Let lambda be host device by default

yaxunl updated this revision to Diff 259452. yaxunl marked 2 inline comments as done. yaxunl added a comment. Add a negative test for lambda kernel. Add more checks to codegen test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78655/new/ https://reviews.llvm.org/D78655 Files: clang/

[PATCH] D72893: [NewPassManager] Add assertions when getting statefull cached analysis.

asbirlea updated this revision to Diff 259450. asbirlea marked 8 inline comments as done. asbirlea added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72893/new/ https://reviews.llvm.org/D72893 Files: clang/test/Code

[PATCH] D78655: [HIP] Let lambda be host device by default

yaxunl updated this revision to Diff 259453. yaxunl added a comment. clean up test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78655/new/ https://reviews.llvm.org/D78655 Files: clang/lib/Sema/SemaCUDA.cpp clang/test/CodeGenCUDA/lambda.cu clang/test/SemaCUDA/lambda.cu Index:

[PATCH] D78659: Add nomerge function attribute to supress tail merge optimization in simplifyCFG

zequanwu added a comment. In D78659#1997528 , @lebedev.ri wrote: > 1. Tests missing > 2. Why isn't `noinline` sufficient, why a whole new attribue? 1. Test added. 2. We want to avoid merging multiple call sites of same function, but `noinline` cannot

[PATCH] D72893: [NewPassManager] Add assertions when getting statefull cached analysis.

asbirlea added inline comments. Comment at: llvm/include/llvm/Analysis/CGSCCPassManager.h:856-858 +auto *ResultFAMCP = +&CGAM.getResult(*C, CG); +ResultFAMCP->updateFAM(FAM); chandlerc wrote: > Check that it doesn't hit an assert failu

[PATCH] D78659: Add nomerge function attribute to supress tail merge optimization in simplifyCFG

zequanwu updated this revision to Diff 259455. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78659/new/ https://reviews.llvm.org/D78659 Files: clang/include/clang/Basic/Attr.td clang/include/clang/Basic/AttrDocs.td clang/lib/CodeGen/CGCall.cpp clang/test/CodeGen/attr-nomerge.c

[PATCH] D78655: [HIP] Let lambda be host device by default

yaxunl marked 4 inline comments as done. yaxunl added inline comments. Comment at: clang/lib/Sema/SemaCUDA.cpp:722 + if (getLangOpts().HIP) { +Method->addAttr(CUDADeviceAttr::CreateImplicit(Context)); +Method->addAttr(CUDAHostAttr::CreateImplicit(Context)); -

[clang] 391c15f - [NFC] Correct typo in comment after D76038

Author: Aaron Puchert Date: 2020-04-23T02:26:02+02:00 New Revision: 391c15fccdc6b0d33bb651a298c07216e532904e URL: https://github.com/llvm/llvm-project/commit/391c15fccdc6b0d33bb651a298c07216e532904e DIFF: https://github.com/llvm/llvm-project/commit/391c15fccdc6b0d33bb651a298c07216e532904e.diff

[PATCH] D78687: [Fuchsia] Build compiler-rt builtins for 32-bit x86

mcgrathr accepted this revision. mcgrathr added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78687/new/ https://reviews.llvm.org/D78687 ___

[PATCH] D67112: [Sema] Introduce function reference conversion, NFC

aaronpuchert added a comment. @rsmith, what do you think about this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67112/new/ https://reviews.llvm.org/D67112 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D78687: [Fuchsia] Build compiler-rt builtins for 32-bit x86

phosek created this revision. phosek added a reviewer: mcgrathr. Herald added subscribers: cfe-commits, s.egerton, simoncook, mgorny, dberris. Herald added a project: clang. While we don't support 32-bit architectures in Fuchsia, these are needed in the early boot phase on x86, so we build just th

[PATCH] D78192: Support compiler extensions as a normal component

Meinersbur added a comment. I looks to work fine under my Windows and Linux configuration. One Point though: llvm-config --libs Extensions returns [...] -lPollyPPCG -lPollyISL -lPolly I think `-lPolly` must be first to work with bfd.ld order semantics. See https://stackoverflow.com/questi

[PATCH] D78661: [Sema] Split off warn_impcast_integer_float_precision_constant into -Wimplicit-const-int-float-conversion

nickdesaulniers accepted this revision. nickdesaulniers added a comment. This revision is now accepted and ready to land. Thanks for the helping get the patch upstreamed! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78661/new/ https://reviews.llvm

[PATCH] D78030: [TimeProfiler] Emit clock synchronization point

This revision was automatically updated to reflect the committed changes. Closed by commit rG2899103108d3: [TimeProfiler] Emit clock synchronization point (authored by broadwaylamb). Changed prior to commit: https://reviews.llvm.org/D78030?vs=258061&id=259413#toc Repository: rG LLVM Github M

[PATCH] D78252: [AArch64] FMLA/FMLS patterns improvement.

ab added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64InstrFormats.td:8058 + def : Pat<(v8f16 (OpNode (v8f16 V128:$Rd), (v8f16 V128:$Rn), + (AArch64duplane16 (v8f16 V128:$Rm), + VectorIndexH:$idx)

[PATCH] D78677: [SveEmitter] Add builtins for gather prefetches

sdesmalen created this revision. sdesmalen added reviewers: SjoerdMeijer, efriedma. Herald added a subscriber: tschuett. Herald added a project: clang. sdesmalen added a parent revision: D78674: [SveEmitter] Add builtins for contiguous prefetches. Repository: rG LLVM Github Monorepo https://re

[PATCH] D78674: [SveEmitter] Add builtins for contiguous prefetches

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM with a couple minor comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:7727 + Value *Offset = Ops.size() > 3 ? Ops[2] : Builder.getInt32(0); + BasePtr = Builder

[PATCH] D78673: [SveEmitter] Use llvm.aarch64.sve.ld1/st1 for contiguous load/store builtins

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78673/new/ https://reviews.llvm.org/D78673 ___

[PATCH] D78642: [clang-format] Handle C# property accessors when parsing lines

jbcoe updated this revision to Diff 259409. jbcoe added a comment. Format patch CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78642/new/ https://reviews.llvm.org/D78642 Files: clang/lib/Format/UnwrappedLineFormatter.cpp clang/lib/Format/UnwrappedLineParser.cpp clang/lib/Format/Un

[clang] 2899103 - [TimeProfiler] Emit clock synchronization point

Author: Sergej Jaskiewicz Date: 2020-04-23T01:09:31+03:00 New Revision: 2899103108d38215af8aae377cd0e54794278209 URL: https://github.com/llvm/llvm-project/commit/2899103108d38215af8aae377cd0e54794278209 DIFF: https://github.com/llvm/llvm-project/commit/2899103108d38215af8aae377cd0e54794278209.d

[PATCH] D78674: [SveEmitter] Add builtins for contiguous prefetches

sdesmalen updated this revision to Diff 259403. sdesmalen added a comment. - Removed unrelated whitespace changes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78674/new/ https://reviews.llvm.org/D78674 Files: clang/include/clang/Basic/TargetBuiltins.h clang/include/clang/Basic/ar

[PATCH] D78661: [Sema] Split off warn_impcast_integer_float_precision_constant into -Wimplicit-const-int-float-conversion

MaskRay updated this revision to Diff 259398. MaskRay marked an inline comment as done. MaskRay added a comment. Change RUN lines Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78661/new/ https://reviews.llvm.org/D78661 Files: clang/include/clang

[PATCH] D78027: [TimeProfiler] Emit real process ID and thread names

This revision was automatically updated to reflect the committed changes. Closed by commit rGa5bf02815d8b: [TimeProfiler] Emit real process ID and thread names (authored by broadwaylamb). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78027/new/ http

[PATCH] D78674: [SveEmitter] Add builtins for contiguous prefetches

sdesmalen created this revision. sdesmalen added reviewers: SjoerdMeijer, efriedma, ctetreau. Herald added a subscriber: tschuett. Herald added a project: clang. sdesmalen updated this revision to Diff 259403. sdesmalen added a comment. - Removed unrelated whitespace changes. This patch also add

[clang] a5bf028 - [TimeProfiler] Emit real process ID and thread names

Author: Sergej Jaskiewicz Date: 2020-04-23T00:12:51+03:00 New Revision: a5bf02815d8b8d1a76682a63281561f076968dae URL: https://github.com/llvm/llvm-project/commit/a5bf02815d8b8d1a76682a63281561f076968dae DIFF: https://github.com/llvm/llvm-project/commit/a5bf02815d8b8d1a76682a63281561f076968dae.d

[PATCH] D78661: [Sema] Split off warn_impcast_integer_float_precision_constant into -Wimplicit-const-int-float-conversion

nickdesaulniers added inline comments. Comment at: clang/test/Sema/implicit-int-float-conversion.c:3 +// RUN: %clang_cc1 %s -verify -Wimplicit-const-int-float-conversion +// RUN: %clang_cc1 %s -DNONCONST=1 -verify -Wimplicit-int-float-conversion If I understand

[PATCH] D76038: PR45000: Let Sema::SubstParmVarDecl handle default args of lambdas in initializers

This revision was automatically updated to reflect the committed changes. Closed by commit rGf43859a099fa: PR45000: Let Sema::SubstParmVarDecl handle default args of lambdas in… (authored by aaronpuchert). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D77595: [SveEmitter] Add builtins for svwhile

This revision was automatically updated to reflect the committed changes. Closed by commit rG1559485e6002: [SveEmitter] Add builtins for svwhile (authored by sdesmalen). Changed prior to commit: https://reviews.llvm.org/D77595?vs=257829&id=259392#toc Repository: rG LLVM Github Monorepo CHAN

[PATCH] D78238: [SveEmitter] Add builtins for svwhilerw/svwhilewr

This revision was automatically updated to reflect the committed changes. Closed by commit rG2d1baf606ab4: [SveEmitter] Add builtins for svwhilerw/svwhilewr (authored by sdesmalen). Changed prior to commit: https://reviews.llvm.org/D78238?vs=257822&id=259394#toc Repository: rG LLVM Github Mo

[PATCH] D77233: [NFC] Refactoring PropertyAttributeKind for ObjCPropertyDecl and ObjCDeclSpec.

plotfi added a comment. In D77233#1997294 , @erik.pilkington wrote: > LGTM, again :) Thanks for cleaning this up. Thank you Erik! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77233/new/ https://reviews.

[clang] 2d1baf6 - [SveEmitter] Add builtins for svwhilerw/svwhilewr

Author: Sander de Smalen Date: 2020-04-22T21:49:18+01:00 New Revision: 2d1baf606ab46daf9a322e5751d364c55c86deca URL: https://github.com/llvm/llvm-project/commit/2d1baf606ab46daf9a322e5751d364c55c86deca DIFF: https://github.com/llvm/llvm-project/commit/2d1baf606ab46daf9a322e5751d364c55c86deca.di

[clang] 1559485 - [SveEmitter] Add builtins for svwhile

Author: Sander de Smalen Date: 2020-04-22T21:47:47+01:00 New Revision: 1559485e600242343cb21c7ffbf345172008cd59 URL: https://github.com/llvm/llvm-project/commit/1559485e600242343cb21c7ffbf345172008cd59 DIFF: https://github.com/llvm/llvm-project/commit/1559485e600242343cb21c7ffbf345172008cd59.di

[clang] f43859a - PR45000: Let Sema::SubstParmVarDecl handle default args of lambdas in initializers

Author: Aaron Puchert Date: 2020-04-22T22:37:21+02:00 New Revision: f43859a099fa3587123717be941fa63ba8d0d4f2 URL: https://github.com/llvm/llvm-project/commit/f43859a099fa3587123717be941fa63ba8d0d4f2 DIFF: https://github.com/llvm/llvm-project/commit/f43859a099fa3587123717be941fa63ba8d0d4f2.diff

[PATCH] D78000: [ASTImporter] Fix handling of not defined FromRecord in ImportContext(...)

a_sidorin accepted this revision. a_sidorin added a comment. Hello Shafik! The patch looks good, I only have a few stylish nits. Comment at: clang/unittests/AST/ASTImporterTest.cpp:5964 + new SourceWithCompletedTagList(CompletedTags); + clang::ASTContext &context = FromTU

[PATCH] D78192: Support compiler extensions as a normal component

Meinersbur added a comment. Is this ready to try out? In D78192#1996859 , @serge-sans-paille wrote: > Note that this should solve in an elegant (?) way the multiple link errors > found when linking clang with LLVM_DYLIB. Aren't these fixed already?

[PATCH] D78658: [clang][Frontend] Add missing error handling

LemonBoy updated this revision to Diff 259374. LemonBoy added a comment. Fix a C&P error in the attached test case. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78658/new/ https://reviews.llvm.org/D78658 Files: clang/lib/Frontend/ASTUnit.cpp clang/unittests/Frontend/ASTUnitTest.cp

[PATCH] D78638: [analyzer] Consider array subscripts to be interesting lvalues

Szelethus accepted this revision. Szelethus added a comment. This revision is now accepted and ready to land. Everything's clear! Nice detective work! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78638/new/ https://reviews.llvm.org/D78638 _

[PATCH] D78661: [Sema] Split off warn_impcast_integer_float_precision_constant into -Wimplicit-const-int-float-conversion

MaskRay updated this revision to Diff 259370. MaskRay added a comment. Fixed a typo noticed by @bmoses Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78661/new/ https://reviews.llvm.org/D78661 Files: clang/include/clang/Basic/DiagnosticGroups.td

[PATCH] D73845: [Gnu toolchain] Move GCC multilib/multiarch paths support from Linux to Gnu

sthibaul added a comment. ping @phosek ? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73845/new/ https://reviews.llvm.org/D73845 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[PATCH] D72841: Add support for pragma float_control, to control precision and exception behavior at the source level

mibintc marked 2 inline comments as done. mibintc added a comment. added a couple inline explanatory comments Comment at: clang/include/clang/Basic/LangOptions.h:307 + bool denormalIsIEEE = false; + I added this boolean as part of validating the correctness

[PATCH] D77374: Fix -fsanitize=array-bounds with comma operator

rsmith added inline comments. Comment at: clang/lib/CodeGen/CGExpr.cpp:882-887 + while (const BinaryOperator *BO = dyn_cast(E)) { +if (!BO->isCommaOp()) + break; +E = BO->getRHS(); +E = E->IgnoreParens(); + } vitalybuka wrote: > rsmith wrote: >

[PATCH] D78638: [analyzer] Consider array subscripts to be interesting lvalues

vsavchenko added a comment. In D78638#1997576 , @Szelethus wrote: > How come rGe20b388e2f923bfc98f63a13fea9fc19aeaec425 > doesn't > solve this? Or, rather, how come it even worked if t

[PATCH] D78649: [clang] Make sure argument expansion locations are correct in presence of predefined buffer

This revision was automatically updated to reflect the committed changes. kadircet marked an inline comment as done. Closed by commit rG411a254af3ff: [clang] Make sure argument expansion locations are correct in presence of… (authored by kadircet). Changed prior to commit: https://reviews.llvm.

[PATCH] D78626: [clangd] Fix a crash for accessing a null template decl returned by findExplicitReferences.

This revision was automatically updated to reflect the committed changes. Closed by commit rG7d1ee639cb9e: [clangd] Fix a crash for accessing a null template decl returned by… (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78626/

[PATCH] D78521: [clangd] Extend dexp to support remote index

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/index/remote/Index.proto:37 +message FuzzyFindReply { + // FIXME(kirillbobyrev): Convert to Symbol. + repeated string symbols = 1; sammccall wrote: > kbobyrev wrote: > > sammccall wrote: > > >

[PATCH] D78638: [analyzer] Consider array subscripts to be interesting lvalues

Szelethus added a comment. How come rGe20b388e2f923bfc98f63a13fea9fc19aeaec425 doesn't solve this? Or, rather, how come it even worked if this patch is needed? Is the index being a global variable the issue? The change looks

[PATCH] D78521: [clangd] Extend dexp to support remote index

kbobyrev updated this revision to Diff 259356. kbobyrev marked 10 inline comments as done. kbobyrev added a comment. Just a checkpoint: resolve several comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78521/new/ https://reviews.llvm.org/D785

[PATCH] D78661: [Sema] Split off warn_impcast_integer_float_precision_constant into -Wimplicit-const-int-float-conversion

MaskRay created this revision. MaskRay added reviewers: aaron.ballman, jfb, nickdesaulniers, rsmith, scanon, xbolva00, ziangwan. Herald added subscribers: cfe-commits, dexonsmith. Herald added a project: clang. Currently, both `warn_impcast_integer_float_precision_constant` and `warn_impcast_inte

[PATCH] D78565: [clang][doc] Clang ARM CPU command line argument reference

SjoerdMeijer added a comment. To be completely open about this, I had an offline chat with @psmith and @kristof.beyls about this. The reasoning is that this is probably related to my relatively poor choice of the 2 first cores that I describe here. They are microcontrollers, and Clang/LLVM do

[PATCH] D78659: Add nomerge function attribute to supress tail merge optimization in simplifyCFG

lebedev.ri added a comment. 1. Tests missing 2. Why isn't `noinline` sufficient, why a whole new attribue? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78659/new/ https://reviews.llvm.org/D78659 ___ c

[PATCH] D78659: Add nomerge function attribute to supress tail merge optimization in simplifyCFG

lebedev.ri added a subscriber: llvm-commits. lebedev.ri added a comment. + llvm-commits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78659/new/ https://reviews.llvm.org/D78659 ___ cfe-commits mailing

[clang] 411a254 - [clang] Make sure argument expansion locations are correct in presence of predefined buffer

Author: Kadir Cetinkaya Date: 2020-04-22T21:01:52+02:00 New Revision: 411a254af3ff5dd05e6c522cc7bccdf043967070 URL: https://github.com/llvm/llvm-project/commit/411a254af3ff5dd05e6c522cc7bccdf043967070 DIFF: https://github.com/llvm/llvm-project/commit/411a254af3ff5dd05e6c522cc7bccdf043967070.dif

[clang-tools-extra] 7d1ee63 - [clangd] Fix a crash for accessing a null template decl returned by findExplicitReferences.

Author: Haojian Wu Date: 2020-04-22T21:00:20+02:00 New Revision: 7d1ee639cb9efea364bec90afe4d1161ec624a7f URL: https://github.com/llvm/llvm-project/commit/7d1ee639cb9efea364bec90afe4d1161ec624a7f DIFF: https://github.com/llvm/llvm-project/commit/7d1ee639cb9efea364bec90afe4d1161ec624a7f.diff LO

[PATCH] D78659: Add nomerge function attribute to supress tail merge optimization in simplifyCFG

zequanwu created this revision. zequanwu added reviewers: asbirlea, rnk. zequanwu added projects: LLVM, clang. Herald added subscribers: cfe-commits, hiraditya. We want to add a way to avoid tail calls to noreturn function from being merged. This patch add nomerge to disable the optimization in

[PATCH] D77641: [analyzer] StdLibraryFunctionsChecker: Associate summaries to FunctionDecls

martong added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77641/new/ https://reviews.llvm.org/D77641 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D78655: [HIP] Let lambda be host device by default

tra added a reviewer: rsmith. tra added a subscriber: rsmith. tra added a comment. Summoning @rsmith as I'm sure that there are interesting corner cases in lambda handling that we didn't consider. Making lambdas implicitly HD will make it easier to write the code which can't be instantiated on

[PATCH] D78626: [clangd] Fix a crash for accessing a null template decl returned by findExplicitReferences.

hokein marked an inline comment as done. hokein added inline comments. Comment at: clang-tools-extra/clangd/unittests/FindTargetTests.cpp:1293 +struct Base {}; +namespace foo { +template kadircet wrote: > is namespace required? yes, the t

[PATCH] D78660: [SemaObjC] Add a warning for dictionary literals with duplicate keys

erik.pilkington created this revision. erik.pilkington added reviewers: rjmccall, bendjones. Herald added subscribers: ributzka, dexonsmith, jkorous. Duplicate keys in a literal break NSDictionary's invariants. Fixes rdar://50454461 Repository: rC Clang https://reviews.llvm.org/D78660 Files

[PATCH] D78658: [clang][Frontend] Add missing error handling

LemonBoy created this revision. LemonBoy added a reviewer: rsmith. LemonBoy added a project: clang. Herald added a subscriber: cfe-commits. Some early errors during the ASTUnit creation were not transferred to the `FailedParseDiagnostic` so when the code in `LoadFromCommandLine` swaps its conten

[PATCH] D78643: [OpenMP] Fix false error report of array subscription for templated indexes.

h-joo updated this revision to Diff 259343. h-joo added a comment. In D78643#1997405 , @ABataev wrote: > In D78643#1997344 , @jdoerfert wrote: > > > This looks reasonable to me. @ABataev WDYT? > > > I would add a po

[PATCH] D62368: Add support for Hygon Dhyana processor

cryptoad added a comment. Hey, `clang/lib/Headers/cpuid.h` would have to be in its own CL that would have to be sent separately from the Scudo one. It would have to be reviewed by clang people and likely some tests added. Once this is done and landed, then the Scudo part can happen. Thanks!

[clang] 1b3f1f4 - Rename warning identifiers from cxx2a to cxx20; NFC.

Author: Aaron Ballman Date: 2020-04-22T14:31:13-04:00 New Revision: 1b3f1f443670f202a0490ccf9d1f7b28e949bfe7 URL: https://github.com/llvm/llvm-project/commit/1b3f1f443670f202a0490ccf9d1f7b28e949bfe7 DIFF: https://github.com/llvm/llvm-project/commit/1b3f1f443670f202a0490ccf9d1f7b28e949bfe7.diff

[PATCH] D78638: [analyzer] Consider array subscripts to be interesting lvalues

vsavchenko updated this revision to Diff 259341. vsavchenko added a comment. Add more clarity on what we test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78638/new/ https://reviews.llvm.org/D78638 Files: clang/lib/StaticAnalyzer/Core/ExplodedG

[PATCH] D76801: [AST] Print a> without extra spaces in C++11 or later.

dblaikie added a comment. In D76801#1996376 , @labath wrote: > In D76801#1995058 , @dblaikie wrote: > > > > It becomes a gdb-index problem because with an index the debugger will do > > > a (hashed?) string lookup

[PATCH] D78649: [clang] Make sure argument expansion locations are correct in presence of predefined buffer

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Basic/SourceManager.cpp:1816 + } else if (IncludeLoc.isValid()) { +// If file wasn't included from FID, there is no more files/ma

[PATCH] D78643: [OpenMP] Fix false error report of array subscription for templated indexes.

ABataev added a comment. In D78643#1997344 , @jdoerfert wrote: > This looks reasonable to me. @ABataev WDYT? I would add a positive test with -ast-print Comment at: clang/lib/Sema/SemaOpenMP.cpp:15913 +if (auto *ASE = dyn_cast

[PATCH] D78638: [analyzer] Consider array subscripts to be interesting lvalues

vsavchenko marked an inline comment as done. vsavchenko added inline comments. Comment at: clang/test/Analysis/PR53280338.cpp:1 +// RUN: %clang_analyze_cc1 -analyzer-checker=core -analyzer-output=text -verify %s + martong wrote: > AFAIK rdar is not accessible ou

[PATCH] D75479: [clangd] go-to-def on names in comments etc that are used nearby.

This revision was automatically updated to reflect the committed changes. Closed by commit rG3f1c2bf1712c: [clangd] go-to-def on names in comments etc that are used nearby. (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75479/

[PATCH] D78565: [clang][doc] Clang ARM CPU command line argument reference

greened added a comment. In D78565#1997372 , @greened wrote: > In D78565#1996297 , @SjoerdMeijer > wrote: > > > Fair enough, perhaps the audience is too small here on llvm.org for this > > and this is too niche. I

[PATCH] D78655: [HIP] Let lambda be host device by default

yaxunl created this revision. yaxunl added reviewers: tra, rjmccall. Lambda functions do not have names, therefore they do not need host/device attribute for overloading resolution. They are also have internal linkage and is only emitted if used, therefore no need to use host/device attribute to i

[PATCH] D78565: [clang][doc] Clang ARM CPU command line argument reference

greened added a comment. In D78565#1996297 , @SjoerdMeijer wrote: > Fair enough, perhaps the audience is too small here on llvm.org for this and > this is too niche. In A-profile we have the same problem, so could the > exercise for an A-core here, but

[PATCH] D78643: [OpenMP] Fix false error report of array subscription for templated indexes.

jdoerfert added a comment. This looks reasonable to me. @ABataev WDYT? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78643/new/ https://reviews.llvm.org/D78643 ___ cfe-commits mailing list cfe-commits@

[PATCH] D78649: [clang] Make sure argument expansion locations are correct in presence of predefined buffer

kadircet updated this revision to Diff 259332. kadircet marked an inline comment as done. kadircet added a comment. - address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78649/new/ https://reviews.llvm.org/D78649 Files: clang/lib/Basi

[PATCH] D74692: [clang-tidy][bugprone-use-after-move] Warn on std::move for consts

ldionne added a comment. I personally don't think the note is useful. What we're trying to tell the user is "don't use X after you've moved out of X" -- whether the move actually has an effect or not is not useful information. To me, adding `; move of a 'const' argument has no effect` just make

[PATCH] D78649: [clang] Make sure argument expansion locations are correct in presence of predefined buffer

kadircet marked 4 inline comments as done. kadircet added inline comments. Comment at: clang/lib/Lex/PPLexerChange.cpp:420 + // Predefines file doesn't have a valid include location. + CurPPLexer->FID == getPredefinesFileID())) { // Notify SourceManager to

[clang-tools-extra] 3f1c2bf - [clangd] go-to-def on names in comments etc that are used nearby.

Author: Sam McCall Date: 2020-04-22T19:46:41+02:00 New Revision: 3f1c2bf1712c7496a80a0f89036ab1625ff347a5 URL: https://github.com/llvm/llvm-project/commit/3f1c2bf1712c7496a80a0f89036ab1625ff347a5 DIFF: https://github.com/llvm/llvm-project/commit/3f1c2bf1712c7496a80a0f89036ab1625ff347a5.diff LO

[clang] 089fbe6 - [Docs] Fixed formatting in release notes, NFC

Author: Mikhail Maltsev Date: 2020-04-22T18:25:22+01:00 New Revision: 089fbe69193364fee14ed94a58c530d8417dc391 URL: https://github.com/llvm/llvm-project/commit/089fbe69193364fee14ed94a58c530d8417dc391 DIFF: https://github.com/llvm/llvm-project/commit/089fbe69193364fee14ed94a58c530d8417dc391.dif

[PATCH] D78643: [OpenMP] Fix false error report of array subscription for templated indexes.

h-joo updated this revision to Diff 259326. h-joo added a comment. In D78643#1997103 , @jdoerfert wrote: > Can we create a test case that shows even if it is a dependent type we will > eventuall issue an error if it is not an addressable lvalue or array i

[PATCH] D77233: [NFC] Refactoring PropertyAttributeKind for ObjCPropertyDecl and ObjCDeclSpec.

erik.pilkington accepted this revision. erik.pilkington added a comment. This revision is now accepted and ready to land. LGTM, again :) Thanks for cleaning this up. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77233/new/ https://reviews.llvm.org/

[PATCH] D77871: [AArch64] Armv8.6-a Matrix Mult Assembly + Intrinsics

LukeGeeson updated this revision to Diff 259327. LukeGeeson marked 5 inline comments as done. LukeGeeson added a comment. - fixed typos - added sroa as mem2reg arg to reduce redundant mem accesses in tests, refactored test - addressed other comments CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D75041: [clang-tidy] Approximate implicit conversion issues in 'experimental-cppcoreguidelines-avoid-adjacent-arguments-of-the-same-type'

whisperity updated this revision to Diff 259324. whisperity retitled this revision from "[clang-tidy] Approximate implicit conversion issues for the 'experimental-cppcoreguidelines-avoid-adjacent-arguments-of-the-same-type' check" to "[clang-tidy] Approximate implicit conversion issues in 'expe

[PATCH] D69560: [clang-tidy] Add 'experimental-cppcoreguidelines-avoid-adjacent-arguments-of-the-same-type' check

whisperity marked an inline comment as done. whisperity added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/experimental-cppcoreguidelines-avoid-adjacent-parameters-of-the-same-type.rst:136-139 +typedef T element_type; +type

[PATCH] D75041: [clang-tidy] Approximate implicit conversion issues in 'experimental-cppcoreguidelines-avoid-adjacent-arguments-of-the-same-type'

whisperity marked 2 inline comments as done. whisperity added inline comments. Comment at: clang-tools-extra/clang-tidy/experimental/CppcoreguidelinesAvoidAdjacentParametersOfTheSameTypeCheck.cpp:747 OS << "..."; - } else + } else { // There are things like "GCC Vect

  1   2   >