nickdesaulniers added inline comments.
================ Comment at: clang/test/Sema/implicit-int-float-conversion.c:3 +// RUN: %clang_cc1 %s -verify -Wimplicit-const-int-float-conversion +// RUN: %clang_cc1 %s -DNONCONST=1 -verify -Wimplicit-int-float-conversion ---------------- If I understand the bug description properly: You should add a test based on the description where you disable -Wimplicit-int-float-conversion, then re-enable -Wimplicit-const-int-float-conversion, and observe -Wimplicit-const-int-float-conversion diagnostics. ie. ``` // RUN: %clang_cc1 %s -verify -Wno-implicit-int-float-conversion -Wimplicit-const-int-float-conversion ``` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78661/new/ https://reviews.llvm.org/D78661 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
