alexbdv marked 6 inline comments as done. alexbdv added a comment. For tests - the existing block tests should be enough, just need to update them. I updated a few - want to make sure changes are final before updating all the tests to not have to update tests again.
================ Comment at: llvm/include/llvm/Demangle/ItaniumDemangle.h:5537 + + paramType->print(ParamOS); + } ---------------- erik.pilkington wrote: > Can you make a special BlockInvocationFunction AST node that stores the > parameter types as AST nodes (rather than strings) in a NodeArray? Right now > it looks like this code is leaking, since initializeOutputStream allocates a > buffer that it expects the user of OutputStream to manage (the ownership is a > bit awkward, but its meant to accommodate the API of `__cxa_demangle`). Resolved with better memory management. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74813/new/ https://reviews.llvm.org/D74813 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
