ab added inline comments.
================ Comment at: llvm/lib/Target/AArch64/AArch64InstrFormats.td:8058 + def : Pat<(v8f16 (OpNode (v8f16 V128:$Rd), (v8f16 V128:$Rn), + (AArch64duplane16 (v8f16 V128:$Rm), + VectorIndexH:$idx))), ---------------- ilinpv wrote: > ab wrote: > > Should this be V128_lo? I don't think this is encodable for Rm in V16-V31 > > (same in the other indexed f16 variants I think) > Yep, I double checked encoding, you are right. Thank you very much for this. > Fixed in 4eca1c06a4a9183fcf7bb230d894617caf3cf3be Thanks Pavel! I think this applies to the `AArch64dup` variants too, which does entail adding `FPR16Op_lo` and `FPR16_lo` I imagine, and maybe a couple more Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78252/new/ https://reviews.llvm.org/D78252 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
