[clang] 6bc7502 - When making modules transitively visible, don't take into account

Author: Richard Smith Date: 2020-04-17T22:49:58-07:00 New Revision: 6bc7502385cc2a06954082a7d0e6418e610d35f4 URL: https://github.com/llvm/llvm-project/commit/6bc7502385cc2a06954082a7d0e6418e610d35f4 DIFF: https://github.com/llvm/llvm-project/commit/6bc7502385cc2a06954082a7d0e6418e610d35f4.diff

[clang] fc76b4a - Rename IsMissingRequirement to IsUnimportable and set it for shadowed

Author: Richard Smith Date: 2020-04-17T22:48:56-07:00 New Revision: fc76b4ad3da3c1f5fdc34370a55d613b3ca7af73 URL: https://github.com/llvm/llvm-project/commit/fc76b4ad3da3c1f5fdc34370a55d613b3ca7af73 DIFF: https://github.com/llvm/llvm-project/commit/fc76b4ad3da3c1f5fdc34370a55d613b3ca7af73.diff

[PATCH] D77753: Change deprecated -fsanitize-recover flag to apply to all sanitizers, not just UBSan.

This revision was automatically updated to reflect the committed changes. Closed by commit rGc8248dc3bb36: Change deprecated -fsanitize-recover flag to apply to all sanitizers, not just… (authored by rsmith). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[clang] c8248dc - Change deprecated -fsanitize-recover flag to apply to all sanitizers, not just UBSan.

Author: Richard Smith Date: 2020-04-17T22:37:30-07:00 New Revision: c8248dc3bb36bea61ac6d87bd02c39c6a781b011 URL: https://github.com/llvm/llvm-project/commit/c8248dc3bb36bea61ac6d87bd02c39c6a781b011 DIFF: https://github.com/llvm/llvm-project/commit/c8248dc3bb36bea61ac6d87bd02c39c6a781b011.diff

[PATCH] D78404: [clang] Implement P0692R1 from C++20 (access checking on specializations)

rsmith added a comment. Thanks! Is this really the only case we were getting wrong? If so, great! We should make sure we have test coverage for all the cases affected by P0692R1. Please add some complementary tests for the cases where diagnostics should still be produced. For example, in additi

[PATCH] D77598: Integral template argument suffix printing

rsmith added a comment. Is is feasible to check whether the corresponding template parameter either has a deduced type or is a parameter of a function template? If not, we don't need to clarify the type of the template argument and could leave off the suffix to shorten the printed argument.

[PATCH] D73307: Unique Names for Functions with Internal Linkage

erichkeane added a comment. > Thanks for the comments! I was one of the authors of the GCC multiversioning > patch, and if I recall correctly from years ago, one of the reasons for > naming the target clones of multi-versioned foo as foo, foo.sse, etc. was so > that c++filt works nicely on t

[PATCH] D78390: [dfsan] Add "DataFlow" option to LLVM_USE_SANITIZER

zbrid updated this revision to Diff 258462. zbrid added a comment. Update nit from Matt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78390/new/ https://reviews.llvm.org/D78390 Files: clang/docs/DataFlowSanitizer.rst libcxx/CMakeLists.txt li

[PATCH] D78390: [dfsan] Add "DataFlow" option to LLVM_USE_SANITIZER

zbrid marked an inline comment as done. zbrid added inline comments. Comment at: libcxx/utils/libcxx/test/config.py:914 +self.cxx.flags += ['-fsanitize=dataflow'] +self.config.available_features.add('dfsan') else: broa

[PATCH] D77168: Add a flag to debug automatic variable initialization

hubert.reinterpretcast added a comment. In D77168#1989973 , @jfb wrote: > I'd also like to see the pragma attribute approach, as well as byte-pattern > variability as I described. I don't think auto-narrowing is the only approach > we should push people

[PATCH] D73307: Unique Names for Functions with Internal Linkage

tmsriram added a comment. In D73307#1989924 , @erichkeane wrote: > In D73307#1989740 , @rnk wrote: > > > In D73307#1978140 , @tmsriram > > wrote: > > > > > In D73307#1972388

[PATCH] D78390: [dfsan] Add "DataFlow" option to LLVM_USE_SANITIZER

morehouse accepted this revision. morehouse added inline comments. Comment at: clang/docs/DataFlowSanitizer.rst:23 +How to build + Nit: "How to build libc++" Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D77168: Add a flag to debug automatic variable initialization

jfb added a comment. Automatic narrowing of bugs is indeed compelling, so I'd support that as long as it: - Allows bracketing as John suggested (lower / upper bounds where to stop / start). - Is implemented in a way which makes it really hard to regress the security mitigation. Maybe this requ

[PATCH] D78390: [dfsan] Add "DataFlow" option to LLVM_USE_SANITIZER

broadwaylamb added inline comments. Comment at: libcxx/utils/libcxx/test/config.py:914 +self.cxx.flags += ['-fsanitize=dataflow'] +self.config.available_features.add('dfsan') else: I'm not sure we need a new feature if

[PATCH] D78390: [dfsan] Add "DataFlow" option to LLVM_USE_SANITIZER

zbrid updated this revision to Diff 258447. zbrid added a comment. Update documentation based on Matt's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78390/new/ https://reviews.llvm.org/D78390 Files: clang/docs/DataFlowSanitizer.rst

[PATCH] D73967: Implement _ExtInt as an extended int type specifier.

NathanielMcVicar added a comment. In D73967#1989932 , @erichkeane wrote: > I didn't see that on any of the buildbots, where did you see it? Thanks so much! It's funny that you say that because we just had that exact discussion this morning. I saw it in

[PATCH] D73307: Unique Names for Functions with Internal Linkage

erichkeane added a comment. In D73307#1989740 , @rnk wrote: > In D73307#1978140 , @tmsriram wrote: > > > In D73307#1972388 , @rnk wrote: > > > > > Regarding the alias attribu

[PATCH] D77621: ADT: SmallVector size & capacity use word-size integers when elements are small.

dexonsmith closed this revision. dexonsmith added a comment. In D77621#1979769 , @browneee wrote: > GIT_COMMITTER_NAME=Andrew Browne > GIT_COMMITTER_EMAIL=brown...@google.com > > This would be my second commit. I will request access next time - thanks >

[PATCH] D73967: Implement _ExtInt as an extended int type specifier.

erichkeane added a comment. In D73967#1989857 , @NathanielMcVicar wrote: > I believe this change pushes clang\lib\Sema\SemaTemplateDeduction.cpp over > the 16-bit COFF section limit for Windows Debug builds. Could you please > resolve it or add /bigobj

[clang] 50511a4 - Add SemaTemplateDeduction.cpp to /bigobj

Author: Erich Keane Date: 2020-04-17T16:33:07-07:00 New Revision: 50511a406df4475984e5c51feadada2c92aaf97a URL: https://github.com/llvm/llvm-project/commit/50511a406df4475984e5c51feadada2c92aaf97a DIFF: https://github.com/llvm/llvm-project/commit/50511a406df4475984e5c51feadada2c92aaf97a.diff L

[PATCH] D77168: Add a flag to debug automatic variable initialization

llozano added a comment. In D77168#1988138 , @srhines wrote: > In D77168#1988122 , @jfb wrote: > > > In D77168#1988049 , @srhines wrote: > > > > > `pragma clang attribute` is

[PATCH] D77621: ADT: SmallVector size & capacity use word-size integers when elements are small.

browneee updated this revision to Diff 258444. browneee added a comment. Rebase to latest HEAD. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77621/new/ https://reviews.llvm.org/D77621 Files: llvm/include/llvm/ADT/SmallVector.h llvm/lib/Suppor

[PATCH] D76932: [AIX] emit .extern and .weak directive linkage

DiggerLin updated this revision to Diff 258442. DiggerLin added a comment. I think I address all the comments. thanks hubert. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76932/new/ https://reviews.llvm.org/D76932 Files: clang/lib/Driver/ToolCh

[PATCH] D76801: [AST] Print a> without extra spaces in C++11 or later.

dblaikie added subscribers: tamur, cmtice, JDevlieghere, labath, probinson, aprantl. dblaikie added a comment. In D76801#1989641 , @sammccall wrote: > Sorry about the problems here, and thanks for letting me know... > > In D76801#1989421

[PATCH] D59647: [CUDA][HIP] Warn shared var initialization

tra requested changes to this revision. tra added a comment. This revision now requires changes to proceed. NVCC is not always right. > Is there a specific use case for this, other than matching nvcc bug-for-bug? I don't think I've seen the answer to my question above. > However, user can turn

[PATCH] D77592: [NFC][CodeGen] Add enum for selecting the layout of components in the vtable

leonardchan added a comment. > Okay, sure, if there are already offsets in bytes already in the AST-level > layout, I agree that we should be able to compute all of the byte offsets at > that level. > > How are you planning to handle alignments here? Currently alignment doesn't > affect the l

[PATCH] D73967: Implement _ExtInt as an extended int type specifier.

NathanielMcVicar added a comment. I believe this change pushes clang\lib\Sema\SemaTemplateDeduction.cpp over the 16-bit COFF section limit for Windows Debug builds. Could you please resolve it or add /bigobj to the CMakeFile file for MSVC (see clang\lib\CodeGen\CMakeLists.txt). ERROR C1128

[PATCH] D76932: [AIX] emit .extern and .weak directive linkage

DiggerLin updated this revision to Diff 258432. DiggerLin added a comment. handle getSymbol returning a function descriptor symbol after rebase on the D78045 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76932/new/

[PATCH] D78239: [SveEmitter] Add builtins for FP conversions

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/utils/TableGen/SveEmitter.cpp:1035 + OS << "#define svcvtxnt_f32_x svcvtxnt_f32_m\n"; + OS << "#define svcvtxnt_f32_f64_x svcvtxnt_f32_f64_m\

[PATCH] D76932: [AIX] emit .extern and .weak directive linkage

hubert.reinterpretcast added inline comments. Comment at: llvm/lib/CodeGen/TargetLoweringObjectFileImpl.cpp:2144 report_fatal_error( -"Unhandled linkage when mapping linkage to StorageClass."); +"AvailableExternallyLinkage is for its first instance of linkage

[PATCH] D59647: [CUDA][HIP] Warn shared var initialization

yaxunl requested review of this revision. yaxunl added a comment. We need to revive this review since we found it is very inconvenient without this. Also, nvcc only emits a warning for it https://cuda.godbolt.org/z/AzrDTt So I think maybe we even want to emit it as warning by default. Reposi

[PATCH] D78239: [SveEmitter] Add builtins for FP conversions

sdesmalen updated this revision to Diff 258426. sdesmalen added a comment. - Added comment to CGBuiltin explaining that the special case for IsFPConvert will be removed in a follow-up patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78239/new/ https://reviews.llvm.org/D78239 Files

[PATCH] D76801: [AST] Print a> without extra spaces in C++11 or later.

sammccall added a comment. In D76801#1989718 , @rnk wrote: > Hang on, I may have been too quick. We *do* have a test for this, at the end > of clang/test/CodeGenCXX/debug-info-codeview-display-names.cpp: > > https://github.com/llvm/llvm-project/blob/f84

[PATCH] D78239: [SveEmitter] Add builtins for FP conversions

sdesmalen marked an inline comment as done. sdesmalen added a comment. In D78239#1987859 , @efriedma wrote: > I think the predicate type is something we should fix. Even if it's not > causing problems now, it seems like the sort of thing that will bite

[PATCH] D78404: [clang] Implement P0692R1 from C++20 (access checking on specializations)

broadwaylamb created this revision. broadwaylamb added reviewers: asl, rsmith, doug.gregor, rjmccall, triton. broadwaylamb added a project: clang. Herald added subscribers: cfe-commits, dexonsmith. This patch implements paper P0692R1

[PATCH] D78402: [AArch64] Define ACLE FP conversion intrinsics with more specific predicate.

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78402/new/ https://reviews.llvm.org/D78402 ___

[clang] 7ce4e65 - [cmake] Temporarily disable building std::filesystem in CrossWinToARMLinux.cmake

Author: Sergej Jaskiewicz Date: 2020-04-18T00:29:44+03:00 New Revision: 7ce4e652312f776c2cdd1650370c8909f7cf992f URL: https://github.com/llvm/llvm-project/commit/7ce4e652312f776c2cdd1650370c8909f7cf992f DIFF: https://github.com/llvm/llvm-project/commit/7ce4e652312f776c2cdd1650370c8909f7cf992f.d

[PATCH] D77278: Remove asserting getters from base Type

This revision was automatically updated to reflect the committed changes. Closed by commit rGc858debebc13: Remove asserting getters from base Type (authored by ctetreau). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77278/new/ https://reviews.llvm.

[PATCH] D73307: Unique Names for Functions with Internal Linkage

rnk added a subscriber: erichkeane. rnk added a comment. In D73307#1978140 , @tmsriram wrote: > In D73307#1972388 , @rnk wrote: > > > Regarding the alias attribute, it occurs to me that reimplementing this as > > a

[PATCH] D78289: [analyzer] Stability improvements for IteratorModeling functions

ASDenysPetrov added a comment. @baloghadamsoftware I know you have much expertise here. Do you have some thoughts of how I can test exactly these cases? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78289/new/ https://reviews.llvm.org/D78289 __

[PATCH] D76801: [AST] Print a> without extra spaces in C++11 or later.

rnk added a subscriber: amccarth. rnk added a comment. In D76801#1989641 , @sammccall wrote: > I've got a sinking feeling that I misunderstood the implications of updating > CodeGenCXX/debug-info-template-explicit-specialization.cpp and the > Modules/*De

[PATCH] D77597: [SveEmitter] Add IsAppendSVALL and builtins for svptrue and svcnt[bhwd]

sdesmalen updated this revision to Diff 258416. sdesmalen retitled this revision from "[SveEmitter] Add ExpandOp1SVALL and builtin for svptrue" to "[SveEmitter] Add IsAppendSVALL and builtins for svptrue and svcnt[bhwd]". sdesmalen edited the summary of this revision. sdesmalen added a comment.

[PATCH] D78401: [SveEmitter] IsInsertOp1SVALL and builtins for svqdec[bhwd] and svqinc[bhwd]

sdesmalen created this revision. sdesmalen added reviewers: efriedma, SjoerdMeijer. Herald added a subscriber: tschuett. Herald added a project: clang. sdesmalen added a parent revision: D77597: [SveEmitter] Add IsAppendSVALL and builtins for svptrue and svcnt[bhwd]. Some ACLE builtins leave out

[clang] c858deb - Remove asserting getters from base Type

Author: Christopher Tetreault Date: 2020-04-17T14:03:31-07:00 New Revision: c858debebc1308e748de882c745e179b1a398fa0 URL: https://github.com/llvm/llvm-project/commit/c858debebc1308e748de882c745e179b1a398fa0 DIFF: https://github.com/llvm/llvm-project/commit/c858debebc1308e748de882c745e179b1a398f

[PATCH] D78308: [NFC][PowerPC] Refactor ppcUserFeaturesCheck()

This revision was automatically updated to reflect the committed changes. lei marked an inline comment as done. Closed by commit rG10b60dde7670: [PowerPC] Refactor ppcUserFeaturesCheck() (authored by lei). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D76932: [AIX] emit .extern and .weak directive linkage

DiggerLin marked 7 inline comments as done. DiggerLin added inline comments. Comment at: llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp:1496 + +MCSymbol *Name = getSymbol(&F); +if (TM.getTargetTriple().isOSBinFormatXCOFF() && !F.isIntrinsic()) { hubert.reinte

[PATCH] D77278: Remove asserting getters from base Type

ctetreau updated this revision to Diff 258411. ctetreau added a comment. catch straggler Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77278/new/ https://reviews.llvm.org/D77278 Files: clang/lib/CodeGen/CGBuiltin.cpp llvm/include/llvm/IR/Deriv

[PATCH] D76932: [AIX] emit .extern and .weak directive linkage

DiggerLin updated this revision to Diff 258409. DiggerLin marked 2 inline comments as done. DiggerLin added a comment. rebase the patch on the D78045 and address comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D76801: [AST] Print a> without extra spaces in C++11 or later.

sammccall added a subscriber: dblaikie. sammccall added a comment. Sorry about the problems here, and thanks for letting me know... In D76801#1989421 , @rnk wrote: > We updated the compiler and break some VS std::map visualizers: > https://crbug.com/1068

[PATCH] D77278: Remove asserting getters from base Type

efriedma accepted this revision. efriedma added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77278/new/ https://reviews.llvm.org/D77278 ___ cfe-commits mailing list cfe-commits@lists.l

[clang] 10b60dd - [PowerPC] Refactor ppcUserFeaturesCheck()

Author: Lei Huang Date: 2020-04-17T15:19:46-05:00 New Revision: 10b60dde767011c250649dc6a305379034c5b5c5 URL: https://github.com/llvm/llvm-project/commit/10b60dde767011c250649dc6a305379034c5b5c5 DIFF: https://github.com/llvm/llvm-project/commit/10b60dde767011c250649dc6a305379034c5b5c5.diff LOG

[PATCH] D78392: [CUDA] Define __CUDACC__ before standard library headers

This revision was automatically updated to reflect the committed changes. Closed by commit rG8e2051654044: [CUDA] Define __CUDACC__ before standard library headers (authored by tambre, committed by tra). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D75917: Expose llvm fence instruction as clang intrinsic

JonChesterfield added a comment. The tests look good, but I can't see the implementation in this diff. Maybe a file missing from the patch? Can be hard to tell with phabricator, the error may be at my end. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[clang] 8e20516 - [CUDA] Define __CUDACC__ before standard library headers

Author: Raul Tambre Date: 2020-04-17T12:56:13-07:00 New Revision: 8e20516540444618ad32dd11e835c05804053697 URL: https://github.com/llvm/llvm-project/commit/8e20516540444618ad32dd11e835c05804053697 DIFF: https://github.com/llvm/llvm-project/commit/8e20516540444618ad32dd11e835c05804053697.diff L

[PATCH] D78390: [dfsan] Add "DataFlow" option to LLVM_USE_SANITIZER

morehouse added inline comments. Comment at: clang/docs/DataFlowSanitizer.rst:24 +How to build + + Let's add some explanation here about why we want to build libc++ with dfsan. Comment at: clang/docs/DataFlowSanitizer.rst:26 + +Buil

[PATCH] D78392: [CUDA] Define __CUDACC__ before standard library headers

tra updated this revision to Diff 258396. tra added a comment. Undef __CUDACC__ after the standard headers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78392/new/ https://reviews.llvm.org/D78392 Files: clang/lib/Headers/__clang_cuda_runtime_wr

[PATCH] D78392: [CUDA] Define __CUDACC__ before standard library headers

tra added inline comments. Comment at: clang/lib/Headers/__clang_cuda_runtime_wrapper.h:44 #include // Preserve common macros that will be changed below by us or by CUDA We should undef __CUDACC__ here to make sure it does not affect anything else in the he

[PATCH] D77278: Remove asserting getters from base Type

ctetreau updated this revision to Diff 258392. ctetreau added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. catch stragglers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77278/new/ https://reviews.llvm.org/D7727

[PATCH] D78392: [CUDA] Define __CUDACC__ before standard library headers

tambre created this revision. tambre added a reviewer: tra. Herald added subscribers: cfe-commits, yaxunl. Herald added a project: clang. tambre edited the summary of this revision. tambre edited the summary of this revision. tra added inline comments. Comment at: clang/lib/Heade

[PATCH] D77278: Remove asserting getters from base Type

ctetreau updated this revision to Diff 258393. ctetreau added a comment. fix permissions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77278/new/ https://reviews.llvm.org/D77278 Files: clang/lib/CodeGen/CGBuiltin.cpp llvm/include/llvm/IR/Deriv

[PATCH] D78390: [dfsan] Add "DataFlow" option to LLVM_USE_SANITIZER

zbrid updated this revision to Diff 258383. zbrid added a comment. Herald added a subscriber: broadwaylamb. Update config.py to support data flow sanitizer Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78390/new/ https://reviews.llvm.org/D78390 Fi

[PATCH] D76801: [AST] Print a> without extra spaces in C++11 or later.

rnk added subscribers: tstellar, hans, rnk. rnk added a comment. We ran into three distinct issues with this change. We updated the compiler and break some VS std::map visualizers: https://crbug.com/1068394 I haven't 100% confirmed that this caused the issue, but looking at the code suggests tha

[PATCH] D77233: [NFC] Refactoring PropertyAttributeKind for ObjCPropertyDecl and ObjCDeclSpec.

plotfi added a comment. In D77233#1977671 , @erik.pilkington wrote: > LGTM (after fixing those tests). Thanks for cleaning this up! Can this be a LGTM again @erik.pilkington @arphaman? I have managed to undo any unintended C API changes. Tests appear

[PATCH] D78390: [dfsan] Add "DataFlow" option to LLVM_USE_SANITIZER

zbrid added a comment. Oh I found some lit tests that fail by running `check-cxx`. I'll address that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78390/new/ https://reviews.llvm.org/D78390 ___ cfe-co

RE: [PATCH] D73967: Implement _ExtInt as an extended int type specifier.

No problem, thanks for the response! Phab emails are apparently about 30 minutes delayed for me apparently, which is unfortunate or I would have had the fix ready before your revert 😊 Let me know if you run into any more issues, but I’m 99% sure I got it right this time. Thanks -Erich From: S

Re: [PATCH] D73967: Implement _ExtInt as an extended int type specifier.

Sorry for the trouble. I think many buildbots don't build lldb--not enough of them anyway. I found this myself. As I understand it, the switch-cover warning is supposed to be enabled everywhere when built in release mode, so it looks like the lldb builders (what few there are) aren't building in r

[PATCH] D78390: [dfsan] Add dataflow option to LLVM_USE_SANITIZER

zbrid created this revision. zbrid added a reviewer: morehouse. Herald added subscribers: libcxx-commits, cfe-commits, mgorny. Herald added projects: clang, libc++. Herald added a reviewer: libc++. zbrid added a reviewer: EricWF. zbrid edited the summary of this revision. This patch add the datafl

[PATCH] D78308: [NFC][PowerPC] Refactor ppcUserFeaturesCheck()

jsji accepted this revision. jsji added a comment. LGTM. Since there is an improvement for multi errors, we should remove `[NFC]` in title and commit messages. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78308/new/ https://reviews.llvm.o

[PATCH] D78308: [NFC][PowerPC] Refactor ppcUserFeaturesCheck()

lei updated this revision to Diff 258375. lei added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78308/new/ https://reviews.llvm.org/D78308 Files: clang/lib/Basic/Targets/PPC.cpp clang/test/Driver/ppc-depend

[PATCH] D73967: Implement _ExtInt as an extended int type specifier.

erichkeane added a comment. Already relanded here: 5f0903e9bec9 @saugustine I checked the buildbots, every one with LLDB in its name stayed green, and I cannot see the warning in any of their STDIO. Can you point out how I

[PATCH] D75917: Expose llvm fence instruction as clang intrinsic

saiislam updated this revision to Diff 258368. saiislam marked an inline comment as done. saiislam added a comment. 1. Moved test case to clang/test/CodeGenCXX. 2. Added a failing test case with invalid sync scope, which gets detected by implementation of fence instruction. 3. Updated the change

[PATCH] D78024: [FileCheck] - Fix the false positive when -implicit-check-not is used with an unknown -check-prefix.

probinson added a comment. I'm just reading this review for the first time, and my thought was, why is this interacting with implicit-check-not? I think specifying a `--check-prefix=FOO` with no uses of FOO should be diagnosed. I can't say I recall the previous discussion in detail, but that's

[PATCH] D73967: Implement _ExtInt as an extended int type specifier.

erichkeane added a comment. In D73967#1989145 , @saugustine wrote: > This change breaks the lldb build with > > lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp:3958:11: error: > enumeration values 'DependentExtInt' and 'ExtInt' not handled in swi

[PATCH] D73967: Implement _ExtInt as an extended int type specifier.

saugustine added a comment. Reverted in a4b88c044980337bb14390be654fe76864aa60ec . Happy to approve an updated change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73967/new/ h

[PATCH] D78308: [NFC][PowerPC] Refactor ppcUserFeaturesCheck()

lei marked an inline comment as done. lei added inline comments. Comment at: clang/lib/Basic/Targets/PPC.cpp:243 + bool Passed = CheckVSXSubfeature("+power8-vector", "-mpower8-vector"); + Passed |= CheckVSXSubfeature("+direct-move", "-mdirect-move"); + Passed |= CheckVSXSubfea

[PATCH] D73967: Implement _ExtInt as an extended int type specifier.

erichkeane added a comment. In D73967#1989145 , @saugustine wrote: > This change breaks the lldb build with > > lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp:3958:11: error: > enumeration values 'DependentExtInt' and 'ExtInt' not handled in swi

[PATCH] D77910: AMDGPU: Define cl_khr_gl_sharing as a supported extension

b-sumner added a comment. In D77910#1988807 , @arsenm wrote: > In D77910#1981828 , @b-sumner wrote: > > > In D77910#1981429 , @arsenm wrote: > > > > > In D77910#1976171

[PATCH] D73967: Implement _ExtInt as an extended int type specifier.

saugustine added a comment. This change breaks the lldb build with lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp:3958:11: error: enumeration values 'DependentExtInt' and 'ExtInt' not handled in switch [-Werror,-Wswitch] switch (qual_type->getTypeClass()) { ^ lldb/source

[PATCH] D78252: [AArch64] FMLA/FMLS patterns improvement.

ilinpv added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64InstrFormats.td:8055 multiclass SIMDFPIndexedTiedPatterns { + let Predicates = [HasNEON, HasFullFP16] in { + // 1 variant for the .8h version: DUPLANE from 128-bit dmgreen wrote: > Should

[PATCH] D78252: [AArch64] FMLA/FMLS patterns improvement.

ilinpv updated this revision to Diff 258337. ilinpv marked an inline comment as done. ilinpv edited the summary of this revision. ilinpv added a comment. More patterns added. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78252/new/ https://reviews.

[PATCH] D78374: [Analyzer][StreamChecker] Added evaluation of fread and fwrite.

balazske created this revision. Herald added subscribers: cfe-commits, ASDenysPetrov, martong, Charusso, gamesh411, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: Szelethus. Herald added a project: clang. Functions fread

[PATCH] D77938: [clangd] Extend YAML Serialization

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thank you! Do you have commit access, or would you like me to land this and D78038 for you? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D7793

[PATCH] D46317: [clang-tidy] New check bugprone-map-subscript-operator-lookup

Quuxplusone added inline comments. Comment at: test/clang-tidy/bugprone-map-subscript-operator-lookup.cpp:48 + int getter() const; + void setter(int); +}; Besides mgehre's request for `auto&` test cases, I'd like to see some test cases involving these member f

[clang] f89abd6 - [SYCL] Update __builtin_unique_stable_name for other backends.

Author: Erich Keane Date: 2020-04-17T07:54:18-07:00 New Revision: f89abd6923bcc0839288af4b96113a0cb4fa4edd URL: https://github.com/llvm/llvm-project/commit/f89abd6923bcc0839288af4b96113a0cb4fa4edd DIFF: https://github.com/llvm/llvm-project/commit/f89abd6923bcc0839288af4b96113a0cb4fa4edd.diff L

[clang] b639091 - Change users of CreateShuffleVector to pass the masks as int instead of Constants

Author: Benjamin Kramer Date: 2020-04-17T16:34:29+02:00 New Revision: b639091c02df31954899c8107709597947e33364 URL: https://github.com/llvm/llvm-project/commit/b639091c02df31954899c8107709597947e33364 DIFF: https://github.com/llvm/llvm-project/commit/b639091c02df31954899c8107709597947e33364.dif

[PATCH] D78365: [AST] Preserve the invalid initializer for auto VarDecl.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Oops, intended to accept this (with the comment above) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78365/new/ https://reviews.llvm.org/D

[PATCH] D78365: [AST] Preserve the invalid initializer for auto VarDecl.

sammccall added a comment. Nice! Yet another case of "do we need to stop here" though. Do you have a doc or bug or somewhere to collect the different directions we could/should extend in? Comment at: clang/lib/Sema/SemaDecl.cpp:11852 + // There are unresolved typos in In

[PATCH] D77910: AMDGPU: Define cl_khr_gl_sharing as a supported extension

arsenm added a comment. In D77910#1981828 , @b-sumner wrote: > In D77910#1981429 , @arsenm wrote: > > > In D77910#1976171 , @b-sumner > > wrote: > > > > > I don't think we c

[PATCH] D78366: [Preamble] Allow recursive inclusion of header-guarded mainfile.

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, ilya-biryukov. Herald added a project: clang. This is guaranteed to be a no-op without the preamble, so should be a no-op with it too. Partially fixes https

[PATCH] D78365: [AST] Preserve the invalid initializer for auto VarDecl.

hokein created this revision. hokein added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, ilya-biryukov. Herald added a project: clang. fixes https://github.com/clangd/clangd/issues/330 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D78365 Files: clang/

[PATCH] D67052: Add reference type transformation builtins

miscco added inline comments. Comment at: clang/include/clang/Sema/DeclSpec.h:416 static bool isTypeRep(TST T) { -return (T == TST_typename || T == TST_typeofType || -T == TST_underlyingType || T == TST_atomic); +return (TST_typename <= T <= TST_atomic);

[PATCH] D78024: [FileCheck] - Fix the false positive when -implicit-check-not is used with an unknown -check-prefix.

jdenny marked an inline comment as done. jdenny added inline comments. Comment at: llvm/lib/Support/FileCheck.cpp:1375-1377 + // We do not allow using -implicit-check-not when an explicitly specified + // check prefix is not present in the input buffer. + if ((Req.IsDefaultChe

[PATCH] D76594: [clang][AST] Support AST files larger than 512M

This revision was automatically updated to reflect the committed changes. Closed by commit rGa7afb211dc46: [clang][AST] Support AST files larger than 512M (authored by DmitryPolukhin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76594/new/ https:/

[clang] a7afb21 - [clang][AST] Support AST files larger than 512M

Author: Dmitry Polukhin Date: 2020-04-17T06:17:33-07:00 New Revision: a7afb211dc460bd4cfb2542ad1f9b05876b57ba1 URL: https://github.com/llvm/llvm-project/commit/a7afb211dc460bd4cfb2542ad1f9b05876b57ba1 DIFF: https://github.com/llvm/llvm-project/commit/a7afb211dc460bd4cfb2542ad1f9b05876b57ba1.dif

[PATCH] D77802: [analyzer] Improved RangeSet::Negate support of unsigned ranges

ASDenysPetrov updated this revision to Diff 258300. ASDenysPetrov added a comment. Refined Negate function. Divided by steps for clarity. Made some changes in comments due to guideline. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77802/new/ https://reviews.llvm.org/D77802 Files: cl

[PATCH] D76038: PR45000: Use Sema::SetParamDefaultArgument in TransformLambdaExpr

aaronpuchert added a comment. Let's have a look at an example. Do we allow this? template int x = [](T = T()){ return 0; }(args...); template int x; // Uses default argument int() = 0. struct S { S(int); }; template int x; // Default argument not well-formed, but not needed. Curr

[PATCH] D78359: [clangd] Do not store BaseOf relations for missing subjects

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG4503cf5f2313: [clangd] Drop dangling relations while sharding (authored by kadircet). Changed prior to commit: https://

[PATCH] D77809: [Analyzer] Include typedef statements in CFG build.

aaron.ballman added inline comments. Comment at: clang/test/Analysis/cfg.cpp:570 } +// CHECK-LABEL: void vla_simple(int x) NoQ wrote: > balazske wrote: > > balazske wrote: > > > aaron.ballman wrote: > > > > Can you also add tests for: > > > > ``` > > > > int v

Re: [clang-tools-extra] dffa9df - [clangd] Shard preamble symbols in dynamic index

On Fri, 2020-04-17 at 15:02 +0300, Kadir Çetinkaya wrote: > Thanks Mikael, > > 66b54d586fa73499714e2bfef3cedffeabb08f34 should fix this. > Yep, now it runs without complaints. Thanks! /Mikael > On Fri, Apr 17, 2020 at 2:42 PM Mikael Holmén < > mikael.hol...@ericsson.com> wrote: > > Hi Kadir, >

Re: [clang-tools-extra] dffa9df - [clangd] Shard preamble symbols in dynamic index

Thanks Mikael, 66b54d586fa73499714e2bfef3cedffeabb08f34 should fix this. On Fri, Apr 17, 2020 at 2:42 PM Mikael Holmén wrote: > Hi Kadir, > > I noticed in our buildbots that run with sanitizers that we got a new > complaint with this commit. It's still there on current top-of-tree now > so the

  1   2   >