[PATCH] D71197: llvm premerge: clang format test

goncharov added a comment. Build result: fail - 60594 tests passed, 30 failed and 726 were skipped. failed: libc++.std/input_output/filesystems/class_directory_entry/directory_entry_cons/path.pass.cpp failed: libc++.std/input_output/filesystems/class_directory_entry/directory_entry_mods/ass

[PATCH] D71197: llvm premerge: clang format test

goncharov added a comment. Build result: SUCCESS - Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71197/new/ https://reviews.llvm.org/D71197 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https

[PATCH] D71208: CodeGen: Allow annotations on globals in non-zero address space

rjmccall added a comment. In D71208#1776633 , @nhaehnle wrote: > In D71208#1776202 , @rjmccall wrote: > > > The questions I'd like to have answered before I can approve this are: > > > > - whether there are clients

[PATCH] D71208: CodeGen: Allow annotations on globals in non-zero address space

nhaehnle added a comment. In D71208#1776202 , @rjmccall wrote: > The questions I'd like to have answered before I can approve this are: > > - whether there are clients of `@llvm.global.annotations` that will have > problems with non-0 address spaces and

[PATCH] D70856: [Syntax] Build nodes for simple cases of top level declarations

merge_guards_bot added a comment. Build result: pass - 60626 tests passed, 0 failed and 726 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D70856: [Syntax] Build nodes for simple cases of top level declarations

ilya-biryukov updated this revision to Diff 233004. ilya-biryukov added a comment. - Do not call Builder.getRange() twice for namespaces Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70856/new/ https://reviews.llvm.org/D70856 Files: clang/includ

[PATCH] D69853: [OpenMP][NFCI] Introduce llvm/IR/OpenMPConstants.h

This revision was automatically updated to reflect the committed changes. Closed by commit rGeb3e81f43f01: [OpenMP][NFCI] Introduce llvm/IR/OpenMPConstants.h (authored by jdoerfert). Changed prior to commit: https://reviews.llvm.org/D69853?vs=232987&id=233003#toc Repository: rG LLVM Github M

[PATCH] D49091: Warn about usage of __has_include/__has_include_next in macro expansions

torarnv added a comment. https://codereview.qt-project.org/c/qt/qtbase/+/284037 has merged and will be part of Qt 5.14.1 I went with treating them all under one strategy: #ifndef __has_foo #define __has_foo(x) 0 #endif This includes `__has_builtin`, `__has_feature`, `__has_attribute`, `

[clang] eb3e81f - [OpenMP][NFCI] Introduce llvm/IR/OpenMPConstants.h

Author: Johannes Doerfert Date: 2019-12-10T00:10:09-06:00 New Revision: eb3e81f43f019cd90da87169aeff0eaddc4c9ecb URL: https://github.com/llvm/llvm-project/commit/eb3e81f43f019cd90da87169aeff0eaddc4c9ecb DIFF: https://github.com/llvm/llvm-project/commit/eb3e81f43f019cd90da87169aeff0eaddc4c9ecb.d

[PATCH] D71049: Remove implicit conversion that promotes half to other larger precision types for fp classification builtins

This revision was automatically updated to reflect the committed changes. Closed by commit rGcefac9dfaac9: Remove implicit conversion that promotes half to other larger precision types… (authored by Jim). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[clang] cefac9d - Remove implicit conversion that promotes half to other larger precision types for fp classification builtins

Author: Jim Lin Date: 2019-12-10T13:24:21+08:00 New Revision: cefac9dfaac9c806433ad88cca85bd2f3ba1edad URL: https://github.com/llvm/llvm-project/commit/cefac9dfaac9c806433ad88cca85bd2f3ba1edad DIFF: https://github.com/llvm/llvm-project/commit/cefac9dfaac9c806433ad88cca85bd2f3ba1edad.diff LOG:

[PATCH] D71240: [clangd] Heuristically resolve dependent method calls

nridge updated this revision to Diff 232998. nridge added a comment. Fix typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71240/new/ https://reviews.llvm.org/D71240 Files: clang-tools-extra/clangd/FindTarget.cpp clang-tools-extra/clangd/XRef

[PATCH] D71240: [clangd] Heuristically resolve dependent method calls

nridge created this revision. nridge added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. nridge updated this revision to Diff 232996. nridge added a comment. nridge edited the summary of

[PATCH] D62686: [RISCV] Add support for save/restore of callee-saved registers via libcalls

shiva0217 added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVFrameLowering.cpp:289 unsigned CFIIndex = MF.addFrameInst( MCCFIInstruction::createDefCfaOffset(nullptr, -StackSize)); BuildMI(MBB, MBBI, DL, TII->get(TargetOpcode::CFI_INSTRUCTION))

[PATCH] D71240: [clangd] Heuristically resolve dependent method calls

nridge updated this revision to Diff 232996. nridge added a comment. Add github issue number Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71240/new/ https://reviews.llvm.org/D71240 Files: clang-tools-extra/clangd/FindTarget.cpp clang-tools-ex

[clang] ae09dd8 - [Remarks][Driver] Error on -foptimization-record-file with multiple -arch options

Author: Francis Visoiu Mistrih Date: 2019-12-09T20:39:26-08:00 New Revision: ae09dd86a9b7f43543baa92d27c9382099691088 URL: https://github.com/llvm/llvm-project/commit/ae09dd86a9b7f43543baa92d27c9382099691088 DIFF: https://github.com/llvm/llvm-project/commit/ae09dd86a9b7f43543baa92d27c9382099691

[PATCH] D70805: [analyzer] SValHasDescendant: Determine whether the SVal has an SVal descendant

Charusso added a comment. In D70805#1776527 , @NoQ wrote: > Usually this kind of code is hard to re-use because all use cases require > different definitions of "has descendant". We already have at least 3 such > definitions floating around and we can't

[PATCH] D69853: [OpenMP][NFCI] Introduce llvm/IR/OpenMPConstants.h

merge_guards_bot added a comment. Build result: pass - 60659 tests passed, 0 failed and 726 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D71155: [analyzer] CERT: StrChecker: 30.c

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/CStringChecker.cpp:2110 +if (const auto *SR = MR->getBaseRegion()->getAs()) { + State = State->BindExpr(CE, LCtx, SrcV); + C.addTransition(State); Charusso wrote: > NoQ wrote:

[PATCH] D69853: [OpenMP][NFCI] Introduce llvm/IR/OpenMPConstants.h

jdoerfert updated this revision to Diff 232987. jdoerfert added a comment. Add missing files Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69853/new/ https://reviews.llvm.org/D69853 Files: clang/include/clang/AST/OpenMPClause.h clang/include/c

[PATCH] D70725: [analyzer] Add path notes to FuchsiaHandleCheck

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Looks great, thanks!~ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70725/new/ https://reviews.llvm.org/D70725 ___ cfe-commits mailing list cf

[PATCH] D71179: [OpenMP][WIP] Initial support for `begin/end declare variant`

hfinkel added a comment. In D71179#1776491 , @ABataev wrote: > In D71179#1776487 , @hfinkel wrote: > > > In D71179#1776467 , @ABataev wrote: > > > > > In D71179#1776457

[PATCH] D71155: [analyzer] CERT: StrChecker: 30.c

Charusso marked 2 inline comments as done. Charusso added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/CStringChecker.cpp:2109 + if (const MemRegion *MR = SrcV.getAsRegion()) { +if (const auto *SR = MR->getBaseRegion()->getAs()) { + State = State->Bind

[PATCH] D70805: [analyzer] SValHasDescendant: Determine whether the SVal has an SVal descendant

NoQ added a comment. Usually this kind of code is hard to re-use because all use cases require different definitions of "has descendant". We already have at least 3 such definitions floating around and we can't re-use them. Even in the world of ASTMatchers the actual `hasDescendant` matcher is

[PATCH] D70469: [attributes] [analyzer] Add handle related attributes

NoQ added a comment. It still mildly worries me that the attributes aren't truly reusable, as the exact meaning of the attribute depends on the domain. In particular, every domain is expected to have different approaches to error handling, i.e. a function that creates or destroys a handle may f

[PATCH] D71155: [analyzer] CERT: StrChecker: 30.c

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/CStringChecker.cpp:2109 + if (const MemRegion *MR = SrcV.getAsRegion()) { +if (const auto *SR = MR->getBaseRegion()->getAs()) { + State = State->BindExpr(CE, LCtx, SrcV); Why does

[clang-tools-extra] 52b1c94 - Turn off unused variable checking here since we're explicitly adding

Author: Eric Christopher Date: 2019-12-09T19:14:04-08:00 New Revision: 52b1c94a5fe47c8bb5e189bc40bfd50255ce5795 URL: https://github.com/llvm/llvm-project/commit/52b1c94a5fe47c8bb5e189bc40bfd50255ce5795 DIFF: https://github.com/llvm/llvm-project/commit/52b1c94a5fe47c8bb5e189bc40bfd50255ce5795.di

[PATCH] D71152: [analyzer] Keep track of escaped locals.

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Looks great, thanks! I'd love to see what effect it immediately causes and whether there will be any true or false negatives because of this change. Also i-i-it's not that i insist or something, but

[PATCH] D71224: [analyzer] Escape symbols stored into specific region after a conservative evalcall.

NoQ added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/ExprEngine.h:632 + /// of some values. + ProgramStateRef escapeValue(ProgramStateRef State, ArrayRef Vs, PointerEscapeKind K) const; Dun

[PATCH] D71179: [OpenMP][WIP] Initial support for `begin/end declare variant`

ABataev added a comment. In D71179#1776487 , @hfinkel wrote: > In D71179#1776467 , @ABataev wrote: > > > In D71179#1776457 , @jdoerfert > > wrote: > > > > > > You're doing a

[PATCH] D69853: [OpenMP][NFCI] Introduce llvm/IR/OpenMPConstants.h

jdoerfert updated this revision to Diff 232984. jdoerfert added a comment. Rebase and creation of libFrontendOpenMP Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69853/new/ https://reviews.llvm.org/D69853 Files: clang/include/clang/AST/OpenMPCla

[PATCH] D71179: [OpenMP][WIP] Initial support for `begin/end declare variant`

hfinkel added a comment. In D71179#1776467 , @ABataev wrote: > In D71179#1776457 , @jdoerfert wrote: > > > > You're doing absolutely the same thing as the original declare variant > > > implementation. > > > > I do

[PATCH] D71224: [analyzer] Escape symbols stored into specific region after a conservative evalcall.

xazax.hun updated this revision to Diff 232982. xazax.hun added a comment. - Reuse `ExprEngine::escapeValue`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71224/new/ https://reviews.llvm.org/D71224 Files: clang/include/clang/StaticAnalyzer/Checkers/Checkers.td clang/include/clang/

[PATCH] D69778: Make -fmodules-codegen and -fmodules-debuginfo work also with precompiled headers

dblaikie added a comment. > In D69778#1772125 , @dblaikie wrote: > >> I was/am still wondering whether there's a way to coalesce these codepaths >> between PCH and the existing modular code generation support? > > > In what way could this be united more

[PATCH] D71239: [clang][Format] Fix ObjC keywords following try/catch getting split.

merge_guards_bot added a comment. Build result: pass - 60659 tests passed, 0 failed and 726 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D71179: [OpenMP][WIP] Initial support for `begin/end declare variant`

ABataev added a comment. In D71179#1776457 , @jdoerfert wrote: > > You're doing absolutely the same thing as the original declare variant > > implementation. > > I don't think so but if you do why do you oppose this approach? > > > And I don't think it wo

[PATCH] D70411: [analyzer] CERT: StrChecker: 31.c

NoQ added a comment. Ok, so, what should the checker warn on? What should be the intended state machine for this checker? We basically have two possible categories of answers to this question: - "The checker warns every time it finds an execution path on which unintended behavior occurs" - des

[PATCH] D70696: [DebugInfo] Support to emit debugInfo for extern variables

dblaikie added inline comments. Comment at: clang/test/CodeGen/debug-info-extern-basic.c:14-23 +extern int (*foo)(int); +int test3() { + return foo(0); +} + +int test4() { + extern int (*foo2)(int); yonghong-song wrote: > dblaikie wrote: > > What do these tests

[PATCH] D71239: [clang][Format] Fix ObjC keywords following try/catch getting split.

Bigcheese created this revision. Bigcheese added reviewers: thakis, djasper. Bigcheese added a project: clang-format. Herald added a subscriber: dexonsmith. Herald added a project: clang. Previously things like: int main() { @try { } @catch (NSException *e) { } @try { } @

[PATCH] D71179: [OpenMP][WIP] Initial support for `begin/end declare variant`

jdoerfert added a comment. > You're doing absolutely the same thing as the original declare variant > implementation. I don't think so but if you do why do you oppose this approach? > And I don't think it would be correct to add them as multiversiin variants to > the original function. Why wo

[PATCH] D71179: [OpenMP][WIP] Initial support for `begin/end declare variant`

jdoerfert marked an inline comment as done. jdoerfert added inline comments. Comment at: clang/lib/Headers/__clang_cuda_math_forward_declares.h:41 __DEVICE__ long abs(long); __DEVICE__ long long abs(long long); -__DEVICE__ double abs(double); I have to double c

[clang] 848934c - [c++20] Fix handling of unqualified lookups from a defaulted comparison

Author: Richard Smith Date: 2019-12-09T17:40:36-08:00 New Revision: 848934c67d484da737b4b92c087bffce069b24ba URL: https://github.com/llvm/llvm-project/commit/848934c67d484da737b4b92c087bffce069b24ba DIFF: https://github.com/llvm/llvm-project/commit/848934c67d484da737b4b92c087bffce069b24ba.diff

[PATCH] D71224: [analyzer] Escape symbols stored into specific region after a conservative evalcall.

xazax.hun marked an inline comment as done. xazax.hun added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/ExprEngineCallAndReturn.cpp:603 + // point. + class CollectReachableSymbolsCallback final : public SymbolVisitor { +ProgramStateRef State;

[PATCH] D70696: [DebugInfo] Support to emit debugInfo for extern variables

yonghong-song updated this revision to Diff 232980. yonghong-song added a comment. remove some redundant test cases Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70696/new/ https://reviews.llvm.org/D70696 Files: clang/include/clang/AST/ASTConsum

[PATCH] D71041: [analyzer][discussion] Talk about escapes

xazax.hun added a comment. This is the next one: https://reviews.llvm.org/D71224 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71041/new/ https://reviews.llvm.org/D71041 ___ cfe-commits mailing list cf

[PATCH] D71224: [analyzer] Escape symbols stored into specific region after a conservative evalcall.

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/ExprEngineCallAndReturn.cpp:603 + // point. + class CollectReachableSymbolsCallback final : public SymbolVisitor { +ProgramStateRef State; xazax.hun wrote: > NoQ wrote: > > xazax.hun wrote

[PATCH] D71224: [analyzer] Escape symbols stored into specific region after a conservative evalcall.

xazax.hun marked an inline comment as done. xazax.hun added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/ExprEngineCallAndReturn.cpp:648 + continue; +State->scanReachableSymbols(Call.getArgSVal(Arg), Scanner); + } NoQ wrote: >

[PATCH] D71224: [analyzer] Escape symbols stored into specific region after a conservative evalcall.

xazax.hun marked an inline comment as done. xazax.hun added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/ExprEngineCallAndReturn.cpp:603 + // point. + class CollectReachableSymbolsCallback final : public SymbolVisitor { +ProgramStateRef State;

[PATCH] D70520: [WebAssembly] Add new `export_name` clang attribute for controlling wasm export names

dschuff added inline comments. Comment at: lld/test/wasm/export-name.ll:20 +; CHECK-NEXT:Exports: +; CHECK-NEXT: - Name:memory +; CHECK-NEXT:Kind:MEMORY sbc100 wrote: > dschuff wrote: > > does this test need to verify that

[PATCH] D70157: Align branches within 32-Byte boundary

skan added a comment. In D70157#1775481 , @fedor.sergeev wrote: > In D70157#1775016 , @annita.zhang > wrote: > > > > The point is that we have explicit requirement at the start and we have a > > > lowering into 1

[PATCH] D70696: [DebugInfo] Support to emit debugInfo for extern variables

yonghong-song marked an inline comment as done. yonghong-song added inline comments. Comment at: clang/test/CodeGen/debug-info-extern-basic.c:14-23 +extern int (*foo)(int); +int test3() { + return foo(0); +} + +int test4() { + extern int (*foo2)(int); dblaikie

[PATCH] D70157: Align branches within 32-Byte boundary

reames added a comment. I just posted an alternate review (https://reviews.llvm.org/D71238) which attempts to carve out a minimum reviewable piece of complexity. The hope is that we can review that one quickly (as there are fewer interacting concerns), and then rebase this one (possibly splitt

[PATCH] D71224: [analyzer] Escape symbols stored into specific region after a conservative evalcall.

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/ExprEngineCallAndReturn.cpp:603 + // point. + class CollectReachableSymbolsCallback final : public SymbolVisitor { +ProgramStateRef State; xazax.hun wrote: > NoQ wrote: > > WDYT about re-u

[PATCH] D65543: [Windows] Autolink with basenames and add libdir to libpath

rnk updated this revision to Diff 232975. rnk added a comment. - rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65543/new/ https://reviews.llvm.org/D65543 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Driver/ToolChain.h clang/

[PATCH] D70520: [WebAssembly] Add new `export_name` clang attribute for controlling wasm export names

sbc100 marked an inline comment as done. sbc100 added inline comments. Comment at: lld/test/wasm/export-name.ll:20 +; CHECK-NEXT:Exports: +; CHECK-NEXT: - Name:memory +; CHECK-NEXT:Kind:MEMORY dschuff wrote: > does this te

[PATCH] D71201: [ObjC][DWARF] Emit DW_AT_APPLE_objc_direct for methods marked as __attribute__((objc_direct))

aprantl added a comment. Looks pretty good, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71201/new/ https://reviews.llvm.org/D71201 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

[PATCH] D71201: [ObjC][DWARF] Emit DW_AT_APPLE_objc_direct for methods marked as __attribute__((objc_direct))

aprantl added inline comments. Comment at: llvm/include/llvm/IR/DebugInfoFlags.def:93 HANDLE_DISP_FLAG((1u << 9), Deleted) +HANDLE_DISP_FLAG((1u << 10), ObjCDirect) I think it would be good to leave a gap for https://reviews.llvm.org/D68117 here. @SouraVX wha

[PATCH] D71224: [analyzer] Escape symbols stored into specific region after a conservative evalcall.

xazax.hun marked an inline comment as done. xazax.hun added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/ExprEngineCallAndReturn.cpp:603 + // point. + class CollectReachableSymbolsCallback final : public SymbolVisitor { +ProgramStateRef State;

[PATCH] D70520: [WebAssembly] Add new `export_name` clang attribute for controlling wasm export names

dschuff accepted this revision. dschuff added inline comments. This revision is now accepted and ready to land. Comment at: lld/test/wasm/export-name.ll:20 +; CHECK-NEXT:Exports: +; CHECK-NEXT: - Name:memory +; CHECK-NEXT:Kind:MEMORY -

[PATCH] D71224: [analyzer] Escape symbols stored into specific region after a conservative evalcall.

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/ExprEngineCallAndReturn.cpp:603 + // point. + class CollectReachableSymbolsCallback final : public SymbolVisitor { +ProgramStateRef State; WDYT about re-using `ExprEngine::escapeValue()` b

[PATCH] D71224: [analyzer] Escape symbols stored into specific region after a conservative evalcall.

xazax.hun updated this revision to Diff 232968. xazax.hun edited the summary of this revision. xazax.hun added a comment. - Added a test. More rigorous tests will come in the FuchsiaHandleChecker. - Added a new PSK_ entry. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71224/new/ https:

[clang] 9c6b7f6 - Revert "[ARM][MVE] Add intrinsics for immediate shifts."

Author: Eric Christopher Date: 2019-12-09T16:47:38-08:00 New Revision: 9c6b7f68b807250e7c3aa01938339fdbd239c4ea URL: https://github.com/llvm/llvm-project/commit/9c6b7f68b807250e7c3aa01938339fdbd239c4ea DIFF: https://github.com/llvm/llvm-project/commit/9c6b7f68b807250e7c3aa01938339fdbd239c4ea.di

[PATCH] D70696: [DebugInfo] Support to emit debugInfo for extern variables

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. In D70696#1774931 , @Jac1494 wrote: > For some real life case like below we need debuginfo for declaration of > global extern variable . > > $cat s

[PATCH] D71225: [OpenMP][WIP] atomic update only evaluate once for expression having side effect

ABataev added a comment. In D71225#1776113 , @jdoerfert wrote: > In D71225#1776105 , @cchen wrote: > > > Oops, accidentally remove my own comment. I'm not sure why `iarr[foo(), > > foo(), 0]` violate the rule since

[PATCH] D70701: Fix more VFS tests on Windows

amccarth marked 2 inline comments as done. amccarth added inline comments. Comment at: llvm/lib/Support/VirtualFileSystem.cpp:1431 -if (IsRootEntry && !sys::path::is_absolute(Name)) { - assert(NameValueNode && "Name presence should be checked earlier"); ---

[clang] 9803178 - Avoid Attr.h includes, CodeGen edition

Author: Reid Kleckner Date: 2019-12-09T16:17:18-08:00 New Revision: 9803178a78c1858b0ac868c2cdf402cec5a10db9 URL: https://github.com/llvm/llvm-project/commit/9803178a78c1858b0ac868c2cdf402cec5a10db9 DIFF: https://github.com/llvm/llvm-project/commit/9803178a78c1858b0ac868c2cdf402cec5a10db9.diff

[PATCH] D71179: [OpenMP][WIP] Initial support for `begin/end declare variant`

ABataev added a comment. In D71179#1776108 , @jdoerfert wrote: > In D71179#1776046 , @ABataev wrote: > > > In D71179#1776034 , @jdoerfert > > wrote: > > > > > > Not always.

[PATCH] D70627: [AST] Split out Attrs.h for table generated *Attr classes

rnk abandoned this revision. rnk added a comment. I think this isn't necessary. I think I got most of the value of this in rG60573ae6fe509b618dc6a2c5c55d921bccd77608 , and we don't need two AttrBase.h / Attr.h headers in the l

[PATCH] D71224: [analyzer] Escape symbols stored into specific region after a conservative evalcall.

xazax.hun updated this revision to Diff 232955. xazax.hun added a comment. - Do not track explicitly if a call was conservative. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71224/new/ https://reviews.llvm.org/D71224 Files: clang/lib/StaticAnalyzer/Core/ExprEngineCallAndReturn.cpp

[PATCH] D71208: CodeGen: Allow annotations on globals in non-zero address space

rjmccall added a comment. The questions I'd like to have answered before I can approve this are: - whether there are clients of `@llvm.global.annotations` that will have problems with non-0 address spaces and - whether this will interfere with someday having an invariant that `addrspacecast` is

[PATCH] D69764: [clang-format] Add Left/Right Const (East/West , Before/After) fixer capability

ilya added a comment. In D69764#1775842 , @MyDeveloperDay wrote: > In D69764#1775835 , @ilya wrote: > > > In D69764#1732235 , @aaron.ballman > > wrote: > > > > > I like the

[PATCH] D71224: [analyzer][WIP] Escape symbols stored into specific region after a conservative evalcall.

NoQ added a comment. I think you don't need to smuggle `WasConservative` all the way up. It's implied that if the evaluation was not conservative, then the respective `ExplodedNodeSet` is going to be empty, as all nodes will be put directly into the worklist instead. Eg., `checkPostCall` isn't

[PATCH] D71224: [analyzer][WIP] Escape symbols stored into specific region after a conservative evalcall.

xazax.hun marked 3 inline comments as done. xazax.hun added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/ExprEngineCallAndReturn.cpp:696 // And make the result node. Bldr.generateNode(Call.getProgramPoint(), State, Pred); } NoQ wrote: > xazax

[PATCH] D71224: [analyzer][WIP] Escape symbols stored into specific region after a conservative evalcall.

xazax.hun updated this revision to Diff 232948. xazax.hun added a comment. - Prototype a new approach. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71224/new/ https://reviews.llvm.org/D71224 Files: clang/include/clang/StaticAnalyzer/Core/CheckerManager.h clang/include/clang/Static

[clang] e6e6e34 - [c++20] Defaulted comparison support for array members.

Author: Richard Smith Date: 2019-12-09T14:54:06-08:00 New Revision: e6e6e34b95cfe03275943fde0db259cc7d57f4ad URL: https://github.com/llvm/llvm-project/commit/e6e6e34b95cfe03275943fde0db259cc7d57f4ad DIFF: https://github.com/llvm/llvm-project/commit/e6e6e34b95cfe03275943fde0db259cc7d57f4ad.diff

[PATCH] D71091: Make sure that the implicit arguments for direct methods have been setup

MadCoder added a comment. In D71091#1776009 , @liuliu wrote: > No problem! I have a custom patch that isn't as nice but get the job done. > Let me know when you put new diff out and I can test it on our codebase again. https://reviews.llvm.org/D71226/ne

[PATCH] D71225: [OpenMP][WIP] atomic update only evaluate once for expression having side effect

cchen added a comment. @jdoerfert , thanks for your explanation, it's really clear and helpful. I'll add a warning message in another patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71225/new/ https://reviews.llvm.org/D71225 __

[PATCH] D71225: [OpenMP][WIP] atomic update only evaluate once for expression having side effect

jdoerfert added a comment. In D71225#1776105 , @cchen wrote: > Oops, accidentally remove my own comment. I'm not sure why `iarr[foo(), > foo(), 0]` violate the rule since it will be evaluated as `iarr[0]`, and the > counter `foo()` modified is also in th

[PATCH] D71226: Also synthesize _cmd and self for properties

This revision was automatically updated to reflect the committed changes. Closed by commit rG1646bb866433: Also synthesize _cmd and self for properties (authored by MadCoder, committed by arphaman). Changed prior to commit: https://reviews.llvm.org/D71226?vs=232928&id=232944#toc Repository:

[clang] 1646bb8 - Also synthesize _cmd and self for properties

Author: Pierre Habouzit Date: 2019-12-09T14:30:01-08:00 New Revision: 1646bb86643326db6e220291d5c71c8d616f66fb URL: https://github.com/llvm/llvm-project/commit/1646bb86643326db6e220291d5c71c8d616f66fb DIFF: https://github.com/llvm/llvm-project/commit/1646bb86643326db6e220291d5c71c8d616f66fb.dif

[PATCH] D71179: [OpenMP][WIP] Initial support for `begin/end declare variant`

jdoerfert added a comment. In D71179#1776046 , @ABataev wrote: > In D71179#1776034 , @jdoerfert wrote: > > > > Not always. If we see that the context selector does not match, we can > > > skip everything between be

[PATCH] D71225: [OpenMP][WIP] atomic update only evaluate once for expression having side effect

cchen added a comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71225/new/ https://reviews.llvm.org/D71225 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mail

[PATCH] D71225: [OpenMP][WIP] atomic update only evaluate once for expression having side effect

cchen added a comment. Oops, accidentally remove my own comment. I'm not sure why `iarr[foo(), foo(), 0]` violate the rule since it will be evaluated as `iarr[0]`, and the counter `foo()` modified is also in the same location for both left hand side and right hand side. Repository: rG LLVM

[PATCH] D71225: [OpenMP][WIP] atomic update only evaluate once for expression having side effect

jdoerfert added a comment. > • For forms that allow multiple occurrences of x, the number of times that x > is evaluated is unspecified. x here is `iarr[foo(), foo(), 0]`, if I'm not mistaken. Assuming not, any multiple of 2 is a fine amount of evaluations for `foo`. I'd vote for a warning her

[PATCH] D71141: [Wdocumentation] Use C2x/C++14 deprecated attribute

gribozavr2 marked an inline comment as done. gribozavr2 added inline comments. Comment at: clang/test/Sema/warn-documentation-fixits.c:27 + +// CHECK: fix-it:"{{.*}}":{7:1-7:1}:"[[ATTRIBUTE]] " +// CHECK: fix-it:"{{.*}}":{11:1-11:1}:"[[ATTRIBUTE]] " Mordante wrot

[PATCH] D71224: [analyzer][WIP] Escape symbols stored into specific region after a conservative evalcall.

NoQ added a comment. In D71224#1776052 , @xazax.hun wrote: > Also, it looks like for example `CStringChecker` calls > `ProgramState::InvalidateRegions` directly when modeling function calls. So > it looks like if checkers are using evalCall, pointerEscap

[PATCH] D71140: [Wdocumentation] Properly place deprecated attribute

gribozavr2 marked an inline comment as done. gribozavr2 added inline comments. Comment at: clang/test/Sema/warn-documentation-fixits.cpp:4 +// RUN: %clang_cc1 -std=c++14 -fsyntax-only -Wdocumentation -Wdocumentation-pedantic -fcomment-block-commands=foobar -fdiagnostics-parseab

[PATCH] D71226: Also synthesize _cmd and self for properties

rjmccall added a comment. Alternatively, we could make IRGen not depend on those parameters being set just to call a function, which seems reasonable since the parameter variables are logically internal to the implementation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D71226: Also synthesize _cmd and self for properties

MadCoder added a comment. In D71226#1776038 , @rjmccall wrote: > It'd be nice if we didn't have to synthesize parameters for all declarations > when we're just handling an `@interface`, but we can improve that in > follow-ups. yeah ideally I'd want to

[PATCH] D71224: [analyzer][WIP] Escape symbols stored into specific region after a conservative evalcall.

xazax.hun added a comment. Also, it looks like for example `CStringChecker` calls `ProgramState::InvalidateRegions` directly when modeling function calls. So it looks like if checkers are using evalCall, pointerEscape will not be triggered automatically. I am not sure if that would be a bug or

[PATCH] D71179: [OpenMP][WIP] Initial support for `begin/end declare variant`

ABataev added a comment. In D71179#1776034 , @jdoerfert wrote: > > Not always. If we see that the context selector does not match, we can skip > > everything between begin/end. It means exactly what I said - > > multiversioning is needed only for `constr

[PATCH] D71179: [OpenMP][WIP] Initial support for `begin/end declare variant`

jdoerfert added a comment. > Not always. If we see that the context selector does not match, we can skip > everything between begin/end. It means exactly what I said - multiversioning > is needed only for `construct` because all other traits can be easily > resolved at the compile time. General

[PATCH] D71224: [analyzer][WIP] Escape symbols stored into specific region after a conservative evalcall.

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/ExprEngineCallAndReturn.cpp:696 // And make the result node. Bldr.generateNode(Call.getProgramPoint(), State, Pred); } xazax.hun wrote: > After some offline conversation it is very likely

[PATCH] D71225: [OpenMP][WIP] atomic update only evaluate once for expression having side effect

ABataev added a comment. It is against the standard, I assume. According to standard, `During the execution of an atomic region, multiple syntactic occurrences of x must designate the same storage location.`. In your case, this is not so. I assume it would be better to implement the diagnostic

[PATCH] D71226: Also synthesize _cmd and self for properties

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71226/new/ https://reviews.llvm.org/D71226 ___

[PATCH] D71226: Also synthesize _cmd and self for properties

rjmccall added a comment. It'd be nice if we didn't have to synthesize parameters for all declarations when we're just handling an `@interface`, but we can improve that in follow-ups. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71226/new/ https:

[PATCH] D71227: [cuda][hip] Fix function overload resolution in the global initiailizer.

hliao updated this revision to Diff 232938. hliao added a comment. refine again Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71227/new/ https://reviews.llvm.org/D71227 Files: clang/include/clang/Sema/Sema.h clang/lib/Parse/ParseDecl.cpp cla

[PATCH] D71091: Make sure that the implicit arguments for direct methods have been setup

liuliu added a comment. No problem! I have a custom patch that isn't as nice but get the job done. Let me know when you put new diff out and I can test it on our codebase again. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71091/new/ https://revi

[PATCH] D71226: Also synthesize _cmd and self for properties

MadCoder added a comment. @liuliu that fixes your test case (which I reproduced in the CG test) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71226/new/ https://reviews.llvm.org/D71226 ___ cfe-commits

[PATCH] D71227: [cuda][hip] Fix function overload resolution in the global initiailizer.

hliao created this revision. hliao added reviewers: tra, jlebar, yaxunl. Herald added a project: clang. Herald added a subscriber: cfe-commits. hliao updated this revision to Diff 232933. hliao added a comment. hliao edited the summary of this revision. refine commit message - As global initiali

  1   2   3   4   >