dschuff added inline comments.
================ Comment at: lld/test/wasm/export-name.ll:20 +; CHECK-NEXT: Exports: +; CHECK-NEXT: - Name: memory +; CHECK-NEXT: Kind: MEMORY ---------------- sbc100 wrote: > dschuff wrote: > > does this test need to verify that the memory and _start are exported? > > seems like just a check for bar would be enough. > The worry that if I just look for ` Name: bar` it might appear in > some other section too mabye? You could do `CHECK-LABEL: Exports` and then `CHECK: - Name: bar` and then `CHECK-LABEL` on the next section? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70520/new/ https://reviews.llvm.org/D70520 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
