xazax.hun marked an inline comment as done.
xazax.hun added inline comments.


================
Comment at: clang/lib/StaticAnalyzer/Core/ExprEngineCallAndReturn.cpp:603
+  // point.
+  class CollectReachableSymbolsCallback final : public SymbolVisitor {
+    ProgramStateRef State;
----------------
NoQ wrote:
> WDYT about re-using `ExprEngine::escapeValue()` by changing it to accept 
> `ArrayRef<SVal>` instead of a single `SVal`?
It is not entirely the same. Here we only collect symbols from non-stack 
regions. There (as far as I understand) we collect all symbols. I could add a 
flag but at that point I wonder if it is worth the change.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71224/new/

https://reviews.llvm.org/D71224



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to