[PATCH] D61040: [Fuchsia] Support multilib for -fsanitize=address and -fno-exceptions

phosek added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.h:122 + +/// \p Flag must be a flag accepted by the driver with its leading '-' removed, +// otherwise '-print-multi-lib' will not emit them correctly. jroelofs wrote: > Can we e

[PATCH] D61046: Fix compilation warnings when compiling with GCC 7.3

MaskRay added inline comments. Comment at: llvm/trunk/include/llvm/BinaryFormat/ELF.h:878 enum : unsigned { + SHF_NONE, + `SHF_NONE` is not defined in `/usr/binclude/elf.h`. `(unsigned)SHF_ALLOC` is probably better. CHANGES SINCE LAST ACTION https://review

[PATCH] D60349: [COFF, ARM64] Fix ABI implementation of struct returns

TomTan added a comment. In D60349#1476371 , @efriedma wrote: > It looks like there's some missing documentation in the ARM64 ABI document > involving homogeneous aggregates... in particular, it looks like non-POD > types are never homogeneous, or somethi

[PATCH] D60988: [analyzer] Fix crash when returning C++ objects from ObjC messages-to-nil.

dcoughlin added a comment. Looks good to me. This is a really interesting corner of Objective-C++! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60988/new/ https://reviews.llvm.org/D60988 ___ cfe-commits mailing list

[PATCH] D58537: lib/Header: Simplify CMakeLists.txt

tstellar marked an inline comment as done. tstellar added a comment. Can you test D61054 ? Comment at: cfe/trunk/lib/Headers/CMakeLists.txt:168 install( - FILES ${cuda_wrapper_files} - COMPONENT clang-headers - PERMISSIONS OWNER_READ OWNER_W

[PATCH] D61054: lib/Header: Fix Visual Studio builds

tstellar created this revision. tstellar added reviewers: smeenai, vzakhari, phosek. Herald added a subscriber: mgorny. Herald added a project: clang. This is a follow up to r355253, which inadvertently broke Visual Studio builds by trying to copy files from CMAKE_CFG_INTDIR. See https://reviews.

[PATCH] D55500: [Builtins] Implement __builtin_is_constant_evaluated for use in C++2a

This revision was automatically updated to reflect the committed changes. Closed by commit rC359067: [Builtins] Implement __builtin_is_constant_evaluated for use in C++2a (authored by EricWF, committed by ). Herald added a project: clang. Repository: rC Clang CHANGES SINCE LAST ACTION https:

[PATCH] D57435: [clang-tidy] Add abseil-wrap-unique check

Dosi-Dough added a comment. @EricWF @JonasToth I was wondering what other changes I should make to submit my check upstream? Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57435/new/ https://reviews.llvm.org/D57435 ___

r359067 - [Builtins] Implement __builtin_is_constant_evaluated for use in C++2a

Author: ericwf Date: Tue Apr 23 19:23:30 2019 New Revision: 359067 URL: http://llvm.org/viewvc/llvm-project?rev=359067&view=rev Log: [Builtins] Implement __builtin_is_constant_evaluated for use in C++2a Summary: This patch implements `__builtin_is_constant_evaluated` as specifier by [P0595R2](ht

Re: r350917 - [Sema] If CheckPlaceholderExpr rewrites the initializer of an auto

Hi Akira, I've reverted this in r359066. This subtly breaks the semantics of C++ initializers by strripping off an outer level of parentheses / braces in some cases. Testcase: struct A { A(); A(const A&) = delete; }; auto x = [a{A()}] {}; (This should be accepted in C++17 mode onwa

r359066 - Revert r350917 "[Sema] If CheckPlaceholderExpr rewrites the initializer

Author: rsmith Date: Tue Apr 23 19:22:38 2019 New Revision: 359066 URL: http://llvm.org/viewvc/llvm-project?rev=359066&view=rev Log: Revert r350917 "[Sema] If CheckPlaceholderExpr rewrites the initializer of an auto" This commit changed the initializer expression passed into initialization (strip

[PATCH] D61051: [analyzer] Treat functions without runtime branches as "small".

NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a_sidorin, rnkovacs, mikhail.ramalho, Szelethus, baloghadamsoftware, Charusso. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, a.sidorin, szepet, eraman. Herald added a project: clang. Currently we always inline fun

[PATCH] D55500: [Builtins] Implement __builtin_is_constant_evaluated for use in C++2a

EricWF updated this revision to Diff 196368. EricWF added a comment. - Merge with master. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55500/new/ https://reviews.llvm.org/D55500 Files: include/clang/Basic/Builtins.def lib/AST/ExprConstant.cpp lib/Basic/Builtins.cpp lib/CodeGen

[PATCH] D60523: [clang] Don't segfault on incorrect using directive (PR41400)

jkorous added a comment. I can't really comment on correctness of your fix but had been willing to do the work I'd suggest making `ASTContext::getDependentNameType` and `DependentNameType::DependentNameType` interface more robust. With current master (95c18c7beec

r359059 - Fix interactions between __builtin_constant_p and constexpr to match

Author: rsmith Date: Tue Apr 23 18:29:28 2019 New Revision: 359059 URL: http://llvm.org/viewvc/llvm-project?rev=359059&view=rev Log: Fix interactions between __builtin_constant_p and constexpr to match current trunk GCC. GCC permits information from outside the operand of __builtin_constant_p (bu

[PATCH] D61046: Fix compilation warnings when compiling with GCC 7.3

tstellar added inline comments. Comment at: llvm/trunk/lib/Target/AMDGPU/R600ISelLowering.cpp:1717-1722 +// Fix spurious warning with gcc 7.3 -O3 for NewBldVec[i] below +// warning: array subscript is above array bounds [-Warray-bounds] +#if defined(__GNUC__) && __GNUC__

[PATCH] D60848: [Parser] Avoid correcting delayed typos in array subscript multiple times.

vsapsai added a comment. In D60848#1472799 , @erik.pilkington wrote: > Wait, why is NumTypos incorrect here? I think its because we don't handle the > typo on the line: `[self undeclaredMethod:undeclaredArg];`, even the > following asserts now. Seems li

r359057 - Fix test after r359009 on platforms where %ms_abi_triple is 32-bit

Author: nico Date: Tue Apr 23 17:48:04 2019 New Revision: 359057 URL: http://llvm.org/viewvc/llvm-project?rev=359057&view=rev Log: Fix test after r359009 on platforms where %ms_abi_triple is 32-bit Modified: cfe/trunk/test/CodeGenCXX/cxx2a-three-way-comparison.cpp Modified: cfe/trunk/test/Co

[PATCH] D61040: [Fuchsia] Support multilib for -fsanitize=address and -fno-exceptions

jroelofs added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.h:122 + +/// \p Flag must be a flag accepted by the driver with its leading '-' removed, +// otherwise '-print-multi-lib' will not emit them correctly. Can we enforce this prec

r359054 - Fixes in creduce-clang-crash.py for clang crash message parsing and reading the command from the repro script.

Author: akhuang Date: Tue Apr 23 17:28:23 2019 New Revision: 359054 URL: http://llvm.org/viewvc/llvm-project?rev=359054&view=rev Log: Fixes in creduce-clang-crash.py for clang crash message parsing and reading the command from the repro script. Modified: cfe/trunk/utils/creduce-clang-crash.p

[PATCH] D61046: Fix compilation warnings when compiling with GCC 7.3

aganea updated this revision to Diff 196358. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61046/new/ https://reviews.llvm.org/D61046 Files: clang/trunk/unittests/AST/ASTImporterTest.cpp clang/trunk/unittests/Tooling/LookupTest.cpp lld/trunk/ELF/LinkerScript.cpp llvm/trunk/includ

[PATCH] D60661: Revert "Revert "[clang-format] Keep protobuf "package" statement on one line""

dchai added a comment. Friendly ping. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60661/new/ https://reviews.llvm.org/D60661 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/ma

[PATCH] D61046: Fix compilation warnings when compiling with GCC 7.3

aganea marked 5 inline comments as done. aganea added inline comments. Comment at: clang/trunk/unittests/AST/ASTImporterTest.cpp:4054 +} } Fixes ``` [2097/2979] Building CXX object tools/clang/unittests/Tooling/CMakeFiles/ToolingTests.dir/LookupTest.cpp

r359051 - Add missing diagnostic for anonymous struct/union definitions that don't

Author: rsmith Date: Tue Apr 23 17:08:02 2019 New Revision: 359051 URL: http://llvm.org/viewvc/llvm-project?rev=359051&view=rev Log: Add missing diagnostic for anonymous struct/union definitions that don't introduce any names. Modified: cfe/trunk/lib/Sema/SemaDecl.cpp cfe/trunk/test/Analy

[PATCH] D61046: Fix compilation warnings when compiling with GCC 7.3

aganea created this revision. aganea added reviewers: spatel, rnk, nikic, chandlerc, MaskRay, martong, ioeric. aganea added projects: LLVM, clang, lld. Herald added subscribers: rnkovacs, arichardson, mgorny, nhaehnle, jvesely, mehdi_amini, emaste, arsenm. Herald added a reviewer: espindola. Heral

[PATCH] D60997: Fix unquoted spaces in args in clang --verbose output

bmoody added a comment. I don't have commit access, so you are welcome to commit on my behalf. Thanks! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60997/new/ https://reviews.llvm.org/D60997 ___ cfe-commits mailing

r359049 - Improve -Wuninitialized warning under ARC for block variables that are

Author: ahatanak Date: Tue Apr 23 16:52:02 2019 New Revision: 359049 URL: http://llvm.org/viewvc/llvm-project?rev=359049&view=rev Log: Improve -Wuninitialized warning under ARC for block variables that are recursively captured. Under ARC, a block variable is zero-initialized when it is recursivel

r359048 - C++ DR2387: a variable template declared wtih (or instantiated with) a

Author: rsmith Date: Tue Apr 23 16:48:00 2019 New Revision: 359048 URL: http://llvm.org/viewvc/llvm-project?rev=359048&view=rev Log: C++ DR2387: a variable template declared wtih (or instantiated with) a const-qualified type is not implicitly given internal linkage. But a variable template declare

[PATCH] D60912: MS ABI: handle inline static data member and inline variable as template static data member

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Comment at: lib/CodeGen/CGDeclCXX.cpp:470-471 PrioritizedCXXGlobalInits.push_back(std::make_pair(Key, Fn)); - } else if (isTemplateInstantiation(D->getTemplateSpecializa

[PATCH] D60349: [COFF, ARM64] Fix ABI implementation of struct returns

efriedma added a comment. It looks like there's some missing documentation in the ARM64 ABI document involving homogeneous aggregates... in particular, it looks like non-POD types are never homogeneous, or something along those lines. I guess we can address that in a followup, though. @TomTan

[PATCH] D60629: [clang-tidy] Change the namespace for llvm checkers from 'llvm' to 'llvm_check'

alexfh added inline comments. Comment at: clang-tools-extra/clang-tidy/rename_check.py:271 +new_namespace = new_module + if old_module != new_module or new_namespace == 'llvm_check': check_implementation_files = glob.glob( Why `new_namespace == 'llvm_ch

[PATCH] D60912: MS ABI: handle inline static data member and inline variable as template static data member

jyu2 updated this revision to Diff 196346. jyu2 retitled this revision from "MS ABI: handle inline static data member as template static data member" to "MS ABI: handle inline static data member and inline variable as template static data member". jyu2 edited the summary of this revision. jyu2 ad

[PATCH] D60349: [COFF, ARM64] Fix ABI implementation of struct returns

mgrang updated this revision to Diff 196342. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60349/new/ https://reviews.llvm.org/D60349 Files: include/clang/AST/DeclCXX.h include/clang/CodeGen/CGFunctionInfo.h lib/CodeGen/CGCall.cpp lib/CodeGen/MicrosoftCXXABI.cpp lib/Sema/SemaDe

[PATCH] D60349: [COFF, ARM64] Fix ABI implementation of struct returns

mgrang updated this revision to Diff 196341. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60349/new/ https://reviews.llvm.org/D60349 Files: include/clang/AST/DeclCXX.h include/clang/CodeGen/CGFunctionInfo.h lib/CodeGen/CGCall.cpp lib/CodeGen/MicrosoftCXXABI.cpp lib/Sema/SemaDe

[PATCH] D60974: Clang IFSO driver action.

jakehehrlich added a comment. > The strong motivation here is to avoid having the list be maintained outside > of the source code. I am not too strongly tied to the YAML approach as long > as the binaries that we get at the end are equivalent to the pruned ELF > binaries from the YAML2ELF appro

[PATCH] D61040: [Fuchsia] Support multilib for -fsanitize=address and -fno-exceptions

phosek created this revision. phosek added reviewers: beanz, jroelofs, mcgrathr. Herald added subscribers: cfe-commits, javed.absar. Herald added a project: clang. This introduces a support for multilibs to Fuchsia driver. Unlike the existing multilibs that are used primarily for handling differen

[PATCH] D56571: [RFC prototype] Implementation of asm-goto support in clang

nickdesaulniers added a comment. @compudj email me the preprocessed output of basic_percpu_ops_test.c and I'll take a look. (Should be able to find my email via `git log`). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56571/new/ https://reviews.llvm.org/D56571 _

[PATCH] D60967: Move setTargetAttributes after setGVProperties in SetFunctionAttributes

This revision was automatically updated to reflect the committed changes. Closed by commit rC359039: Move setTargetAttributes after setGVProperties in SetFunctionAttributes (authored by scott.linder, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D609

r359039 - Move setTargetAttributes after setGVProperties in SetFunctionAttributes

Author: scott.linder Date: Tue Apr 23 14:50:11 2019 New Revision: 359039 URL: http://llvm.org/viewvc/llvm-project?rev=359039&view=rev Log: Move setTargetAttributes after setGVProperties in SetFunctionAttributes AMDGPU currently relies on global properties being set before setTargetProperties is c

[PATCH] D60967: Move setTargetAttributes after setGVProperties in SetFunctionAttributes

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Yeah, that's fine. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60967/new/ https://reviews.llvm.org/D60967

[PATCH] D60967: Move setTargetAttributes after setGVProperties in SetFunctionAttributes

scott.linder added a comment. In D60967#1476226 , @rjmccall wrote: > I suspect that other OpenCL and CUDA implementations don't care at all about > symbol visibility for device-side code generation, and giving kernel > functions default visibility seems

[PATCH] D56571: [RFC prototype] Implementation of asm-goto support in clang

compudj added a comment. Hi, First, thanks for working on this. I am the author of the "rseq" system call in the Linux kernel, and the user-space code required to interact with that system call requires asm goto. I therefore look forward to getting asm goto support in clang. I tried this patc

[PATCH] D60990: [Driver] Support priority for multilibs

phosek updated this revision to Diff 196331. phosek marked 2 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60990/new/ https://reviews.llvm.org/D60990 Files: clang/include/clang/Driver/Multilib.h clang/lib/Driver/Multilib.cpp Index: clang/lib/Driver/Multilib

[PATCH] D59121: [analyzer] Fix macro names in diagnostics within bigger macros.

This revision was automatically updated to reflect the committed changes. Closed by commit rC359037: [analyzer] Fix macro names in diagnostics within bigger macros. (authored by dergachev, committed by ). Changed prior to commit: https://reviews.llvm.org/D59121?vs=192917&id=196329#toc Reposito

r359037 - [analyzer] Fix macro names in diagnostics within bigger macros.

Author: dergachev Date: Tue Apr 23 14:30:30 2019 New Revision: 359037 URL: http://llvm.org/viewvc/llvm-project?rev=359037&view=rev Log: [analyzer] Fix macro names in diagnostics within bigger macros. If macro "CHECK_X(x)" expands to something like "if (x != NULL) ...", the "Assuming..." note no l

[PATCH] D60967: Move setTargetAttributes after setGVProperties in SetFunctionAttributes

rjmccall added a comment. I suspect that other OpenCL and CUDA implementations don't care at all about symbol visibility for device-side code generation, and giving kernel functions default visibility seems like the right thing to do for the (relatively few) things at the AST level that are sen

[PATCH] D60974: Clang IFSO driver action.

compnerd added a comment. The strong motivation here is to avoid having the list be maintained outside of the source code. I am not too strongly tied to the YAML approach as long as the binaries that we get at the end are equivalent to the pruned ELF binaries from the YAML2ELF approach. Howev

[PATCH] D60523: [clang] Don't segfault on incorrect using directive (PR41400)

riccibruno resigned from this revision. riccibruno added a comment. In D60523#1473867 , @riccibruno wrote: > I will take a look at this tomorrow, I know that it is annoying to get no > feedback! Sorry, I don't think I can judge whether this is the corre

[PATCH] D59977: [Lexer] Fix an off-by-one bug in Lexer::getAsCharRange() - NFC.

This revision was automatically updated to reflect the committed changes. Closed by commit rC359035: Re-apply r357823 "[Lexer] NFC: Fix an off-by-one bug in getAsCharRange()." (authored by dergachev, committed by ). Changed prior to commit: https://reviews.llvm.org/D59977?vs=196310&id=196323#t

[clang-tools-extra] r359035 - Re-apply r357823 "[Lexer] NFC: Fix an off-by-one bug in getAsCharRange()."

Author: dergachev Date: Tue Apr 23 14:15:26 2019 New Revision: 359035 URL: http://llvm.org/viewvc/llvm-project?rev=359035&view=rev Log: Re-apply r357823 "[Lexer] NFC: Fix an off-by-one bug in getAsCharRange()." It now comes with a follow-up fix for the clients of this API in clangd and clang-tidy

r359035 - Re-apply r357823 "[Lexer] NFC: Fix an off-by-one bug in getAsCharRange()."

Author: dergachev Date: Tue Apr 23 14:15:26 2019 New Revision: 359035 URL: http://llvm.org/viewvc/llvm-project?rev=359035&view=rev Log: Re-apply r357823 "[Lexer] NFC: Fix an off-by-one bug in getAsCharRange()." It now comes with a follow-up fix for the clients of this API in clangd and clang-tidy

r359034 - Revert "[MS] Emit S_HEAPALLOCSITE debug info" because of ToTWin64(db)

Author: akhuang Date: Tue Apr 23 14:12:58 2019 New Revision: 359034 URL: http://llvm.org/viewvc/llvm-project?rev=359034&view=rev Log: Revert "[MS] Emit S_HEAPALLOCSITE debug info" because of ToTWin64(db) buildbot failure. This reverts commit d07d6d617713bececf57f3547434dd52f0f13f9e and c774f687b6

[PATCH] D60967: Move setTargetAttributes after setGVProperties in SetFunctionAttributes

scott.linder added a comment. In D60967#1476069 , @rjmccall wrote: > In D60967#1476057 , @scott.linder > wrote: > > > In D60967#1476029 , @rjmccall > > wrote: > > > > > Sho

[PATCH] D60283: [DebugInfo] Don't emit checksums when compiling a preprocessed CPP

aganea updated this revision to Diff 196321. aganea retitled this revision from "[clang-cl] Don't emit checksums when compiling a preprocessed CPP" to "[DebugInfo] Don't emit checksums when compiling a preprocessed CPP". aganea added a comment. Herald added a project: LLVM. Herald added a subscri

[PATCH] D60967: Move setTargetAttributes after setGVProperties in SetFunctionAttributes

atanasyan added a comment. I do not see any problem from MIPS targets point of view. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60967/new/ https://reviews.llvm.org/D60967 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D59702: Unbreak the build of compiler-rt on Linux/mips64el

atanasyan added a comment. I'm sorry for delay with handling this issue. The **160** constant in the `FIRST_32_SECOND_64(144, 104)` depends on the following fragment from the `cmake/modules/HandleLLVMOptions.cmake` file introduced by the rL301171 . If `_LARGE

[PATCH] D60974: Clang IFSO driver action.

jakehehrlich added a comment. > I actually don't see why something like this couldn't be used in both > scenarios (ie some users generating the files at build time, and others using > -emit-ifso to periodically generate and land changes to checked in files). They could be used in parallel in mo

[PATCH] D60974: Clang IFSO driver action.

plotfi added a comment. In D60974#1476084 , @jakehehrlich wrote: > Why is this better than producing output from the output of the static linker > at the end? Also how do we plan on integrating this with llvm-elfabi so that > we don't have unnecessarily

[PATCH] D60996: [clang-format] Fix bug in reflow of block comments containing CR/LF

This revision was automatically updated to reflect the committed changes. Closed by commit rC359029: [clang-format] Fix bug in reflow of block comments containing CR/LF (authored by owenpan, committed by ). Changed prior to commit: https://reviews.llvm.org/D60996?vs=196261&id=196314#toc Reposi

r359029 - [clang-format] Fix bug in reflow of block comments containing CR/LF

Author: owenpan Date: Tue Apr 23 13:29:46 2019 New Revision: 359029 URL: http://llvm.org/viewvc/llvm-project?rev=359029&view=rev Log: [clang-format] Fix bug in reflow of block comments containing CR/LF Fix PR36119 Differential Revision: https://reviews.llvm.org/D60996 Modified: cfe/trunk/li

[PATCH] D59977: [Lexer] Fix an off-by-one bug in Lexer::getAsCharRange() - NFC.

NoQ marked an inline comment as done. NoQ added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/NamespaceCommentCheck.cpp:110-111 + Lexer::getSourceText(TextRange, Sources, getLangOpts()) + .rtrim('{') // Drop the { itself. + .rtrim()

[PATCH] D59977: [Lexer] Fix an off-by-one bug in Lexer::getAsCharRange() - NFC.

NoQ marked an inline comment as done. NoQ added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/ConcatNestedNamespacesCheck.cpp:42 const LangOptions &LangOpts) { + // FIXME: This logic breaks when there is a comment with ':'s

[PATCH] D59977: [Lexer] Fix an off-by-one bug in Lexer::getAsCharRange() - NFC.

NoQ updated this revision to Diff 196310. NoQ marked an inline comment as done. NoQ added a comment. Add comments that `getAsCharRange()` is in fact used often misused. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59977/new/ https://reviews.llvm.org/D59977 Files: clang-tools-extra/c

[PATCH] D60974: Clang IFSO driver action.

jakehehrlich added a comment. Why is this better than producing output from the output of the static linker at the end? Also how do we plan on integrating this with llvm-elfabi so that we don't have unnecessarily duplicated efforts? Why does that tool not suffice? > I'm well versed in the compl

[PATCH] D60967: Move setTargetAttributes after setGVProperties in SetFunctionAttributes

rjmccall added a comment. In D60967#1476057 , @scott.linder wrote: > In D60967#1476029 , @rjmccall wrote: > > > Shouldn't it be an error if the user tries to give it hidden visibility? > > > We effectively consider

[PATCH] D60967: Move setTargetAttributes after setGVProperties in SetFunctionAttributes

scott.linder added a comment. In D60967#1476029 , @rjmccall wrote: > Shouldn't it be an error if the user tries to give it hidden visibility? We effectively consider the user explicitly specifying that a symbol is e.g. a `kernel` to also carry with it v

[PATCH] D59963: [clang-tidy] Add a module for the Linux kernel.

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/linuxkernel/MustCheckErrsCheck.cpp:24 + "ERR_CAST", "PTR_ERR_OR_ZERO")); + auto NonCheckingStmts = stmt(anyOf(compoundStmt(), labelStmt())); + Finder->addMatcher(

[PATCH] D60967: Move setTargetAttributes after setGVProperties in SetFunctionAttributes

rjmccall added a comment. Shouldn't it be an error if the user tries to give it hidden visibility? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60967/new/ https://reviews.llvm.org/D60967 ___ cfe-commits mailing list

[PATCH] D60485: [AArch64] Add support for MTE intrinsics

javed.absar updated this revision to Diff 196297. javed.absar marked an inline comment as done. javed.absar added a comment. Hi Tim: Have made the changes as suggested. Please have a look. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60485/new/ https://reviews.llvm.org/D60485 Files:

[PATCH] D60967: Move setTargetAttributes after setGVProperties in SetFunctionAttributes

scott.linder added a comment. In D60967#1475925 , @rjmccall wrote: > It seems reasonable to me for target hooks to run after global hooks, but can > I ask why AMDGPU specifically relies on this? We want to ensure certain symbols have a meaningful visibi

[PATCH] D60985: Fix compatability for cuda sm_75

eagleonhill added a comment. That's great! will it be cherry-picked for clang8.1 if there's one? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60985/new/ https://reviews.llvm.org/D60985 ___ cfe-commits mailing list c

[PATCH] D60507: [clang-tidy] new check: bugprone-unhandled-self-assignment

ztamas marked 8 inline comments as done. ztamas added a comment. Mark some comments Done, which were handled some way. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60507/new/ https://reviews.llvm.org/D60507 _

[PATCH] D61022: [ThinLTO] Pass down opt level to LTO backend and handle -O0 LTO in new PM

This revision was automatically updated to reflect the committed changes. Closed by commit rL359025: [ThinLTO] Pass down opt level to LTO backend and handle -O0 LTO in new PM (authored by tejohnson, committed by ). Changed prior to commit: https://reviews.llvm.org/D61022?vs=196263&id=196296#toc

r359025 - [ThinLTO] Pass down opt level to LTO backend and handle -O0 LTO in new PM

Author: tejohnson Date: Tue Apr 23 11:56:19 2019 New Revision: 359025 URL: http://llvm.org/viewvc/llvm-project?rev=359025&view=rev Log: [ThinLTO] Pass down opt level to LTO backend and handle -O0 LTO in new PM Summary: The opt level was not being passed down to the ThinLTO backend when invoked vi

[PATCH] D60974: Clang IFSO driver action.

compnerd added inline comments. Comment at: clang/lib/Frontend/FrontendActions.cpp:326 +(*OS) << " - Name:.text\n"; +(*OS) << "Type:STT_SECTION\n"; +(*OS) << "Section: .text\n"; This is wrong, this marks the ty

[PATCH] D60507: [clang-tidy] new check: bugprone-unhandled-self-assignment

ztamas added a comment. I also reformatted the code with clang-format. So now the templates are handled, however, it's still not fit with the cert rule because we not catch all classes, but only those who have suspicious fields. I think this one can be added in a follow-up patch and then this c

[PATCH] D60974: Clang IFSO driver action.

plotfi added a comment. In D60974#1474777 , @jakehehrlich wrote: > In D60974#1474751 , @plotfi wrote: > > > There are a few that I have in mind. > > > > 1. -emit-ifso could be added to a build to produce .so files

[PATCH] D60974: Clang IFSO driver action.

compnerd added a comment. BTW, to clarify how this is intended to be used: the collection of the public interfaces defines the *public* interfaces of the module. This information can be used to generate a **minimally** viable ELF module that the linker can use to link against - no `.text` segm

[PATCH] D60507: [clang-tidy] new check: bugprone-unhandled-self-assignment

ztamas updated this revision to Diff 196295. ztamas added a comment. Make the check to work with templates too Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60507/new/ https://reviews.llvm.org/D60507 Files: clang-tools-extra/clang-tidy/bugprone/

[PATCH] D59963: [clang-tidy] Add a module for the Linux kernel.

gribozavr added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/linuxkernel-must-use-errs.rst:10 +functions are marked with ``__attribute__((warn_unused_result))``, but +the compiler warning for this attribute is not always enabled. + tmroe

[PATCH] D60974: Clang IFSO driver action.

plotfi added a comment. In D60974#1474994 , @compnerd wrote: > Note that I am not advocating that this change go in as is - I think that > this is far from something which would be useful, and until it can produce > something meaningful, this shouldn't r

[PATCH] D60974: Clang IFSO driver action.

plotfi updated this revision to Diff 196291. plotfi added a comment. Herald added a subscriber: mgrang. I've added an output format. The YAML coming out of -emit-ifso can now run through yaml2obj to produce a striped .o file. Those .o files can be handled by an existing linker. Repository: r

[PATCH] D61032: [clang] Avoid defining duplicate header search paths for libc++ on Darwin

ldionne added a comment. I will build a significant codebase with the change and report on the results, since we lack good tests for the removal of `/usr/include/c++/v1`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61032/new/ https://reviews.llv

[PATCH] D61032: [clang] Avoid defining duplicate header search paths for libc++ on Darwin

ldionne created this revision. ldionne added a reviewer: jfb. Herald added a reviewer: EricWF. Herald added subscribers: cfe-commits, dexonsmith, jkorous. Herald added a project: clang. Before this patch, we would add both /usr/include/c++/v1 and /usr/include/c++/v1 to the header search paths for

[PATCH] D60967: Move setTargetAttributes after setGVProperties in SetFunctionAttributes

rjmccall added a comment. It seems reasonable to me for target hooks to run after global hooks, but can I ask why AMDGPU specifically relies on this? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60967/new/ https://reviews.llvm.org/D60967

[PATCH] D60507: [clang-tidy] new check: bugprone-unhandled-self-assignment

ztamas marked 3 inline comments as done. ztamas added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/UnhandledSelfAssignmentCheck.cpp:62-64 + const auto ThisHasSuspiciousField = cxxMethodDecl(ofClass(cxxRecordDecl( + has(fieldDecl(anyOf(hasType(pointerT

[PATCH] D61022: [ThinLTO] Pass down opt level to LTO backend and handle -O0 LTO in new PM

mehdi_amini added inline comments. Comment at: llvm/test/tools/gold/X86/opt-level.ll:53 + ; CHECK-O1-OLDPM: select + ; The new PM does not do as many optimizations at O1 + ; CHECK-O1-NEWPM: phi tejohnson wrote: > chandlerc wrote: > > tejohnson wrote: > > > tej

[PATCH] D60507: [clang-tidy] new check: bugprone-unhandled-self-assignment

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/UnhandledSelfAssignmentCheck.cpp:54 + recordType(hasDeclaration(classTemplateSpecializationDecl( + hasAnyName("std::shared_ptr", "std::unique_ptr", "std::weak_ptr", +

[PATCH] D60507: [clang-tidy] new check: bugprone-unhandled-self-assignment

ztamas added a comment. Ok, so I removed the alias from cert module and added CERT rule link as a "see also". So I think we solved the problem that things do not conform with the CERT requirements and can focus on the actual problem. Summary, templates are still ignored. If there is any idea ho

[PATCH] D60956: [Sema] Fix the lookup for a declaration conflicting with an enumerator (bogus use of LookupResult::getAsSingle)

riccibruno marked an inline comment as done. riccibruno added inline comments. Comment at: test/CXX/dcl.dcl/dcl.enum/p11-enumerator_scope.cpp:107 enum { typedef_type };// expected-error {{redefinition of 'typedef_type'}} }; Note also that t

[PATCH] D61022: [ThinLTO] Pass down opt level to LTO backend and handle -O0 LTO in new PM

xur accepted this revision. xur added a comment. This revision is now accepted and ready to land. LGTM. We need to Initialize the OptLevel no matter what. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61022/new/ https://reviews.llvm.org/D61022

[PATCH] D60507: [clang-tidy] new check: bugprone-unhandled-self-assignment

ztamas marked 5 inline comments as done. ztamas added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/UnhandledSelfAssignmentCheck.cpp:34-36 + const auto HasNoSelfCheck = cxxMethodDecl(unless(hasDescendant( + binaryOperator(anyOf(hasOperatorName("=="), h

[PATCH] D60507: [clang-tidy] new check: bugprone-unhandled-self-assignment

ztamas updated this revision to Diff 196279. ztamas added a comment. Added missing fullstop Added a new test cases making sure that HasNoSelfCheck works correctly Added template instantiation to tests Remove the alias from cert module and add the CERT link as a see also Repository: rG LLVM Git

[PATCH] D61022: [ThinLTO] Pass down opt level to LTO backend and handle -O0 LTO in new PM

tejohnson marked an inline comment as done. tejohnson added inline comments. Comment at: llvm/test/tools/gold/X86/opt-level.ll:53 + ; CHECK-O1-OLDPM: select + ; The new PM does not do as many optimizations at O1 + ; CHECK-O1-NEWPM: phi chandlerc wrote: > tejoh

[PATCH] D61029: clang-cl: List valid values for /std: in /? output

thakis created this revision. thakis added a reviewer: hans. https://reviews.llvm.org/D61029 Files: clang/include/clang/Driver/CLCompatOptions.td Index: clang/include/clang/Driver/CLCompatOptions.td === --- clang/include/clang/Dr

[PATCH] D58537: lib/Header: Simplify CMakeLists.txt

vzakhari added inline comments. Comment at: cfe/trunk/lib/Headers/CMakeLists.txt:168 install( - FILES ${cuda_wrapper_files} - COMPONENT clang-headers - PERMISSIONS OWNER_READ OWNER_WRITE GROUP_READ WORLD_READ - DESTINATION lib${LLVM_LIBDIR_SUFFIX}/clang/${CLANG_VERSION}/inc

[PATCH] D61022: [ThinLTO] Pass down opt level to LTO backend and handle -O0 LTO in new PM

chandlerc added inline comments. Comment at: llvm/test/tools/gold/X86/opt-level.ll:53 + ; CHECK-O1-OLDPM: select + ; The new PM does not do as many optimizations at O1 + ; CHECK-O1-NEWPM: phi tejohnson wrote: > tejohnson wrote: > > mehdi_amini wrote: > > > Thi

[PATCH] D59712: [APSInt][OpenMP] Fix isNegative, etc. for unsigned types

This revision was automatically updated to reflect the committed changes. Closed by commit rC359012: [APSInt][OpenMP] Fix isNegative, etc. for unsigned types (authored by jdenny, committed by ). Changed prior to commit: https://reviews.llvm.org/D59712?vs=195626&id=196274#toc Repository: rC C

[PATCH] D60507: [clang-tidy] new check: bugprone-unhandled-self-assignment

ztamas marked an inline comment as done. ztamas added inline comments. Comment at: clang-tools-extra/test/clang-tidy/bugprone-unhandled-self-assignment.cpp:351 + int *p; +}; aaron.ballman wrote: > ztamas wrote: > > aaron.ballman wrote: > > > ztamas wrote: > > >

[PATCH] D59963: [clang-tidy] Add a module for the Linux kernel.

tmroeder updated this revision to Diff 196273. tmroeder added a comment. Remove an unnecessary header and fix the error text. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59963/new/ https://reviews.llvm.org/D59963 Files: clang-tools-extra/clang

  1   2   >