scott.linder added a comment. In D60967#1475925 <https://reviews.llvm.org/D60967#1475925>, @rjmccall wrote:
> It seems reasonable to me for target hooks to run after global hooks, but can > I ask why AMDGPU specifically relies on this? We want to ensure certain symbols have a meaningful visibility. For example, kernel symbols must not have hidden visibility. It's reasonable for the user to arrange for a kernel symbol to have either protected or default visibility, though, so we want our hook to be run after the global hooks have already calculated the global visibility. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60967/new/ https://reviews.llvm.org/D60967 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
