compnerd added inline comments.
================ Comment at: clang/lib/Frontend/FrontendActions.cpp:326 + (*OS) << " - Name: .text\n"; + (*OS) << " Type: STT_SECTION\n"; + (*OS) << " Section: .text\n"; ---------------- This is wrong, this marks the type to be a section symbol, which is not correct. ================ Comment at: clang/lib/Frontend/FrontendActions.cpp:332 + << " Section: .text\n" + << " Binding: STB_GLOBAL\n"; + (*OS) << "...\n"; ---------------- Hmm, you need to classify the data symbols properly and mark them appropriately, not as `STT_FUNC`. This is particularly important on ARM where the ISA selection bit may alter the address. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60974/new/ https://reviews.llvm.org/D60974 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
