[PATCH] D46862: [libclang] Optionally add code completion results for arrow instead of dot

yvvan added inline comments. Comment at: include/clang-c/Index.h:5264 + * FixIts that *must* be applied before inserting the text for the + * corresponding completion item. + * nik wrote: > * Please use proper documentation style, e.g. make use of "\brief", "\par

[PATCH] D46862: [libclang] Optionally add code completion results for arrow instead of dot

yvvan updated this revision to Diff 149049. yvvan marked 6 inline comments as done. yvvan added a comment. Address review comments https://reviews.llvm.org/D46862 Files: include/clang-c/Index.h include/clang/Sema/CodeCompleteConsumer.h test/Index/complete-arrow-dot.cpp tools/c-index-tes

[PATCH] D47137: [Sparc] Add floating-point register names

This revision was automatically updated to reflect the committed changes. Closed by commit rL333510: [Sparc] Add floating-point register names (authored by dcederman, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D47137?vs=148351&id=1

r333510 - [Sparc] Add floating-point register names

Author: dcederman Date: Tue May 29 23:02:18 2018 New Revision: 333510 URL: http://llvm.org/viewvc/llvm-project?rev=333510&view=rev Log: [Sparc] Add floating-point register names Reviewers: jyknight Reviewed By: jyknight Subscribers: eraman, fedor.sergeev, jrtc27, cfe-commits Differential Revis

[PATCH] D45517: [analyzer] False positive refutation with Z3

rnkovacs added inline comments. Comment at: lib/StaticAnalyzer/Core/Z3ConstraintManager.cpp:1249 +bool Z3ConstraintManager::isModelFeasible() { + return Solver.check() != Z3_L_FALSE; +} george.karpenkov wrote: > solver can also return "unknown", what happens the

r333509 - [X86] Remove masking from the AVX512VNNI builtins. Use a select in IR instead.

Author: ctopper Date: Tue May 29 22:26:04 2018 New Revision: 333509 URL: http://llvm.org/viewvc/llvm-project?rev=333509&view=rev Log: [X86] Remove masking from the AVX512VNNI builtins. Use a select in IR instead. Modified: cfe/trunk/include/clang/Basic/BuiltinsX86.def cfe/trunk/lib/Header

Re: r333498 - Sema: Add a flag for rejecting member pointers with incomplete base types.

Ah, sorry I just saw 333501 and this already passed on the bot. All green again. Thanks for the quick patch, sorry for the noise. -Mike On Tue, May 29, 2018 at 9:33 PM, Mike Edwards wrote: > Hi Peter, > Would you please have a look at: > http://green.lab.llvm.org/green/job/clang-stage1-cmake-

Re: r333498 - Sema: Add a flag for rejecting member pointers with incomplete base types.

Hi Peter, Would you please have a look at: http://green.lab.llvm.org/green/job/clang-stage1-cmake-RA-incremental/48945/ It looks like this commit cause a test failure on the Green Dragon Incremental Builder. Thanks, Mike On Tue, May 29, 2018 at 8:40 PM, Peter Collingbourne via cfe-commits < cfe-

r333501 - Protect a clang-cl file path with --.

Author: pcc Date: Tue May 29 21:08:34 2018 New Revision: 333501 URL: http://llvm.org/viewvc/llvm-project?rev=333501&view=rev Log: Protect a clang-cl file path with --. Modified: cfe/trunk/test/Driver/complete-member-pointers.cpp Modified: cfe/trunk/test/Driver/complete-member-pointers.cpp UR

[PATCH] D47067: Update NRVO logic to support early return

tzik added a comment. In https://reviews.llvm.org/D47067#1115566, @rsmith wrote: > Thank you, do you need someone to commit this for you? No, I recently got the commit access to the repository. Repository: rC Clang https://reviews.llvm.org/D47067

[PATCH] D47067: Update NRVO logic to support early return

This revision was automatically updated to reflect the committed changes. Closed by commit rC333500: Update NRVO logic to support early return (authored by tzik, committed by ). Changed prior to commit: https://reviews.llvm.org/D47067?vs=148603&id=149035#toc Repository: rC Clang https://rev

r333500 - Update NRVO logic to support early return

Author: tzik Date: Tue May 29 20:53:16 2018 New Revision: 333500 URL: http://llvm.org/viewvc/llvm-project?rev=333500&view=rev Log: Update NRVO logic to support early return Summary: The previous implementation misses an opportunity to apply NRVO (Named Return Value Optimization) below. That disc

Buildbot numbers for the week of 5/20/2018 - 5/26/2018

Hello everyone, Below are some buildbot numbers for the last week of 5/20/2018 - 5/26/2018. Please see the same data in attached csv files: The longest time each builder was red during the week; "Status change ratio" by active builder (percent of builds that changed the builder status from greed

Buildbot numbers for the week of 5/13/2018 - 5/19/2018

Hello everyone, Below are some buildbot numbers for the week of 5/13/2018 - 5/19/2018. Please see the same data in attached csv files: The longest time each builder was red during the week; "Status change ratio" by active builder (percent of builds that changed the builder status from greed to r

Buildbot numbers for the week of 5/6/2018 - 5/12/2018

Hello everyone, Below are some buildbot numbers for the week of 5/6/2018 - 5/12/2018. Please see the same data in attached csv files: The longest time each builder was red during the week; "Status change ratio" by active builder (percent of builds that changed the builder status from greed to re

r333498 - Sema: Add a flag for rejecting member pointers with incomplete base types.

Author: pcc Date: Tue May 29 20:40:04 2018 New Revision: 333498 URL: http://llvm.org/viewvc/llvm-project?rev=333498&view=rev Log: Sema: Add a flag for rejecting member pointers with incomplete base types. Codebases that need to be compatible with the Microsoft ABI can pass this flag to avoid issu

[PATCH] D47503: Sema: Add a flag for rejecting member pointers with incomplete base types.

This revision was automatically updated to reflect the committed changes. Closed by commit rC333498: Sema: Add a flag for rejecting member pointers with incomplete base types. (authored by pcc, committed by ). Changed prior to commit: https://reviews.llvm.org/D47503?vs=149029&id=149031#toc Rep

r333497 - [X86] Fix the names of a bunch of icelake intrinsics.

Author: ctopper Date: Tue May 29 20:38:15 2018 New Revision: 333497 URL: http://llvm.org/viewvc/llvm-project?rev=333497&view=rev Log: [X86] Fix the names of a bunch of icelake intrinsics. Mostly this fixes the names of all the 128-bit intrinsics to start with _mm_ instead of _mm128_ as is the co

[PATCH] D47503: Sema: Add a warning for member pointers with incomplete base types.

pcc updated this revision to Diff 149029. pcc added a comment. - Implement as -f flag https://reviews.llvm.org/D47503 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/include/clang/Basic/LangOptions.def clang/include/clang/Driver/Options.td clang/lib/Driver/ToolChains/Clang

[PATCH] D44931: [WebAssembly] Use Windows EH instructions for Wasm EH

aheejin added a comment. Oh no, sorry, it actually depends on https://reviews.llvm.org/D43746; but not others on the chain. I changed the signatures of `wasm.get.exception` and `wasm.get.ehselector` intrinsics to take a token argument, and the intrinsic signature change is added in https://revi

[PATCH] D46971: [DWARF] Get RA from RA register even if it appears unused

whitequark added a comment. > It would be nice if we had a test case added for this This is inherently architecture and platform specific, and libunwind currently doesn't have any provisions for this... In principle, would a x86-only Linux-only test suffice? I'm not sure if I can spend time mak

[PATCH] D44931: [WebAssembly] Use Windows EH instructions for Wasm EH

aheejin added a comment. Thanks! No, it does not depend on the other CL chain on the llvm side. Repository: rC Clang https://reviews.llvm.org/D44931 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/lis

[PATCH] D47503: Sema: Add a warning for member pointers with incomplete base types.

pcc added inline comments. Comment at: clang/lib/Sema/SemaType.cpp:7599-7604 + if (!Context.getDiagnostics().isIgnored(diag::warn_memptr_incomplete, + Loc) && + !MPTy->getClass()->getAsCXXRecordDecl()->isBeingDefined() &&

[PATCH] D46846: [AST] Fix loss of enum forward decl from decl context

jdenny updated this revision to Diff 149021. jdenny added a comment. Rebased. Ping. https://reviews.llvm.org/D46846 Files: lib/Sema/SemaDecl.cpp test/Sema/ast-print.c test/SemaCXX/MicrosoftCompatibility.cpp Index: test/SemaCXX/MicrosoftCompatibility.cpp

[PATCH] D46805: If some platforms do not support an attribute, we should exclude the platform

rsmith added a comment. In https://reviews.llvm.org/D46805#1113358, @aaron.ballman wrote: > @rsmith -- do the object file formats listed look correct to you? They look at least plausible. We should be able to test whether LLVM can actually emit aliases on each of these targets easily enough...

r333491 - Fix test failure after r333485. Try 2.

Author: ericwf Date: Tue May 29 19:20:40 2018 New Revision: 333491 URL: http://llvm.org/viewvc/llvm-project?rev=333491&view=rev Log: Fix test failure after r333485. Try 2. Sorry for the breakage. Modified: cfe/trunk/test/Misc/diag-template-diffing.cpp Modified: cfe/trunk/test/Misc/diag-temp

Re: r333485 - [Sema] Use %sub to cleanup overload diagnostics

Sorry for the breakage. Fix incoming as soon as my test suite run completes. On Tue, May 29, 2018 at 7:00 PM, Eric Fiselier via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: ericwf > Date: Tue May 29 18:00:41 2018 > New Revision: 333485 > > URL: http://llvm.org/viewvc/llvm-project?re

r333489 - Make the mangled name collision diagnostic a bit more useful by listing the mangling.

Author: rsmith Date: Tue May 29 18:52:16 2018 New Revision: 333489 URL: http://llvm.org/viewvc/llvm-project?rev=333489&view=rev Log: Make the mangled name collision diagnostic a bit more useful by listing the mangling. This helps especially when the collision is for a template specialization, wh

[PATCH] D47503: Sema: Add a warning for member pointers with incomplete base types.

rsmith added inline comments. Comment at: clang/lib/Sema/SemaType.cpp:7599-7604 + if (!Context.getDiagnostics().isIgnored(diag::warn_memptr_incomplete, + Loc) && + !MPTy->getClass()->getAsCXXRecordDecl()->isBeingDefined()

[PATCH] D47503: Sema: Add a warning for member pointers with incomplete base types.

pcc updated this revision to Diff 149017. pcc added a comment. - Move the warning to RequireCompleteTypeImpl https://reviews.llvm.org/D47503 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/lib/Sema/SemaType.cpp clang/test/SemaCXX/warn-incomplete-member-pointers.cpp Index:

r333488 - Fix test failure after r333485.

Author: ericwf Date: Tue May 29 18:22:14 2018 New Revision: 333488 URL: http://llvm.org/viewvc/llvm-project?rev=333488&view=rev Log: Fix test failure after r333485. I missed adjusting a test under Misc in the last commit. This patch updates that test. Modified: cfe/trunk/test/Misc/diag-templ

[PATCH] D47233: [CodeGen] Emit MSVC RTTI for Obj-C EH types

DHowett-MSFT accepted this revision. DHowett-MSFT added a comment. This revision is now accepted and ready to land. This largely matches what we've done in the WinObjC clang patchset here

r333486 - [ODRHash] Support FunctionTemplateDecl in records.

Author: rtrieu Date: Tue May 29 18:12:26 2018 New Revision: 333486 URL: http://llvm.org/viewvc/llvm-project?rev=333486&view=rev Log: [ODRHash] Support FunctionTemplateDecl in records. Modified: cfe/trunk/include/clang/Basic/DiagnosticSerializationKinds.td cfe/trunk/lib/AST/ODRHash.cpp

[PATCH] D47101: [Sema] Use %sub to cleanup overload diagnostics

This revision was automatically updated to reflect the committed changes. Closed by commit rL333485: [Sema] Use %sub to cleanup overload diagnostics (authored by EricWF, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D47101?vs=147649&i

r333485 - [Sema] Use %sub to cleanup overload diagnostics

Author: ericwf Date: Tue May 29 18:00:41 2018 New Revision: 333485 URL: http://llvm.org/viewvc/llvm-project?rev=333485&view=rev Log: [Sema] Use %sub to cleanup overload diagnostics Summary: This patch adds the newly added `%sub` diagnostic modifier to cleanup repetition in the overload candidate

[PATCH] D45212: Add HIP toolchain

This revision was automatically updated to reflect the committed changes. yaxunl marked an inline comment as done. Closed by commit rC333484: Add HIP toolchain (authored by yaxunl, committed by ). Changed prior to commit: https://reviews.llvm.org/D45212?vs=148277&id=149013#toc Repository: rC

r333484 - Add HIP toolchain

Author: yaxunl Date: Tue May 29 17:53:50 2018 New Revision: 333484 URL: http://llvm.org/viewvc/llvm-project?rev=333484&view=rev Log: Add HIP toolchain This patch adds HIP toolchain to support HIP language mode. It includes: Create specific compiler jobs for HIP. Choose specific libraries for HI

[PATCH] D47503: Sema: Add a warning for member pointers with incomplete base types.

pcc added inline comments. Comment at: clang/lib/Sema/SemaType.cpp:2451-2455 + // FIXME: This will cause errors if template instantiation fails. + if (!Context.getDiagnostics().isIgnored(diag::warn_memptr_incomplete, Loc) && + !Class->isDependentType() && + !Class->ge

[PATCH] D46476: [HIP] Add action builder for HIP

This revision was automatically updated to reflect the committed changes. yaxunl marked an inline comment as done. Closed by commit rC333483: Add action builder for HIP (authored by yaxunl, committed by ). Changed prior to commit: https://reviews.llvm.org/D46476?vs=148051&id=149012#toc Reposit

r333483 - Add action builder for HIP

Author: yaxunl Date: Tue May 29 17:49:10 2018 New Revision: 333483 URL: http://llvm.org/viewvc/llvm-project?rev=333483&view=rev Log: Add action builder for HIP To support separate compile/link and linking across device IR in different source files, a new HIP action builder is introduced. Basical

Re: r332839 - [CodeGen] Disable aggressive structor optimizations at -O0, take 2

Sorry, this is still resulting in problems: we're seeing miscompiles and "definition with same mangled name as another definition" errors after this change. It seems plausible that this is a pre-existing issue that's just being exposed by this change, but either way I've temporarily reverted this i

r333482 - Revert r332839.

Author: rsmith Date: Tue May 29 17:45:10 2018 New Revision: 333482 URL: http://llvm.org/viewvc/llvm-project?rev=333482&view=rev Log: Revert r332839. This is causing miscompiles and "definition with same mangled name as another definition" errors. Modified: cfe/trunk/lib/CodeGen/ItaniumCXXABI

[PATCH] D47480: clang-cl: Expose -no-canonical-prefixes

takuto.ikuta added a comment. GetExecutablePath is called here. http://llvm-cs.pcc.me.uk/tools/clang/tools/driver/driver.cpp#427 You'll understand what I said if you see the behavior of clang-cl on windows. Comment at: test/Driver/cl-options.c:595 +// RUN: -no-canonical-pr

[PATCH] D37035: Implement __builtin_LINE() et. al. to support source location capture.

EricWF updated this revision to Diff 149009. EricWF added a comment. - Fix merge conflicts. https://reviews.llvm.org/D37035 Files: docs/LanguageExtensions.rst include/clang/AST/Expr.h include/clang/AST/ExprCXX.h include/clang/AST/RecursiveASTVisitor.h include/clang/AST/SourceLocExprSc

[PATCH] D45517: [analyzer] False positive refutation with Z3

george.karpenkov added inline comments. Comment at: lib/StaticAnalyzer/Core/Z3ConstraintManager.cpp:1267 + +Z3Expr Constraints = Z3Expr::fromBoolean(false); + george.karpenkov wrote: > almost certainly a bug, we shouldn't default to unfeasible when the list o

[PATCH] D45517: [analyzer] False positive refutation with Z3

NoQ added inline comments. Comment at: lib/StaticAnalyzer/Core/Z3ConstraintManager.cpp:1292 + Constraints = + Z3Expr::fromBinOp(Constraints, BO_LOr, SymRange, IsSignedTy); +} george.karpenkov wrote: > I'm very confused as to why are we doing dis

[PATCH] D47101: [Sema] Use %sub to cleanup overload diagnostics

EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. Actually I'm OK making this a post-commit review. @rsmith Please let me know if you have any thoughts in your own time. Repository: rC Clang https://reviews.llvm.org/D47101

[PATCH] D45517: [analyzer] False positive refutation with Z3

george.karpenkov added inline comments. Comment at: include/clang/StaticAnalyzer/Core/PathSensitive/ProgramState.h:496 std::unique_ptr ConstraintMgr; + std::unique_ptr RefutationMgr; See the comment below, I think we should not have this manager here. J

[PATCH] D47101: [Sema] Use %sub to cleanup overload diagnostics

EricWF added a comment. @rsmith Ping. Do you have any objection to the addition of "template" to some of the overload diagnostics? Repository: rC Clang https://reviews.llvm.org/D47101 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

[PATCH] D47067: Update NRVO logic to support early return

rsmith added a comment. Thank you, do you need someone to commit this for you? Repository: rC Clang https://reviews.llvm.org/D47067 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D37035: Implement __builtin_LINE() et. al. to support source location capture.

EricWF updated this revision to Diff 149007. EricWF added a comment. - Merge with upstream. Ping. https://reviews.llvm.org/D37035 Files: docs/LanguageExtensions.rst include/clang/AST/Expr.h include/clang/AST/ExprCXX.h include/clang/AST/RecursiveASTVisitor.h include/clang/AST/SourceLo

[PATCH] D47358: : Implement {un, }synchronized_pool_resource.

Quuxplusone added inline comments. Comment at: test/std/experimental/memory/memory.resource.pool/pool_options.pass.cpp:11 +// UNSUPPORTED: c++98, c++03, c++11, c++14 +// UNSUPPORTED: apple-clang-7 + This test comes from Eric's D27402. The default-initialization

[PATCH] D47358: : Implement {un, }synchronized_pool_resource.

Quuxplusone updated this revision to Diff 149006. Quuxplusone added a comment. Rebase and update the diff. Repository: rCXX libc++ https://reviews.llvm.org/D47358 Files: include/experimental/memory_resource src/experimental/memory_resource.cpp test/std/experimental/memory/memory.resour

[PATCH] D45835: Add new driver mode for dumping compiler options

rsmith added a comment. +@dlj, who had some more ambitious plans for expressing our configuration as JSON. The part you have here seems fine. I share Eli's concerns about exposing our `LangOptions` with any kind of implied stability guarantee. https://reviews.llvm.org/D45835 __

[PATCH] D44931: [WebAssembly] Use Windows EH instructions for Wasm EH

dschuff accepted this revision. dschuff added a comment. This revision is now accepted and ready to land. LGTM assuming we are convinced for now that finding the rethrow block from the CatchSwitch will work. Does this need to wait until after https://reviews.llvm.org/D43746 or other CLs from tha

[PATCH] D47503: Sema: Add a warning for member pointers with incomplete base types.

rsmith added a comment. In https://reviews.llvm.org/D47503#1115505, @rnk wrote: > [...] And rewrite the side-effecting isCompleteType call to use > RequireCompleteType with the warning diagnostic. We should keep the `isCompleteType` call and diagnose `if (!isCompleteType(...))`. `RequireCompl

[libcxx] r333479 - Mark deduction guide tests as failing on apple-clang-9

Author: jfb Date: Tue May 29 16:28:04 2018 New Revision: 333479 URL: http://llvm.org/viewvc/llvm-project?rev=333479&view=rev Log: Mark deduction guide tests as failing on apple-clang-9 As discussed here: http://lists.llvm.org/pipermail/cfe-dev/2018-May/058116.html The tests fail on clang-5, as we

[PATCH] D47503: Sema: Add a warning for member pointers with incomplete base types.

rnk added a comment. Should we do this in exactly the places we would lock in an inheritance model in the MS ABI, i.e. when the member pointer type is required to be complete? I think we could take this code: bool Sema::RequireCompleteTypeImpl(SourceLocation Loc, QualType T,

[PATCH] D47503: Sema: Add a warning for member pointers with incomplete base types.

pcc updated this revision to Diff 149001. pcc added a comment. - One more negative test https://reviews.llvm.org/D47503 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/lib/Sema/SemaType.cpp clang/test/SemaCXX/warn-incomplete-member-pointers.cpp Index: clang/test/SemaCXX/wa

[PATCH] D47503: Sema: Add a warning for member pointers with incomplete base types.

pcc updated this revision to Diff 149000. pcc added a comment. - Add some negative tests https://reviews.llvm.org/D47503 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/lib/Sema/SemaType.cpp clang/test/SemaCXX/warn-incomplete-member-pointers.cpp Index: clang/test/SemaCXX/w

[PATCH] D47503: Sema: Add a warning for member pointers with incomplete base types.

pcc created this revision. pcc added reviewers: rnk, rsmith. Codebases that need to be compatible with the Microsoft ABI can enable this warning to avoid issues caused by the lack of a fixed ABI for incomplete member pointers. https://reviews.llvm.org/D47503 Files: clang/include/clang/Basic/D

[PATCH] D46791: Make -gsplit-dwarf generally available

compnerd added inline comments. Comment at: test/Driver/split-debug.c:23 +// Macosx // RUN: %clang -target x86_64-macosx -gsplit-dwarf -c -### %s 2> %t NIT: macOS or the legacy spelling of Mac OS X. https://reviews.llvm.org/D46791

[PATCH] D46971: [DWARF] Get RA from RA register even if it appears unused

compnerd added a comment. It would be nice if we had a test case added for this, but, seems correct to me. Comment at: src/DwarfInstructions.hpp:195 } +else if (i == (int)cieInfo.returnAddressRegister) + returnAddress = registers.getRegister(i); --

[PATCH] D47480: clang-cl: Expose -no-canonical-prefixes

thakis added a subscriber: rnk. thakis added a comment. But GetExecutablePath isn't called if -no-canonical-prefixes is passed, is it? (See the first link I pasted above) https://reviews.llvm.org/D47480 ___ cfe-commits mailing list cfe-commits@lists

Re: [PATCH] D47480: clang-cl: Expose -no-canonical-prefixes

But GetExecutablePath isn't called if -no-canonical-prefixes is passed, is it? (See the first link I pasted above) On Tue, May 29, 2018, 5:28 PM Takuto Ikuta via Phabricator via cfe-commits < cfe-commits@lists.llvm.org> wrote: > takuto.ikuta added a comment. > > On windows, argv0 is changed to ab

r333471 - Check pointer null-ness before dereferencing it.

Author: rtrieu Date: Tue May 29 15:43:00 2018 New Revision: 333471 URL: http://llvm.org/viewvc/llvm-project?rev=333471&view=rev Log: Check pointer null-ness before dereferencing it. -Warc-repeated-use-of-weak may trigger a segmentation fault when the Decl being checked is outside of a function sc

[PATCH] D47357: [Driver] Rename DefaultTargetTriple to TargetTriple

This revision was automatically updated to reflect the committed changes. Closed by commit rC333468: [Driver] Rename DefaultTargetTriple to TargetTriple (authored by phosek, committed by ). Changed prior to commit: https://reviews.llvm.org/D47357?vs=148539&id=148996#toc Repository: rC Clang

r333468 - [Driver] Rename DefaultTargetTriple to TargetTriple

Author: phosek Date: Tue May 29 15:35:39 2018 New Revision: 333468 URL: http://llvm.org/viewvc/llvm-project?rev=333468&view=rev Log: [Driver] Rename DefaultTargetTriple to TargetTriple While this value is initialized with the DefaultTargetTriple, it can be later overriden using the -target flag s

[PATCH] D47157: Warning for framework headers using double quote includes

dexonsmith added inline comments. Comment at: lib/Lex/HeaderSearch.cpp:753-754 + IncluderAndDir.second->getName())) +Diags.Report(IncludeLoc, + diag::warn_quoted_include_in_framework_header) +<< Filename; --

[PATCH] D45012: [Modules] Skip adding unused module maps to the dependency file

rsmith added a comment. This feature seems reasonable to me. Comment at: lib/Frontend/DependencyFile.cpp:206-223 class DFGMMCallback : public ModuleMapCallbacks { DFGImpl &Parent; public: DFGMMCallback(DFGImpl &Parent) : Parent(Parent) {} void moduleMapFileRead(Sourc

[libcxx] r333467 - Fix embarrasing typo in uncaught_exceptions. Update tests to really test this. Thanks to Peter Klotz for calling my attention to this.

Author: marshall Date: Tue May 29 15:25:42 2018 New Revision: 333467 URL: http://llvm.org/viewvc/llvm-project?rev=333467&view=rev Log: Fix embarrasing typo in uncaught_exceptions. Update tests to really test this. Thanks to Peter Klotz for calling my attention to this. Modified: libcxx/trunk

[PATCH] D47157: Warning for framework headers using double quote includes

bruno added a comment. > Consistency would be nice, but at the same time, I don't see a good metric > for when we'd know it's time to switch it to being on by default. I'm worried > that it'll remain off by default forever simply because no one thinks to go > turn it on (because it's silent b

[PATCH] D47499: [analyzer] Annotate program state update methods with LLVM_NODISCARD.

NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a.sidorin, george.karpenkov, szepet, rnkovacs, baloghadamsoftware. Herald added a subscriber: cfe-commits. A follow-up to https://reviews.llvm.org/D47496. This would warn the developer on the very common bug that consists in w

[PATCH] D45012: [Modules] Skip adding unused module maps to the dependency file

bruno added a comment. Ping Repository: rC Clang https://reviews.llvm.org/D45012 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D46485: Add python tool to dump and construct header maps

bruno added a comment. Ping! https://reviews.llvm.org/D46485 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D47290: [Sema] -Wformat-pedantic only for NSInteger/NSUInteger %zu/%zi on Darwin

jfb added a comment. In https://reviews.llvm.org/D47290#1113422, @aaron.ballman wrote: > In https://reviews.llvm.org/D47290#1113412, @jfb wrote: > > > In https://reviews.llvm.org/D47290#1113365, @aaron.ballman wrote: > > > > > This is relaxing `-Wformat` and making users instead write > > > `-Wf

[PATCH] D47474: Implement cpu_dispatch/cpu_specific Multiversioning

craig.topper added inline comments. Comment at: include/clang/Basic/X86Target.def:295 +CPU_SPECIFIC("pentium_iii", 'H', + (1ULL << FEATURE_CMOV | 1ULL << FEATURE_MMX | 1ULL << FEATURE_SSE)) +CPU_SPECIFIC("pentium_iii_no_xmm_regs", 'H', Could we just

[PATCH] D47480: clang-cl: Expose -no-canonical-prefixes

takuto.ikuta added a comment. On windows, argv0 is changed to absolute path before we call GetExecutablePath. That makes resource-dir absolute. I need clang-cl on windows has relative --resource-dir. See around heres. https://github.com/llvm-project/llvm-project-20170507/blob/83b39c10b1d7a9189b7e

[PATCH] D47474: Implement cpu_dispatch/cpu_specific Multiversioning

erichkeane updated this revision to Diff 148977. https://reviews.llvm.org/D47474 Files: include/clang/AST/Decl.h include/clang/Basic/Attr.td include/clang/Basic/AttrDocs.td include/clang/Basic/DiagnosticGroups.td include/clang/Basic/DiagnosticSemaKinds.td include/clang/Basic/TargetInf

[PATCH] D47474: Implement cpu_dispatch/cpu_specific Multiversioning

erichkeane marked 2 inline comments as done. erichkeane added a comment. Woops, looks like I lost those in the rebase. Thanks for catching them! Repository: rC Clang https://reviews.llvm.org/D47474 ___ cfe-commits mailing list cfe-commits@lists.

[PATCH] D47474: Implement cpu_dispatch/cpu_specific Multiversioning

mgrang added inline comments. Comment at: lib/Sema/SemaDecl.cpp:9440 + // Sort order doesn't matter, it just needs to be consistent. + std::sort(NewParsed.Features.begin(), NewParsed.Features.end()); Please use llvm::sort instead of std::sort. See https://ll

Re: [libcxx] r333325 - Add nonnull; use it for atomics

Hi Marshall, I’ve been thinking about this, and I propose we proceed the following way: Add a new warning to clang, -Wnonnull-attribute (modulo name bikeshed), which is part of the nonnull group and on by default. That warning specifically controls warnings generated by usage of the nonnull att

[PATCH] D45517: [analyzer] False positive refutation with Z3

george.karpenkov added inline comments. Comment at: lib/StaticAnalyzer/Core/BugReporter.cpp:3153 +if (getAnalyzerOptions().shouldCrosscheckWithZ3()) + R->addVisitor(llvm::make_unique()); + Unless I'm mistaken, visitors are run in the order they are being

[PATCH] D44480: [Sema] Don't skip function bodies with 'auto' without trailing return type

rsmith accepted this revision. rsmith added inline comments. This revision is now accepted and ready to land. Comment at: test/CodeCompletion/skip-auto-funcs.cpp:9 + if (x = 10) {} + // Check that this function is skipped. + // CHECK: 8:9: warning: using the result of an assig

Re: r333141 - Use zeroinitializer for (trailing zero portion of) large array initializers

On 28 May 2018 at 15:34, David Blaikie via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Probably nice to mention in the commit message what the fix was (& > if/where there was there a test added for it?) so readers don't have to try > to eyeball diff this commit against the otherone. > Fair

[PATCH] D45517: [analyzer] False positive refutation with Z3

mikhail.ramalho updated this revision to Diff 148969. mikhail.ramalho marked 6 inline comments as done. mikhail.ramalho added a comment. 1. Moved FalsePositiveRefutationBRVisitor::Profile definition to BugReporterVisitor.cpp 2. Update test cases two run twice, with and without the crosscheck 3. R

[PATCH] D47476: Support __iso_volatile_load8 etc on aarch64-win32.

mstorsjo accepted this revision. mstorsjo added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rC Clang https://reviews.llvm.org/D47476 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.ll

[PATCH] D46476: [HIP] Add action builder for HIP

yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: test/Driver/cuda-phases.cu:16 +// RUN: | FileCheck -check-prefixes=BIN,BIN_NV %s +// RUN: %clang -x hip -target powerpc64le-ibm-linux-gnu -ccc-print-phases --cuda-gpu-arch=gfx803 %s 2>&1 \ +// RUN

[PATCH] D44826: Add -Wunused-using, a warning that finds unused using declarations.

CarlosAlbertoEnciso added inline comments. Comment at: include/clang/Basic/DiagnosticGroups.td:828-829 // -Wunused-local-typedefs = -Wunused-local-typedef +def : DiagGroup<"unused-usings", [UnusedUsing]>; +// -Wunused-usings = -Wunused-using ---

[PATCH] D47394: [OpenMP][Clang][NVPTX] Replace bundling with partial linking for the OpenMP NVPTX device offloading toolchain

Hahnfeld added a comment. In https://reviews.llvm.org/D47394#1115086, @tra wrote: > On one hand I can see how being able to treat GPU-side binaries as any other > host files is convenient. On the other hand, this convenience comes with the > price of targeting only NVPTX. This seems contrary to

[PATCH] D46476: [HIP] Add action builder for HIP

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. One nit. LGTM otherwise. Comment at: test/Driver/cuda-phases.cu:16 +// RUN: | FileCheck -check-prefixes=BIN,BIN_NV %s +// RUN: %clang -x hip -target powerpc64le-ibm-linux-gnu -ccc-

[PATCH] D47450: [ASTImporter] Use InjectedClassNameType at import of templated record.

a.sidorin requested changes to this revision. a.sidorin added a comment. This revision now requires changes to proceed. Hello, Balázs, You can find my comments inline. Comment at: lib/AST/ASTImporter.cpp:2131 D2CXX->setDescribedClassTemplate(ToDescribed); +if

[PATCH] D47394: [OpenMP][Clang][NVPTX] Replace bundling with partial linking for the OpenMP NVPTX device offloading toolchain

tra added a comment. "Interoperability with other compilers" is probably a statement that's a bit too strong. At best it's kind of compatible with CUDA tools and I don't think it's feasible for other compilers. I.e. it will be useless for AMD GPUs and whatever compiler they use. In general it

[PATCH] D47354: [CodeGen][Darwin] Set the calling-convention of a thread-local variable initialization function to fix calling-convention mismatch

This revision was automatically updated to reflect the committed changes. Closed by commit rL333447: [CodeGen][Darwin] Set the calling-convention of thread-local variable (authored by ahatanak, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llv

r333447 - [CodeGen][Darwin] Set the calling-convention of thread-local variable

Author: ahatanak Date: Tue May 29 11:28:49 2018 New Revision: 333447 URL: http://llvm.org/viewvc/llvm-project?rev=333447&view=rev Log: [CodeGen][Darwin] Set the calling-convention of thread-local variable initialization functions to 'cxx_fast_tlscc'. This fixes a bug where instructions calling in

r333446 - [X86] Tag some 128/256 load/store instructions as requiring avx512vl instead of avx512f.

Author: ctopper Date: Tue May 29 11:23:22 2018 New Revision: 333446 URL: http://llvm.org/viewvc/llvm-project?rev=333446&view=rev Log: [X86] Tag some 128/256 load/store instructions as requiring avx512vl instead of avx512f. Modified: cfe/trunk/include/clang/Basic/BuiltinsX86.def Modified: cf

[PATCH] D35110: [Analyzer] Constraint Manager Negates Difference

NoQ added inline comments. Comment at: lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:192 +if (from.isMinSignedValue()) { + F.add(newRanges, Range(BV.getMinValue(from), BV.getMinValue(from))); +} NoQ wrote: > Return value of `add` seems to be acc

[PATCH] D35110: [Analyzer] Constraint Manager Negates Difference

NoQ added inline comments. Comment at: lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:191 +} +if (from.isMinSignedValue()) { + F.add(newRanges, Range(BV.getMinValue(from), BV.getMinValue(from))); We'll also need to merge the two adjacent segments

[PATCH] D47394: [OpenMP][Clang][NVPTX] Replace bundling with partial linking for the OpenMP NVPTX device offloading toolchain

gtbercea added a comment. In https://reviews.llvm.org/D47394#1114848, @sfantao wrote: > Just to clarify one thing in my last comment: > > When I say that we didn't aim at having clang compatible with other > compilers, I mean the OpenMP offloading descriptors, where all the variables > and offl

[PATCH] D47394: [OpenMP][Clang][NVPTX] Replace bundling with partial linking for the OpenMP NVPTX device offloading toolchain

gtbercea added inline comments. Comment at: lib/Driver/ToolChains/Cuda.cpp:536 + } } sfantao wrote: > What prevents all this from being done in the bundler? If I understand it > correctly, if the bundler implements this wrapping all the checks for > librari

  1   2   >