dexonsmith added inline comments.
================ Comment at: lib/Lex/HeaderSearch.cpp:753-754 + IncluderAndDir.second->getName())) + Diags.Report(IncludeLoc, + diag::warn_quoted_include_in_framework_header) + << Filename; ---------------- bruno wrote: > aaron.ballman wrote: > > This seems like a good place for a fix-it to switch the include style. Is > > there a reason to not do that work for the user? > Like I explained above, we don't know which framework the header could be > part of, so a fix-it could be misleading. Clang supports editor placeholders, which we use in some refactoring-style fix-its. I think this would be spelled `<#framework-name#>`, or `#include <<#framework-name#>/Foo.h>` Repository: rC Clang https://reviews.llvm.org/D47157 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
