hintonda updated this revision to Diff 130748.
hintonda added a comment.
- Use LLVM_CONFIG_PATH instead of LLVM_CONFIG_EXE.
Repository:
rC Clang
https://reviews.llvm.org/D41829
Files:
cmake/caches/Linux.cmake
Index: cmake/caches/Linux.cmake
This revision was automatically updated to reflect the committed changes.
Closed by commit rC323022: Link sanitized programs on NetBSD with -lkvm
(authored by kamil, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D42017
Files:
lib/Driver/ToolChains/CommonArgs.cpp
Index: lib
Author: kamil
Date: Fri Jan 19 17:03:45 2018
New Revision: 323022
URL: http://llvm.org/viewvc/llvm-project?rev=323022&view=rev
Log:
Link sanitized programs on NetBSD with -lkvm
Summary:
kvm - kernel memory interface
The kvm(3) functions like kvm_open(), kvm_getargv() or kvm_getenvv()
are used in
juliehockett added inline comments.
Comment at: include/clang/ASTMatchers/ASTMatchers.h:5904
+return F->hasTrailingReturn();
+ return false;
+}
lebedev.ri wrote:
> There are no negative tests in the unittest that cover this false path.
Is there a test case y
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
juliehockett marked 4 inline comments as done.
Closed by commit rCTE323011: [clang-tidy] Adding Fuchsia checker for multiple
inheritance (aut
Author: juliehockett
Date: Fri Jan 19 15:59:59 2018
New Revision: 323011
URL: http://llvm.org/viewvc/llvm-project?rev=323011&view=rev
Log:
[clang-tidy] Adding Fuchsia checker for multiple inheritance
Adds a check to the Fuchsia module to warn when a class
inherits from multiple classes that are n
Sounds like a good idea to me.
On 19 Jan 2018 15:23, "Richard Trieu via cfe-commits" <
cfe-commits@lists.llvm.org> wrote:
> Hans,
>
> I recommend merging this revision into the release. It fixes an infinite
> loop in Scope::dump()
>
> Richard
>
> On Wed, Jan 17, 2018 at 8:28 PM, Richard Trieu vi
MaskRay updated this revision to Diff 130711.
MaskRay added a comment.
functionProtoType
Repository:
rC Clang
https://reviews.llvm.org/D42213
Files:
include/clang/ASTMatchers/ASTMatchers.h
Index: include/clang/ASTMatchers/ASTMatchers.h
=
This revision was automatically updated to reflect the committed changes.
Closed by commit rC323008: [Lex] Fix crash on code completion in comment in
included file. (authored by vsapsai, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D41688?vs=128480&id=130710#toc
Repository
Author: vsapsai
Date: Fri Jan 19 15:41:47 2018
New Revision: 323008
URL: http://llvm.org/viewvc/llvm-project?rev=323008&view=rev
Log:
[Lex] Fix crash on code completion in comment in included file.
This fixes PR32732 by updating CurLexerKind to reflect available lexers.
We were hitting null point
Hans,
I recommend merging this revision into the release. It fixes an assertion
error when mixing modules and blocks.
Richard
On Fri, Jan 19, 2018 at 12:46 PM, Richard Trieu via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: rtrieu
> Date: Fri Jan 19 12:46:19 2018
> New Revision:
Hans,
I recommend merging this revision into the release. It fixes an infinite
loop in Scope::dump()
Richard
On Wed, Jan 17, 2018 at 8:28 PM, Richard Trieu via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: rtrieu
> Date: Wed Jan 17 20:28:56 2018
> New Revision: 322813
>
> URL: htt
arphaman accepted this revision.
arphaman added a comment.
This revision is now accepted and ready to land.
I think that's a sensible fix, thanks!
https://reviews.llvm.org/D41688
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.l
Author: az
Date: Fri Jan 19 15:11:18 2018
New Revision: 323006
URL: http://llvm.org/viewvc/llvm-project?rev=323006&view=rev
Log:
[AArch64] Add ARMv8.2-A FP16 scalar intrinsics
https://reviews.llvm.org/D41792
Added:
cfe/trunk/include/clang/Basic/arm_fp16.td
cfe/trunk/include/clang/Basic/a
tra created this revision.
tra added a reviewer: jlebar.
Herald added a subscriber: sanjoy.
We should (almost) never consider a device-side declaration to match a
builtin. If we do, the un-inlined device-side functions provided by
CUDA headers that ship with clang may be ignored. We may end up em
SjoerdMeijer created this revision.
SjoerdMeijer added reviewers: olista01, t.p.northover, rjmccall, aschwaighofer.
Herald added subscribers: kristof.beyls, javed.absar, aemerson.
Pass and return _Float16 as if it were an int or float for ARM, but with the
top 16 bits unspecified, similarly like w
sammccall added inline comments.
Comment at: clangd/CodeComplete.cpp:350
+ std::string QueryScope =
+ (normalizeScope(VS) +
+ (UnresolvedQualifier
sammccall wrote:
> It seems like you have stored the scopes in an unknown format, and call
Author: sammccall
Date: Fri Jan 19 14:18:21 2018
New Revision: 323000
URL: http://llvm.org/viewvc/llvm-project?rev=323000&view=rev
Log:
[clangd] Change index scope convention from "outer::inner" to "outer::inner::"
Global scope is "" (was "")
Top-level namespace scope is "ns::" (was "ns")
Nested
Author: sammccall
Date: Fri Jan 19 14:09:34 2018
New Revision: 322998
URL: http://llvm.org/viewvc/llvm-project?rev=322998&view=rev
Log:
Revert "[clangd] Change index scope convention from "outer::inner" to
"outer::inner::""
This reverts commit r322996.
Modified:
clang-tools-extra/trunk/clan
aaron.ballman added a comment.
In https://reviews.llvm.org/D42213#982385, @MaskRay wrote:
> Yes, I was asking about this because the results seemed to be wrong. I should
> have used `parameterCountIs()` to reduce the confusion :) I'll leave them
> untouched.
Alternatively, you can try out tho
Author: sammccall
Date: Fri Jan 19 13:58:58 2018
New Revision: 322996
URL: http://llvm.org/viewvc/llvm-project?rev=322996&view=rev
Log:
[clangd] Change index scope convention from "outer::inner" to "outer::inner::"
Global scope is "" (was "")
Top-level namespace scope is "ns::" (was "ns")
Nested
MaskRay added a comment.
In https://reviews.llvm.org/D42213#982261, @aaron.ballman wrote:
> In https://reviews.llvm.org/D42213#982256, @MaskRay wrote:
>
> > I am also not sure about this function: line 3548
> >
> > /// \brief Matches \c FunctionDecls and \c FunctionProtoTypes that have a
> >
yaxunl accepted this revision.
yaxunl added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks!
https://reviews.llvm.org/D42307
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listi
Author: rtrieu
Date: Fri Jan 19 12:46:19 2018
New Revision: 322984
URL: http://llvm.org/viewvc/llvm-project?rev=322984&view=rev
Log:
Allow BlockDecl in CXXRecord scope to have no access specifier.
Using a BlockDecl in a default member initializer causes it to be attached to
CXXMethodDecl without
mclow.lists accepted this revision.
mclow.lists added a comment.
This revision is now accepted and ready to land.
This looks fine to me. Thanks!
Comment at: test/std/re/re.regex/re.regex.construct/bad_ctype.pass.cpp:28
+} catch (const std::regex_error &ex) {
+result
hintonda added a comment.
In https://reviews.llvm.org/D41623#982262, @hintonda wrote:
> In https://reviews.llvm.org/D41623#982189, @phosek wrote:
>
> > Isn't `NO_DEFAULT_PATH` more appropriate here? That's what libc++ uses as
> > well.
>
>
> Unfortunately no.
>
> When cross compiling, it's impor
vitalybuka requested changes to this revision.
vitalybuka added a comment.
This revision now requires changes to proceed.
Please update the summary. No need to define kvm. Probably just few example of
essential functions needed by sanitizers.
Repository:
rL LLVM
https://reviews.llvm.org/D420
vitalybuka accepted this revision.
vitalybuka added a comment.
This revision is now accepted and ready to land.
LGTM, but please update the summary and git/svn patch description
Repository:
rL LLVM
https://reviews.llvm.org/D42017
___
cfe-commits
mclow.lists accepted this revision.
mclow.lists added a comment.
This revision is now accepted and ready to land.
This looks good to me.
Please add a test in test/libcxx/strings/string.modifiers and commit.
Something like this:
#include
#include
int main () {
std::string l = "Th
hintonda added a comment.
In https://reviews.llvm.org/D41623#982189, @phosek wrote:
> Isn't `NO_DEFAULT_PATH` more appropriate here? That's what libc++ uses as
> well.
Unfortunately no.
When cross compiling, it's important to look for headers in CMAKE_SYSROOT
and/or CMAKE_FIND_ROOT_PATH, or
aaron.ballman added a comment.
In https://reviews.llvm.org/D42213#982256, @MaskRay wrote:
> I am also not sure about this function: line 3548
>
> /// \brief Matches \c FunctionDecls and \c FunctionProtoTypes that have a
> /// specific parameter count.
> ///
> /// Given
> /// \code
>
MaskRay added a comment.
I am also not sure about this function: line 3548
/// \brief Matches \c FunctionDecls and \c FunctionProtoTypes that have a
/// specific parameter count.
///
/// Given
/// \code
/// void f(int i) {}
/// void g(int i, int j) {}
/// void h(int i, int
lebedev.ri added inline comments.
Comment at: include/clang/ASTMatchers/ASTMatchers.h:5904
+return F->hasTrailingReturn();
+ return false;
+}
There are no negative tests in the unittest that cover this false path.
https://reviews.llvm.org/D42273
___
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM with a minor commenting/documentation nit.
Comment at: include/clang/ASTMatchers/ASTMatchers.h:5898
+/// \code
+/// int X() {};
+/// auto Y() -> int {};
--
MaskRay updated this revision to Diff 130672.
MaskRay added a comment.
Address comment
Repository:
rC Clang
https://reviews.llvm.org/D42213
Files:
include/clang/ASTMatchers/ASTMatchers.h
Index: include/clang/ASTMatchers/ASTMatchers.h
===
trixirt created this revision.
trixirt added reviewers: emaste, filcab, rsmith.
Herald added subscribers: cfe-commits, krytarowski.
FreeBSD's libgcc and libgcc_p are symlinks to libcompiler_rt and
libcompiler_rt_p
Start using the compiler rt libs directly.
Repository:
rC Clang
https://review
juliehockett updated this revision to Diff 130671.
juliehockett marked 2 inline comments as done.
juliehockett added a comment.
Updating matcher and fixing semicolons
https://reviews.llvm.org/D42273
Files:
docs/LibASTMatchersReference.html
include/clang/ASTMatchers/ASTMatchers.h
lib/ASTMa
Author: ctopper
Date: Fri Jan 19 11:43:36 2018
New Revision: 322982
URL: http://llvm.org/viewvc/llvm-project?rev=322982&view=rev
Log:
[X86] Add goldmont to test/Driver/x86-march.c
Modified:
cfe/trunk/test/Driver/x86-march.c
Modified: cfe/trunk/test/Driver/x86-march.c
URL:
http://llvm.org/vi
craig.topper updated this revision to Diff 130670.
craig.topper added a comment.
Add doxygen comment
https://reviews.llvm.org/D42272
Files:
include/clang/Basic/BuiltinsX86.def
include/clang/Driver/Options.td
lib/Basic/Targets/X86.cpp
lib/Basic/Targets/X86.h
lib/Headers/immintrin.h
t
sammccall added a comment.
I think this mostly does the right thing, but I find some of the code
structure/description confusing.
I might have made misguided comments, happy to sit down together and work this
out :-)
Comment at: clangd/CodeComplete.cpp:316
+
+/// \brief Scope
NoQ added a comment.
The patch seems correct, but i suspect that your overall approach to the
checker you're trying to make is not ideal. `offsetof` returns a concrete value
(because, well, symbolic `offsetof`s are not yet supported in the analyzer),
and even if you see the concrete value, you'
phosek added a comment.
Isn't `NO_DEFAULT_PATH` more appropriate here? That's what libc++ uses as well.
Repository:
rCXXA libc++abi
https://reviews.llvm.org/D41623
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-
aaron.ballman added a comment.
In https://reviews.llvm.org/D42213#982047, @MaskRay wrote:
> In https://reviews.llvm.org/D42213#981700, @aaron.ballman wrote:
>
> > The documentation needs to be regenerated for this patch. One thing that
> > seems to be inconsistent is with the "what gets matched"
Author: jvesely
Date: Fri Jan 19 10:57:22 2018
New Revision: 322980
URL: http://llvm.org/viewvc/llvm-project?rev=322980&view=rev
Log:
tanpi: Port from amd_builtins
Passes piglit on turks and carrizo.
Passes CTS on carrizo.
Acked-By: Aaron Watry
Tested-By: Aaron Watry
Signed-off-by: Jan Vesely
Author: jvesely
Date: Fri Jan 19 10:57:19 2018
New Revision: 322979
URL: http://llvm.org/viewvc/llvm-project?rev=322979&view=rev
Log:
tan: Port from amd_builtins
v2: fixup constant precision
Passes piglit on turks and carrizo.
Passes CTS on carrizo
Fixes half_tan to pass CTS on carrizo
Acked-By:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL322977: [cmake] Also pass CMAKE_ASM_COMPILER_ID to next
stage when bootstrapping (authored by dhinton, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.
Anastasia created this revision.
Anastasia added reviewers: yaxunl, bader, hans.
https://reviews.llvm.org/D42307
Files:
docs/ReleaseNotes.rst
Index: docs/ReleaseNotes.rst
===
--- docs/ReleaseNotes.rst
+++ docs/ReleaseNotes.rst
@@
benhamilton updated this revision to Diff 130661.
benhamilton added a comment.
- Remove debugging code
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D42261
Files:
clang-tidy/objc/PropertyDeclarationCheck.cpp
clang-tidy/objc/PropertyDeclarationCheck.h
docs/clang-tidy/check
Author: dhinton
Date: Fri Jan 19 10:31:12 2018
New Revision: 322977
URL: http://llvm.org/viewvc/llvm-project?rev=322977&view=rev
Log:
[cmake] Also pass CMAKE_ASM_COMPILER_ID to next stage when bootstrapping
Summary:
When setting CMAKE_ASM_COMPILER=clang, we also need to set
CMAKE_ASM_COMPILER_ID=
benhamilton added a comment.
Thanks, fixed.
Comment at: clang-tidy/objc/PropertyDeclarationCheck.h:38
const std::vector SpecialAcronyms;
+const std::vector AdditionalAcronyms;
};
hokein wrote:
> nit: code indent
Ah, the previous one was wrong, I see.
benhamilton updated this revision to Diff 130657.
benhamilton marked 2 inline comments as done.
benhamilton added a comment.
- Switch to IncludeDefaultAcronyms option (defaults to 1).
- Use array for default acronyms, since we no longer need to parse it.
- Don't regex-escape default acronyms, sinc
hintonda added a comment.
In https://reviews.llvm.org/D42232#982043, @compnerd wrote:
> Took a bit of reading to realize that the compiler is being set to clang, and
> therefore `CMAKE_ASM_COMPILER_ID` should be `Clang`.
Thanks, I'll add that to the commit message.
Repository:
rC Clang
ht
qcolombet added inline comments.
Comment at: lib/Driver/ToolChains/Clang.cpp:4699
+else
+ CmdArgs.push_back("-global-isel=0");
+ }
I think that it would be useful to also set -global-isel-abort=2, so that users
can report problem early.
What do you th
hintonda added a comment.
Unless there's any further comment, I plan to commit these patches tomorrow.
Repository:
rCXXA libc++abi
https://reviews.llvm.org/D41623
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-b
MaskRay added a comment.
In https://reviews.llvm.org/D42213#981700, @aaron.ballman wrote:
> The documentation needs to be regenerated for this patch. One thing that
> seems to be inconsistent is with the "what gets matched" messages is that
> sometimes it includes extra adornments like curly br
Author: marshall
Date: Fri Jan 19 10:07:29 2018
New Revision: 322975
URL: http://llvm.org/viewvc/llvm-project?rev=322975&view=rev
Log:
More P0202 constexpr-ifying in . This commit handles
replace/replace_if/replace_copy/replace_copy_if.
Modified:
libcxx/trunk/include/algorithm
libcxx/tr
compnerd accepted this revision.
compnerd added a comment.
This revision is now accepted and ready to land.
Took a bit of reading to realize that the compiler is being set to clang, and
therefore `CMAKE_ASM_COMPILER_ID` should be `Clang`.
Repository:
rC Clang
https://reviews.llvm.org/D42232
MaskRay updated this revision to Diff 130644.
MaskRay added a comment.
Revert some changes to address comments
Repository:
rC Clang
https://reviews.llvm.org/D42213
Files:
include/clang/ASTMatchers/ASTMatchers.h
Index: include/clang/ASTMatchers/ASTMatchers.h
===
hintonda updated this revision to Diff 130638.
hintonda edited the summary of this revision.
hintonda added a comment.
- Also pass LLVM_CONFIG_EXE.
- Add llvm-objcopy, and make sure that is stage2 cache file is passed,
Repository:
rC Clang
https://reviews.llvm.org/D41829
Files:
cmake/cache
Author: marshall
Date: Fri Jan 19 09:45:39 2018
New Revision: 322970
URL: http://llvm.org/viewvc/llvm-project?rev=322970&view=rev
Log:
More P0202 constexpr-ifying in . This commit handles 'transform'.
Modified:
libcxx/trunk/include/algorithm
libcxx/trunk/test/std/algorithms/alg.modifying
Author: djg
Date: Fri Jan 19 09:16:32 2018
New Revision: 322967
URL: http://llvm.org/viewvc/llvm-project?rev=322967&view=rev
Log:
[WebAssembly] Add target flags for sign-ext opcodes.
Add -msign-ext and -mno-sign-ext to control the new sign-ext target
feature.
Modified:
cfe/trunk/docs/ClangCo
sammccall added a comment.
Sorry, our comments crossed...
Comment at: clangd/URI.cpp:57
+ Body = "/";
+Body += path::convert_to_slash(AbsolutePath, path::Style::posix);
+return (llvm::Twine(Scheme) + ":" + percentEncode(Body)).str();
ioeric wrote:
Sorry, I forgot to commit this before heading off on vacation. I'll be back
on monday.
Jon
On Fri, Jan 19, 2018 at 1:53 AM, Paul Fertser wrote:
> Hello Jonathan,
>
> On Mon, Jan 15, 2018 at 08:36:03AM -0700, Jonathan Roelofs wrote:
> > LGTM. Would you like me to commit it for you?
>
> Yes, ple
This revision was automatically updated to reflect the committed changes.
Closed by commit rC322956: [clang-format] Adds a canonical delimiter to raw
string formatting (authored by krasimir, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D42187?vs=130587&id=130626#toc
Reposi
Author: krasimir
Date: Fri Jan 19 08:18:47 2018
New Revision: 322956
URL: http://llvm.org/viewvc/llvm-project?rev=322956&view=rev
Log:
[clang-format] Adds a canonical delimiter to raw string formatting
Summary:
This patch adds canonical delimiter support to the raw string formatting.
This allows
ilya-biryukov added a comment.
This looks good, but we should add a test.
Should've noticed that before, sorry for the slowing this down a bit more.
After the test is there, I'm happy to commit this change for you.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D41535
___
a.sidorin created this revision.
a.sidorin added reviewers: xazax.hun, szepet, jingham.
a.sidorin added a project: clang.
Herald added subscribers: rnkovacs, kristof.beyls, aemerson.
Also, a number of style and bug fixes was done:
- ASTImporterTest: added sanity check for source node
- ExternalAS
This revision was automatically updated to reflect the committed changes.
Closed by commit rL322954: [clang-format] Fix shortening blocks in macros
causing merged next line (authored by krasimir, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.
Author: krasimir
Date: Fri Jan 19 08:12:37 2018
New Revision: 322954
URL: http://llvm.org/viewvc/llvm-project?rev=322954&view=rev
Log:
[clang-format] Fix shortening blocks in macros causing merged next line
Summary:
This patch addresses bug 36002, where a combination of options causes the line
fo
sammccall added inline comments.
Comment at: clangd/URI.cpp:94
+
+std::vector createEncodeMap() {
+ std::vector Result(128, "");
Performance doesn't really matter here, but it looks like this is intended to
save time by precomputing, and I don't think it's any
ioeric updated this revision to Diff 130621.
ioeric marked 14 inline comments as done.
ioeric added a comment.
- Address review comments
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D41946
Files:
clangd/CMakeLists.txt
clangd/URI.cpp
clangd/URI.h
unittests/clangd/CMakeL
ioeric added inline comments.
Comment at: clangd/URI.cpp:43
+ Body.consume_front("/");
+return llvm::sys::path::convert_to_slash(Body);
+ }
sammccall wrote:
> Don't you want the opposite here, convert from unix to native?
Ah, right!
C
hokein added inline comments.
Comment at: clangd/CodeComplete.cpp:270
+ /// namespace scopes which are visible to the qualified-id completion token.
+ std::vector Scopes;
+};
ilya-biryukov wrote:
> sammccall wrote:
> > ilya-biryukov wrote:
> > > sammccall wrote
hokein updated this revision to Diff 130618.
hokein marked 4 inline comments as done.
hokein added a comment.
- Rebase the patch to latest
- Update the patch based on the offline discussion
Updating D42073: [clangd] Query all visible scopes based on all visible
using-namespace declarations
=
a.sidorin added a comment.
Hello Henry,
The patch looks reasonable. I think it can be landed after comments are
resolved.
Comment at: lib/StaticAnalyzer/Core/ExprEngine.cpp:1497
+ ExplodedNodeSet PostVisit;
+ for (ExplodedNodeSet::iterator i = PreVisit.begin(), e =
nik added a comment.
Hmm, nothing changed. So how to get rid of this correctly. Is "Abandon
Revision" the right thing to do?
Repository:
rC Clang
https://reviews.llvm.org/D42099
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://list
This revision was automatically updated to reflect the committed changes.
Closed by commit rL322950: [CodeGenCXX] annotate a GEP to a derived class with
'inbounds' (PR35909) (authored by spatel, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.ll
Author: spatel
Date: Fri Jan 19 07:14:51 2018
New Revision: 322950
URL: http://llvm.org/viewvc/llvm-project?rev=322950&view=rev
Log:
[CodeGenCXX] annotate a GEP to a derived class with 'inbounds' (PR35909)
The standard says:
[expr.static.cast] p11: "If the prvalue of type “pointer to cv1 B” point
nik added a comment.
Ping!
https://reviews.llvm.org/D40481
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: sammccall
Date: Fri Jan 19 07:03:49 2018
New Revision: 322949
URL: http://llvm.org/viewvc/llvm-project?rev=322949&view=rev
Log:
[clangd] Fix memcpy(?, null, 0) UB by switching to std::copy
Modified:
clang-tools-extra/trunk/clangd/FuzzyMatch.cpp
Modified: clang-tools-extra/trunk/clang
MTC created this revision.
MTC added reviewers: NoQ, a.sidorin, dcoughlin.
Herald added subscribers: cfe-commits, szepet, xazax.hun.
PreStmt and PostStmt callbacks for OffsetOfExpr are necessary to implement
`Cert ARR39-C: Do not add or subtract a scaled integer to a pointer`. And
should I defin
bkramer accepted this revision.
bkramer added a comment.
This revision is now accepted and ready to land.
lgtm
Comment at: lib/Format/UnwrappedLineFormatter.cpp:310
+MergedLines = tryMergeSimpleBlock(I - 1, E, Limit);
+// If we managed to merge the block, discar
krasimir updated this revision to Diff 130609.
krasimir added a comment.
- Remove double whitespace
Repository:
rC Clang
https://reviews.llvm.org/D42298
Files:
lib/Format/UnwrappedLineFormatter.cpp
unittests/Format/FormatTest.cpp
Index: unittests/Format/FormatTest.cpp
=
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE322945: [clangd] Merge index-provided completions with
those from Sema. (authored by sammccall, committed by ).
Changed
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
sammccall marked an inline comment as done.
Closed by commit rL322945: [clangd] Merge index-provided completions with those
from Sema. (autho
krasimir updated this revision to Diff 130604.
krasimir added a comment.
- Remove added newline
Repository:
rC Clang
https://reviews.llvm.org/D42298
Files:
lib/Format/UnwrappedLineFormatter.cpp
unittests/Format/FormatTest.cpp
Index: unittests/Format/FormatTest.cpp
=
Author: sammccall
Date: Fri Jan 19 06:34:02 2018
New Revision: 322945
URL: http://llvm.org/viewvc/llvm-project?rev=322945&view=rev
Log:
[clangd] Merge index-provided completions with those from Sema.
Summary:
- we match on USR, and do a field-by-field merge if both have results
- scoring is pos
krasimir created this revision.
krasimir added a reviewer: bkramer.
Herald added a subscriber: klimek.
This patch addresses bug 36002, where a combination of options causes the line
following a short block in macro to be merged with that macro.
Repository:
rC Clang
https://reviews.llvm.org/D4
sammccall marked 2 inline comments as done.
sammccall added inline comments.
Comment at: clangd/CodeComplete.cpp:308
+return None;
+ }
+}
hokein wrote:
> add `return None` to make compiler happier? I think it might trigger
> -Wreturn-type warning.
added llv
kosarev updated this revision to Diff 130599.
kosarev added a comment.
- Supported propagation of TBAA info for aggregate transfers.
- Added tests on copying of `may_alias` aggregates.
https://reviews.llvm.org/D41539
Files:
lib/CodeGen/CGAtomic.cpp
lib/CodeGen/CGCall.cpp
lib/CodeGen/CGCla
sammccall added a comment.
Oops, I forgot to submit comments with my last update.
I don't think there's anything surprising so I'll land this, but let me know if
you want any changes!
Comment at: clangd/CodeComplete.cpp:339
+ std::vector Results;
+ CodeCompletionContext CCCo
hokein added a comment.
looks good to me too, just a few nits.
Comment at: clangd/CodeComplete.cpp:308
+return None;
+ }
+}
add `return None` to make compiler happier? I think it might trigger
-Wreturn-type warning.
Comment at: clangd/C
aaron.ballman added inline comments.
Comment at: include/clang/ASTMatchers/ASTMatchers.h:5902
+AST_MATCHER(FunctionDecl, hasTrailingReturn) {
+ return Node.getType()->castAs()->hasTrailingReturn();
+}
I think this may cause failed assertions on code like `void f
aaron.ballman added a comment.
The documentation needs to be regenerated for this patch. One thing that seems
to be inconsistent is with the "what gets matched" messages is that sometimes
it includes extra adornments like curly braces and other times it does not. It
might be good to pick a styl
ioeric added a comment.
LGTM
Comment at: clangd/CodeComplete.cpp:743
+ int NSema = 0, NIndex = 0, NBoth = 0; // Counters for logging.
+ bool Incomplete = false;
+ llvm::Optional Filter; // Initialized once Sema runs.
`InComplete` can probably be output varia
aaron.ballman accepted this revision.
aaron.ballman added a comment.
LGTM aside from a few small nits.
Comment at: clang-tidy/fuchsia/MultipleInheritanceCheck.cpp:85
+void MultipleInheritanceCheck::registerMatchers(MatchFinder *Finder) {
+ // Match declarations which have base
RKSimon added inline comments.
Comment at: lib/Headers/immintrin.h:251
+#if !defined(_MSC_VER) || __has_feature(modules) || defined(__RDPID__)
+static __inline__ unsigned int __attribute__((__always_inline__, __nodebug__,
__target__("rdpid")))
+_rdpid_u32(void) {
---
petarj added a comment.
This sounds as a valid improvement. Can we have this code committed?
https://reviews.llvm.org/D39053
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
vladimir.plyashkun updated this revision to Diff 130589.
vladimir.plyashkun added a comment.
Some more nits were fixed.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D41535
Files:
clang-tidy/ClangTidy.cpp
clang-tidy/ClangTidy.h
clang-tidy/tool/ClangTidyMain.cpp
Index: cl
ilya-biryukov added a comment.
Just a few more NITs and we're good to go
Comment at: clang-tidy/tool/ClangTidyMain.cpp:347
+llvm::errs() << "Error: virtual filesystem overlay file '" << OverlayFile
+ << "' not found.\n";
+return nullptr;
1 - 100 of 117 matches
Mail list logo
